B62E1M231
2017-10-13 16:48:23
[cucumber/cucumber-js] charlierudolph commented on #947: (refactor) Update testCase to include pickle object
<p>Please remove the text: "matching the event data for <code>test-case-finished</code>" as that is no longer true. Same for the Before Hook.</p>
<p>Thoughts on saying the "will be an object of the form <code>{sourceLocation, pickle}</code> (see After hook for more details)" instead of repeating the structure. Alternatively can reference the other way where they are defined only here and not in the After hook. </p>
B62E1M231
2017-10-14 06:14:17
B62E1M231
2017-10-14 06:15:19
B62E1M231
2017-10-14 09:03:18
B62E1M231
2017-10-14 09:51:16
[cucumber/cucumber-js] aslakhellesoy commented on #951: add --language cli option
<p>In theory, yes. In practice, no, as nobody (to my knowledge) is consuming these events yet.</p>
<p>No need for a major bump. </p>
B62E1M231
2017-10-17 16:07:19
[cucumber/cucumber-js] darrinholst commented on #954: cli: don't split formatter:output on Windows drive letters (#953)
<p>Yes, I get that it’s in the eslint config. That feels like a workaround because prettier didn’t support config files for a while. The reason I like it outside of eslint is because I have my editor set up to run prettier on save if it’s available locally in the project so it’s conveinent to have those preferences declared in a format that’s native to the tool. I contribute here so infrequently that it’s not a big deal to me either way. Prettier will also read config from <code>package.json</code> if it’s the extra file you don’t like.</p>
B62E1M231
2017-10-17 16:15:22
[cucumber/cucumber-js] charlierudolph commented on #954: cli: don't split formatter:output on Windows drive letters (#953)
<p>I want it to live in one place. I'm fine removing it from <code>.eslintrc.yml</code> if having this config file is enough. Either way though, that is an unrelated change to this PR and thus I think should be removed (and be in its own PR)</p>
B62E1M231
2017-10-17 16:30:23
[cucumber/cucumber-js] darrinholst commented on #954: cli: don't split formatter:output on Windows drive letters (#953)
<p>Although if living in one place is the goal then eslint is probably the place to put it since that enforces the style. Looks like neoformat supports prettier-eslint so I'll get that configured next time I'm in here.</p>
B62E1M231
2017-10-23 07:20:20
[cucumber/cucumber-js] charlierudolph commented on #960: Fix #959
<p>Instead of saving this variable, please use an arrow function on the callback passed to <code>.then</code> in order to retain scope. Alternatively can use async/await with a requirement of using node 8 for this example.</p>
B62E1M231
2017-10-23 16:17:22
B62E1M231
2017-10-23 16:30:25
[cucumber/cucumber-js] mmuller99 commented on #962: pickle_filter: use absolute paths
<p><code>resolve</code> requires a string argument, could rewrite as:</p>
<p><code>const lines = this.featureUriToLinesMapping[uri ? path.resolve(uri) : undefined]
</code>
or just return true if uri is undefined, which is the case when running with a line that does not exist</p>
B62E1M231
2017-10-23 16:54:24
B62E1M231
2017-10-24 00:09:22
B62E1M231
2017-10-24 07:01:29
[cucumber/cucumber-js] charlierudolph commented on #962: pickle_filter: use absolute paths
<p>Auhh. Can you please update the unit tests so a uri is always passed in? I'd prefer not to have the <code>|| ''</code> since in real use I expect the uri to always be there</p>
B62E1M231
2017-10-24 09:09:23
[cucumber/cucumber-js] charlierudolph commented on #958: cli: extract option splitting and use it for --compiler (#746)
<p>Thoughts on converting this to something like</p>
<pre><code>// The following is within the describe block for OptionSplitter
const examples = [
{
description: "doesn't split when nothing to split on",
input: '../custom/formatter',
output: ['../custom/formatter']
}
//...
]
examples.forEach(({description, input, output}) =&gt; {
it(description, function() {
expect(OptionSplitter.split(input)).to.eql(output)
})
})
</code></pre>
B62E1M231
2017-10-24 10:53:22
[cucumber/cucumber-js] darrinholst commented on #958: cli: extract option splitting and use it for --compiler (#746)
<p>I went ahead and changed it. I'm kind of indifferent either way. The individual <code>it</code> blocks were already pretty terse, but this way does remove what boilerplate there was and gets to the point of what you're testing.</p>
B62E1M231
2017-11-08 00:43:20
[cucumber/cucumber-js] finaruioana approved #973: Exception message in json formatter
<p>for consistency over the type of error<em>message, I would suggest to have a <code>JSON.stringify(exception)</code>. It would be a rare exception, but at least we know error</em>message will be a string all the time.</p>
B62E1M231
2017-11-08 06:13:24
[cucumber/cucumber-js] innocentiv commented on #973: Exception message in json formatter
<p>I omitted the JSON.stringify in the pull request because that would change the spec (JSON.stringify add escaped quotes to string object):</p>
<p><a href="https://github.com/cucumber/cucumber-js/blob/267725e3a8b00e28336ef75727d7487e5a6739ab/src/formatter/json_formatter_spec.js#L128">https://github.com/cucumber/cucumber-js/blob/267725e3a8b00e28336ef75727d7487e5a6739ab/src/formatter/json_formatter_spec.js#L128</a></p>
<p><a href="https://github.com/cucumber/cucumber-js/blob/267725e3a8b00e28336ef75727d7487e5a6739ab/src/formatter/json_formatter_spec.js#L141">https://github.com/cucumber/cucumber-js/blob/267725e3a8b00e28336ef75727d7487e5a6739ab/src/formatter/json_formatter_spec.js#L141</a></p>
<p>Adding a type check would enforce a string without changing the spec.
I wouldn't add more code if not really needed</p>
<p><code>data.result.error_message = message + stack || _.isString(exception) ? exception : JSON.stringify(exception)
</code></p>
B62E1M231
2017-11-08 06:26:25
[cucumber/cucumber-js] innocentiv commented on #973: Exception message in json formatter
<p>@finaruioana </p>
<p>This may be a better solution, what do you think?</p>
<p><code>if(_.isString(exception)) {
data.result.error_message = exception
} else {
let {message = '', stack = ''} = exception
message = _.includes(stack, message) ? '' : message + '\n'
data.result.error_message = message + stack || JSON.stringify(exception)
}
</code></p>
B62E1M231
2017-11-21 19:19:19
[cucumber/cucumber-js] charlierudolph commented on #973: Exception message in json formatter
<p>This is hard for me to follow. Thoughts on breaking out a function <code>stringifyException</code> and focusing on making it easy to understand:
<code>function stringifyException(exception) {
// if is string
// return it
// else if has message or stack
// if stack includes message
// return stack
// else
// return message newline stack
// else
// return stringified exception
}
</code>
The function could then go in a util file and be unit tested with some sample exceptions from the different browsers and non-error objects</p>
B62E1M231
2017-11-22 00:51:20
[cucumber/cucumber-js] innocentiv commented on #973: Exception message in json formatter
<p>You are right, move this code to a function would be a better solution.
Any suggestion on where to put this utils file?
What about using /src/formatter/helpers/error_helpers.js?</p>
B62E1M231
2017-11-22 06:03:23
B62E1M231
2017-11-26 06:35:19
[cucumber/cucumber-js] charlierudolph commented on #973: Exception message in json formatter
<p>Thanks for the great test cases but thinking more on this feature I think we should use <a href="https://github.com/charlierudolph/node-assertion-error-formatter">node-assertion-error-formatter</a> which is what we use when displaying errors in the terminal. It includes the logic for concatenating the message / stack and shows diffs as well. Sorry I didn't remember this sooner.</p>
B62E1M231
2017-11-27 02:03:21
[cucumber/cucumber-js] innocentiv commented on #973: Exception message in json formatter
<p>node-assertion-error-formatter does not pass 3 of the tests case I wrote. If those error are acceptable I can modify for the fourth time the pull request :)</p>
<p>1) ErrorHelpers<br />
stringifyException<br />
return stack:<br />
AssertionError: expected '[object Object]stack' to equal 'stack' </p>
<p>2) ErrorHelpers<br />
stringifyException<br />
return message and stack:<br />
AssertionError: expected 'errorstack' to equal 'error\nstack' </p>
<p>3) ErrorHelpers<br />
stringifyException<br />
stringify an object:<br />
TypeError: stack.indexOf is not a function </p>
B62E1M231
2017-11-27 07:51:28
[cucumber/cucumber-js] charlierudolph commented on #973: Exception message in json formatter
<p>I just released v2.0.1 of <code>node-assertion-error-formatter</code> which should fix cases 2 and 3 (<a href="https://github.com/charlierudolph/node-assertion-error-formatter/commit/ca21cfd552ce090b0273bd160e44b7cb54f7c071">https://github.com/charlierudolph/node-assertion-error-formatter/commit/ca21cfd552ce090b0273bd160e44b7cb54f7c071</a>). Please update the version in the package.json / yarn.lock. </p>
<p>I think test case number 1 needs to be updated so the message is an empty string instead of undefined. Testing out the error constructor in node 8, this was always the case.</p>
<p>If all your test cases pass, I think the tests / util file you added can be deleted as the test cases are now covered in <code>node-assertion-error-formatter</code>. We can use <code>node-assertion-error-formatter</code> directly in <code>src/formatter/json_formatter.js</code></p>
B62E1M231
2017-11-29 10:01:27
[cucumber/cucumber-js] aslakhellesoy commented on #980: Upgrade to cucumber-expressions@5.0.6 and tag-expressions@1.1.0
<p>Ah crap I thought that’s what I did. I always make an empty section for the next release when I make a release. That way contributors have a place to dump comments. They don’t have to figure out what the section formatting is like.</p>
<p>Can you do this for future releases? Example: <a href="https://github.com/cucumber/cucumber/blob/master/gherkin/CHANGELOG.md">https://github.com/cucumber/cucumber/blob/master/gherkin/CHANGELOG.md</a></p>
B62E1M231
2018-01-09 12:13:29
[cucumber/cucumber-js] charlierudolph commented on #1003: Issue #956: Add default snippetInterface <async\await> and snippetSyntax for async/await
<p>This isn't a typical cli option: <a href="https://github.com/cucumber/cucumber-js/blob/master/docs/cli.md#interface">https://github.com/cucumber/cucumber-js/blob/master/docs/cli.md#interface</a>. I'd prefer the dash to make it easier to read.</p>
B62E1M231
2018-01-30 09:21:21
[cucumber/cucumber-js] charlierudolph commented on #1028: vary error for callback vs promise
<p>Can we update this to: <code>function timed out, ensure the callback is executed within 500 milliseconds</code>?</p>
B62E1M231
2018-03-19 17:46:26
[cucumber/cucumber-js] charlierudolph commented on #1041: Print attachment step text on error format
<p>This can be simplified to <code>if (testStep.attachments) {</code> as it should always be an array or null.</p>
<p>I'm uncertain about attachments always being yellow. Thoughts on it being the same color as the step or not having any color?</p>
<p>Thoughts on this being: <code>Attachment (text/plain): Basic info.</code>
Then other non text attachments could be <code>Attachment (other/type)</code>
Currently the figures are only used for steps and not related messages and I'd like to keep that pattern</p>
B62E1M231
2018-03-20 02:15:26
B62E1M231
2018-03-20 02:20:24
B62E1M231
2018-03-20 02:40:28
B62E1M231
2018-03-20 09:01:26
[cucumber/cucumber-js] charlierudolph commented on #1041: Print attachment step text on error format
<p>For the other media types, I was thinking the value could be suppressed. So for now the line would be <code>Attachment (other/type)</code>. We can add json in another PR. Yes please add some docs to the attachment page.</p>
B62E1M231
2018-03-20 09:06:27
[cucumber/cucumber-js] charlierudolph commented on #1041: Print attachment step text on error format
<p>If this was block was placed after the next block (that includes buildStepArgumentIterator) I believe it would appear after the step argument. Please add a test for this as well</p>
B62E1M231
2018-03-20 09:28:28
B62E1M231
2018-03-20 10:04:28
[cucumber/cucumber-js] charlierudolph commented on #1047: Fix error display in parallel mode
<p>This path cleanup should go in the formatters and should be its own PR. I'd prefer we replace the cwd with <code>.</code> instead of removing it entirely</p>
B62E1M231
2018-03-20 10:21:30
B62E1M231
2018-04-03 11:03:25
[cucumber/cucumber-js] charlierudolph commented on #1056: Feature/976
<p>Thoughts on the following: update runHooks / runHook to also take in a <code>isBeforeHook</code> argument. Then in <code>runHook</code> if its a before hook and <code>isSkippingSteps</code> returns true, then we return <code>{ status: Status.SKIPPED }</code>.</p>
<p>Note if you are curious: <code>this.skip</code> in for when the entire scenario is skipped (via dry run or fail fast) and thus no before hooks / after hooks are run</p>
B62E1M231
2018-04-03 11:35:30
[cucumber/cucumber-js] charlierudolph commented on #1058: Issue: 997 Start of BeforeStep functionality
<p>Can we please put these new features in their own feature file? I think we will have enough new features by the end to warrant their own file. The world in hooks would get its own step hook feature </p>
<p>Hmm. I don't expect the beforeStep would need these parameters. I think we could start with passing in only the step. The after step will end up getting the step and the stepResult.</p>
<p>I think this should be within the call to <code>this.aroundTestStep</code>. That function emits the events <code>test-step-started/finished</code>. I think these before/after step hooks should actually be thought of as part of the step. We would run the beforeStep/step/afterStep and merge the results of each. The step fails if the beforeStep, step, or afterStep fails. We would also not run the step if the beforeStep fails.</p>
B62E1M231
2018-04-07 12:57:21
[cucumber/cucumber-js] eis95 commented on #1058: Issue: 997 Start of BeforeStep functionality
<p>Definitely</p>
<p>will fix</p>
<p>does it make sense that i move into the <code>runStep</code> function? <code>aroundTestStep</code> is where I initially tried it but it gets called for each of the <code>Before</code> hooks. I think I would also need a check in <code>aroundTestStep</code> to make it work there.</p>
B62E1M231
2018-04-07 13:06:23
[cucumber/cucumber-js] eis95 commented on #1058: Issue: 997 Start of BeforeStep functionality
<p>I was getting a linting error here.</p>
<p>I'm curious how we should handle multiple exceptions? And should I instead check if status is <code>failed</code> here instead of checking for <code>exception</code> in any of the responses? Or both?</p>
<p>can move this to background</p>
B62E1M231
2018-04-09 23:02:22
[cucumber/cucumber-js] eis95 commented on #1058: Issue: 997 Start of BeforeStep functionality
<p>@charlierudolph BeforeStep/AfterStep are working. I do have questions about stacktrace reporting and duration calculation.
For duration my current thinking is to calculate the duration for the beforeSteps, the step, and the afterSteps and update that value on the <code>stepResult</code> prior to returning.
I'm interested in hearing what you feel would be the best way to handle multiple errors in the hooks . </p>
B62E1M231
2018-04-26 02:41:31
[cucumber/cucumber-js] DevSide commented on #1058: Issue: 997 Start of BeforeStep functionality
<p>Looks like we already skip the steps inside <code>runStep</code> with <code>isSkippingSteps</code> check</p>
B62E1M231
2018-05-22 20:47:29
B62E1M231
2018-05-22 20:47:29
B62E1M231
2018-05-28 21:35:28
B62E1M231
2018-05-28 21:56:23
[cucumber/cucumber-js] charlierudolph commented on #1058: Issue: 997 Start of BeforeStep functionality
<p>I don't think these hooks need invocation parameters (like what is passed to before/after hooks)</p>
<p>I disagree with how this function works. I think we should run the step hooks sequentially and if any does not pass we return the step result of the not passing hook. If all pass, we return status passed.</p>
<p>Thinking on this function, we are currently not adding the duration of the step hooks to the overall duration of the step. That should be testable with unit tests</p>
B62E1M231
2018-05-28 22:55:28
GitHub
2021-04-15 01:49:23
[cucumber/cucumber-js] Comment on #1641
Hi <a href="https://github.com/zanona">@zanona</a>
Your module looks interesting
Your investigation on that issue too
As you already have a good idea of what is happening and how it may be fixed, do you think you could open a PR for that, and to support the discussion around that?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-15 02:01:52
[cucumber/cucumber-js] Comment on #1582
I think if you submit a PR to bring those back - and also the other missing ones - there are good chances that it would be accepted ☺️
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-15 02:04:08
[cucumber/cucumber-js] Comment on #1640
<a href="https://github.com/charlierudolph">@charlierudolph</a> may I let you qualify that issue using labels?
Also if you could add some context and/or description, that would be great 😄
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-15 03:13:53
[cucumber/cucumber-js] Comment on #1582
You could also consider using `colors` directly, given that `errorMessage` just delegates to `colors.red`.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-15 04:04:50
[cucumber/cucumber-js] Comment on #1582
<a href="https://github.com/davidjgoss">@davidjgoss</a> that was my first though too
Then I looked at custom formatters documentation, and we easily find the get_color_fns module, so it could be considered as public api. Thus, maybe <a href="https://github.com/code4muktesh">@code4muktesh</a> is not the only one facing that issue. That is why I suggested to bring those props back as part of a good first issue for new contributors.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-15 12:29:04
[cucumber/cucumber-js] Comment on #1589
Thoughts on putting this in src and as part of building copy it into lib? Same for wrappers.mjs.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-15 12:29:40
[cucumber/cucumber-js] Issue opened by yopasa94
<p>Cucumber Version: 7.0.1<br />
Node Version: 14.14.31<br />
Operating System: Win 10</p>
<p>Scenario Outline: Sample test case<br />
Given this is a test case<br />
When I have the following data table<br />
| <scenario_example> |<br />
Then a JSON report will be generated</p>
<p><a href="https://github.com/critical">@critical</a><br />
Examples:<br />
| scenario_example |<br />
| Test Child Tag 1 |</p>
<p><a href="https://github.com/blocker">@blocker</a><br />
Examples:<br />
| scenario_example |<br />
| Test Child Tag 2 |</p>
<p>When I run the test case above with the tag: "--tags <a href="https://github.com/critical">@critical</a>" and "-f json:reports/cucumber-report.json", the test case runs successfully, but the following error is thrown:<br />
``[chrome <a href="https://github.com/cucumber/cucumber-js/issues/1">#1</a>]<br />
[chrome <a href="https://github.com/cucumber/cucumber-js/issues/1">#1</a>] 8 scenarios (8 passed)<br />
[chrome <a href="https://github.com/cucumber/cucumber-js/issues/1">#1</a>] 48 steps (48 passed)<br />
[chrome <a href="https://github.com/cucumber/cucumber-js/issues/1">#1</a>] 2m58.724s (executing steps: 2m58.252s)<br />
[chrome <a href="https://github.com/cucumber/cucumber-js/issues/1">#1</a>] [14:22:34] I/runnerCli - Cannot read property 'location' of undefined</p>
<p>[14:22:34] I/testLogger -</p>
<p>[14:22:34] E/launcher - Runner process exited unexpectedly with error code: 1<br />
[14:22:34] I/launcher - 0 instance(s) of WebDriver still running<br />
Is there any way to support tag at the example level (it was supported in the past )? why was that feature removed ?<br />
<a href="https://user-images.githubusercontent.com/22714699/114927341-f7cf3680-9df6-11eb-8786-21003cdd73b1.png">image</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-15 12:32:18
[cucumber/cucumber-js] Review on #
Just the last comment about the location of a couple files. Otherwise looks great! Thanks for doing this!
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-15 12:32:37
[cucumber/cucumber-js] Comment on #1589
Looks good. Thanks!
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-15 12:40:25
[cucumber/cucumber-js] Comment on #1641
Hmm, I don't see any issue with moving the reset to just before require-module. It being after was more a product of what require-module was used for in the past which had the primary use case of setting up transpilers (typescript / babel)
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-15 12:46:59
[cucumber/cucumber-js] Comment on #1642
We have this <a href="https://github.com/cucumber/cucumber-js/blob/master/features/target_specific_scenarios_by_tag.feature">feature</a> that should be validating this is working. I'm not sure why all out examples are verify it failing though. Let me review that feature.
In the mean time can you provide a more complete example of what you are running? (ie a repo with the source and the exact command to run to reproduce the error). Based on the sample output it appears you are not running just basic cucumber-js
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-15 12:50:45
[cucumber/cucumber-js] Pull request opened by charlierudolph
<p>Follow up to <a href="https://github.com/cucumber/cucumber-js/issues/1642">#1642</a> just to make the feature a bit better</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-15 12:51:24
[cucumber/cucumber-js] Comment on #1642
Okay reviewing the feature, it appears the issue is the JSON formatter. Going to close this as a duplicate of <a href="https://github.com/cucumber/cucumber-js/issues/1621">#1621</a>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-15 12:51:29
[cucumber/cucumber-js] Issue closed by charlierudolph
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-15 12:57:35
[cucumber/cucumber-js] Comment on #1643
<a href="https://coveralls.io/builds/38862688">Coverage Status</a>
Coverage remained the same at 98.575% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/32f20d28205f4b101a2a78f0a39ff198690107b7">32f20d2</a> on tags-features* into *<a href="https://github.com/cucumber/cucumber-js/commit/e2fd32a4fe411484275307e2a4b59605a8ded165">e2fd32a</a> on master*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-15 13:34:56
[cucumber/cucumber-js] Comment on #1538
Did you try with PickleFilter from @cucumber/cucumber ?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-15 13:39:41
[cucumber/cucumber-js] Comment on #1489
I faced this issue some days ago and I replaced with 'parseGherkinMessageStream'
```
//This will return all the test id
parseGherkinMessageStream({
cwd: '',
eventBroadcaster,
eventDataCollector,
gherkinMessageStream: gherkinMsgStream,
order: 'defined',
pickleFilter: new PickleFilter({
cwd: '',
tagExpression: cucumberTags,
}),
});
//returns list of scenarios as 'testsCases'
```
```
//Find all the information related to the scenarios
tests = testCases.map((result) => {
const pickeTest = eventDataCollector.getPickle(result);
const gherkinDoc = eventDataCollector.getGherkinDocument(pickeTest.uri);
const lineNumber = formatterHelpers.PickleParser.getPickleLocation({
gherkinDocument: gherkinDoc,
pickle: pickeTest,
}).line;
// return desired information from the test
return { uri: '../../' + pickeTest.uri, lineNumber };
});
```
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-15 22:28:19
[cucumber/cucumber-js] Review on #
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-16 00:43:39
[cucumber/cucumber-js] Comment on #1641
Sounds great guys.
I can surely prepare a PR, perhaps we can scope it as a feature rather than a bug, so I can prepare tests scoped to the user being able to create a custom preset and making sure the test runner understands it?
Alternatively, we could simply swap those two lines and watch for failed tests?
How would you prefer to go about it?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-16 00:54:09
[cucumber/cucumber-js] Comment on #1382
Definitely, let me prepare some doc updates and send for review. Not sure if you tried but this is also blazing fast `cucumber-js --require-module ts-eager/register --require features/support/*.ts`. <a href="https://github.com/mhart/ts-eager">It's</a> the same as ts-node but transforms with esbuild :) So I might add a note for these recipes as well to provide some ideas of usage, if you think that'd be OK?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-16 03:02:18
[cucumber/cucumber-js] Comment on #1641
Regarding cucumber, this remain a bug as there is an unexpected error while trying to load a module in a regular way, that should actually work.
But you still can scope your PR as an enhancement with a scoped test as you described - I actually like the idea - which would have the benefit to fix that issue as well. What do you think?
Regarding the possibility to swap the two lines, that could be a first good starting point IMO :)
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-17 03:23:15
[cucumber/cucumber-js] Comment on #1589
Good point - done!
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-17 03:23:52
[cucumber/cucumber-js] Pull request merged by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-18 13:24:21
[cucumber/cucumber-js] Pull request merged by charlierudolph
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-18 13:28:03
[cucumber/cucumber-js] Comment on #1588
Don't worry about yarn audit as that is unfortunately failing on master. Personally think we need to handle auditing deps differently as not something we can currently deal with (its in a dependency of our dependency and we need to wait for other before we can update).
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-18 23:07:30
[cucumber/cucumber-js] Comment on #1274
I also get this error, even when I run npm install on a fresh pull of my git repo. I'm using node v15.14.0 and npm 7.7.6
```
npm WARN deprecated cucumber@6.0.5: The npm package has moved to @cucumber/cucumber
npm ERR! code 1
npm ERR! path /home/circleci/project/test/node_modules/grpc
npm ERR! command failed
npm ERR! command sh -c node-gyp rebuild
npm ERR! gyp info it worked if it ends with ok
npm ERR! gyp info using node-gyp@7.1.2
npm ERR! gyp info using node@15.14.0 | linux | x64
npm ERR! gyp info find Python using Python version 3.8.5 found at "/usr/bin/python3"
npm ERR! gyp http GET <https://nodejs.org/download/release/v15.14.0/node-v15.14.0-headers.tar.gz>
npm ERR! gyp http 200 <https://nodejs.org/download/release/v15.14.0/node-v15.14.0-headers.tar.gz>
npm ERR! gyp http GET <https://nodejs.org/download/release/v15.14.0/SHASUMS256.txt>
npm ERR! gyp http 200 <https://nodejs.org/download/release/v15.14.0/SHASUMS256.txt>
npm ERR! gyp info spawn /usr/bin/python3
npm ERR! gyp info spawn args [
npm ERR! gyp info spawn args '/usr/local/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py',
npm ERR! gyp info spawn args 'binding.gyp',
npm ERR! gyp info spawn args '-f',
npm ERR! gyp info spawn args 'make',
npm ERR! gyp info spawn args '-I',
npm ERR! gyp info spawn args '/home/circleci/project/test/node_modules/grpc/build/config.gypi',
npm ERR! gyp info spawn args '-I',
npm ERR! gyp info spawn args '/usr/local/lib/node_modules/npm/node_modules/node-gyp/addon.gypi',
npm ERR! gyp info spawn args '-I',
npm ERR! gyp info spawn args '/home/circleci/.cache/node-gyp/15.14.0/include/node/common.gypi',
npm ERR! gyp info spawn args '-Dlibrary=shared_library',
npm ERR! gyp info spawn args '-Dvisibility=default',
npm ERR! gyp info spawn args '-Dnode_root_dir=/home/circleci/.cache/node-gyp/15.14.0',
npm ERR! gyp info spawn args '-Dnode_gyp_dir=/usr/local/lib/node_modules/npm/node_modules/node-gyp',
npm ERR! gyp info spawn args '-Dnode_lib_file=/home/circleci/.cache/node-gyp/15.14.0/<(target_arch)/node.lib',
npm ERR! gyp info spawn args '-Dmodule_root_dir=/home/circleci/project/test/node_modules/grpc',
npm ERR! gyp info spawn args '-Dnode_engine=v8',
npm ERR! gyp info spawn args '--depth=.',
npm ERR! gyp info spawn args '--no-parallel',
npm ERR! gyp info spawn args '--generator-output',
npm ERR! gyp info spawn args 'build',
npm ERR! gyp info spawn args '-Goutput_dir=.'
npm ERR! gyp info spawn args ]
npm ERR! gyp: Undefined variable module_name in binding.gyp while trying to load binding.gyp
npm ERR! gyp ERR! configure error
npm ERR! gyp ERR! stack Error: `gyp` failed with exit code: 1
npm ERR! gyp ERR! stack at ChildProcess.onCpExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:351:16)
npm ERR! gyp ERR! stack at ChildProcess.emit (node:events:369:20)
npm ERR! gyp ERR! stack at Process.ChildProcess._handle.onexit (node:internal/child_process:290:12)
npm ERR! gyp ERR! System Linux 4.19.121-linuxkit
npm ERR! gyp ERR! command "/usr/local/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
npm ERR! gyp ERR! cwd /home/circleci/project/test/node_modules/grpc
npm ERR! gyp ERR! node -v v15.14.0
npm ERR! gyp ERR! node-gyp -v v7.1.2
npm ERR! gyp ERR! not ok
```
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-19 01:48:27
[cucumber/cucumber-js] Issue opened by aslakhellesoy
<https://github.com/cucumber/cucumber-js/issues/1644|#1644 Allow using a HTTP proxy to send results>
<p>We should allow users behind a HTTP(S) proxy to publish results. The implementation could be based on <a href="https://github.com/TooTallNate/node-https-proxy-agent">https://github.com/TooTallNate/node-https-proxy-agent</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-19 01:54:45
[cucumber/cucumber-js] Comment on #1644
We should make sure all implementations use the same environment variables to configure proxy settings.
• <a href="https://github.com/cucumber/cucumber-ruby/issues/1526">cucumber/cucumber-ruby#1526</a>
• <a href="https://github.com/cucumber/cucumber-jvm/issues/2285">cucumber/cucumber-jvm#2285</a>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-19 02:16:46
[cucumber/cucumber-js] Comment on #1304
<a href="https://github.com/davidjgoss">@davidjgoss</a> does <a href="https://github.com/cucumber/cucumber-js/pull/1589">#1589</a> being merged is enough for that issue to be closed? Or do we need something else?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-19 03:30:01
[cucumber/cucumber-js] Comment on #1621
I have investigated the issue further.
Indeed, the json formatter does not support tags on examples. It actually should.
The new json-formatter does not help here. It does not recognize examples tags either.
As the built-in json formatter is deprectated, I will focus on fixing the new standalone one.
<a href="https://github.com/xenbartolokath">@xenbartolokath</a> <a href="https://github.com/yopasa94">@yopasa94</a> do you have specific need in using the legacy deprecated formatter? Or anything else which would prevent you to use the new <a href="https://github.com/cucumber/cucumber/tree/master/json-formatter">standalone json formatter</a>?
Which version of cucumber are you using?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-19 04:17:31
[cucumber/cucumber-js] Comment on #1621
Hi <a href="https://github.com/aurelien-reeves">@aurelien-reeves</a>,
For this issue, I was using @cucumber/cucumber v7.0.0, but I still use v6.0.5 on other repositories that I have.
I don't have specific need in the legacy deprecated formatter. For the standalone json formatter, I saw that I needed to download and execute some commands to install it, and I don't know if my pipeline's current setup would accommodate the changes. I prefer installing it via npm if available.
As long us I can put tags on Examples tables and generate reports without problems, then I'm good with it. 😃
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-19 05:12:05
[cucumber/cucumber-js] Comment on #1621
FYI the standalone json-formatter is a standalone binary written in go. It does not require any installation beside making sure it is executable.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-19 18:48:26
[cucumber/cucumber-js] Comment on #1621
> FYI the standalone json-formatter is a standalone binary written in go. It does not require any installation beside making sure it is executable.
Got it. Thanks for the clarification. 😊
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-20 08:21:53
[cucumber/cucumber-js] Comment on #1588
<a href="https://github.com/charlierudolph">@charlierudolph</a>, we are good now then. Please let me know if there is anything else we need from this PR.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-20 09:45:32
[cucumber/cucumber-js] Comment on #1304
Thanks for the nudge <a href="https://github.com/aurelien-reeves">@aurelien-reeves</a>!
Version 7.2.0 of `@cucumber/cucumber` is now on npm, including experimental support for ESM as described in the docs here:
<a href="https://github.com/cucumber/cucumber-js/blob/master/docs/cli.md#es-modules-experimental-nodejs-12">https://github.com/cucumber/cucumber-js/blob/master/docs/cli.md#es-modules-experimental-nodejs-12</a>
If those interested could give it a try and report what you find that would be great. I put a super minimal example project up here:
<a href="https://github.com/davidjgoss/cucumber-esm-example">https://github.com/davidjgoss/cucumber-esm-example</a>
Happy to keep this issue open for a bit just to catch the early feedback in one place.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-20 17:47:47
[cucumber/cucumber-js] Issue opened by jan-molak
<p>Hey <a href="https://github.com/davidjgoss">@davidjgoss</a> and <a href="https://github.com/charlierudolph">@charlierudolph</a>!</p>
<p>It looks like support for ESM introduced in <code>7.2.0</code> (<a href="https://github.com/cucumber/cucumber-js/pull/1589">#1589</a>) breaks a number of external reporters, as it no longer allows for sub-module imports.</p>
<p>This manifests itself with an error in projects that attempt a sub-module import.</p>
<p>For example, calling either:</p>
<pre><code>const TestCaseHookDefinition = require('@cucumber/cucumber/lib/models/test_case_hook_definition')
</code></pre>
<p>or:</p>
<pre><code>import TestCaseHookDefinition from '@cucumber/cucumber/lib/models/test_case_hook_definition';
</code></pre>
<p>results in:</p>
<pre><code>Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './lib/models/test_case_hook_definition'
is not defined by "exports" in /path/to/project/node_modules/@cucumber/cucumber/package.json
</code></pre>
<p>Affected projects I'm aware of (there could be more):</p>
<p>• Serenity/JS - <code>@serenity-js/cucumber</code> module relies on following sub-module imports:
• <code>@cucumber/cucumber/package.js</code> (to read the version)
• <code>@cucumber/cucumber/lib/models/test_case_hook_definition</code> - to instantiate <code>TestCaseHookDefinition</code>
• <a href="https://github.com/jbpros">@jbpros</a> <code>cucumber-pretty-formatter</code> - see <a href="https://github.com/jbpros/cucumber-pretty-formatter/issues/2">jbpros/cucumber-pretty-formatter#2</a>, which relies on loading:
• <code>@cucumber/cucumber/lib/formatter</code> - <code>IFormatterOptions</code>
• <code>@cucumber/cucumber/lib/formatter/helpers</code> - <code>formatLocation</code>
• <code>@cucumber/cucumber/lib/formatter/helpers/gherkin_document_parser</code> - <code>getGherkinExampleRuleMap</code>, <code>getGherkinScenarioMap</code>, <code>getGherkinStepMap</code>
• <code>@cucumber/cucumber/lib/formatter/helpers/pickle_parser</code> - <code>getPickleStepMap</code>
• <a href="https://github.com/christian-bromann">@christian-bromann</a> - <code>@wdio/cucumber-framework</code>, which loads:
• <code>@cucumber/cucumber/lib/support_code_library_builder/types</code> - <code>ITestCaseHookParameter</code>
• <code>@cucumber/cucumber/lib/formatter/helpers/event_data_collector</code> - <code>EventDataCollector</code>
• <code>@cucumber/cucumber/lib/support_code_library_builder/types</code> - <code>ITestCaseHookParameter</code>
• <code>@cucumber/cucumber/lib/runtime</code> - <code>IRuntimeOptions</code></p>
<p>Would it be possible for Cucumber.js to export the above classes, types, and functions, for example under <code>reporters</code> namespace (or something similar so that they don't get in the way of regular users):</p>
<pre><code>import { reporters } from '@cucumber/cucumber';
reporters.TestCaseHookDefinition
</code></pre>
<p>Alternatively, would it be possible to revert those changes if the above proposal requires too much work?</p>
<p>Thanks,<br />
Jan</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-21 01:51:23
[cucumber/cucumber-js] Issue closed by aurelien-reeves
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-21 02:12:29
[cucumber/cucumber-js] Comment on #1646
<a href="https://github.com/jan-molak">@jan-molak</a>
> It looks like support for ESM introduced in 7.2.0 (<a href="https://github.com/cucumber/cucumber-js/pull/1589">#1589</a>) breaks a number of external reporters, as it no longer allows for sub-module imports.
Just to quickly clarify, this only occurs when using `--esm`, right?
I had noticed the issue with pretty as well today, I will look at the impact of expanding what we export on the main entry point. Most looks reasonable but we'll need to be careful as we're effectively adding new things to the API contract which undoing later would be a breaking change.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-21 02:30:24
[cucumber/cucumber-js] Comment on #1646
Hi <a href="https://github.com/davidjgoss">@davidjgoss</a>!
> Just to quickly clarify, this only occurs when using --esm, right?
No, the issue occurs whenever an external project tries to import any sub-module from `@cucumber/cucumber`.
I've reproduced the issue here - <a href="https://github.com/jan-molak/cucumber-js-1646">https://github.com/jan-molak/cucumber-js-1646</a>
```
git clone <https://github.com/jan-molak/cucumber-js-1646.git>
cd cucumber-js-1646
npm install
npm start
```
See error:
```
> cucumber-js-1646@1.0.0 start /path/to/jan-molak/cucumber-js-1646
> node index.js
internal/modules/cjs/loader.js:438
throw e;
^
Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './lib/models/test_case_hook_definition' is not defined by "exports" in /path/to/jan-molak/cucumber-js-1646/node_modules/@cucumber/cucumber/package.json
at throwExportsNotFound (internal/modules/esm/resolve.js:290:9)
at packageExportsResolve (internal/modules/esm/resolve.js:513:3)
at resolveExports (internal/modules/cjs/loader.js:432:36)
at Function.Module._findPath (internal/modules/cjs/loader.js:472:31)
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:867:27)
at Function.Module._load (internal/modules/cjs/loader.js:725:27)
at Module.require (internal/modules/cjs/loader.js:952:19)
at require (internal/modules/cjs/helpers.js:88:18)
at Object.<anonymous> (/path/to/jan-molak/cucumber-js-1646/index.js:1:32)
```
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-21 05:28:18
[cucumber/cucumber-js] Comment on #1621
A fix has been merged in the new standalone json-formatter
But I'll try to fix the legacy built-in formatter too
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-21 05:28:19
[cucumber/cucumber-js] Issue reopened by aurelien-reeves
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-21 05:30:34
[cucumber/cucumber-js] Comment on #1304
Refs. <a href="https://github.com/cucumber/cucumber-js/issues/1646">#1646</a>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-21 06:23:06
[cucumber/cucumber-js] Pull request opened by davidjgoss
<p>See <a href="https://github.com/cucumber/cucumber-js/issues/1646">#1646</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-21 06:36:46
[cucumber/cucumber-js] Comment on #1647
<a href="https://coveralls.io/builds/39007829">Coverage Status</a>
Coverage increased (+0.08%) to 98.575% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/49e1703176c75994746050d5ee43b350a4f48895">49e1703</a> on revert-esm* into *<a href="https://github.com/cucumber/cucumber-js/commit/b7edd0f15f78e287a88d74ba9155597929320882">b7edd0f</a> on master*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-21 06:43:17
[cucumber/cucumber-js] Review on #
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-21 07:44:37
[cucumber/cucumber-js] Issue opened by mattwynne
<p>When we converted cucumber-js from JavaScript to TypeScript, we used the <code>any</code> type quite liberally to hasten the process.</p>
<p>We have a long-term goal to replace all instances of <code>any</code> with the suitable type.</p>
<p>This would make a great first-timer contribution to potter around in the code and get to know it. As always, you can find the commiters in the <a href="https://cucumber.io/community#slack">https://cucumber.io/community#slack</a> if you need any guidance.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-21 07:49:53
[cucumber/cucumber-js] Pull request merged by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-21 08:23:28
[cucumber/cucumber-js] Comment on #1648
Probably worth a qualifier that IIRC a lot of the `any` is in the JSON formatter, which is deprecated and probably not worth changing. Other than that though this would definitely be great.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-21 13:47:20
[cucumber/cucumber-js] Comment on #1646
Okay, 7.2.1 is out with a revert, I'll dig back into the ESM thing and see if there's a way we can avoid this issue. Thanks for raising <a href="https://github.com/jan-molak">@jan-molak</a>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-21 13:47:21
[cucumber/cucumber-js] Issue closed by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-21 13:49:42
[cucumber/cucumber-js] Comment on #1304
So this change caused an issue with third-party frameworks and formatters that `require` certain stuff directly (as opposed to from the entry point). I've released 7.2.1 which is basically a revert to 7.1.0 to unblock those folks, and I'll dig into the cause and see if we can avoid it while still supporting ESM. In the meantime, if that doesn't affect you, 7.2.0 is still there to experiment with.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-21 14:55:29
[cucumber/cucumber-js] Comment on #1646
Thanks for responding so quickly, <a href="https://github.com/davidjgoss">@davidjgoss</a>!
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-22 02:18:23
[cucumber/cucumber-js] Comment on #1621
<a href="https://github.com/xenbartolokath">@xenbartolokath</a> <a href="https://github.com/yopasa94">@yopasa94</a> The standalone json-formatter has just been released with the support of tagged examples.
You can download it there: <https://github.com/cucumber/cucumber/releases/tag/cucumber-json-formatter%2Fv17.0.2|https://github.com/cucumber/cucumber/releases/tag/cucumber-json-formatter%2Fv17.0.2>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-22 05:16:18
[cucumber/cucumber-js] Comment on #1649
Added a scenario to prove the issue, where user support code does e.g.:
```
const TestCaseHookDefinition = require('@cucumber/cucumber/lib/models/test_case_hook_definition')
```
And we get an error like:
```
Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './lib/models/test_case_hook_definition' is not defined by "exports" in /Users/davidgoss/Projects/cucumber-js/package.json imported from /Users/davidgoss/Projects/cucumber-js/tmp/direct_imports.feature_49/features/step_definitions/cucumber_steps.js
at throwExportsNotFound (internal/modules/esm/resolve.js:285:9)
at packageExportsResolve (internal/modules/esm/resolve.js:508:3)
at trySelf (internal/modules/cjs/loader.js:400:34)
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:793:24)
at Function.Module._load (internal/modules/cjs/loader.js:667:27)
at Module.require (internal/modules/cjs/loader.js:887:19)
at require (internal/modules/cjs/helpers.js:74:18)
at Object.<anonymous> (/Users/davidgoss/Projects/cucumber-js/tmp/direct_imports.feature_49/features/step_definitions/cucumber_steps.js:2:32)
at Module._compile (internal/modules/cjs/loader.js:999:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
at Module.load (internal/modules/cjs/loader.js:863:32)
at Function.Module._load (internal/modules/cjs/loader.js:708:14)
at Module.require (internal/modules/cjs/loader.js:887:19)
at require (internal/modules/cjs/helpers.js:74:18)
at World.<anonymous> (/Users/davidgoss/Projects/cucumber-js/features/support/hooks.ts:119:11)
```
This happens whether or not you're using ESM, and is because of the new block added to our `package.json`:
```
"exports": {
"import": "./lib/wrapper.mjs",
"require": "./lib/index.js"
},
```
We need this in order for ESM to work (and for CommonJS to still work), but it does have the effect of enforcing that `require`s can only be done at the entry point, meaning "deep" ones to individual files will fail.
Node has the concept of <a href="https://nodejs.org/docs/latest-v14.x/api/packages.html#packages_subpath_patterns">subpath patterns</a> for this kind of thing, but this can't be mix-and-matched with the usage of `exports` for ESM vs CommonJS entry points like we have, so that's off the table.
* * *
My current thinking: the public API for cucumber-js is what we expose on the main entry point. Once you `require` other things via their file path, you're into the weeds; package authors understand this. So in principle running with this as it is wouldn't be a breaking change...but it would be disruptive to end users and it's not their fault.
We could instead:
1. Add things to our main entry point to address the needs of package authors (see list in <a href="https://github.com/cucumber/cucumber-js/issues/1646">#1646</a>)
2. Submit PRs to those projects to update their imports
3. Release this change again as semver minor
WDYT <a href="https://github.com/charlierudolph">@charlierudolph</a> <a href="https://github.com/aurelien-reeves">@aurelien-reeves</a> ?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-22 05:24:16
[cucumber/cucumber-js] Comment on #1640
<a href="https://github.com/aurelien-reeves">@aurelien-reeves</a> updated!
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-22 12:46:59
[cucumber/cucumber-js] Pull request opened by davidjgoss
<p>Closes <a href="https://github.com/cucumber/cucumber-js/issues/1250">#1250</a> as agreed in today's community call for all implementations.</p>
<p>The previous deprecation has resulted in some hesitation to upgrade from users who use tools that rely on the JSON formatter output.</p>
<p>The tone now is about "maintenance mode" - it'll stay functional, but won't benefit from any new features. As the documentation and tooling around messages improves, we'll gradually encourage authors of maintained tools to switch over to that. Feedback welcome on the exact wording. Also, the noisy console warning is gone.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2413780560)
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2413722339)
GitHub
2021-04-22 12:49:38
[cucumber/cucumber-js] Comment on #1650
<a href="https://coveralls.io/builds/39057838">Coverage Status</a>
Coverage decreased (-0.0007%) to 98.574% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/932aa506fb3d8bdb19d6e1dad0a333e5abbdb563">932aa50</a> on undeprecate-json-formatter* into *<a href="https://github.com/cucumber/cucumber-js/commit/4f1015f94fcc4ea42f3d9b16c8100d1837fd9719">4f1015f</a> on master*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-22 14:49:47
[cucumber/cucumber-js] Comment on #1489
Thanks <a href="https://github.com/yopasa94">@yopasa94</a> , I'm a bit tied up with some other work currently. I'll come back to this as soon as I get a gap.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-23 00:22:32
[cucumber/cucumber-js] Comment on #1650
Why the `*` at the end of the sentence?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-23 00:29:44
[cucumber/cucumber-js] Comment on #1650
Closes the one before “Note”, to italicise that section
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-23 02:16:10
[cucumber/cucumber-js] Comment on #1651
<a href="https://coveralls.io/builds/39073548">Coverage Status</a>
Coverage decreased (-3.2%) to 95.336% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/159eaade8cbc6a76a5b740adc220374d3977364e">159eaad</a> on fix-1621-json-formatter-tagged-examples* into *<a href="https://github.com/cucumber/cucumber-js/commit/4f1015f94fcc4ea42f3d9b16c8100d1837fd9719">4f1015f</a> on master*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-23 02:21:55
[cucumber/cucumber-js] Comment on #1650
👍
I looked for it, did not found it before. Now I do 😅
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-23 06:47:25
[cucumber/cucumber-js] Pull request ready for review by aurelien-reeves
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-23 08:55:25
[cucumber/cucumber-js] Comment on #1651
Consider inlining this function in the `map` for better readability
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-23 08:55:25
[cucumber/cucumber-js] Comment on #1651
Could this method be private?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-23 08:55:25
[cucumber/cucumber-js] Review on #
Looks good, couple of queries, and I think we still need a changelog entry.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-23 08:55:25
[cucumber/cucumber-js] Comment on #1651
Would it be worth testing the multiple examples tables with different tags here?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-23 09:10:08
[cucumber/cucumber-js] Comment on #1651
> Looks good, couple of queries, and I think we still need a changelog entry.
I've pushed an update to the changelog.
The PR has not been updated yet, but the branch is <a href="https://github.com/cucumber/cucumber-js/commits/fix-1621-json-formatter-tagged-examples">https://github.com/cucumber/cucumber-js/commits/fix-1621-json-formatter-tagged-examples</a>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-23 09:11:40
[cucumber/cucumber-js] Comment on #1651
Yes, it could.
Why other methods in that class are not private?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-23 09:12:49
[cucumber/cucumber-js] Comment on #1651
Actually I did it that way for readability
But maybe it is unsuccessful 😅
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-23 09:13:55
[cucumber/cucumber-js] Comment on #1651
Yes, I'll do that.
We could even add two example tables with more tags to cover even more possibilities!?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-23 09:19:31
[cucumber/cucumber-js] Comment on #1651
Most of the time array fns like `map` and `filter` tend to be inline (at least in JS land), so I think it's a more familiar style. Subjective though, not super fussed about it.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-23 09:25:30
[cucumber/cucumber-js] Comment on #1651
Good question!
I guess technically the class could be extended by a user for their own formatter, though I'm not sure why anyone would extend this one.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-23 09:27:08
[cucumber/cucumber-js] Comment on #1651
I think two scenarios - one with the simplest, one with the most complex permutation you mentioned - should be good.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-23 09:28:58
[cucumber/cucumber-js] Comment on #1651
> I've pushed an update to the changelog...The PR has not been updated yet
Really confused about how/why this commit doesn't show up on the PR - is there a trick I don't know? :)
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-23 10:35:54
[cucumber/cucumber-js] Comment on #1651
> > I've pushed an update to the changelog...The PR has not been updated yet
>
> Really confused about how/why this commit doesn't show up on the PR - is there a trick I don't know? :)
I know it may happen when there are issue with github webhook
But did not saw any outage today on github 🤔
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-23 10:37:13
[cucumber/cucumber-js] Comment on #1651
I'll update the PR with your remarks at the latest on monday
Thanks for your review :)
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-23 15:10:20
[cucumber/cucumber-js] Review on #
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-23 22:02:40
[cucumber/cucumber-js] Issue closed by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-23 22:02:40
[cucumber/cucumber-js] Pull request merged by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-26 01:04:57
[cucumber/cucumber-js] Review on #
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-26 03:30:03
[cucumber/cucumber-js] Issue closed by aurelien-reeves
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-26 03:30:04
[cucumber/cucumber-js] Pull request merged by aurelien-reeves
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-26 04:02:08
[cucumber/cucumber-js] Comment on #1621
<a href="https://github.com/aurelien-reeves">@aurelien-reeves</a> Will try this out and will let you know if there are some feedbacks from my end. Thank you! Appreciated your time and effort 😊
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-26 07:37:39
[cucumber/cucumber-js] Comment on #1568
Sorry for the late reply
We have added the PR to the Cucumber Open Board: <a href="https://github.com/orgs/cucumber/projects/8">https://github.com/orgs/cucumber/projects/8</a>
We will review your solution soon
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-26 07:42:42
[cucumber/cucumber-js] Comment on #1575
Thank you for your contribution
We want stricter typing than what you have proposed
See. <a href="https://github.com/cucumber/cucumber/issues/1138">cucumber/cucumber#1138</a> which would apply to cucumber-js too
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-26 07:42:43
[cucumber/cucumber-js] Pull request closed by aurelien-reeves
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-26 07:44:26
[cucumber/cucumber-js] Comment on #1587
<a href="https://github.com/davidjgoss">@davidjgoss</a> would you have any info about this one?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-26 07:46:36
[cucumber/cucumber-js] Comment on #1587
<a href="https://github.com/aurelien-reeves">@aurelien-reeves</a> ah thanks for the nudge, this can close actually, needs a different approach
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-26 07:46:37
[cucumber/cucumber-js] Pull request closed by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-27 22:36:33
[cucumber/cucumber-js] Comment on #1489
Thanks <a href="https://github.com/yopasa94">@yopasa94</a> . A few questions from your implementation if you would be so kind?
I assume the `parseGherkinMessageStream` is in @cucumber/cucumber/lib/cli/helper.js?
What are the following properties being passed as the object arguement to `parseGherkinMessageStream`, did you define them, if so how and where, as I'll need to replicate them:
• `eventDataCollector`
• `gherkinMessageStream`
• `formatterHelpers`
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-28 07:40:47
[cucumber/cucumber-js] Issue opened by dmitriyKowWib
<p>Fails to create json report file after run:<br />
47 scenarios (14 failed, 18 skipped, 15 passed)<br />
347 steps (14 failed, 156 skipped, 177 passed)<br />
3m15.454s (executing steps: 18m36.066s)</p>
<p>/home/jenkins/apiAutomation/node<em>modules/@cucumber/cucumber/lib/formatter/json</em>formatter.js:185<br />
: scenarioSource.location.line;<br />
^</p>
<p>TypeError: Cannot read property 'location' of undefined<br />
at lodash<em>1.default.map (/home/jenkins/apiAutomation/node</em>modules/@cucumber/cucumber/lib/formatter/json<em>formatter.js:185:34)<br />
at arrayMap (/home/jenkins/apiAutomation/node</em>modules/@cucumber/cucumber/node<em>modules/lodash/lodash.js:653:23)<br />
at Function.map (/home/jenkins/apiAutomation/node</em>modules/@cucumber/cucumber/node<em>modules/lodash/lodash.js:9622:14)<br />
at JsonFormatter.getScenarioTags (/home/jenkins/apiAutomation/node</em>modules/@cucumber/cucumber/lib/formatter/json<em>formatter.js:180:33)<br />
at JsonFormatter.getScenarioData (/home/jenkins/apiAutomation/node</em>modules/@cucumber/cucumber/lib/formatter/json<em>formatter.js:125:24)<br />
at group.map (/home/jenkins/apiAutomation/node</em>modules/@cucumber/cucumber/lib/formatter/json<em>formatter.js:84:29)<br />
at Array.map ()<br />
at lodash</em>1.default.map (/home/jenkins/apiAutomation/node<em>modules/@cucumber/cucumber/lib/formatter/json</em>formatter.js:69:36)<br />
at /home/jenkins/apiAutomation/node<em>modules/@cucumber/cucumber/node</em>modules/lodash/lodash.js:3585:27<br />
at /home/jenkins/apiAutomation/node<em>modules/@cucumber/cucumber/node</em>modules/lodash/lodash.js:4967:15<br />
at baseForOwn (/home/jenkins/apiAutomation/node<em>modules/@cucumber/cucumber/node</em>modules/lodash/lodash.js:3032:24)<br />
at /home/jenkins/apiAutomation/node<em>modules/@cucumber/cucumber/node</em>modules/lodash/lodash.js:4936:18<br />
at baseMap (/home/jenkins/apiAutomation/node<em>modules/@cucumber/cucumber/node</em>modules/lodash/lodash.js:3584:7)<br />
at Function.map (/home/jenkins/apiAutomation/node<em>modules/@cucumber/cucumber/node</em>modules/lodash/lodash.js:9622:14)<br />
at JsonFormatter.onTestRunFinished (/home/jenkins/apiAutomation/node<em>modules/@cucumber/cucumber/lib/formatter/json</em>formatter.js:63:43)<br />
at EventEmitter.JsonFormatter.options.eventBroadcaster.on (/home/jenkins/apiAutomation/node<em>modules/@cucumber/cucumber/lib/formatter/json</em>formatter.js:23:22)<br />
at EventEmitter.emit (events.js:187:15)<br />
at Coordinator.onWorkerProcessClose (/home/jenkins/apiAutomation/node<em>modules/@cucumber/cucumber/lib/runtime/parallel/coordinator.js:109:35)<br />
at ChildProcess.worker.process.on (/home/jenkins/apiAutomation/node</em>modules/@cucumber/cucumber/lib/runtime/parallel/coordinator.js:92:18)<br />
at ChildProcess.emit (events.js:182:13)<br />
at maybeClose (internal/child<em>process.js:962:16)<br />
at Process.ChildProcess.</em>handle.onexit (internal/child_process.js:251:5)</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-28 09:24:34
[cucumber/cucumber-js] Comment on #1652
What Cucumber version <a href="https://github.com/dmitriyKowWib">@dmitriyKowWib</a>?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-28 15:17:12
[cucumber/cucumber-js] Comment on #1649
<a href="https://github.com/davidjgoss">@davidjgoss</a> to avoid "polluting" the main entry point with functions and classes only package authors need to know about you might want to consider exporting them under some object like `internal`.
So a regular Cucumber user would only see one additional thing exported by the module, for example:
```
import { Given, When, Then, internal } from '@cucumber/cucumber'
const definition = new internal.TestCaseHookDefinition(...)
```
This way you could keep attaching "internal" functions useful for package maintainers without making it disruptive.
Could this work?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-28 16:14:58
[cucumber/cucumber-js] Comment on #1652
Please provide an example that lets us reproduce this.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-29 07:11:14
[cucumber/cucumber-js] Comment on #1532
Another downstream compilation issue:
If tsconfig.json contains `compilerOptions.strict = true` then compiler will complain about not finding lodash types (unless you already have @types/lodash installed somewhere) eg.
```
node_modules/@cucumber/cucumber/lib/formatter/helpers/event_data_collector.d.ts:2:28 - error TS7016: Could not find a declaration file for module 'lodash'. 'C:/Code/ref-boilerplate-core/node_modules/@cucumber/cucumber/node_modules/lodash/lodash.js' implicitly has an 'any' type.
Try `npm i --save-dev @types/lodash` if it exists or add a new declaration (.d.ts) file containing `declare module 'lodash';`
2 import { Dictionary } from 'lodash';
```
I think @types/lodash needs to be in cucumbers dependencies instead of devDependencies. Simple workaround in the meantime is to just install @types/lodash in the downstream.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-29 07:41:01
[cucumber/cucumber-js] Comment on #1532
Good find <a href="https://github.com/lyndoh">@lyndoh</a> - I don't think we should be relying on the `Dictionary` type for that. I'll try and break that dependency.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-30 00:49:16
[cucumber/cucumber-js] Comment on #1649
<a href="https://github.com/jan-molak">@jan-molak</a> I think that's a good point yeah. It's still part of the API but at least grouped where it's less commonly used. I think there is some prior art here with `formatterHelpers`
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-30 18:25:25
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2480329706)
GitHub
2021-04-30 18:25:40
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2480330785)
GitHub Actions: test (ubuntu-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2480330776)
GitHub
2021-04-30 20:23:26
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Disabled due to failing status checks.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-30 20:23:27
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Release Notes</strong>
Microsoft/TypeScript
<strong><a href="https://togithub.com/Microsoft/TypeScript/releases/v4.2.4"><code>v4.2.4</code></a></strong></p>
<p><a href="https://togithub.com/Microsoft/TypeScript/compare/v4.2.3...v4.2.4">Compare Source</a></p>
<p>For release notes, check out the <a href="https://devblogs.microsoft.com/typescript/announcing-typescript-4-2">release announcement</a>.</p>
<p>For the complete list of fixed issues, check out the</p>
<p>• <https://togithub.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+4.2.0%22+is%3Aclosed+|fixed issues query for TypeScript v4.2.0 (Beta)>.
• <https://togithub.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+4.2.1%22+is%3Aclosed+|fixed issues query for TypeScript v4.2.1 (RC)>.
• <https://togithub.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+4.2.2%22+is%3Aclosed+|fixed issues query for TypeScript v4.2.2 (Stable)>.
• <https://togithub.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+4.2.3%22+is%3Aclosed+|fixed issues query for TypeScript v4.2.3>.
• <https://togithub.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+4.2.4%22+is%3Aclosed+|fixed issues query for TypeScript v4.2.4>.</p>
<p>Downloads are available on:</p>
<p>• <a href="https://www.npmjs.com/package/typescript">npm</a>
• <a href="https://marketplace.visualstudio.com/items?itemName=TypeScriptTeam.TypeScript-424">Visual Studio 2017/2019</a> (<a href="https://togithub.com/Microsoft/TypeScript/wiki/Updating-TypeScript-in-Visual-Studio-2017">Select new version in project options</a>)
• <a href="https://www.nuget.org/packages/Microsoft.TypeScript.MSBuild">NuGet package</a></p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Disabled due to failing status checks.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2480699306)
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2480332097)
GitHub Actions: test (windows-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2480332015)
GitHub
2021-04-30 22:17:52
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Release Notes</strong>
typescript-eslint/typescript-eslint
<strong><a href="https://togithub.com/typescript-eslint/typescript-eslint/blob/master/CHANGELOG.md#%E2%80%8B4220-httpsgithubcomtypescript-eslinttypescript-eslintcomparev4210v4220-2021-04-12|<code">https://togithub.com/typescript-eslint/typescript-eslint/blob/master/CHANGELOG.md#%E2%80%8B4220-httpsgithubcomtypescript-eslinttypescript-eslintcomparev4210v4220-2021-04-12|<code</a>v4.22.0</code>></strong></p>
<p><a href="https://togithub.com/typescript-eslint/typescript-eslint/compare/v4.21.0...v4.22.0">Compare Source</a></p>
<p><strong>Bug Fixes</strong></p>
<p>• <strong>eslint-plugin:</strong> [no-unsafe-argument] handle tuple types on rest arguments (<a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/3269">#3269</a>) (<a href="https://togithub.com/typescript-eslint/typescript-eslint/commit/6f8cfe6f83ee26b66b2146cc17b1205100a54a9c">6f8cfe6</a>)</p>
<p><strong>Features</strong></p>
<p>• <strong>eslint-plugin:</strong> [prefer-regexp-exec] add autofix (<a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/3207">#3207</a>) (<a href="https://togithub.com/typescript-eslint/typescript-eslint/commit/e2cbeefb3d9a7cce257b5675f7f19f1b159a9d26">e2cbeef</a>)</p>
<p><strong><a href="https://togithub.com/typescript-eslint/typescript-eslint/blob/master/CHANGELOG.md#%E2%80%8B4210-httpsgithubcomtypescript-eslinttypescript-eslintcomparev4200v4210-2021-04-05|<code">https://togithub.com/typescript-eslint/typescript-eslint/blob/master/CHANGELOG.md#%E2%80%8B4210-httpsgithubcomtypescript-eslinttypescript-eslintcomparev4200v4210-2021-04-05|<code</a>v4.21.0</code>></strong></p>
<p><a href="https://togithub.com/typescript-eslint/typescript-eslint/compare/v4.20.0...v4.21.0">Compare Source</a></p>
<p><strong>Bug Fixes</strong></p>
<p>• <strong>eslint-plugin:</strong> [no-type-alias] consider <code>keyof</code> as an alias (<a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/3242">#3242</a>) (<a href="https://togithub.com/typescript-eslint/typescript-eslint/commit/329ef023090c004694b5996ddb04fdde5b05ebb0">329ef02</a>)
• <strong>eslint-plugin:</strong> [no-unnecessary-type-assertion] correct bad fix for angle bracket assertion (<a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/3244">#3244</a>) (<a href="https://togithub.com/typescript-eslint/typescript-eslint/commit/265a039c7e728b719143e09ee61066039d721f62">265a039</a>)
• <strong>eslint-plugin:</strong> [restrict-plus-operands] consider template literal types as strings (<a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/3234">#3234</a>) (<a href="https://togithub.com/typescript-eslint/typescript-eslint/commit/ccfd68e365391b3f117df96792355f9c3655288c">ccfd68e</a>)
• <strong>eslint-plugin:</strong> [strict-boolean-expressions] account for truthy literals (<a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/3236">#3236</a>) (<a href="https://togithub.com/typescript-eslint/typescript-eslint/commit/0913f40c87762de198b05a5473b4fb79aeb46967">0913f40</a>)
• <strong>eslint-plugin:</strong> always ignore assignments in no-unnecessary-type-assertion (<a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/3235">#3235</a>) (<a href="https://togithub.com/typescript-eslint/typescript-eslint/commit/02214768a3721d8514c70e00546e861da6581e4d">0221476</a>)</p>
<p><strong>Features</strong></p>
<p>• <strong>eslint-plugin:</strong> [no-unsafe-argument] add rule (<a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/3256">#3256</a>) (<a href="https://togithub.com/typescript-eslint/typescript-eslint/commit/b1aa7dc6971ee8409b729dffb8b69478455734ed">b1aa7dc</a>), closes <a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/791">#791</a>
• <strong>eslint-plugin:</strong> [no-unsafe-call][no-unsafe-member-access] improve report messages for <code>this</code> for <code>noImplicitThis</code> (<a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/3199">#3199</a>) (<a href="https://togithub.com/typescript-eslint/typescript-eslint/commit/b1b26c4843a4cfa209a0c9c3d8bea1de37333b48">b1b26c4</a>)</p>
<p>eslint/eslint
<strong><a href="https://togithub.com/eslint/eslint/releases/v7.25.0"><code>v7.25.0</code></a></strong></p>
<p><a href="https://togithub.com/eslint/eslint/compare/v7.24.0...v7.25.0">Compare Source</a></p>
<p>• <a href="https://togithub.com/eslint/eslint/commit/5df5e4a9976964fcf4dc67e241d4e22ec1370fe0"><code>5df5e4a</code></a> Update: highlight last write reference for no-unused-vars (fixes <a href="https://togithub.com/eslint/eslint/issues/14324">#14324</a>) (<a href="https://togithub.com/eslint/eslint/issues/14335">#14335</a>) (Nitin Kumar)
• <a href="https://togithub.com/eslint/eslint/commit/00238729329b86b4f8af89ebfe278da3095a6075"><code>0023872</code></a> Docs: Add deprecated note to <code>working-with-rules-deprecated</code> page (<a href="https://togithub.com/eslint/eslint/issues/14344">#14344</a>) (Michael Novotny)
• <a href="https://togithub.com/eslint/eslint/commit/36fca70fa29ab65080076810de98e09133254b8a"><code>36fca70</code></a> Chore: Upgrade eslump to 3.0.0 (<a href="https://togithub.com/eslint/eslint/issues/14350">#14350</a>) (Stephen Wade)
• <a href="https://togithub.com/eslint/eslint/commit/59b689a0b3fa658b8380431007cc1facb4617a3b"><code>59b689a</code></a> Chore: add node v16 (<a href="https://togithub.com/eslint/eslint/issues/14355">#14355</a>) (薛定谔的猫)
• <a href="https://togithub.com/eslint/eslint/commit/35a1f5e967e4e87360d3e70d3fca0f7adeeaa1d7"><code>35a1f5e</code></a> Sponsors: Sync README with website (ESLint Jenkins)
• <a href="https://togithub.com/eslint/eslint/commit/fb0a92b3d2fed4a17bc39b7f02c540cd1175ec7d"><code>fb0a92b</code></a> Chore: rename misspelled identifier in test (<a href="https://togithub.com/eslint/eslint/issues/14346">#14346</a>) (Tobias Nießen)
• <a href="https://togithub.com/eslint/eslint/commit/f2babb1069194166e0ac1afd1269bbd06ac299b6"><code>f2babb1</code></a> Docs: update pull request template (<a href="https://togithub.com/eslint/eslint/issues/14336">#14336</a>) (Nitin Kumar)
• <a href="https://togithub.com/eslint/eslint/commit/02dde29eeb523ca24bc4ae7797d38627c3ba9fe9"><code>02dde29</code></a> Docs: Fix anchor in 'docs/developer-guide/working-with-rules.md' (<a href="https://togithub.com/eslint/eslint/issues/14332">#14332</a>) (Nate-Wilkins)
• <a href="https://togithub.com/eslint/eslint/commit/07d14c304c358fbc9c3d318e1377d2b2bda9179f"><code>07d14c3</code></a> Chore: remove extraneous command from lint-staged config (<a href="https://togithub.com/eslint/eslint/issues/14314">#14314</a>) (James George)
• <a href="https://togithub.com/eslint/eslint/commit/41b3570b6c014c534bb3208ed00050fd99842101"><code>41b3570</code></a> Update: lint code block with same extension but different content (<a href="https://togithub.com/eslint/eslint/issues/14227">#14227</a>) (JounQin)
• <a href="https://togithub.com/eslint/eslint/commit/eb299966bdc3920dd2c6f9774d95103d242fc409"><code>eb29996</code></a> Docs: add more examples with arrow functions for no-sequences rule (<a href="https://togithub.com/eslint/eslint/issues/14313">#14313</a>) (Nitin Kumar)</p>
<p><strong><a href="https://togithub.com/eslint/eslint/releases/v7.24.0"><code>v7.24.0</code></a></strong></p>
<p><a href="https://togithub.com/eslint/eslint/compare/v7.23.0...v7.24.0">Compare Source</a></p>
<p>• <a href="https://togithub.com/eslint/eslint/commit/0c346c87fa83c6d1184fdafb9c0748c2e15a423d"><code>0c346c8</code></a> Chore: ignore <code>pnpm-lock.yaml</code> (<a href="https://togithub.com/eslint/eslint/issues/14303">#14303</a>) (Nitin Kumar)
• <a href="https://togithub.com/eslint/eslint/commit/f06ecdf78b6d6f366434d73a6acfe7041d575223"><code>f06ecdf</code></a> Update: Add disallowTemplateShorthand option in no-implicit-coercion (<a href="https://togithub.com/eslint/eslint/issues/13579">#13579</a>) (Remco Haszing)
• <a href="https://togithub.com/eslint/eslint/commit/71a80e38aab2dada01b808ed43d9b0e806d863c4"><code>71a80e3</code></a> Docs: fix broken links in Node.js API docs toc (<a href="https://togithub.com/eslint/eslint/issues/14296">#14296</a>) (u-sho (Shouhei Uechi))
• <a href="https://togithub.com/eslint/eslint/commit/bd46dc4647faa4c3bbb5f60d4c00616a64081398"><code>bd46dc4</code></a> Docs: Fix incorrect reference to "braces" in arrow-parens (<a href="https://togithub.com/eslint/eslint/issues/14300">#14300</a>) (emclain)
• <a href="https://togithub.com/eslint/eslint/commit/0d6235ea201b8b90761ee69bb4d46ae18899c28d"><code>0d6235e</code></a> Docs: update header in max-lines (<a href="https://togithub.com/eslint/eslint/issues/14273">#14273</a>) (Shinigami)
• <a href="https://togithub.com/eslint/eslint/commit/70c92164017238e329e3a2d1654a0227b8f953f7"><code>70c9216</code></a> Docs: Update issue triage to include blocked column (<a href="https://togithub.com/eslint/eslint/issues/14275">#14275</a>) (Nicholas C. Zakas)
• <a href="https://togithub.com/eslint/eslint/commit/abca186a845200fd7728c4e5f220973e640054f9"><code>abca186</code></a> Docs: Fix typo in suggestions section (<a href="https://togithub.com/eslint/eslint/issues/14293">#14293</a>) (Kevin Partington)
• <a href="https://togithub.com/eslint/eslint/commit/c4d8b0db62b859e721105d4bc0f4044ce346995e"><code>c4d8b0d</code></a> Fix: no-unused-vars ignoreRestSiblings check assignments (fixes <a href="https://togithub.com/eslint/eslint/issues/14163">#14163</a>) (<a href="https://togithub.com/eslint/eslint/issues/14264">#14264</a>) (YeonJuan)
• <a href="https://togithub.com/eslint/eslint/commit/b51d0778d76c2aa27578caca3ea82c867dced3e4|<code">https://togithub.com/eslint/eslint/commit/b51d0778d76c2aa27578caca3ea82c867dced3e4|<code</a>b51d077</code>…</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-04-30 22:17:53
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Release Notes</strong>
sinonjs/fake-timers
<strong><a href="https://togithub.com/sinonjs/fake-timers/blob/master/CHANGELOG.md#%E2%80%8B705--2021-04-11|<code">https://togithub.com/sinonjs/fake-timers/blob/master/CHANGELOG.md#%E2%80%8B705--2021-04-11|<code</a>v7.0.5</code>></strong></p>
<p><a href="https://togithub.com/sinonjs/fake-timers/compare/v7.0.4...v7.0.5">Compare Source</a></p>
<p>==================</p>
<p>• Fix up some clock types in JSDoc (becomes <code>.d.ts</code>) (<a href="https://togithub.com/sinonjs/fake-timers/issues/370">#370</a>)
• Fix refresh arguments forwarding (<a href="https://togithub.com/sinonjs/fake-timers/issues/369">#369</a>)</p>
<p><strong><a href="https://togithub.com/sinonjs/fake-timers/blob/master/CHANGELOG.md#%E2%80%8B704--2021-04-08|<code">https://togithub.com/sinonjs/fake-timers/blob/master/CHANGELOG.md#%E2%80%8B704--2021-04-08|<code</a>v7.0.4</code>></strong></p>
<p><a href="https://togithub.com/sinonjs/fake-timers/compare/v7.0.2...v7.0.4">Compare Source</a></p>
<p>==================</p>
<p>• Fix usage with TypeScript</p>
<p>mesaugat/chai-exclude
<strong><a href="https://togithub.com/mesaugat/chai-exclude/releases/v2.0.3"><code>v2.0.3</code></a></strong></p>
<p><a href="https://togithub.com/mesaugat/chai-exclude/compare/v2.0.2...v2.0.3">Compare Source</a></p>
<p>• Support for assertion aliases <code>eql</code> and <code>eqls</code></p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Disabled due to failing status checks.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>👻 <strong>Immortal</strong>: This PR will be recreated if closed unmerged. Get <a href="https://togithub.com/renovatebot/renovate/discussions">config help</a> if that's undesired.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-01 01:36:19
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Release Notes</strong>
cucumber/cucumber-expressions-javascript
<strong><a href="https://togithub.com/cucumber/cucumber-expressions-javascript/compare/v12.1.0...v12.1.1"><code>v12.1.1</code></a></strong></p>
<p><a href="https://togithub.com/cucumber/cucumber-expressions-javascript/compare/v12.1.0...v12.1.1">Compare Source</a></p>
<p><strong><a href="https://togithub.com/cucumber/cucumber-expressions-javascript/compare/v12.0.1...v12.1.0"><code>v12.1.0</code></a></strong></p>
<p><a href="https://togithub.com/cucumber/cucumber-expressions-javascript/compare/v12.0.1...v12.1.0">Compare Source</a></p>
<p>cucumber/gherkin-javascript
<strong><a href="https://togithub.com/cucumber/gherkin-javascript/compare/v18.1.0...v18.1.1"><code>v18.1.1</code></a></strong></p>
<p><a href="https://togithub.com/cucumber/gherkin-javascript/compare/v18.1.0...v18.1.1">Compare Source</a></p>
<p><strong><a href="https://togithub.com/cucumber/gherkin-javascript/compare/v18.0.0...v18.1.0"><code>v18.1.0</code></a></strong></p>
<p><a href="https://togithub.com/cucumber/gherkin-javascript/compare/v18.0.0...v18.1.0">Compare Source</a></p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>👻 <strong>Immortal</strong>: This PR will be recreated if closed unmerged. Get <a href="https://togithub.com/renovatebot/renovate/discussions">config help</a> if that's undesired.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2481701556)
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2481701538)
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2481701521)
GitHub Actions: test (windows-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2481701502)
GitHub Actions: test (ubuntu-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2481701486)
GitHub Actions: test (ubuntu-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2481701469)
GitHub Actions: test (ubuntu-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2481701459)
GitHub Actions: test (ubuntu-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2481701452)
GitHub Actions: test (windows-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2481701313)
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2481701300)
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2481701290)
GitHub Actions: test (windows-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2481701274)
GitHub Actions: test (ubuntu-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2481701256)
GitHub Actions: test (ubuntu-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2481701247)
GitHub Actions: test (ubuntu-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2481701237)
GitHub Actions: test (ubuntu-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2481701220)
GitHub
2021-05-01 01:36:21
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Release Notes</strong>
xjamundx/eslint-plugin-promise
<strong><a href="https://togithub.com/xjamundx/eslint-plugin-promise/blob/master/CHANGELOG.md#%E2%80%8B510|<code">https://togithub.com/xjamundx/eslint-plugin-promise/blob/master/CHANGELOG.md#%E2%80%8B510|<code</a>v5.1.0</code>></strong></p>
<p><a href="https://togithub.com/xjamundx/eslint-plugin-promise/compare/7ac8796e8fa88a257619d7f98264604ef57045af...485509660ccc1901fd30040cf4e75c88922c6255">Compare Source</a></p>
<p>• Included <code>catch()</code> and <code>finally()</code> in <code>prefer-await-to-then</code> <a href="https://togithub.com/xjamundx/eslint-plugin-promise/issues/196">#196</a>
• Added some additional tests and upgraded some dev deps <a href="https://togithub.com/xjamundx/eslint-plugin-promise/issues/196">#196</a>
• Exempted array methods in prefer-await-to-callbacks (<a href="https://togithub.com/xjamundx/eslint-plugin-promise/issues/212">#212</a>)</p>
<p><strong><a href="https://togithub.com/xjamundx/eslint-plugin-promise/blob/master/CHANGELOG.md#%E2%80%8B500|<code">https://togithub.com/xjamundx/eslint-plugin-promise/blob/master/CHANGELOG.md#%E2%80%8B500|<code</a>v5.0.0</code>></strong></p>
<p><a href="https://togithub.com/xjamundx/eslint-plugin-promise/compare/v4.3.1...7ac8796e8fa88a257619d7f98264604ef57045af">Compare Source</a></p>
<p>• ESLint 7.0 Support</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Disabled by config. Please merge this manually once you are satisfied.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2481668567)
GitHub Actions: test (ubuntu-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2481668539)
GitHub Actions: test (windows-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2480335593)
GitHub
2021-05-01 01:46:38
[cucumber/cucumber-js] Pull request merged by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-01 01:49:43
[cucumber/cucumber-js] Comment on #1653
<a href="https://coveralls.io/builds/39281647">Coverage Status</a>
Coverage remained the same at 98.624% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/8c1dc76b2f3b57c8ff8613c212e21c8c53ddd6a0">8c1dc76</a> on renovate/fs-extra-9.x* into *<a href="https://github.com/cucumber/cucumber-js/commit/dadfc510bb80b088348e904ce87559e464819991">dadfc51</a> on master*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-01 01:53:37
[cucumber/cucumber-js] Comment on #1654
<a href="https://coveralls.io/builds/39281671">Coverage Status</a>
Coverage remained the same at 98.624% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/3b09a8580b09af1c8fa20e0d6ff759380e2b18f9">3b09a85</a> on renovate/node-14.x* into *<a href="https://github.com/cucumber/cucumber-js/commit/dadfc510bb80b088348e904ce87559e464819991">dadfc51</a> on master*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-01 01:56:04
[cucumber/cucumber-js] Comment on #1655
<a href="https://coveralls.io/builds/39281709">Coverage Status</a>
Coverage remained the same at 98.624% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/06f7f47e8ace770f4bf4ac12b7fb2d316dd8544e">06f7f47</a> on renovate/semver-7.x* into *<a href="https://github.com/cucumber/cucumber-js/commit/dadfc510bb80b088348e904ce87559e464819991">dadfc51</a> on master*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-01 01:59:18
[cucumber/cucumber-js] Comment on #1656
<a href="https://coveralls.io/builds/39281729">Coverage Status</a>
Coverage remained the same at 98.624% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/187eac6aa96c735cf6a350d55c3c5ec803e42848">187eac6</a> on renovate/typescript-4.x* into *<a href="https://github.com/cucumber/cucumber-js/commit/dadfc510bb80b088348e904ce87559e464819991">dadfc51</a> on master*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-01 02:02:28
[cucumber/cucumber-js] Comment on #1657
<a href="https://coveralls.io/builds/39281742">Coverage Status</a>
Coverage remained the same at 98.624% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/b8fc77a9293b853bec440f3f4211a16407f43d44">b8fc77a</a> on renovate/eslint-packages* into *<a href="https://github.com/cucumber/cucumber-js/commit/dadfc510bb80b088348e904ce87559e464819991">dadfc51</a> on master*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-01 02:06:30
[cucumber/cucumber-js] Comment on #1658
<a href="https://coveralls.io/builds/39281777">Coverage Status</a>
Coverage remained the same at 98.624% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/4904331f7f6f5b212aff63da9f2d08a4fb45b621">4904331</a> on renovate/unit-test-packages* into *<a href="https://github.com/cucumber/cucumber-js/commit/dadfc510bb80b088348e904ce87559e464819991">dadfc51</a> on master*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-01 02:08:34
[cucumber/cucumber-js] Comment on #1659
<a href="https://coveralls.io/builds/39281798">Coverage Status</a>
Coverage remained the same at 98.624% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/68640c7e07415941a152d0fa092cc7c9ec33a057">68640c7</a> on renovate/cucumber-packages* into *<a href="https://github.com/cucumber/cucumber-js/commit/dadfc510bb80b088348e904ce87559e464819991">dadfc51</a> on master*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-01 03:17:35
[cucumber/cucumber-js] davidjgoss requested changes on renovate[bot]'s pull request
Multiple gherkin versions coming in, need to probably release some other packages.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-01 03:17:50
[cucumber/cucumber-js] Pull request merged by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-01 03:20:00
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Release Notes</strong>
sindresorhus/indent-string
<strong><a href="https://togithub.com/sindresorhus/indent-string/releases/v5.0.0"><code>v5.0.0</code></a></strong></p>
<p><a href="https://togithub.com/sindresorhus/indent-string/compare/v4.0.0...v5.0.0">Compare Source</a></p>
<p><strong>Breaking</strong></p>
<p>• Require Node.js 12 <a href="https://togithub.com/sindresorhus/indent-string/commit/860ac63"><code>860ac63</code></a>
• This package is now pure ESM. Please <a href="https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c">read this</a>.</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Disabled by config. Please merge this manually once you are satisfied.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2481975459)
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2481975435)
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2481975409)
GitHub Actions: test (windows-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2481975376)
GitHub Actions: test (ubuntu-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2481975335)
GitHub Actions: test (ubuntu-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2481975295)
GitHub Actions: test (ubuntu-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2481975261)
GitHub Actions: test (ubuntu-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2481975227)
GitHub Actions: test (windows-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2480336226)
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2480336196)
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2480336173)
GitHub Actions: test (windows-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2480336140)
GitHub Actions: test (ubuntu-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2480336111)
GitHub Actions: test (ubuntu-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2480336090)
GitHub Actions: test (ubuntu-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2480336060)
GitHub Actions: test (ubuntu-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2480336031)
GitHub
2021-05-01 23:55:25
[cucumber/cucumber-js] Pull request merged by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-02 00:14:53
[cucumber/cucumber-js] Pull request merged by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-02 00:15:10
[cucumber/cucumber-js] Pull request merged by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-02 00:18:15
[cucumber/cucumber-js] Comment on #1661
Breaking change to require Node 12 and ESM - can't do this yet.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-02 00:18:16
[cucumber/cucumber-js] Pull request closed by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-02 00:18:51
[cucumber/cucumber-js] Comment on #1661
*Renovate Ignore Notification*
As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for _any_ future 5.x releases. However, if you upgrade to 5.x manually then Renovate will then reenable updates for minor and patch updates automatically.
If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-02 00:26:50
[cucumber/cucumber-js] Pull request merged by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-02 00:40:29
[cucumber/cucumber-js] Pull request merged by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-02 01:17:56
[cucumber/cucumber-js] Pull request opened by davidjgoss
<p>Helps with <a href="https://github.com/cucumber/cucumber-js/issues/1532">#1532</a> - avoids an implicit dependency on <code>@types/lodash</code> where TypeScript users reference some of our models and functions.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-02 01:20:25
[cucumber/cucumber-js] Comment on #1662
<a href="https://coveralls.io/builds/39288080">Coverage Status</a>
Coverage remained the same at 98.624% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/e4505cacd400bc8a07546284bd6f9a5a7ff88fec">e4505ca</a> on ts-compilation* into *<a href="https://github.com/cucumber/cucumber-js/commit/030075d05bb571d2562ee446669210c9fc1681d1">030075d</a> on master*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-02 10:03:28
[cucumber/cucumber-js] Pull request opened by davidjgoss
<p>Last piece of <a href="https://github.com/cucumber/cucumber-js/issues/1532">#1532</a>.</p>
<p>We need TypeScript users to have this on due to an upstream library that exports typings doing an <code>import</code> of a JSON file. I think this is very common and it seems more sensible to advise users to switch the compiler option on than try to control what goes on in libraries.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-02 10:05:32
[cucumber/cucumber-js] Comment on #1663
<a href="https://coveralls.io/builds/39291031">Coverage Status</a>
Coverage remained the same at 98.624% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/51ed4b74f9a273d26f96e51d0e2659ee2a3ea87c">51ed4b7</a> on resolvejsonmodule* into *<a href="https://github.com/cucumber/cucumber-js/commit/030075d05bb571d2562ee446669210c9fc1681d1">030075d</a> on master*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-02 13:52:59
[cucumber/cucumber-js] Issue opened by plocket
<p>Our data table has some very long strings in it. The final log tries to make all the columns line up. That combination makes the whole table quite a lot longer than it needs to be. We'd prefer that the log not attempt to make the table columns all the same width.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-02 13:57:02
[cucumber/cucumber-js] Comment on #1664
I think I understand the problem. I have an idea for a different feature that I think would address your problem, and also preserve readability.
We trim the values of long cells. The cell width can be computed by <a href="https://stackoverflow.com/questions/30335637/get-width-of-terminal-in-node-js/30335724">querying the terminal's width</a>. Alternatively you could supply one with `CUCUMBER_MAX_CELL_WIDTH=number`
Would that work for you?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-03 05:50:12
[cucumber/cucumber-js] Comment on #1664
Those options sound good in some cases, but in our cases I suspect we'd sometimes want to see the full contents of each cell. We just wouldn't want every cell to need to have the same width.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-03 06:21:09
[cucumber/cucumber-js] Comment on #1664
My second post apparently did not post:
> On second thought, maybe I'm making assumptions. The option you suggested would require a couple extra steps when trying to troubleshoot a problem (scroll through to find which file and test was run and then look up the test itself in its file), but maybe it wouldn't be that big of a burden. Or maybe it would. It probably just needs some user testing.
I do think there would need to be some indicator in a cell when its input did get truncated.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-03 09:31:12
[cucumber/cucumber-js] Comment on #1664
How about this then:
• `CUCUMBER_TEXT_OVERFLOW` which can take any value. If the value is `ellipsis`, use the `…` character, if it is `clip`, just clip it. Otherwise, use the value itself. Inspired from CSS' <a href="https://developer.mozilla.org/en-US/docs/Web/CSS/text-overflow">text-overflow</a>
• `CUCUMBER_TABLE_UNFORMATTED` which would disable table cell alignment if the env var has a <a href="https://github.com/cucumber/cucumber-js/blob/084c1f258097d1e424c3ecddf8bd980d8d8f5229/src/cli/configuration_builder.ts#L199-L204">truthy value</a>.
Would you be interested in submitting a pull request for this <a href="https://github.com/plocket">@plocket</a>?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-04 06:56:05
[cucumber/cucumber-js] Comment on #1664
Both sound good. Great CSS inspiration. No need for a custom cell size unless someone asks for it - I'm sure that can be hard-coded at first. Do they have to be env vars or can they get passed in as options? Would allow more flexibility with the names.
`CUCUMBER_TEXT_OVERFLOW` alternative names depending on type of var: `CUCUMBER_TABLE_OVERFLOW`, `TABLE_OVERFLOW`, `table_overflow`
`CUCUMBER_TABLE_UNFORMATTED` alternative names depending on type of var: `CUCUMBER_UNFORMATTED_TABLE`, `unformatted_table`, `remove_table_formatting`, `cell_fit_content`, `table_fit_content`, `equal_table_cell_width` (which would be the opposite).
As for me coding it up, I think it may be over my head. I'm not very experienced and I don't have a ton of bandwidth. If you don't mind my asking a ton of questions to take some of that load off, that would be more doable, but then it probably wouldn't help the team that much.
Looking at <a href="https://github.com/cli-table/cli-table3/blob/master/advanced-usage.md">cli-table3</a>, a reasonable mvp might be to allow the dev to set the column width directly.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-04 07:05:55
[cucumber/cucumber-js] Issue opened by ggarcia24
<p>Hello, first of all thank you very much for porting this tool to javascript! I've found an issue with the --profile flag, I've followed the 10 minutes guide for cucumber-js (<a href="https://cucumber.io/docs/guides/10-minute-tutorial/">https://cucumber.io/docs/guides/10-minute-tutorial/</a>), I've modified some things from the tutorial to run in the following way:</p>
<p>Directory structure:</p>
<pre><code>|- features
|- is_it_friday_yet.feature
| -src
|- step_definitions
|- stepdefs.js
|- support
|- hooks.js
|- custom_parameters.js
|- world.js
|- README.md
|- cucumber.js
</code></pre>
<pre><code>// cucumber.js
onst DEFAULT_OPTIONS = [
'--no-strict',
'--require src/support/hooks.js',
'--require src/support/custom_parameters.js',
'--require src/support/world.js',
'--require src/step_definitions/****/**.js',
'--publish-quiet',
];
const cliOpts = DEFAULT_OPTIONS.join(' ');
module.exports = {
// The default is only run on dev machines
default: `${cliOpts} --format progress-bar --format-options '{"snippetInterface": "synchronous"}' --tags @wip`,
all: `${cliOpts} --format message:output/cucumber-messages.ndjson --retry 3 --retry-tag-filter @flacky`,
}
</code></pre>
<pre><code>// stepdefs.js
const { Given, When, Then } = require('@cucumber/cucumber');
Given('today is Sunday', function () {
// Write code here that turns the phrase above into concrete
return 'pending';
});
When('I ask whether it\'s Friday yet', function () {
// Write code here that turns the phrase above into concrete actions
return 'pending';
});
Then('I should be told {string}', function (string) {
// Write code here that turns the phrase above into concrete actions
return 'pending';
});
</code></pre>
<p>Running the command line with <code>--profile all</code> returns error code 1 when it shouldn't</p>
<pre><code>$ cucumber-js --profile all
...
$ echo $?
1
</code></pre>
<p>But if I expand the command line to include all the information included in the profile everything works file</p>
<pre><code>$ cucumber-js --no-strict --require src/support/hooks.js --require src/support/custom_parameters.js --require src/support/world.js --require "src/step_definitions/****/**.js" --publish-quiet --format message:output/cucumber-messages.ndjson --retry 3 --retry-tag-filter @flacky
$ echo $?
0
</code></pre>
<p>I'm currently investigating if I can solve the issue, hope to create a PR.</p>
<p>Best regards<br />
Gonzalo</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-04 14:37:36
[cucumber/cucumber-js] Comment on #1664
Happy to answer any questions if you or anyone else want to take a stab at it.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-05 00:20:03
[cucumber/cucumber-js] Comment on #1664
To be clear when we talk about the "final log" do we mean the summary (default) formatter?
If so we could lean on <a href="https://github.com/cucumber/cucumber-js/blob/master/docs/cli.md#format-options">the `--format-options` mechanism</a> rather than introducing new flags or env variables. Other formatters could then also use (or ignore) these cues for formatting.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-05 01:33:54
[cucumber/cucumber-js] aurelien-reeves commented on davidjgoss's pull request
`src/formatter/json_formatter.ts:316`: could we replace `{ [id: string]: IScenario }` with a `Record`?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-05 01:33:54
[cucumber/cucumber-js] Comment on #1662
As `this.raw()` returns a `string[][]`, would it be possible for rowsHash to return a `Record<string, string>` instead of `Record<string, any>`?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-05 01:40:09
[cucumber/cucumber-js] aurelien-reeves approved davidjgoss's pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-05 03:38:50
[cucumber/cucumber-js] Pull request merged by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-05 05:21:47
[cucumber/cucumber-js] Issue opened by jaheikki
<p>Cucumber js version 6.x supports giving additional (non-cucumber) command line options, but it does not work anymore with Cucumber js 7.x!</p>
<p>Error message with Cucumber js v7.2.1:<br />
node_modules/.bin/cucumber-js ./e2e/features --require-module @babel/register --configuration android.emu.release<br />
error: unknown option '--configuration'</p>
<p>Tested with both Cucumber js v.6.x and v.7.x, node --version: v15.14.0, detox --version: 17.13.2, Mac OS Catalina 10.15.7</p>
<p>This is needed e.g. with Cucumber js & Detox (for React-native testing) where it is mandatory to use Detox command line options like "--configuration". "--configuration" is Detox command line option and not Cucumber js command line option.</p>
<p>For example this works with Cucumber 6.x but not with 7.x:<br />
node_modules/.bin/cucumber-js ./e2e/features --require-module @babel/register --configuration android.emu.release</p>
<p>See:<br />
<a href="https://github.com/mathanpec/react-native-detox-cucumber">https://github.com/mathanpec/react-native-detox-cucumber</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-05 06:37:32
[cucumber/cucumber-js] Comment on #1666
Thanks for raising <a href="https://github.com/jaheikki">@jaheikki</a>
Allowing arbitrary command line options is considered bad practise by many, and I tend to agree. Restricting to only known valid options helps guide users to avoid mistakes.
Does detox support a way to programattically set this configuration, or an environment variable - I'd be keen to help enable a way to avoid relying on cucumber-js CLI in this way.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-05 06:40:11
[cucumber/cucumber-js] Comment on #1666
I knew this sounded familiar - see comments on <a href="https://github.com/cucumber/cucumber-js/issues/1474">#1474</a> where there is an alternate solution provided.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-05 06:40:11
[cucumber/cucumber-js] Issue closed by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-06 05:42:12
[cucumber/cucumber-js] Comment on #1662
You're right, good catch - will change.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-06 11:20:34
[cucumber/cucumber-js] Comment on #1662
<a href="https://github.com/aurelien-reeves">@aurelien-reeves</a> thanks for feedback - addressed now
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-06 23:48:20
[cucumber/cucumber-js] aurelien-reeves approved davidjgoss's pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-06 23:51:22
[cucumber/cucumber-js] Comment on #1662
<a href="https://github.com/davidjgoss">@davidjgoss</a> LGTM
Quick question - off topic: I see that cucumber-js uses a lot lodash even when it seems it could be replaced with native functions. Is there a reason for that? Are we encouraged to use lodash? To try to remove it? To let it as-is?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-07 00:30:01
[cucumber/cucumber-js] Comment on #1579
This bugs me a lot on my custom formatter also. Any progress how to fix this?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-07 01:18:52
[cucumber/cucumber-js] Pull request merged by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-07 01:25:07
[cucumber/cucumber-js] Comment on #1662
<a href="https://github.com/aurelien-reeves">@aurelien-reeves</a> good point. I think a lot of the lodash usage is valid, but also probably a lot of stuff like `map`, `each` and `filter` predates the native functions being available in Node. If you raise a ticket we can maybe chip away at those?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-07 01:29:48
[cucumber/cucumber-js] Comment on #1662
<a href="https://github.com/davidjgoss">@davidjgoss</a> actually I was more thinking about taking care of that as part of other work. For example my last PR, I let some lodash usage which I could have replaced by native methods if I had been aware that I could.
Would you prefer a dedicated PR?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-07 01:59:26
[cucumber/cucumber-js] Issue opened by MilanJimi
<p>Node v12.19.0, TypeScript v4.2.4, @cucumber/cucumber v7.2.1, Ubuntu v20.04</p>
<p>I can no longer use <code>World</code> in my tests, because <code>this</code> is no longer typed inside the <code>Given/When/Then</code> functions, instead defaulting to being typed as <code>any</code>.</p>
<p>If I downgrade to version <code>cucumber v7.0.0-rc.0</code>, <code>this</code> is properly typed as <code>World</code>.<br />
<a href="https://user-images.githubusercontent.com/6137091/117426798-9cd7bd80-af24-11eb-9a38-671d5fbfcb97.png">image</a></p>
<p><a href="https://user-images.githubusercontent.com/6137091/117426338-14591d00-af24-11eb-9e41-6aef83557184.png">image</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-07 03:41:06
[cucumber/cucumber-js] Comment on #1662
<a href="https://github.com/aurelien-reeves">@aurelien-reeves</a> ah no worries - no I think it's fine to do them piecemeal as you touch areas.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-07 04:55:02
[cucumber/cucumber-js] Comment on #1667
Thanks for raising <a href="https://github.com/MilanJimi">@MilanJimi</a>, I can reproduce this and will fix.
In the meantime as a workaround, you can specify the type of `this` by prepending it to the function's arguments, e.g.:
```
import {Then, World} from '@cucumber/cucumber';
Then('the test runs with string parameter {string}', async function(this: World, parameter: string) {
this.driver.close()
})
```
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-09 02:19:50
[cucumber/cucumber-js] Comment on #1649
Have you looked into subpath exports? <a href="https://nodejs.org/api/packages.html#packages_subpath_exports">https://nodejs.org/api/packages.html#packages_subpath_exports</a>
Not sure if it is possible to combine with the import/require statements here <a href="https://github.com/cucumber/cucumber-js/pull/1649/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R167">https://github.com/cucumber/cucumber-js/pull/1649/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R167</a> but I think that is the way to expose other exported paths than the main one going forward.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-09 22:25:49
[cucumber/cucumber-js] Comment on #1568
I think we need an additional assertion that it runs no scenarios
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-09 22:26:17
[cucumber/cucumber-js] Comment on #1568
Can we please add a unit test for this change as well?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-09 22:26:22
[cucumber/cucumber-js] Comment on #1568
I disagree with this change. I think we run though the rest of things normally otherwise the formatters won't write that 0 scenarios / steps ran (and the user just gets no output)
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-10 00:42:54
[cucumber/cucumber-js] Comment on #1568
<a href="https://github.com/charlierudolph">@charlierudolph</a> thank you for the review 👍
<a href="https://github.com/jshifflet">@jshifflet</a> sorry again for the delay 😰
Are you still interesting into working on that PR?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-10 12:29:27
[cucumber/cucumber-js] Comment on #1583
I just want to add that the same thing happens if we use builtin *message formatter*. <a href="https://github.com/FrankieDcom">@FrankieDcom</a>, did you find any workaround for that?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-11 14:09:38
[cucumber/cucumber-js] Comment on #1568
Yep. I can look into making those changes.
Thanks for the review.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-12 08:41:18
[cucumber/cucumber-js] Issue opened by yopasa94
<p>Hello,</p>
<p>I've found a issue when I try to run all scenarios (including wip) using dry-run mode. I.E:</p>
<p>This is the feature file, I'm trying to run</p>
<p>` <a href="https://github.com/blocker">@blocker</a> <a href="https://github.com/wip">@wip</a><br />
Scenario: Login to application<br />
Given Go to the App<br />
When I enter user credential<br />
Then App home should be displayed</p>
<p><a href="https://github.com/major">@major</a> <a href="https://github.com/wip">@wip</a><br />
Scenario: Login using a external app</p>
<p><a href="https://github.com/minor">@minor</a> <a href="https://github.com/wip">@wip</a><br />
Scenario: Login using token<br />
`</p>
<p>When I try to run a feature like that I got this error<br />
[10:38:10] E/launcher - <strong>Error: TypeError: Cannot read property 'uri' of undefined</strong><br />
at parseStep (~node<em>modules@cucumber\cucumber\src\formatter\helpers\test</em>case<em>attempt</em>parser.ts:90:27)<br />
at ~node<em>modules@cucumber\cucumber\src\formatter\helpers\test</em>case<em>attempt</em>parser.ts:169:24</p>
<p>I took a look into the code and seems likely the app does not support scenarios without steps.</p>
<p><a href="https://github.com/cucumber/cucumber-js/blob/f37edaadbefea557d87ef5f19bc301a277ac4264/src/formatter/helpers/test_case_attempt_parser.ts#L55">cucumber-js/src/formatter/helpers/test<em>case</em>attempt_parser.ts</a></p>
<p>Line 55 in </cucumber/cucumber-js/commit/f37edaadbefea557d87ef5f19bc301a277ac4264|f37edaa></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-15 17:50:07
[cucumber/cucumber-js] Comment on #1588
This feels a bit complex to me. Using the handlers and verifying as it parses each envelope while efficient, is a bit hard to follow.
Since our assertion are all on the pickle level, thoughts on having a function that takes in a list of envelopes and returns an array where each element is a list of pickles that are running simultaneously.
Then we can assert that list is empty, or certain things about each list of pickles. I think then could have something like
```
Then the following pickles run simultaneously:
| complex1, simple4 |
| complex1, simple5 |
| complex2, simple5 |
| complex2, simple6 |
```
(To make that more reliable, may need to change time for each (maybe make complex take 350 milliseconds)
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-15 17:51:44
[cucumber/cucumber-js] Comment on #1588
I'm not certain I see any value in this test that isn't covered by the next test. And since the setParallelCanAssign is less a real world example, think it could just be deleted
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-15 17:53:17
[cucumber/cucumber-js] Comment on #1588
I think if we switch to verifying what runs in parallel, we could delete this step_def code and just have steps set timeout and that's call
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-15 17:54:29
[cucumber/cucumber-js] Comment on #1588
Can we name the scenarios complex# and simple# to make it easier for us in assertions?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-15 17:55:34
[cucumber/cucumber-js] Comment on #1588
Thoughts on these just being
```
Given('complex step', ...)
Given('simple step', ...)
```
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-15 17:57:24
[cucumber/cucumber-js] Comment on #1588
Sorry for delayed review. Took me awhile to find time to get back to this
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-17 07:44:54
[cucumber/cucumber-js] Comment on #1645
I have released all the `@cucumber/*` libraries and updated the dependencies. No need to do the `npm link` dance described above.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-17 07:44:57
[cucumber/cucumber-js] Pull request ready for review by aslakhellesoy
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-17 07:45:50
[cucumber/cucumber-js] Comment on #1645
I'd like to add support for Markdown before merging this - it should be a small change.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-17 07:46:26
[cucumber/cucumber-js] Comment on #1645
<a href="https://coveralls.io/builds/39746599">Coverage Status</a>
Coverage decreased (-0.01%) to 98.612% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/473ea97c3dd3f5ffcd85d7e2da29dc531aa042f3">473ea97</a> on messages-without-protobuf* into *<a href="https://github.com/cucumber/cucumber-js/commit/f37edaadbefea557d87ef5f19bc301a277ac4264">f37edaa</a> on main*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-17 14:39:47
[cucumber/cucumber-js] Comment on #1568
Agreed.
I added the above snippet because removing caused the following timeout error:
```
When I run cucumber-js with `@test.txt` # features/step_definitions/cli_steps.ts:19
Error: function timed out, ensure the promise resolves within 10000 milliseconds
at Timeout._onTimeout (/home/lemur/code/cucumber-js/src/user_code_runner.ts:80:18)
at listOnTimeout (internal/timers.js:554:17)
at processTimers (internal/timers.js:497:7)
```
If I set `pickleIds` to [] when `configuration.featurePaths.length === 0` things seem to work as expected without the unexpected side effect of no formatter output.
Are there other side effects to setting `pickleIds` to `[]` when there are no features to run, that I am not seeing?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-18 09:35:11
[cucumber/cucumber-js] Comment on #1645
This is now ready for review. I don't plan any more changes other than addressing review comments.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-18 20:05:26
[cucumber/cucumber-js] Comment on #1304
i've been attempting to give `v7.2.0` a shot along with the `--esm` flag. i use testdouble in the tests for the package that i am attempting to convert to ESM.
in order to use <a href="https://github.com/testdouble/testdouble.js/blob/65d7023b2f1c9084cdd7cd288550aa4ab68495bf/docs/7-replacing-dependencies.md#es-module-support">`td.replaceEsm`</a>, a loader must be used like `--loader=testdouble`. when i try to provide the loader directly to the cucumber cli, i get the following error:
```
> cucumber-js test/integration --esm --loader=testdouble
error: unknown option '--loader=testdouble'
```
since that option wasn't available, i then attempted with `NODE_OPTIONS`:
```
> NODE_OPTIONS='--loader=testdouble' cucumber-js test/integration --esm
(node:62231) ExperimentalWarning: --experimental-loader is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
internal/process/esm_loader.js:74
internalBinding('errors').triggerUncaughtException(
^
TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension "" for /path/to/project/node_modules/@cucumber/cucumber/bin/cucumber-js
at defaultGetFormat (internal/modules/esm/get_format.js:71:15)
at getFormat (file:///path/to/project/node_modules/quibble/lib/quibble.mjs:65:12)
at Loader.getFormat (internal/modules/esm/loader.js:104:42)
at Loader.getModuleJob (internal/modules/esm/loader.js:242:31)
at async Loader.import (internal/modules/esm/loader.js:176:17)
at async Object.loadESM (internal/process/esm_loader.js:68:5) {
code: 'ERR_UNKNOWN_FILE_EXTENSION'
}
```
for reference, this was against node `v14.17.0`
it would be nice if this worked with the `NODE_OPTIONS` approach, but ideally the `--loader` option would be supported directly by the cli like some test frameworks have started to support. please consider these approaches with your next version that approaches ESM support :)
is there an approach to defining a loader that you would expect to work with `v7.2.0`?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-19 01:01:24
[cucumber/cucumber-js] Comment on #1645
Should the extension `.feature.md` be for MDG files?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-19 01:01:24
[cucumber/cucumber-js] aurelien-reeves commented on aslakhellesoy's pull request
Another big PR 😅
Is there something specific we should take care of?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-19 01:04:58
[cucumber/cucumber-js] Comment on #1645
I'm not sure. What are the benefits of enforcing that extension?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-19 01:05:02
[cucumber/cucumber-js] davidjgoss requested changes on aslakhellesoy's pull request
Changes LGTM in general. Few bits:
• A `package-lock.json` file has shown up here - we're currently using yarn for this project though. I pushed an updated `yarn.lock` after installing locally, suggest we remove and gitignore the npm lockfile until/unless we switch to using npm.
• We have multiple versions of `messages` and `message-streams`, this looks to be due to `gherkin` still depending on an older `message-streams` - see below. Topic for another day, but it might be worth looking at whether we can use `peerDependencies` to reduce the need to basically release everything when certain packages change?
• We seem to be scanning for `*.md` files - did we change from the default convention being `*.feature.md`?
Output of `yarn why @cucumber/message-streams`:
```
yarn why v1.22.10
[1/4] 🤔 Why do we have the module "@cucumber/message-streams"...?
[2/4] 🚚 Initialising dependency graph...
[3/4] 🔍 Finding dependency...
[4/4] 🚡 Calculating file sizes...
=> Found "@cucumber/message-streams@2.0.0"
info Has been hoisted to "@cucumber/message-streams"
info Reasons this module exists
- Specified in "devDependencies"
- Hoisted from "@cucumber#gherkin-streams#@cucumber#message-streams"
info Disk size without dependencies: "384KB"
info Disk size with unique dependencies: "932KB"
info Disk size with transitive dependencies: "3.19MB"
info Number of shared dependencies: 3
=> Found "@cucumber/gherkin#@cucumber/message-streams@1.0.0"
info This module exists because "@cucumber#gherkin" depends on it.
info Disk size without dependencies: "1.89MB"
info Disk size with unique dependencies: "10.04MB"
info Disk size with transitive dependencies: "13.71MB"
info Number of shared dependencies: 5
✨ Done in 0.54s.
```
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-19 01:07:18
[cucumber/cucumber-js] Comment on #1645
Thanks <a href="https://github.com/davidjgoss">@davidjgoss</a> - I'll have a look at fixing the dependencies and also removing `package-lock.json`.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-19 01:07:34
[cucumber/cucumber-js] Comment on #1645
From the discussion the other day it was that:
• We'd avoid collecting Markdown files that weren't intended as specs for Cucumber e.g. READMEs or whatever
• Tools like IDEs could use this convention to look for steps in `.feature.md` files and offer completion and quick-run features like they do for feature files
Users could always specify the glob differently themselves, as many do.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-19 01:11:42
[cucumber/cucumber-js] Comment on #1645
For a human, from just reading the file name, we know that this should be an executable spec in addition of some documentation
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-19 01:14:15
[cucumber/cucumber-js] Comment on #1645
That's a good point. IIRC, <a href="https://github.com/mpkorstanje">@mpkorstanje</a> also suggested that using `.feature.md` could protect against accidentally picking up Markdown files without any Gherkin in it.
I'll change it.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-20 05:54:43
[cucumber/cucumber-js] Comment on #1373
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two months if no further activity occurs.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-20 22:47:16
[cucumber/cucumber-js] Comment on #1588
I don't see a way around most of what I'm doing. Given a list of envelops there seems to be no easy way to determine the simultaneously running pickles. From what I gather, to derive this information we must follow a chain that dives past the pickle level.
```
Pickle
pickleId -> testCase
testCaseId -> testCaseStarted
testCaseStartedId -> testCaseFinished
```
I'm using the `started` & `finished` states to determine parallel processing. I have yet to discover another option. Granted, I'm not too familiar with cucumberjs inner workings.
Also, while I agree that simplicity is a necessity I'm not sure it wins out in this case if the test will become less reliable and slower.
If there is no other way to do this then I can attempt to refactor it to be more clear (maybe through verbosity). Please provide additional direction.
Thanks!
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-20 22:49:44
[cucumber/cucumber-js] Comment on #1588
Agreed! Will remove it.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-20 23:15:51
[cucumber/cucumber-js] Comment on #1588
We don't actually need to do any validation here. The last step of the scenario will verify everything we need to know. Therefore, just setting the timeout is adequate.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-20 23:19:44
[cucumber/cucumber-js] Comment on #1588
Removed the assertions in `step_def` method. At this point there is no added benefit but I'll keep this thought in mind if something changes.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-20 23:30:55
[cucumber/cucumber-js] Pull request opened by eman2673
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-20 23:31:21
[cucumber/cucumber-js] Pull request closed by eman2673
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-20 23:34:30
[cucumber/cucumber-js] Comment on #1588
Yay! Workflow probation :)
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-24 09:38:13
[cucumber/cucumber-js] Comment on #1645
Fixed - it's looking for `.feature.md` by default now
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-24 09:53:01
[cucumber/cucumber-js] davidjgoss approved aslakhellesoy's pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-24 09:56:16
[cucumber/cucumber-js] Pull request merged by aslakhellesoy
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-24 09:56:55
[cucumber/cucumber-js] Pull request closed by renovate[bot]
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-25 02:44:14
[cucumber/cucumber-js] Comment on #1568
It looks pretty good to me.
<a href="https://github.com/charlierudolph">@charlierudolph</a> what do you think?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-25 02:47:02
[cucumber/cucumber-js] Comment on #1568
<a href="https://github.com/aurelien-reeves">@aurelien-reeves</a> - the build isn't passing though, I haven't looked into why. Can you try to figure that out <a href="https://github.com/aurelien-reeves">@aurelien-reeves</a> ?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-25 03:05:33
[cucumber/cucumber-js] Comment on #1568
Ok, it's passing now, after I merged in the `main` branch. The changelog needs to be updated. Otherwise LGTM
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-25 03:12:22
[cucumber/cucumber-js] aurelien-reeves commented on jshifflet's pull request
Oh, yes!
Please, update the changelog :)
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-26 14:41:29
[cucumber/cucumber-js] Pull request opened by aslakhellesoy
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2679541456)
GitHub
2021-05-26 14:44:08
[cucumber/cucumber-js] Comment on #1671
<a href="https://coveralls.io/builds/40061045">Coverage Status</a>
Coverage remained the same at 98.516% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/1c6494d361116be0bccf86249affd1ed4a643d8a">1c6494d</a> on update-cucumber-dependencies-20210526* into *<a href="https://github.com/cucumber/cucumber-js/commit/ac124f7b2be5fa54d904c7feac077a2657b19440">ac124f7</a> on main*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-26 15:06:33
[cucumber/cucumber-js] Pull request merged by aslakhellesoy
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-27 00:34:39
[cucumber/cucumber-js] Pull request opened by davidjgoss
<p>Fixes <a href="https://github.com/cucumber/cucumber-js/issues/1534">#1534</a>.</p>
<p>☐ Fix whatever's making it break on Windows</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2682656974)
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2682656943)
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2682656914)
GitHub Actions: test (windows-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2682656840)
GitHub Actions: test (windows-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2682656485)
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2682656442)
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2682656409)
GitHub Actions: test (windows-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2682656381)
GitHub
2021-05-27 00:36:50
[cucumber/cucumber-js] Comment on #1672
<a href="https://coveralls.io/builds/40072962">Coverage Status</a>
Coverage decreased (-0.004%) to 98.512% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/a6f79689fa6d3217258b92d961796f2587fee596">a6f7968</a> on gherkin-relative-uris* into *<a href="https://github.com/cucumber/cucumber-js/commit/62ca6bcdefe26c46cf00031a532fab488bd80bec">62ca6bc</a> on main*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-27 03:34:18
[cucumber/cucumber-js] Comment on #1489
Any feedback <a href="https://github.com/yopasa94">@yopasa94</a> ?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-27 04:33:27
[cucumber/cucumber-js] aslakhellesoy approved davidjgoss's pull request
Lovely!
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-27 04:35:11
[cucumber/cucumber-js] Issue closed by aslakhellesoy
<https://github.com/cucumber/cucumber-js/issues/1534|#1534 some messages emitted with absolute uris>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-27 04:35:12
[cucumber/cucumber-js] Pull request merged by aslakhellesoy
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-27 05:07:29
[cucumber/cucumber-js] Comment on #1672
<a href="https://github.com/aslakhellesoy">@aslakhellesoy</a> It has been merged, but the windows build is still broken. Was that on purpose?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-27 05:23:20
[cucumber/cucumber-js] Comment on #1672
<a href="https://github.com/aurelien-reeves">@aurelien-reeves</a> I’m looking at this now on my Windows machine
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-27 05:52:49
[cucumber/cucumber-js] Comment on #1672
<a href="https://github.com/aurelien-reeves">@aurelien-reeves</a> the windows builds have been intermittently failing for months on the master/main branch because of <a href="https://github.com/cucumber/cucumber-js/issues/1457">#1457</a>, which you have tried to address in <a href="https://github.com/cucumber/cucumber-js/pull/1617">#1617</a>.
I therefore assumed that the Windows build failures were unrelated to this PR and merged.
This is dangerous, because other Windows related bugs might not be discovered.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-27 05:53:50
[cucumber/cucumber-js] Comment on #1457
<a href="https://github.com/aurelien-reeves">@aurelien-reeves</a> and I tried to fix this a few months ago without success.
I think the pragmatic solution is to just disable these tests for Windows in CI.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-27 06:03:36
[cucumber/cucumber-js] Comment on #1672
Actually <a href="https://github.com/cucumber/cucumber-js/issues/1457">#1457</a> is not related to Windows. Any build can be impacted as we can see here for example: <a href="https://github.com/cucumber/cucumber-js/commit/edc8f106edda0d001f1b31a82a5b4bd86f260fb5">edc8f10</a>
Windows related CI issues was more a cucumber-ruby thing.
It rarely impact more than a single build for a commit.
I agree, a flaky CI is dangerous. Yet we still have no idea how to fix the issue :(
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-27 06:16:47
[cucumber/cucumber-js] Comment on #1457
<a href="https://github.com/aslakhellesoy">@aslakhellesoy</a> are they definitely limited to just Windows?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-27 06:22:10
[cucumber/cucumber-js] Comment on #1457
No, they are not limited to windows.
<a href="https://github.com/cucumber/cucumber-js/pull/1617">#1617</a> shows us that all build may be impacted.
Cf. <a href="https://github.com/cucumber/cucumber-js/commit/edc8f106edda0d001f1b31a82a5b4bd86f260fb5">edc8f10</a>
I would suggest:
• deactivating the tests that are flacky
• eventually executing those only when changes to specific files are pushed
• rerun the build after a first failure
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-27 06:26:06
[cucumber/cucumber-js] Comment on #1457
My bad - I thought it was Windows only.
Rerunning the build won't solve anything, they are just as likely to fail a 2nd time. I think we'd have a better chance with `--retry`. But even then it might end up failing.
We need 100% consistent test runs. I'd propose disabling the tests in CI. This code has low churn, and it might be sufficient to run them locally.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-27 06:28:26
[cucumber/cucumber-js] Comment on #1457
> My bad - I thought it was Windows only.
>
> Rerunning the build won't solve anything, they are just as likely to fail a 2nd time. I think we'd have a better chance with `--retry`. But even then it might end up failing.
That was what I had in mind, using the rerun file
> We need 100% consistent test runs. I'd propose disabling the tests in CI. This code has low churn, and it might be sufficient to run them locally.
I have a preference for that one too
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-27 06:30:13
[cucumber/cucumber-js] Comment on #1457
For information: the build seems to be more stable than it used to be.
The recent failures was not always related to that issue, but to dependency audit. But it seems to be have been fixed recently.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-27 06:55:21
[cucumber/cucumber-js] Pull request opened by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2685585000)
GitHub
2021-05-27 06:56:42
[cucumber/cucumber-js] Comment on #1457
I think it could be worth an experiment with `--retry` - happy to run that up and see what happens with e.g. 30 builds in a row?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-27 07:01:36
[cucumber/cucumber-js] aurelien-reeves approved davidjgoss's pull request
Looks good to me :)
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-27 07:03:05
[cucumber/cucumber-js] Comment on #1673
<a href="https://coveralls.io/builds/40084654">Coverage Status</a>
Coverage decreased (-0.003%) to 98.513% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/2c7f0f6cbe868ec1c1028656ed5174411839827d">2c7f0f6</a> on relative-path-windows-fix* into *<a href="https://github.com/cucumber/cucumber-js/commit/8a54a1b383bfe63d89365eec3988528bb3e0d8f0">8a54a1b</a> on main*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-27 07:08:22
[cucumber/cucumber-js] Pull request merged by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-27 07:39:36
[cucumber/cucumber-js] Pull request opened by davidjgoss
<p>Closes <a href="https://github.com/cucumber/cucumber-js/issues/1457">#1457</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2686128585)
GitHub
2021-05-27 07:46:41
[cucumber/cucumber-js] Comment on #1674
<a href="https://coveralls.io/builds/40086862">Coverage Status</a>
Coverage remained the same at 98.513% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/dfd9efa11cdb13152b8d988f23d5bbd8e1259257">dfd9efa</a> on retry-flaky-publish-tests* into *<a href="https://github.com/cucumber/cucumber-js/commit/24ff9dc635ed25a32bdb6daf0028ecaf89569393">24ff9dc</a> on main*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-27 08:24:06
[cucumber/cucumber-js] Comment on #1674
Thanks <a href="https://github.com/davidjgoss">@davidjgoss</a>. Alas, Node 10 still fails, which reminds me: Node 10 <a href="https://nodejs.org/en/about/releases/">is no longer in LTS</a>, so how about we remove that from our CI? (could be done in this PR).
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-27 09:46:43
[cucumber/cucumber-js] Comment on #1674
<a href="https://github.com/aslakhellesoy">@aslakhellesoy</a> agree on dropping Node 10 but should that be a breaking change and therefore major release?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-27 11:17:44
[cucumber/cucumber-js] Comment on #1674
Good question.
How about we just allow the CI to fail for Node 10, but still run it? That way we can keep support for CI without getting too distracted about the bugs in its http lib?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-27 14:31:34
[cucumber/cucumber-js] Comment on #1457
Does this test actually integrate with the live cucumber reports server? Would it be possible to have it call a stub server instead, running locally? Or swap out a little adapter that wraps the calls to the remote reports endpoints?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-27 22:53:59
[cucumber/cucumber-js] Comment on #1457
The test uses a local Node http server that we start and stop in every test.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-28 00:31:17
[cucumber/cucumber-js] Comment on #1674
I'm not sure the failed build is because of Node 10.
Why to use `--retry-tag-filter`? Will that be added to the filtering of the rerun file? Or override it?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-28 01:14:53
[cucumber/cucumber-js] Comment on #1674
> I'm not sure the failed build is because of Node 10.
Yeah, I don't think it's exclusive to Node 10 either actually.
> Why to use `--retry-tag-filter`? Will that be added to the filtering of the rerun file? Or override it?
We aren't using the rerun file mechanism. The retry config I've added here means that, for pickles that have the `@flaky` tag, the test case will be retried up to twice (during the same test run).
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-28 01:24:00
[cucumber/cucumber-js] Comment on #1674
> > Why to use `--retry-tag-filter`? Will that be added to the filtering of the rerun file? Or override it?
>
> We aren't using the rerun file mechanism. The retry config I've added here means that, for pickles that have the `@flaky` tag, the test case will be retried up to twice (during the same test run).
Ok, thanks for the details.
In our case, I would have tried for a rerun instead of a retry then - if I finally understand correctly the distinction between those 😅.
If there is something in the state of the HTTP server that is broken, a retry may not be sufficient to reset that broken state.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-28 01:28:04
[cucumber/cucumber-js] Comment on #1674
I think we create a new instance of the fake http server for each test case? If so you would get a fresh one for each retry (we discard any state from the failed run and create a new world etc)
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-28 01:36:34
[cucumber/cucumber-js] Comment on #1674
> I think we create a new instance of the fake http server for each test case? If so you would get a fresh one for each retry
Yes, we have a new instance of the http server for each test case.
But as we do not understand what is happening when it is failing, I think we cannot really trust the internal state of what is related to that http server at some point.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-28 03:29:00
[cucumber/cucumber-js] Comment on #1674
I don't think I'm quite grasping what the issue is with retry, but at any rate if we're against retry then what are we _for_? (Besides fixing the actual issue.)
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-28 05:55:36
[cucumber/cucumber-js] Comment on #1674
I just noticed: the failed build here is not a cucumber test, but a mocha test, so it has even not been retried as the impacted suite was not the one we expected
I took a look on past builds, it happens very, very occasionally.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-28 06:02:36
[cucumber/cucumber-js] Comment on #1674
I re-run the jobs, It worked as expected this time: it failed a first time, then has been retried successfully:
```
Warnings:
1) Scenario: a banner is displayed after publication (attempt 1, retried) # features\publish.feature:76
(...)
1 scenario (1 passed)
1 step (1 passed)
0m00.005s (executing steps: 0m00.001s)
Error Output:
┌──────────────────────────────────────────────────────────────────────────┐
│ View your Cucumber Report at: │
│ <https://reports.cucumber.io/reports/f318d9ec-5a3d-4727-adec-bd7b69e2edd3> │
│ │
│ This report will self-destruct in 24h unless it is claimed or deleted. │
└──────────────────────────────────────────────────────────────────────────┘
Premature close
at World.<anonymous> (D:\a\cucumber_js\cucumber_js\features\support\hooks.ts:107:11)
at process._tickCallback (internal/process/next_tick.js:68:7)
266 scenarios (266 passed)
...
```
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-28 06:04:06
[cucumber/cucumber-js] aurelien-reeves approved davidjgoss's pull request
So, for me, it is a way to stabilize the build a little bit, so we may regain some confidence.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-28 09:35:40
[cucumber/cucumber-js] Issue closed by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-28 09:35:41
[cucumber/cucumber-js] Pull request merged by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-29 09:13:39
[cucumber/cucumber-js] Comment on #1669
<a href="https://coveralls.io/builds/40142137">Coverage Status</a>
Coverage increased (+0.0007%) to 98.514% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/e8fe377ed12f4faef01b632a6bb387c3c2cb88f5">e8fe377</a> on prog-bar-counts* into *<a href="https://github.com/cucumber/cucumber-js/commit/04c2747e1788bfc4a998059e26fdda7e6767c045">04c2747</a> on main*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-29 10:05:22
[cucumber/cucumber-js] Pull request ready for review by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-30 14:22:22
[cucumber/cucumber-js] Pull request reopened by renovate[bot]
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-30 18:03:07
[cucumber/cucumber-js] Issue opened by binarymist
<p>Upgrading from:</p>
<p>"@cucumber/cucumber": "7.0.0",<br />
"@cucumber/gherkin": "17.0.2",</p>
<p>To:</p>
<p>"@cucumber/cucumber": "7.2.1",<br />
"@cucumber/gherkin-streams": "2.0.2"</p>
<p><a href="https://www.npmjs.com/package/@cucumber/gherkin-streams">doc</a> says to require the <code>fromPaths</code> like the following:</p>
<p><code>const { fromPaths } = require('@cucumber/gherkin-streams')</code></p>
<p>When I do this <code>fromPaths</code> is <code>undefined</code>.</p>
<p>Although if I run in the debugger:</p>
<p><code>require('@cucumber/gherkin-streams');</code></p>
<p>I get:</p>
<pre><code>{GherkinStreams: {…}, __esModule: true}
GherkinStreams: {fromPaths: ƒ, fromSources: ƒ}
__esModule: true
__proto__: Object
</code></pre>
<p>Is there some sort of additional undocumented trick to require <code>fromPaths</code> or is this a bug?</p>
<p>I've read the <a href="https://github.com/cucumber/common/blob/main/gherkin/CHANGELOG.md">Changelog</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-31 01:13:30
[cucumber/cucumber-js] Comment on #1669
This sounds obscures internal things.
Would it be some way to give it more sense for users? Or, in that case, add-ons developers which may be impacted? Maybe adding some kind of introduction or conclusion which explains that it will mainly impact formatter APIs for example?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-31 01:13:30
[cucumber/cucumber-js] Comment on #1669
Suggested change
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-31 01:13:30
[cucumber/cucumber-js] aurelien-reeves commented on davidjgoss's pull request
Why did you export assembleTestCases a function and not a class?
The whole PR looks nice, great job. After a first look it seems to be good 👍
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-31 01:45:16
[cucumber/cucumber-js] Comment on #1669
Good catch thanks!
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-31 01:46:57
[cucumber/cucumber-js] Comment on #1669
Good point, added a note that it's about formatters
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-31 01:49:12
[cucumber/cucumber-js] Comment on #1669
> Why did you export assembleTestCases a function and not a class?
It just does one thing and doesn't need to hold any state, so a class would seem unnecessary.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-31 01:55:38
[cucumber/cucumber-js] Comment on #1669
> > Why did you export assembleTestCases a function and not a class?
>
> It just does one thing and doesn't need to hold any state, so a class would seem unnecessary.
Ok, thanks for clarifying it :)
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-31 03:15:33
[cucumber/cucumber-js] Comment on #1675
If you try something like the following, does it work?
```
const { GherkinStreams } = require('@cucumber/gherkin-streams')
const stream = GherkinStreams.fromPaths(/*...*/)
```
If so, it seems to be an error in the documentation.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-31 08:29:16
[cucumber/cucumber-js] Comment on #1489
As you have noticed, there have been a major refactoring of the internals of cucumber in the past few month.
Also, `@cucumber/gherkin-streams` has been released publicly and provide the `fromPaths` method that will help parsing given `.feature` documents.
This is not a transparent refactoring: the new API relies on <a href="https://github.com/cucumber/common/tree/main/messages">messages</a>.
<a href="https://github.com/binarymist">@binarymist</a> it would be easier for us to help with your issue with more explanation regarding your problem. Could you please give us a concise summary of what you are facing, and a <a href="https://stackoverflow.com/help/minimal-reproducible-example">minimal reproducible example</a>?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-31 16:19:01
[cucumber/cucumber-js] aslakhellesoy approved davidjgoss's pull request
Excellent stuff <a href="https://github.com/davidjgoss">@davidjgoss</a> !
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-31 17:37:29
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-31 17:37:42
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2714388269)
GitHub
2021-05-31 17:39:32
[cucumber/cucumber-js] Comment on #1676
<a href="https://coveralls.io/builds/40184679">Coverage Status</a>
Coverage remained the same at 98.513% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/b5aa62cee4e271b806f0cf9678a9360b87a21887">b5aa62c</a> on renovate/bluebird-3.x* into *<a href="https://github.com/cucumber/cucumber-js/commit/04c2747e1788bfc4a998059e26fdda7e6767c045">04c2747</a> on main*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-31 17:43:38
[cucumber/cucumber-js] Comment on #1677
<a href="https://coveralls.io/builds/40184728">Coverage Status</a>
Coverage remained the same at 98.513% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/d38fe5510d974f62ee343fd1fc6d64771e1653f0">d38fe55</a> on renovate/express-4.x* into *<a href="https://github.com/cucumber/cucumber-js/commit/04c2747e1788bfc4a998059e26fdda7e6767c045">04c2747</a> on main*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-31 19:19:58
[cucumber/cucumber-js] Pull request merged by renovate[bot]
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-31 19:21:00
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-31 19:21:13
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2714754002)
GitHub
2021-05-31 19:26:57
[cucumber/cucumber-js] Comment on #1678
<a href="https://coveralls.io/builds/40185985">Coverage Status</a>
Coverage remained the same at 98.513% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/53b1d68f55f3cb9b8d5ce997b987b9922c89504f">53b1d68</a> on renovate/lodash-4.x* into *<a href="https://github.com/cucumber/cucumber-js/commit/5de727faedf524a9dad708882e9bc29638b7daea">5de727f</a> on main*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-31 19:29:31
[cucumber/cucumber-js] Comment on #1679
<a href="https://coveralls.io/builds/40186041">Coverage Status</a>
Coverage remained the same at 98.513% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/65680f9e65ead893f5bdbeae3e3b68ed89428da1">65680f9</a> on renovate/semver-7.x* into *<a href="https://github.com/cucumber/cucumber-js/commit/5de727faedf524a9dad708882e9bc29638b7daea">5de727f</a> on main*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-31 21:09:47
[cucumber/cucumber-js] Pull request merged by renovate[bot]
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-31 21:11:19
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-31 21:11:33
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Release Notes</strong>
SamVerschueren/tsd
<strong><a href="https://togithub.com/SamVerschueren/tsd/releases/v0.16.0"><code>v0.16.0</code></a></strong></p>
<p><a href="https://togithub.com/SamVerschueren/tsd/compare/v0.15.1...v0.16.0">Compare Source</a></p>
<p>• Upgrade to TypeScript@4.2.4 <a href="https://togithub.com/SamVerschueren/tsd/commit/05f9f3b"><code>05f9f3b</code></a>
• Fix missing ES types regression in 0.15 (<a href="https://togithub.com/SamVerschueren/tsd/issues/100">#100</a>) <a href="https://togithub.com/SamVerschueren/tsd/commit/b39bd98"><code>b39bd98</code></a>
• Handle multiple diagnostic errors in a single <code>expectError</code> assertion (<a href="https://togithub.com/SamVerschueren/tsd/issues/103">#103</a>) <a href="https://togithub.com/SamVerschueren/tsd/commit/87f7109"><code>87f7109</code></a>
• Allow <code>expectError</code> directives to detect parameter count mismatches (<a href="https://togithub.com/SamVerschueren/tsd/issues/102">#102</a>) <a href="https://togithub.com/SamVerschueren/tsd/commit/8fe3924"><code>8fe3924</code></a>
• Allow <code>expectError</code> assertions to detect non-callable/non-constructable values/expressions (<a href="https://togithub.com/SamVerschueren/tsd/issues/104">#104</a>) <a href="https://togithub.com/SamVerschueren/tsd/commit/27ccc49"><code>27ccc49</code></a>
• Allow <code>expectError</code> assertions to detect <code>this</code> type mismatches on class methods (<a href="https://togithub.com/SamVerschueren/tsd/issues/105">#105</a>) <a href="https://togithub.com/SamVerschueren/tsd/commit/abf7082"><code>abf7082</code></a>
• Detect "Type X has no properties in common with type Y" in <code>expectError</code> (TS2559) (<a href="https://togithub.com/SamVerschueren/tsd/issues/97">#97</a>) <a href="https://togithub.com/SamVerschueren/tsd/commit/27c93af"><code>27c93af</code></a></p>
<p><strong><a href="https://togithub.com/SamVerschueren/tsd/releases/v0.15.1"><code>v0.15.1</code></a></strong></p>
<p><a href="https://togithub.com/SamVerschueren/tsd/compare/v0.15.0...v0.15.1">Compare Source</a></p>
<p>• Add dom.iterable lib by default <a href="https://togithub.com/SamVerschueren/tsd/commit/13dd5e3"><code>13dd5e3</code></a></p>
<p><strong><a href="https://togithub.com/SamVerschueren/tsd/releases/v0.15.0"><code>v0.15.0</code></a></strong></p>
<p><a href="https://togithub.com/SamVerschueren/tsd/compare/v0.14.0...v0.15.0">Compare Source</a></p>
<p>• Add dom lib by default <a href="https://togithub.com/SamVerschueren/tsd/commit/f5b69ed"><code>f5b69ed</code></a>
• Add support for ESM - fixes <a href="https://togithub.com/SamVerschueren/tsd/issues/95">#95</a> <a href="https://togithub.com/SamVerschueren/tsd/commit/d2284a1"><code>d2284a1</code></a>
• Allow specifying the test files and typings file manually (<a href="https://togithub.com/SamVerschueren/tsd/issues/74">#74</a>) <a href="https://togithub.com/SamVerschueren/tsd/commit/0e9228a"><code>0e9228a</code></a></p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2715152940)
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2715152921)
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2715152905)
GitHub Actions: test (windows-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2715152893)
GitHub Actions: test (ubuntu-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2715152881)
GitHub Actions: test (ubuntu-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2715152873)
GitHub Actions: test (ubuntu-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2715152858)
GitHub Actions: test (ubuntu-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2715152843)
GitHub Actions: test (windows-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2715152738)
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2715152726)
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2715152704)
GitHub Actions: test (windows-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2715152688)
GitHub Actions: test (ubuntu-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2715152676)
GitHub Actions: test (ubuntu-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2715152659)
GitHub Actions: test (ubuntu-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2715152644)
GitHub Actions: test (ubuntu-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2715152633)
GitHub
2021-05-31 21:21:46
[cucumber/cucumber-js] Comment on #1680
<a href="https://coveralls.io/builds/40188061">Coverage Status</a>
Coverage remained the same at 98.513% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/d978d0d5ed4e01ec6b374d12e1c8d858f5efb78a">d978d0d</a> on renovate/node-14.x* into *<a href="https://github.com/cucumber/cucumber-js/commit/ee90922abebe53f45e852d23a50f3fc01d26c517">ee90922</a> on main*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-05-31 21:24:43
[cucumber/cucumber-js] Comment on #1681
<a href="https://coveralls.io/builds/40188152">Coverage Status</a>
Coverage remained the same at 98.513% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/8ea85f44ad8b2ef4632d6ad61121d78c8db56068">8ea85f4</a> on renovate/tsd-0.x* into *<a href="https://github.com/cucumber/cucumber-js/commit/ee90922abebe53f45e852d23a50f3fc01d26c517">ee90922</a> on main*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-01 00:01:55
[cucumber/cucumber-js] Issue closed by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-01 00:01:56
[cucumber/cucumber-js] Issue closed by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-01 00:01:57
[cucumber/cucumber-js] Pull request merged by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-01 00:55:21
[cucumber/cucumber-js] Pull request merged by aslakhellesoy
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-01 00:55:34
[cucumber/cucumber-js] Pull request merged by aslakhellesoy
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-01 00:56:50
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Release Notes</strong>
Microsoft/TypeScript
<strong><a href="https://togithub.com/Microsoft/TypeScript/releases/v4.3.2"><code>v4.3.2</code></a></strong></p>
<p><a href="https://togithub.com/Microsoft/TypeScript/compare/v4.2.4...v4.3.2">Compare Source</a></p>
<p>For release notes, check out the <a href="https://devblogs.microsoft.com/typescript/announcing-typescript-4-3">release announcement</a>.</p>
<p>For the complete list of fixed issues, check out the</p>
<p>• <https://togithub.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+4.3.0%22+is%3Aclosed+|fixed issues query for TypeScript v4.3.0 (Beta)>.
• <https://togithub.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+4.3.1%22+is%3Aclosed+|fixed issues query for TypeScript v4.3.1 (RC)>.
• <https://togithub.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+4.3.2%22+is%3Aclosed+|fixed issues query for TypeScript v4.3.2>.</p>
<p>Downloads are available on:</p>
<p>• <a href="https://www.npmjs.com/package/typescript">npm</a>
• <a href="https://marketplace.visualstudio.com/items?itemName=TypeScriptTeam.TypeScript-43">Visual Studio 2017/2019</a> (<a href="https://togithub.com/Microsoft/TypeScript/wiki/Updating-TypeScript-in-Visual-Studio-2017">Select new version in project options</a>)
• <a href="https://www.nuget.org/packages/Microsoft.TypeScript.MSBuild">NuGet package</a></p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-01 00:57:07
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Release Notes</strong>
typescript-eslint/typescript-eslint
<strong><a href="https://togithub.com/typescript-eslint/typescript-eslint/blob/master/CHANGELOG.md#%E2%80%8B4260-httpsgithubcomtypescript-eslinttypescript-eslintcomparev4250v4260-2021-05-31|<code">https://togithub.com/typescript-eslint/typescript-eslint/blob/master/CHANGELOG.md#%E2%80%8B4260-httpsgithubcomtypescript-eslinttypescript-eslintcomparev4250v4260-2021-05-31|<code</a>v4.26.0</code>></strong></p>
<p><a href="https://togithub.com/typescript-eslint/typescript-eslint/compare/v4.25.0...v4.26.0">Compare Source</a></p>
<p><strong>Bug Fixes</strong></p>
<p>• <strong>eslint-plugin:</strong> [no-type-alias] consider type imports as alias types (<a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/3433">#3433</a>) (<a href="https://togithub.com/typescript-eslint/typescript-eslint/commit/d4f077473afb04f7c4d377dd87318749632b4404">d4f0774</a>)
• generate library types for TypeScript v4.3 (<a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/3460">#3460</a>) (<a href="https://togithub.com/typescript-eslint/typescript-eslint/commit/ed4776afa1374279027b9b7d82aa4b453b334998">ed4776a</a>), closes <a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/3449">#3449</a></p>
<p><strong>Features</strong></p>
<p>• <strong>eslint-plugin:</strong> [member-ordering] add callback as an ordering type of node (<a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/3354">#3354</a>) (<a href="https://togithub.com/typescript-eslint/typescript-eslint/commit/d134b1fa2540dec7094728f3dec1bbb8c644fe58">d134b1f</a>)
• <strong>eslint-plugin:</strong> [space-infix-ops] Add support for Union and intersection of type declarations (<a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/3360">#3360</a>) (<a href="https://togithub.com/typescript-eslint/typescript-eslint/commit/3d2932390cc335ab2cf80ae7a7fad066fd2eb22b">3d29323</a>)
• <strong>scope-manager:</strong> reduce generated lib file size (<a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/3468">#3468</a>) (<a href="https://togithub.com/typescript-eslint/typescript-eslint/commit/258116ba7b0dd4ac7a1cc3876fab12f2556bda74">258116b</a>)</p>
<p><strong><a href="https://togithub.com/typescript-eslint/typescript-eslint/blob/master/CHANGELOG.md#%E2%80%8B4250-httpsgithubcomtypescript-eslinttypescript-eslintcomparev4240v4250-2021-05-24|<code">https://togithub.com/typescript-eslint/typescript-eslint/blob/master/CHANGELOG.md#%E2%80%8B4250-httpsgithubcomtypescript-eslinttypescript-eslintcomparev4240v4250-2021-05-24|<code</a>v4.25.0</code>></strong></p>
<p><a href="https://togithub.com/typescript-eslint/typescript-eslint/compare/v4.24.0...v4.25.0">Compare Source</a></p>
<p><strong>Bug Fixes</strong></p>
<p>• corrected no-unsupported-browser-code in roadmap as unimplemented (<a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/3407">#3407</a>) (<a href="https://togithub.com/typescript-eslint/typescript-eslint/commit/2319b0e1847991b8b8902ff4a3b779f1a27c7a45">2319b0e</a>)
• <strong>experimental-utils:</strong> fix <code>isAwaitKeyword</code> predicate in ast-utils (<a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/3290">#3290</a>) (<a href="https://togithub.com/typescript-eslint/typescript-eslint/commit/c15da67b939b615ed063291cde12c55c0d6d236e">c15da67</a>)</p>
<p><strong>Features</strong></p>
<p>• <strong>typescript-estree:</strong> [TS4.3] support overrides on class members (<a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/3429">#3429</a>) (<a href="https://togithub.com/typescript-eslint/typescript-eslint/commit/21d1b62a0b84b502d2cf12674b3d141994a3ffd4">21d1b62</a>)
• <strong>typescript-estree:</strong> add support for getter/setter signatures on types (<a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/3427">#3427</a>) (<a href="https://togithub.com/typescript-eslint/typescript-eslint/commit/b830b7f4e8a99affc8af8b53cb83371ef81d7032">b830b7f</a>), closes <a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/3272">#3272</a> <a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/3272">#3272</a></p>
<p><strong><a href="https://togithub.com/typescript-eslint/typescript-eslint/blob/master/CHANGELOG.md#%E2%80%8B4240-httpsgithubcomtypescript-eslinttypescript-eslintcomparev4230v4240-2021-05-17|<code">https://togithub.com/typescript-eslint/typescript-eslint/blob/master/CHANGELOG.md#%E2%80%8B4240-httpsgithubcomtypescript-eslinttypescript-eslintcomparev4230v4240-2021-05-17|<code</a>v4.24.0</code>></strong></p>
<p><a href="https://togithub.com/typescript-eslint/typescript-eslint/compare/v4.23.0...v4.24.0">Compare Source</a></p>
<p><strong>Bug Fixes</strong></p>
<p>• <strong>eslint-plugin:</strong> [no-shadow] fix static class method generics shadowing class generics (<a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/3393">#3393</a>) (<a href="https://togithub.com/typescript-eslint/typescript-eslint/commit/b1e1c8a44695a58d29d19cf32ce35a8267bf506f">b1e1c8a</a>), closes <a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/2592">#2592</a>
• <strong>eslint-plugin:</strong> [no-unsafe-**] special case handling for the empty map constructor with no generics (<a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/3394">#3394</a>) (<a href="https://togithub.com/typescript-eslint/typescript-eslint/commit/cae4f4a0f33f8c954b1670d0abcfc8edd6193a06">cae4f4a</a>), closes <a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/2109">#2109</a></p>
<p><strong>Features</strong></p>
<p>• <strong>eslint-plugin:</strong> [dot-notation] optionally allow square bracket notation where an index signature exists in conjunction with <code>noPropertyAccessFromIndexSignature</code> (<a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/3361">#3361</a>) (<a href="https://togithub.com/typescript-eslint/typescript-eslint/commit/37ec2c2264add3e6ce20ac4e02d48644afda3fa8">37ec2c2</a>)</p>
<p><strong><a href="https://togithub.com/typescript-eslint/typescript-eslint/blob/master/CHANGELOG.md#%E2%80%8B4230-httpsgithubcomtypescript-eslinttypescript-eslintcomparev4221v4230-2021-05-10|<code">https://togithub.com/typescript-eslint/typescript-eslint/blob/master/CHANGELOG.md#%E2%80%8B4230-httpsgithubcomtypescript-eslinttypescript-eslintcomparev4221v4230-2021-05-10|<code</a>v4.23.0</code>></strong></p>
<p><a href="https://togithub.com/typescript-eslint/typescript-eslint/compare/v4.22.1...v4.23.0">Compare Source</a></p>
<p><strong>Bug Fixes</strong></p>
<p>• <strong>scope-manager:</strong> fix visiting TSAsExpression in assignment (<a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/3355">#3355</a>) (<a href="https://togithub.com/typescript-eslint/typescript-eslint/commit/87521a024103bc5fc643861649bee9a288f55b7b">87521a0</a>)</p>
<p><strong>Features</strong></p>
<p>• <strong>experimental-utils:</strong> Include <code>getCwd()</code> in <code>RuleContext</code> type (<a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/3308">#3308</a>) (<a href="https://togithub.com/typescript-eslint/typescript-eslint/commit/2b75c11d69bee88ca0cb77d7efd32b8d0387e6b3">2b75c11</a>)
• refactor to split AST specification out as its own module (<a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/2911">#2911</a>) (<a href="https://togithub.com/typescript-eslint/typescript-eslint/commit/25ea953cc60b118bd385c71e0a9b61c286c26fcf">25ea953</a>)</p>
<p><strong><a href="https://togithub.com/typescript-eslint/typescript-eslint/compare/v4.22.0...v4.22.1">4.22.1</a> (2021-05-04)</strong></p>
<p><strong>Note:</strong> Version bump only for package <a href="https://togithub.com/typescript-eslint/typescript-eslint">@typescript-eslint/typescript-eslint</a></p>
<p><strong><a href="https://togithub.com/typescript-eslint/typescript-eslint/blob/master/CHANGELOG.md#%E2%80%8B4221-httpsgithubcomtypescript-eslinttypescript-eslintcomparev4220v4221-2021-05-04|<code">https://togithub.com/typescript-eslint/typescript-eslint/blob/master/CHANGELOG.md#%E2%80%8B4221-httpsgithubcomtypescript-eslinttypescript-eslintcomparev4220v4221-2021-05-04|<code</a>v4.22.1</code>></strong></p>
<p><a href="https://togithub.com/typescript-eslint/typescript-eslint/compare/v4.22.0...v4.22.1">Compare Source</a></p>
<p><strong>Note:</strong> Version bump only for package <a href="https://togithub.com/typescript-eslint/typescript-eslint">@typescript-eslint/typescript-eslint</a></p>
<p>eslint/eslint
<strong><a href="https://togithub.com/eslint/eslint/releases/v7.27.0"><code>v7.27.0</code></a></strong></p>
<p><a href="https://togithub.com/eslint/eslint/compare/v7.26.0...v7.27.0">Compare Source</a></p>
<p>• <a href="https://togithub.com/eslint/eslint/commit/2c0868cbeadc9f42716fa1178ebdc6b4cee6d31e"><code>2c0868c</code></a> Chore: merge all html formatter files into <code>html.js</code> (<a href="https://togithub.com/eslint/eslint/issues/14612">#14612</a>) (Milos Djermanovic)
• <a href="https://togithub.com/eslint/eslint/commit/9e9b5e07475564813b62cd1d7562a93c5fb4bc74"><code>9e9b5e0</code></a> Update: no-unused-vars false negative with comma operator (fixes <a href="https://togithub.com/eslint/eslint/issues/14325">#14325</a>) (<a href="https://togithub.com/eslint/eslint/issues/14354">#14354</a>) (Nitin Kumar)
• <a href="https://togithub.com/eslint/eslint/commit/afe95693e1e4316a1c6f01d39345061d4c5921c7"><code>afe9569</code></a> Chore: use includes instead of indexOf (<a href="https://togithub.com/eslint/eslint/issues/14607">#14607</a>) (Mikhail Bodrov)
• <a href="https://togithub.com/eslint/eslint/commit/c0f418e2476df98519bc156b81d20431984e8704"><code>c0f418e</code></a> Chore: Remove lodash (<a href="https://togithub.com/eslint/eslint/issues/14287">#14287</a>) (Stephen Wade)
• <a href="https://togithub.com/eslint/eslint/commit/52655dd54925ee02af2ba3a0ebc09de959ae3101"><code>52655dd</code></a> Update: no-restricted-imports custom message for patterns (fixes <a href="https://togithub.com/eslint/eslint/issues/11843">#11843</a>) (<a href="https://togithub.com/eslint/eslint/issues/14580">#14580</a>) (Alex Holden…</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2716524094)
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2716524062)
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2716524039)
GitHub Actions: test (windows-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2716524012)
GitHub Actions: test (ubuntu-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2716523990)
GitHub Actions: test (ubuntu-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2716523959)
GitHub Actions: test (ubuntu-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2716523928)
GitHub Actions: test (ubuntu-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2716523899)
GitHub Actions: test (windows-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2716523453)
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2716523440)
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2716523406)
GitHub Actions: test (windows-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2716523381)
GitHub Actions: test (ubuntu-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2716523356)
GitHub Actions: test (ubuntu-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2716523325)
GitHub Actions: test (ubuntu-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2716523294)
GitHub Actions: test (ubuntu-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2716523265)
GitHub
2021-06-01 01:10:35
[cucumber/cucumber-js] Comment on #1682
<a href="https://coveralls.io/builds/40193984">Coverage Status</a>
Coverage remained the same at 98.514% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/8fb4e745cdeb907893faba6a5079e183f3608e60">8fb4e74</a> on renovate/typescript-4.x* into *<a href="https://github.com/cucumber/cucumber-js/commit/e9983c154e05f7ad929dfdc072ad025b7057975a">e9983c1</a> on main*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-01 01:12:47
[cucumber/cucumber-js] Comment on #1683
<a href="https://coveralls.io/builds/40194064">Coverage Status</a>
Coverage remained the same at 98.514% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/47e4361a59498da64370ff9ad3eda96f0a18511c">47e4361</a> on renovate/eslint-packages* into *<a href="https://github.com/cucumber/cucumber-js/commit/e9983c154e05f7ad929dfdc072ad025b7057975a">e9983c1</a> on main*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-01 01:50:05
[cucumber/cucumber-js] Comment on #1669
Great to see this fixed! Any idea when this will be published to npm?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-01 02:18:45
[cucumber/cucumber-js] Pull request merged by renovate[bot]
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-01 02:20:31
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Release Notes</strong>
sinonjs/fake-timers
<strong><a href="https://togithub.com/sinonjs/fake-timers/blob/master/CHANGELOG.md#%E2%80%8B712--2021-05-28|<code">https://togithub.com/sinonjs/fake-timers/blob/master/CHANGELOG.md#%E2%80%8B712--2021-05-28|<code</a>v7.1.2</code>></strong></p>
<p><a href="https://togithub.com/sinonjs/fake-timers/compare/v7.1.1...v7.1.2">Compare Source</a></p>
<p>==================</p>
<p>• Fix <a href="https://togithub.com/sinonjs/fake-timers/issues/382">#382</a> by making config fields optional (<a href="https://togithub.com/sinonjs/fake-timers/issues/383">#383</a>)
• Fix <a href="https://togithub.com/sinonjs/fake-timers/issues/347">#347</a> : Support util.promisify</p>
<p><strong><a href="https://togithub.com/sinonjs/fake-timers/blob/master/CHANGELOG.md#%E2%80%8B711--2021-05-27|<code">https://togithub.com/sinonjs/fake-timers/blob/master/CHANGELOG.md#%E2%80%8B711--2021-05-27|<code</a>v7.1.1</code>></strong></p>
<p><a href="https://togithub.com/sinonjs/fake-timers/compare/v7.1.0...v7.1.1">Compare Source</a></p>
<p>==================</p>
<p>• Fix JSDoc for createClock</p>
<p><strong><a href="https://togithub.com/sinonjs/fake-timers/blob/master/CHANGELOG.md#%E2%80%8B710--2021-05-20|<code">https://togithub.com/sinonjs/fake-timers/blob/master/CHANGELOG.md#%E2%80%8B710--2021-05-20|<code</a>v7.1.0</code>></strong></p>
<p><a href="https://togithub.com/sinonjs/fake-timers/compare/v7.0.5...v7.1.0">Compare Source</a></p>
<p>==================</p>
<p>• Remove Safari from Sauce Lab (ref <a href="https://togithub.com/sinonjs/fake-timers/issues/380">#380</a>)
• Bump hosted-git-info from 2.6.0 to 2.8.9
• Bump handlebars from 4.7.6 to 4.7.7
• Bump lodash from 4.17.19 to 4.17.21
• Add in latest Safari and evergreen Edge
• Drop IE11 and Safari 9
• chore: add type tests (<a href="https://togithub.com/sinonjs/fake-timers/issues/373">#373</a>)
• remove constructor types
• use globalThis to avoid conflicts
• Update yargs-parser
• Update mkdirp
• Upgrade jsdom
• Upgrade mochify to latest
• Upgrade Mocha to latest
• Bump y18n from 4.0.0 to 4.0.1
• make config optional
• add a bunch more types</p>
<p>mochajs/mocha
<strong><a href="https://togithub.com/mochajs/mocha/blob/master/CHANGELOG.md#%E2%80%8B840--2021-05-07|<code">https://togithub.com/mochajs/mocha/blob/master/CHANGELOG.md#%E2%80%8B840--2021-05-07|<code</a>v8.4.0</code>></strong></p>
<p><a href="https://togithub.com/mochajs/mocha/compare/v8.3.2...v8.4.0">Compare Source</a></p>
<p><strong>🎉 Enhancements</strong></p>
<p>• <a href="https://togithub.com/mochajs/mocha/issues/4502">#4502</a>: CLI file parsing errors now have error codes (<a href="https://togithub.com/evaline-ju"><strong>@evaline-ju</strong></a>)</p>
<p><strong>🐛 Fixes</strong></p>
<p>• <a href="https://togithub.com/mochajs/mocha/issues/4614">#4614</a>: Watch: fix crash when reloading files (<a href="https://togithub.com/outsideris"><strong>@outsideris</strong></a>)</p>
<p><strong>📖 Documentation</strong></p>
<p>• <a href="https://togithub.com/mochajs/mocha/issues/4630">#4630</a>: Add <code>options.require</code> to Mocha constructor for <code>root hook</code> plugins on parallel runs (<a href="https://togithub.com/juergba"><strong>@juergba</strong></a>)
• <a href="https://togithub.com/mochajs/mocha/issues/4617">#4617</a>: Dynamically generating tests with <code>top-level await</code> and ESM test files (<a href="https://togithub.com/juergba"><strong>@juergba</strong></a>)
• <a href="https://togithub.com/mochajs/mocha/issues/4608">#4608</a>: Update default file extensions (<a href="https://togithub.com/outsideris"><strong>@outsideris</strong></a>)</p>
<p>Also thanks to <a href="https://togithub.com/outsideris"><strong>@outsideris</strong></a> for various improvements on our GH actions workflows.</p>
<p>domenic/sinon-chai
<strong><a href="https://togithub.com/domenic/sinon-chai/blob/master/CHANGELOG.md#%E2%80%8B370|<code">https://togithub.com/domenic/sinon-chai/blob/master/CHANGELOG.md#%E2%80%8B370|<code</a>v3.7.0</code>></strong></p>
<p><a href="https://togithub.com/domenic/sinon-chai/compare/3.6.0...3.7.0">Compare Source</a></p>
<p>• No longer check for the max sinon version (<a href="https://togithub.com/domenic/sinon-chai/issues/150">#150</a>)</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>👻 <strong>Immortal</strong>: This PR will be recreated if closed unmerged. Get <a href="https://togithub.com/renovatebot/renovate/discussions">config help</a> if that's undesired.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-01 02:20:44
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Release Notes</strong>
jprichardson/node-fs-extra
<strong><a href="https://togithub.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md#%E2%80%8B1000--2021-05-03|<code">https://togithub.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md#%E2%80%8B1000--2021-05-03|<code</a>v10.0.0</code>></strong></p>
<p><a href="https://togithub.com/jprichardson/node-fs-extra/compare/9.1.0...10.0.0">Compare Source</a></p>
<p><strong>Breaking changes</strong></p>
<p>• Require Node.js v12+ (<a href="https://togithub.com/jprichardson/node-fs-extra/issues/886">#886</a>, <a href="https://togithub.com/jprichardson/node-fs-extra/pull/893">#893</a>, <a href="https://togithub.com/jprichardson/node-fs-extra/pull/890">#890</a>, <a href="https://togithub.com/jprichardson/node-fs-extra/pull/894">#894</a>, <a href="https://togithub.com/jprichardson/node-fs-extra/pull/895">#895</a>)
• Allow copying broken symlinks (<a href="https://togithub.com/jprichardson/node-fs-extra/pull/779">#779</a>, <a href="https://togithub.com/jprichardson/node-fs-extra/issues/765">#765</a>, <a href="https://togithub.com/jprichardson/node-fs-extra/issues/638">#638</a>, <a href="https://togithub.com/jprichardson/node-fs-extra/issues/761">#761</a>)</p>
<p><strong>The following changes, although technically semver-major, will not affect the vast majority of users:</strong></p>
<p>• Ensure correct type when destination exists for <code>ensureLink**()</code>/<code>ensureSymlink**()</code> (<a href="https://togithub.com/jprichardson/node-fs-extra/pull/826">#826</a>, <a href="https://togithub.com/jprichardson/node-fs-extra/issues/786">#786</a>, <a href="https://togithub.com/jprichardson/node-fs-extra/issues/870">#870</a>)
• Error when attempting to <code>copy**()</code> unknown file type (<a href="https://togithub.com/jprichardson/node-fs-extra/pull/880">#880</a>)
• Remove undocumented options for <code>remove**()</code> (<a href="https://togithub.com/jprichardson/node-fs-extra/pull/882">#882</a>)</p>
<p><strong>Improvements</strong></p>
<p>• Allow changing case of filenames with <code>move**()</code>, even on technically case-insensitive filesystems (<a href="https://togithub.com/jprichardson/node-fs-extra/issues/759">#759</a>, <a href="https://togithub.com/jprichardson/node-fs-extra/pull/801">#801</a>)
• Use native <code>fs.rm**()</code> for <code>remove**()</code> in environments that support it (<a href="https://togithub.com/jprichardson/node-fs-extra/pull/882">#882</a>, <a href="https://togithub.com/jprichardson/node-fs-extra/issues/806">#806</a>)
• Improve <code>emptyDir()</code> performance (<a href="https://togithub.com/jprichardson/node-fs-extra/pull/885">#885</a>)</p>
<p><strong>Bugfixes</strong></p>
<p>• Ensure <code>copy**()</code>'s <code>filter</code> function is not called more than necessary (<a href="https://togithub.com/jprichardson/node-fs-extra/pull/883">#883</a>, <a href="https://togithub.com/jprichardson/node-fs-extra/issues/809">#809</a>)
• Fix <code>move**()</code> raising <code>EPERM</code> error when moving a file to the root of a drive on Windows (<a href="https://togithub.com/jprichardson/node-fs-extra/pull/897">#897</a>, <a href="https://togithub.com/jprichardson/node-fs-extra/issues/819">#819</a>)</p>
<p><strong>Miscellaneous changes</strong></p>
<p>• Do not use <code>at-least-node</code> as a dependency (<a href="https://togithub.com/jprichardson/node-fs-extra/pull/896">#896</a>)
• Improve documentation (<a href="https://togithub.com/jprichardson/node-fs-extra/pull/888">#888</a>, <a href="https://togithub.com/jprichardson/node-fs-extra/issues/830">#830</a>, <a href="https://togithub.com/jprichardson/node-fs-extra/pull/884">#884</a>, <a href="https://togithub.com/jprichardson/node-fs-extra/issues/843">#843</a>)</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Disabled by config. Please merge this manually once you are satisfied.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2717174072)
GitHub Actions: test (ubuntu-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2717173919)
GitHub Actions: test (windows-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2717173603)
GitHub Actions: test (ubuntu-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2717173506)
GitHub
2021-06-01 02:31:07
[cucumber/cucumber-js] Comment on #1684
<a href="https://coveralls.io/builds/40196159">Coverage Status</a>
Coverage remained the same at 98.514% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/9cd7c26e21b33ce6381eb541cfb493d3d832b176">9cd7c26</a> on renovate/unit-test-packages* into *<a href="https://github.com/cucumber/cucumber-js/commit/4d468fce4f6ca9dc4d73b36088c1863c76ee8e12">4d468fc</a> on main*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-01 02:34:08
[cucumber/cucumber-js] Comment on #1685
<a href="https://coveralls.io/builds/40196282">Coverage Status</a>
Coverage remained the same at 98.514% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/da7654e272fcfbabb32632e9cd6053a48b71d12b">da7654e</a> on renovate/fs-extra-10.x* into *<a href="https://github.com/cucumber/cucumber-js/commit/4d468fce4f6ca9dc4d73b36088c1863c76ee8e12">4d468fc</a> on main*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-01 03:17:45
[cucumber/cucumber-js] Pull request merged by renovate[bot]
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-01 03:19:48
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Release Notes</strong>
sinonjs/sinon
<strong><a href="https://togithub.com/sinonjs/sinon/blob/master/CHANGELOG.md#%E2%80%8B1111--2021-05-26|<code">https://togithub.com/sinonjs/sinon/blob/master/CHANGELOG.md#%E2%80%8B1111--2021-05-26|<code</a>v11.1.1</code>></strong></p>
<p><a href="https://togithub.com/sinonjs/sinon/compare/v11.1.0...v11.1.1">Compare Source</a></p>
<p>==================</p>
<p>• Fix <a href="https://togithub.com/sinonjs/sinon/issues/2379">#2379</a> by using v7 of supports-color</p>
<p><strong><a href="https://togithub.com/sinonjs/sinon/blob/master/CHANGELOG.md#%E2%80%8B1110--2021-05-25|<code">https://togithub.com/sinonjs/sinon/blob/master/CHANGELOG.md#%E2%80%8B1110--2021-05-25|<code</a>v11.1.0</code>></strong></p>
<p><a href="https://togithub.com/sinonjs/sinon/compare/v11.0.0...v11.1.0">Compare Source</a></p>
<p>==================</p>
<p>• Add sinon.promise() implementation (<a href="https://togithub.com/sinonjs/sinon/issues/2369">#2369</a>)
• Set wrappedMethod on getters/setters (<a href="https://togithub.com/sinonjs/sinon/issues/2378">#2378</a>)
• [Docs] Update fake-server usage & descriptions (<a href="https://togithub.com/sinonjs/sinon/issues/2365">#2365</a>)
• Fake docs improvement (<a href="https://togithub.com/sinonjs/sinon/issues/2360">#2360</a>)
• Update nise to 5.1.0 (fixed <a href="https://togithub.com/sinonjs/sinon/issues/2318">#2318</a>)</p>
<p><strong><a href="https://togithub.com/sinonjs/sinon/blob/master/CHANGELOG.md#%E2%80%8B1100--2021-05-24|<code">https://togithub.com/sinonjs/sinon/blob/master/CHANGELOG.md#%E2%80%8B1100--2021-05-24|<code</a>v11.0.0</code>></strong></p>
<p><a href="https://togithub.com/sinonjs/sinon/compare/v10.0.1...v11.0.0">Compare Source</a></p>
<p>==================</p>
<p>• Explicitly use samsam 6.0.2 with fix for <a href="https://togithub.com/sinonjs/sinon/issues/2345">#2345</a>
• Update most packages (<a href="https://togithub.com/sinonjs/sinon/issues/2371">#2371</a>)
• Update compatibility docs (<a href="https://togithub.com/sinonjs/sinon/issues/2366">#2366</a>)
• Update packages (includes breaking fake-timers change, see <a href="https://togithub.com/sinonjs/sinon/issues/2352">#2352</a>)
• Warn of potential memory leaks (<a href="https://togithub.com/sinonjs/sinon/issues/2357">#2357</a>)
• Fix clock test errors</p>
<p><strong><a href="https://togithub.com/sinonjs/sinon/blob/master/CHANGELOG.md#%E2%80%8B1001--2021-04-08|<code">https://togithub.com/sinonjs/sinon/blob/master/CHANGELOG.md#%E2%80%8B1001--2021-04-08|<code</a>v10.0.1</code>></strong></p>
<p><a href="https://togithub.com/sinonjs/sinon/compare/v10.0.0...v10.0.1">Compare Source</a></p>
<p>==================</p>
<p>• Upgrade sinon components (bumps y18n to 4.0.1)
• Bump y18n from 4.0.0 to 4.0.1</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Disabled by config. Please merge this manually once you are satisfied.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-01 03:20:02
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Release Notes</strong>
TypeStrong/ts-node
<strong><a href="https://togithub.com/TypeStrong/ts-node/releases/v10.0.0"><code>v10.0.0</code></a></strong></p>
<p><a href="https://togithub.com/TypeStrong/ts-node/compare/v9.1.1...v10.0.0">Compare Source</a></p>
<p>Questions about this release? Ask in the official discussion thread: <a href="https://togithub.com/TypeStrong/ts-node/issues/1337">#1337</a></p>
<p><em>Breaking changes are prefixed with <strong>[BREAKING]</strong></em></p>
<p><strong>Added</strong></p>
<p>• Adds <code>--show-config</code> to log the resolved configuration (<a href="https://typestrong.org/ts-node/docs/troubleshooting#understanding-configuration">docs</a>) (<a href="https://togithub.com/TypeStrong/ts-node/issues/1100">#1100</a>, <a href="https://togithub.com/TypeStrong/ts-node/issues/1243">#1243</a>)
• Bundle and re-export <a href="https://togithub.com/tsconfig/node">@tsconfig/node</a><em>* configurations for convenience (<a href="https://typestrong.org/ts-node/docs/configuration#tsconfigbases">docs</a>) (<a href="https://togithub.com/TypeStrong/ts-node/issues/1202">#1202</a>, <a href="https://togithub.com/TypeStrong/ts-node/issues/1236">#1236</a>, <a href="https://togithub.com/TypeStrong/ts-node/issues/1313">#1313</a>)
• Default to appropriate <a href="https://togithub.com/tsconfig/node">@tsconfig/node</a></em>* configuration based on node and typescript versions (<a href="https://typestrong.org/ts-node/docs/configuration#default-config">docs</a>) (<a href="https://togithub.com/TypeStrong/ts-node/issues/1202">#1202</a>, <a href="https://togithub.com/TypeStrong/ts-node/issues/1236">#1236</a>, <a href="https://togithub.com/TypeStrong/ts-node/issues/1313">#1313</a>)
• Automatically reference <a href="https://togithub.com/types/node">@types/node</a>; use globally-installed <a href="https://togithub.com/types/node">@types/node</a> if not locally installed (<a href="https://togithub.com/TypeStrong/ts-node/issues/1240">#1240</a>, <a href="https://togithub.com/TypeStrong/ts-node/issues/1257">#1257</a>)
• Add <code>swc</code> integration and new <code>--transpiler</code> option to use third-party transpilers for a massive speed boost on large codebases (<a href="https://typestrong.org/ts-node/docs/transpilers">docs</a>) (<a href="https://togithub.com/TypeStrong/ts-node/issues/779">#779</a>, <a href="https://togithub.com/TypeStrong/ts-node/issues/1160">#1160</a>)
• Add <code>scopeDir</code> API option (<a href="https://typestrong.org/ts-node/api/interfaces/RegisterOptions.html#scopeDir">docs</a>) (<a href="https://togithub.com/TypeStrong/ts-node/issues/1155">#1155</a>)
• Add <code>projectSearchDir</code> API option (<a href="https://typestrong.org/ts-node/api/interfaces/RegisterOptions.html#projectSearchDir">docs</a>) (<a href="https://togithub.com/TypeStrong/ts-node/issues/1155">#1155</a>)
• Add <code>--cwd-mode</code> and <code>ts-node-cwd</code> to resolve config file relative to cwd, not entrypoint script (<a href="https://togithub.com/TypeStrong/ts-node/issues/1155">#1155</a>)</p>
<p><strong>Changed</strong></p>
<p>• <strong>[BREAKING]</strong> Make <code>--script-mode</code> default behavior; resolve tsconfig relative to entrypoint script instead of cwd (<a href="https://togithub.com/TypeStrong/ts-node/issues/949">#949</a>, <a href="https://togithub.com/TypeStrong/ts-node/issues/1197">#1197</a>, <a href="https://togithub.com/TypeStrong/ts-node/issues/1155">#1155</a>)
• In most cases this change will have no noticeable effect
• Primarily benefits portable shell scripts on your <code>$PATH</code>, because <code>ts-node</code> will respect the script's local <code>tsconfig.json</code>
• Use <code>--cwd-mode</code> or <code>ts-node-cwd</code> if you need legacy behavior
• <strong>[BREAKING]</strong> <code>ignore</code> rules evaluate relative to <code>tsconfig.json</code> directory, otherwise <code>cwd</code> (<a href="https://togithub.com/TypeStrong/ts-node/issues/1155">#1155</a>)
• <strong>[BREAKING]</strong> Remove support for node 10. Minimum supported version is node 12 (<a href="https://togithub.com/TypeStrong/ts-node/issues/1312">#1312</a>)
• Rename <code>--dir</code> to <code>--cwd</code>; rename <code>TS_NODE_DIR</code> to <code>TS_NODE_CWD</code> (<a href="https://togithub.com/TypeStrong/ts-node/issues/1155">#1155</a>)
• <code>--dir</code> and <code>TS_NODE_DIR</code> are deprecated but still parsed for backwards-compatibility
• <code>--dir</code> effectively changed the working directory of <code>ts-node</code>; renaming makes this behavior more obvious</p>
<p><strong>Deprecated</strong></p>
<p>• Deprecate <code>TS_NODE_SCOPE</code> (<a href="https://togithub.com/TypeStrong/ts-node/issues/1155">#1155</a>)
• Deprecate <code>--dir</code> and <code>TS_NODE_DIR</code> (<a href="https://togithub.com/TypeStrong/ts-node/issues/1155">#1155</a>)</p>
<p><strong>Removed</strong></p>
<p>• <strong>[BREAKING]</strong> Internal APIs removed from type declarations (<a href="https://togithub.com/TypeStrong/ts-node/issues/1242">#1242</a>)
• Removed <code>DEFAULTS</code>, <code>normalizeSlashes</code>, <code>parse</code>, <code>split</code>
• No features were removed
• This will only affect consumers of <code>ts-node</code>'s programmatic API</p>
<p><strong>Fixed</strong></p>
<p>• <strong>[BREAKING]</strong> Fix <a href="https://togithub.com/TypeStrong/ts-node/issues/1229">#1229</a> and <a href="https://togithub.com/TypeStrong/ts-node/issues/1235">#1235</a>: always throw <code>ERR_REQUIRE_ESM</code> when attempting to execute ESM as CJS, even when not using <code>--loader ts-node/esm</code> (<a href="https://togithub.com/TypeStrong/ts-node/issues/1232">#1232</a>)
• This aligns our behavior with vanilla <code>node</code>
• <strong>[BREAKING]</strong> Fix <a href="https://togithub.com/TypeStrong/ts-node/issues/1225">#1225</a>: <code>compiler</code> is loaded relative to <code>tsconfig.json</code> instead of entrypoint script (<a href="https://togithub.com/TypeStrong/ts-node/issues/1155">#1155</a>)
• In most cases this change will have no noticable effect
• Fix <a href="https://togithub.com/TypeStrong/ts-node/issues/1217">#1217</a>: REPL not always using passed stdout and stderr (<a href="https://togithub.com/TypeStrong/ts-node/issues/1224">#1224</a>)
• Fix <a href="https://togithub.com/TypeStrong/ts-node/issues/1220">#1220</a>: <code>ts-node ./index</code> may execute the wrong file extension because tsconfig search poisons the <code>require.resolve</code> cache (<a href="https://togithub.com/TypeStrong/ts-node/issues/1155">#1155</a>)
• Fix <a href="https://togithub.com/TypeStrong/ts-node/issues/1322">#1322</a>: Sourcemaps fail for filenames with spaces or other characters which are percent-encoded in URLs (<a href="https://togithub.com/TypeStrong/ts-node/issues/1160">#1160</a>, <a href="https://togithub.com/TypeStrong/ts-node/issues/1330">#1330</a>)
• Fix <a href="https://togithub.com/TypeStrong/ts-node/issues/1331">#1331</a>: Resolution of node builtin modules in ESM loader fails on node >=12.20.0, <13 (<a href="https://togithub.com/TypeStrong/ts-node/issues/1332">#1332</a>)</p>
<p><strong>Docs</strong></p>
<p>• New documentation website: <a href="https://typestrong.org/ts-node">https://typestrong.org/ts-node</a>
• README is generated to match the website
• Added page explaining CommonJS vs ESM
• Added page with Performance advice
• Added Troubleshooting page
• Organized and added to "Recipes" section with third-party tool integrations
• Added TypeDoc-generated API docs
• Work was spread across multiple tickets: <a href="https://togithub.com/TypeStrong/ts-node/issues/1207">#1207</a>, <a href="https://togithub.com/TypeStrong/ts-node/issues/1213">#1213</a>, <a href="https://togithub.com/TypeStrong/ts-node/issues/1221">#1221</a>, <a href="https://togithub.com/TypeStrong/ts-node/issues/1228">#1228</a>, <a href="https://togithub.com/TypeStrong/ts-node/issues/1244">#1244</a>, <a href="https://togithub.com/TypeStrong/ts-node/issues/1250">#1250</a>, <a href="https://togithub.com/TypeStrong/ts-node/issues/1294">#1294</a>, <a href="https://togithub.com/TypeStrong/ts-node/issues/1295">#1295</a>, <a href="https://togithub.com/TypeStrong/ts-node/issues/1296">#1296</a>, <a href="https://togithub.com/TypeStrong/ts-node/issues/1297">#1297</a>
• Thanks to these contributors for PRs which improved our documentation
• add troubleshooting tip for syntax errors (<a href="https://togithub.com/TypeStrong/ts-node/issues/1201">#1201</a>) <a href="https://togithub.com/jedwards1211">@jedwards1211</a>
• Clarify handling of tsx/jsx file extensions (<a href="https://togithub.com/TypeStrong/ts-node/issues/1179">#1179</a>) <a href="https://togithub.com/NaridaL">@NaridaL</a>
• Added <code>CONTRIBUTING.md</code> to document the codebase and our development workflow</p>
<p><a href="https://github.com/TypeStrong/ts-node/milestone/1">https://github.com/TypeStrong/ts-node/milestone/1</a></p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Disabled by config. Please merge this manually once you are satisfied.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry …</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2717618873)
GitHub Actions: test (ubuntu-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2717618730)
GitHub Actions: test (windows-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2717618613)
GitHub Actions: test (ubuntu-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2717618424)
GitHub
2021-06-01 03:32:13
[cucumber/cucumber-js] Comment on #1686
<a href="https://coveralls.io/builds/40198018">Coverage Status</a>
Coverage remained the same at 98.514% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/47b36fe10d316c47ef744e3bbcbd39d0e6550cf3">47b36fe</a> on renovate/major-unit-test-packages* into *<a href="https://github.com/cucumber/cucumber-js/commit/c3a5aeba0cf3b7fdc48d162f232dbbd4d8d07375">c3a5aeb</a> on main*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-01 03:35:54
[cucumber/cucumber-js] Comment on #1687
<a href="https://coveralls.io/builds/40198109">Coverage Status</a>
Coverage remained the same at 98.514% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/4fa3471481d890a14aeac3a0ca8414d5311ff112">4fa3471</a> on renovate/ts-node-10.x* into *<a href="https://github.com/cucumber/cucumber-js/commit/c3a5aeba0cf3b7fdc48d162f232dbbd4d8d07375">c3a5aeb</a> on main*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-01 04:51:54
[cucumber/cucumber-js] Pull request merged by renovate[bot]
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-01 05:09:09
[cucumber/cucumber-js] Pull request merged by aslakhellesoy
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-01 05:11:34
[cucumber/cucumber-js] Comment on #1687
We can't upgrade ts-node while we're still supporting Node 10. I think we'll see more and more libraries dropping support for Node 10, so maybe we should reconsider dropping support for it? It would mean our next release would be a major release.
WDYT <a href="https://github.com/davidjgoss">@davidjgoss</a> <a href="https://github.com/aurelien-reeves">@aurelien-reeves</a> <a href="https://github.com/mattwynne">@mattwynne</a> <a href="https://github.com/charlierudolph">@charlierudolph</a>?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-01 05:17:48
[cucumber/cucumber-js] Comment on #1687
I agree with dropping support for node 10
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-01 05:30:06
[cucumber/cucumber-js] Comment on #1687
I'd be in favour of doing a last 7.3.0 with the current unreleased fixes and then cutting a 8.0.0 after removing Node 10 support.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-01 05:37:05
[cucumber/cucumber-js] Comment on #1532
Addressed by the various linked PRs.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-01 05:37:05
[cucumber/cucumber-js] Issue closed by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-01 05:38:49
[cucumber/cucumber-js] Issue closed by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-01 06:59:02
[cucumber/cucumber-js] Pull request opened by aslakhellesoy
<p>This is necessary in order to make tests behave independently of the value of environment variables such as <code>CUCUMBER_PUBLISH_TOKEN</code>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2719313870)
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2719313834)
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2719313804)
GitHub Actions: test (windows-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2719313763)
GitHub Actions: test (ubuntu-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2719313715)
GitHub Actions: test (ubuntu-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2719313654)
GitHub Actions: test (ubuntu-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2719313617)
GitHub Actions: test (ubuntu-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2719313583)
GitHub Actions: test (windows-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2719304276)
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2719304230)
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2719304182)
GitHub Actions: test (windows-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2719304141)
GitHub Actions: test (ubuntu-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2719304096)
GitHub Actions: test (ubuntu-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2719304052)
GitHub Actions: test (ubuntu-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2719304015)
GitHub Actions: test (ubuntu-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2719303961)
GitHub
2021-06-01 07:37:22
[cucumber/cucumber-js] Comment on #1434
<a href="https://github.com/deepziem">@deepziem</a> are you confident into continue working on this PR?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-01 07:39:09
[cucumber/cucumber-js] Comment on #1531
The code makes sense to me too.
<a href="https://github.com/jan-molak">@jan-molak</a> would you have the possibility to add a test for this?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-01 07:56:41
[cucumber/cucumber-js] davidjgoss commented on aslakhellesoy's pull request
LGTM, just needs changes to the support code for feature tests I think.
Also not sure if there's anything specific we need to do for parallel runtime?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-01 08:58:28
[cucumber/cucumber-js] Comment on #1688
Could type as `ProcessEnv` from `@types/node`?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-01 21:00:35
[cucumber/cucumber-js] Comment on #1489
There has been a lot of water under this bridge since I first posted this issue, so being concise may be difficult. I'll do my best though.
*Rephrasing*
As per my very first message in this issue on 2 Dec 2020, `cucumber.getTestCasesFromFilesystem` did "exactly" what I and others needed it to do.
*What did I and others need it to do?*
For us (purpleteam-labs) the main file involved (now and when it was doing what we needed it to do (last year)) in the Cucumber invocations is /src/api/app/models/app.js of the <a href="https://github.com/purpleteam-labs/purpleteam-app-scanner">app-scanner</a>.
In the past <a href="https://github.com/purpleteam-labs/purpleteam-app-scanner/blob/92fca1c18c30805cea0acef3717945d6ff3eabcc/src/api/app/models/app.js#L141">`getActiveTestCases`</a> did exactly what we needed it to do.
We needed it to <a href="https://github.com/purpleteam-labs/purpleteam-app-scanner/blob/92fca1c18c30805cea0acef3717945d6ff3eabcc/src/api/app/models/app.js#L143">`getActiveTestCasesFromFilesystem`</a>. We still need this functionality.
We provide the paths to our feature files, actually the cucumber Cli did and still does this.
The <a href="https://github.com/purpleteam-labs/purpleteam-app-scanner/blob/92fca1c18c30805cea0acef3717945d6ff3eabcc/src/api/app/models/app.js#L148">`pickleFilter`</a> provided the details around what an active test case was, which I think was and is based on <a href="https://github.com/purpleteam-labs/purpleteam-app-scanner/blob/92fca1c18c30805cea0acef3717945d6ff3eabcc/src/api/app/models/app.js#L131">`cucumber.tagExpression`</a>.
Simply put, we need the active test cases as a string based on the tags we initialise the Cucumber CLI with. Why? Because users of the system need a test plan, they need to know which feature files are going to be run when they start the test.
*Where are we now?*
Currently <a href="https://github.com/purpleteam-labs/purpleteam-app-scanner/blob/06c5148c9f080388164a74ccf990e8ae18f7316f/src/api/app/models/app.js#L141">`getActiveFeatureFileUris`</a> passes <a href="https://github.com/purpleteam-labs/purpleteam-app-scanner/blob/06c5148c9f080388164a74ccf990e8ae18f7316f/test/api/app/models/app.js#L27-L55">these tests</a>.
Currently <a href="https://github.com/purpleteam-labs/purpleteam-app-scanner/blob/06c5148c9f080388164a74ccf990e8ae18f7316f/src/api/app/models/app.js#L141">`getActiveFeatureFileUris`</a> does not pass <a href="https://github.com/purpleteam-labs/purpleteam-app-scanner/blob/06c5148c9f080388164a74ccf990e8ae18f7316f/test/api/app/models/app.js#L59-L93">these tests</a> (I mentioned this in <a href="https://github.com/cucumber/cucumber-js/issues/1489#issuecomment-808828443">this post</a>).
The names of the tests should explain what they are supposed to do, but currently do not.
All you need to do is compare the passing tests with the failing tests to see where the shortfall is.
*Thoughts, question, comments*
So far I've setup everything as <a href="https://github.com/aslakhellesoy">@aslakhellesoy</a> has suggested.
Do you recognise anything workable from <a href="https://github.com/yopasa94">@yopasa94</a> solution?
Basically what we're doing here is reimplementing functionality that has been removed but needed by myself and others.
Hopefully this is sumarised well enough to understand?
Thanks.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-02 00:36:43
[cucumber/cucumber-js] Issue opened by binarymist
<p><strong>Summary</strong></p>
<p>In upgradeing from "@cucumber/cucumber": "7.0.0" to "@cucumber/cucumber": "7.2.1" as per <a href="https://github.com/cucumber/common/issues/1585">this issue</a> I had problems at 7.1.0.<br />
In looking at the <a href="https://github.com/cucumber/cucumber-js/blob/main/CHANGELOG.md#fixed-2">Changelog</a>, I see <a href="https://github.com/cucumber/cucumber-js/pull/1608/files">pr 1608</a> introduced a <code>stream.on</code> (in a ts file (I'm using js)). Correct me if I'm wrong, but this seems to assume that the cucumber stdout has an <code>on</code> function. I haven't seen this documented anywhere, what is the purpose of this? Also the actual change doesn't seem to be in the Changelog. I also can't find it in the <a href="https://github.com/cucumber/cucumber-js">https://github.com/cucumber/cucumber-js</a> repository. I can only see it when I npm install @cucumber/cucumber 7.1.0. Where is this code?</p>
<p>I've added <a href="https://github.com/purpleteam-labs/purpleteam-app-scanner/blob/06c5148c9f080388164a74ccf990e8ae18f7316f/src/scripts/runCuc.js#L42-L45">this</a> to get around the problem, but I have no idea what the <code>on</code> function is supposed to do?</p>
<p><a href="https://github.com/purpleteam-labs/purpleteam-app-scanner/blob/06c5148c9f080388164a74ccf990e8ae18f7316f/src/scripts/runCuc.js#L63-L67">This is where/how</a> I've been instantiating the CLI for years.</p>
<p><a href="https://github.com/purpleteam-labs/purpleteam-app-scanner/blob/06c5148c9f080388164a74ccf990e8ae18f7316f/src/api/app/models/app.parallel.js#L502-L505">This is how</a> I've been handling the CLI erros for years.</p>
<p>Is my empty <code>on</code> function the way to do this, I'm struggling to understand what's going on here?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-02 03:36:28
[cucumber/cucumber-js] Comment on #1489
Did you explore `gherkinStream.fromPaths`? What is the situation with this?
Also, the suggestion from <a href="https://github.com/yopasa94">@yopasa94</a> was pretty interesting. Did you had the opportunity to take a look? `parseGherkinMessageStream` is a helper method in cucumber-js:
<a href="https://github.com/cucumber/cucumber-js/blob/24ff9dc635ed25a32bdb6daf0028ecaf89569393/src/cli/helpers.ts#L46">cucumber-js/src/cli/helpers.ts</a>
Line 46 in </cucumber/cucumber-js/commit/24ff9dc635ed25a32bdb6daf0028ecaf89569393|24ff9dc>
You give too many references to your own code base. Please give minimum reproducible snippets here instead.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-02 03:42:07
[cucumber/cucumber-js] Comment on #1689
> I did not say that. I just said that we cannot guaranty the type of the data here as this is not specific to Cucumber. This is based on a Node API which gives any guaranty on the type of the incoming data.
>
> That stream is passed to formatters, including custom formatters. We do not know what is going on in those custom formatters.
Ah, some more context/background. That helps. We're don't use any formatters other than what's in the Cucumber box. Does that mean it'll always be a string or is there still some uncertanty?
> That stream representing stdout, it is relatively safe to assume they'll receive strings or data easily convertible as strings.
Ok, that's helpful.
> But as it is passed to custom formatters and end users being able to easily implement their own custom formatters, you should not trust the data and implement proper checks and guards before publishing it to your system, or before processing it by your own services.
Our end users don't come anywhere near the backend (Cucumber). The only data we take in from users is a <a href="https://purpleteam-labs.com/doc/definitions/">_Job_</a> file which looks a bit like <a href="https://github.com/purpleteam-labs/purpleteam/blob/main/testResources/jobs/job_0.1.0-alpha.1_local">this one</a> and is passed through several forms of <a href="https://f1.holisticinfosecforwebdevelopers.com/chap06.html#leanpub-auto-generic">validation, filtering and sanitisation</a>. No user input is directly used with Cucumber.
Which is sounding like we just check whether `chunk` is `string` or `buffer` if string, wer're good to log it, if `buffer` attempt conversion to string and... we're good to log it?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-02 04:54:18
[cucumber/cucumber-js] Comment on #1489
> Did you explore gherkinStream.fromPaths? What is the situation with this?
Yes. I've just provided a link to it again. Here it is again <a href="https://github.com/purpleteam-labs/purpleteam-app-scanner/blob/06c5148c9f080388164a74ccf990e8ae18f7316f/src/api/app/models/app.js#L160">https://github.com/purpleteam-labs/purpleteam-app-scanner/blob/06c5148c9f080388164a74ccf990e8ae18f7316f/src/api/app/models/app.js#L160</a>. This is what's under test.
> Also, the suggestion from <a href="https://github.com/yopasa94">@yopasa94</a> was pretty interesting. Did you had the opportunity to take a look?
Yes I thought so to, but sadly who knows where it is, and there are still unanswerd questions needed to take it further. Where is it? My comments on it <a href="https://github.com/cucumber/cucumber-js/issues/1489#issuecomment-828158060">here</a>, <a href="https://github.com/cucumber/cucumber-js/issues/1489#issuecomment-849524710">here</a> and <a href="https://github.com/cucumber/cucumber-js/issues/1489#issuecomment-852700148">here</a>.
> parseGherkinMessageStream is a helper method in cucumber-js:
I thought it might be, as I mentioned <a href="https://github.com/cucumber/cucumber-js/issues/1489#issuecomment-828158060">here</a>.
<a href="https://github.com/aurelien-reeves">@aurelien-reeves</a>: Are you actually reading my comments, as you keep asking questions I've already answerd?
> You give too many references to your own code base. Please give minimum reproducible snippets here instead.
Ok, I can do this, but all I'll be doing is copy, pasting what I've already linked to. Then if you want to run it, you'll have to do even more work than simply clone the repo, `npm install` -> `npm test`. The links I've provided to the unit tests and SUT are "minimum reproducible snippets"
Thanks.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-02 05:07:08
[cucumber/cucumber-js] Comment on #1489
> <a href="https://github.com/aurelien-reeves">@aurelien-reeves</a>: Are you actually reading my comments, as you keep asking questions I've already answerd?
I missed that one. But yes, I do read your responses.
You keep posting links to your code base. I won't go there. There is too many code. I won't take the time to understand how all your code base works.
Also I don't ask for you to copy paste your code here. I ask you for a minimal reproducible example of your issues / what you want to accomplish.
I do my best do keep helping you. Please try to simplify as much as possible your questions.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-02 06:23:00
[cucumber/cucumber-js] Comment on #1689
> Ah, some more context/background. That helps. We're don't use any formatters other than what's in the Cucumber box. Does that mean it'll always be a string or is there still some uncertanty?
There cannot be any warranty. The `stdout` parameter for the Cucumber CLI constructor must be a `IFormatterStream`, which can be a `fs.writeStream`, a `tty.writeStream`, a `stream.passThrough`, or a cucumber `http_stream`. Those are Node streams. You should stick to that. Even if cucumber would use only strings, you should not trust such assumption. The only assumptions you _may_ trust are the ones enforce by a strong type system.
> Which is sounding like we just check whether `chunk` is `string` or `buffer` if string, wer're good to log it, if `buffer` attempt conversion to string and... we're good to log it?
Looks good if considering my previous sentence in the process
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-02 08:29:33
[cucumber/cucumber-js] Pull request opened by davidjgoss
<p>Fixes <a href="https://github.com/cucumber/cucumber-js/issues/1667">#1667</a>.</p>
<p>I'd have preferred to type it as <code>World</code> rather than <code>any</code>, but this then prevents a user from overriding the type of <code>this</code> in their own function - going to try and find a clever way to address that (maybe with generics) in a follow up.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-02 08:33:59
[cucumber/cucumber-js] Issue closed by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-02 08:38:57
[cucumber/cucumber-js] Comment on #1690
<a href="https://coveralls.io/builds/40245694">Coverage Status</a>
Coverage remained the same at 98.514% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/d5791d942f39e969acd0e0962cfc086bee991f8c">d5791d9</a> on world-typings* into *<a href="https://github.com/cucumber/cucumber-js/commit/07978ef4086bbdae427eba03bed811a079a78f62">07978ef</a> on main*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-02 08:42:23
[cucumber/cucumber-js] Comment on #1690
Have you tried this?
```
export type TestCaseHookFunction<World = any> = (
this: World,
arg?: ITestCaseHookParameter
) => any | Promise<any>
```
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-02 09:04:43
[cucumber/cucumber-js] Comment on #1690
That works but doesn't improve things, I think. The type of `this` would still be `any` by default.
IMO `this` should default to our builtin `World` which includes `parameters` being readonly, the `attach` signature etc. If I do that with your suggestion then the signature with a custom world becomes like:
```
Before(async function() {
this.doThing()
} as TestCaseHookFunction<CustomWorld>)
```
which is sort of a breaking change for users who are doing it the pseudo-argument way.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-02 14:17:22
[cucumber/cucumber-js] Issue opened by znevrly
<p>Hi,</p>
<p>looking on <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/support_files/timeouts.md">https://github.com/cucumber/cucumber-js/blob/main/docs/support_files/timeouts.md</a> but it seems does not work in CucumberJS 7+ version.</p>
<p>I have old code with setDefaultTimeout(timeoutInMilisec) in world and it worked for long time (version 6+). Now I got report that it does not work anymore with 7+ but not sure since because timeout is kind of edge case.</p>
<p>Getting this message when different global timeout via setDefaultTimeout is set up:</p>
<p>Error: function timed out, ensure the callback is executed within 30000 milliseconds</p>
<p>When('step definition', {timeout: 100000}, callback)<br />
Setting timeout as step parameter works as expected but I have many steps and I want to set up globally.</p>
<p>Thanks.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-02 16:13:01
[cucumber/cucumber-js] Comment on #1691
Thanks for reporting this! Can't promise anything, but we'll try to have that fixed for the next release.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-02 22:10:27
[cucumber/cucumber-js] Comment on #1691
> I have old code with setDefaultTimeout(timeoutInMilisec) _in world_
It should be called globally, not from within any step, hook or world, see <a href="https://github.com/cucumber/cucumber-js/issues/1610">#1610</a>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 00:24:34
[cucumber/cucumber-js] Comment on #1690
I have a couple of question, for my own understanding 😅
• What is that `test-d` directory?
• The issue <a href="https://github.com/cucumber/cucumber-js/issues/1667">#1667</a> explained that `this` in the step definitions was not explicitly typed as `World`, but implicitly as `any`. The PR explicitly type it as `any`. How will it be aware of the `World` members as shown in the `test-d` directory?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 01:27:50
[cucumber/cucumber-js] Comment on #1669
I am pretty sure this will be released "soon". But we cannot know for sure actually.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 02:14:35
[cucumber/cucumber-js] Comment on #1690
> What is that test-d directory?
Tests to ensure the TypeScript typings don't change in unexpected ways for users - see <a href="https://github.com/SamVerschueren/tsd">https://github.com/SamVerschueren/tsd</a>
> The PR explicitly type it as `any`. How will it be aware of the `World` members as shown in the `test-d` directory?
It doesn't yet - just explicitly typing it as `any` internals makes the "implicit any" error from tsc go away. My concern with typing it as `World` is that if you then want to override to a custom world class at the function level, TypeScript will give you a different compilation issue. So the change here is just enough to resolve the reported issue, but still room for improvement.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 02:15:36
[cucumber/cucumber-js] Comment on #1690
(I'm still experimenting to see if I can make it better though.)
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 02:16:56
[cucumber/cucumber-js] Comment on #1690
Thanks for the explanations 👍
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 03:40:05
[cucumber/cucumber-js] Comment on #1691
Please reopen if you still have issues after calling `setDefaultTimeout` globally.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 03:40:05
[cucumber/cucumber-js] Issue closed by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 03:42:01
[cucumber/cucumber-js] Pull request opened by davidjgoss
<p>Closes <a href="https://github.com/cucumber/cucumber-js/issues/1537">#1537</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2736283606)
GitHub Actions: test (windows-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2736283409)
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2736283368)
GitHub
2021-06-03 03:44:15
[cucumber/cucumber-js] Comment on #1692
<a href="https://coveralls.io/builds/40273034">Coverage Status</a>
Coverage remained the same at 98.514% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/4dac1f40a46fbd3be07c01cac0b39821d22e0b23">4dac1f4</a> on after-result-migration-doc* into *<a href="https://github.com/cucumber/cucumber-js/commit/07978ef4086bbdae427eba03bed811a079a78f62">07978ef</a> on main*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 03:59:33
[cucumber/cucumber-js] Comment on #1538
Sorry for the late reply <a href="https://github.com/VivekLande">@VivekLande</a>.
With "pickle", there is a new object structure for that which is part of the standardised messages schema now. This is the `pickle` that is part of the result object passed to your `After` hook function. I've described the change a bit in <a href="https://github.com/cucumber/cucumber-js/pull/1692">#1692</a> including a link to <a href="https://github.com/cucumber/common/blob/main/messages/jsonschema/Pickle.json">its schema definition</a>.
The model for events changed completely as part of 7.0.0, so the previous events described in the `@types/cucumber` package are no longer emitted, and now we emit <a href="https://github.com/cucumber/common/blob/main/messages/jsonschema/Envelope.json">`envelope`</a> events, each containing a standardised message object. If you have any issues using the messages to e.g. build a formatter, please drop a question in the <a href="https://cucumber.io/docs/community/get-in-touch/">Slack or forum</a> and you should get some help. The <a href="https://github.com/cucumber/cucumber-js/tree/main/src/formatter">built-in formatters</a> are a good reference point for this also.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 03:59:33
[cucumber/cucumber-js] Issue closed by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 04:03:48
[cucumber/cucumber-js] Pull request opened by davidjgoss
<p>Closes <a href="https://github.com/cucumber/cucumber-js/issues/1263">#1263</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 04:06:12
[cucumber/cucumber-js] Comment on #1693
<a href="https://coveralls.io/builds/40273546">Coverage Status</a>
Coverage remained the same at 98.514% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/11cf40a4a339574459b50cb32651019203ee2336">11cf40a</a> on parallel-env-doco* into *<a href="https://github.com/cucumber/cucumber-js/commit/07978ef4086bbdae427eba03bed811a079a78f62">07978ef</a> on main*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 04:07:28
[cucumber/cucumber-js] Comment on #1689
Thanks muchly for your help on this one <a href="https://github.com/aurelien-reeves">@aurelien-reeves</a> !
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 04:07:28
[cucumber/cucumber-js] Issue closed by binarymist
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 04:47:54
[cucumber/cucumber-js] Comment on #1690
Followed this path and got something that covers all the bases now - thanks!
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 05:59:45
[cucumber/cucumber-js] Comment on #1691
OK, I can confirm it's working but still docs is misleading. Therefore I have this issue title. IMHO docs needs to be updated.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 06:01:44
[cucumber/cucumber-js] Comment on #1691
<a href="https://github.com/znevrly">@znevrly</a> what edit would you propose to <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/support_files/timeouts.md">https://github.com/cucumber/cucumber-js/blob/main/docs/support_files/timeouts.md</a>? Could you raise a pull request?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 06:04:03
[cucumber/cucumber-js] Comment on #1691
Very glad but my English is too bad for docs and I don't want to be misleading :(
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 06:06:38
[cucumber/cucumber-js] Comment on #1691
No problem - I have made this change, hopefully that covers it <a href="https://github.com/cucumber/cucumber-js/commit/097ef2670252b2480ceb8eb4f6a3e980aee40eb5">097ef26</a>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 06:08:28
[cucumber/cucumber-js] Comment on #1551
<a href="https://github.com/hdorgeval">@hdorgeval</a> what assertion library are you using here?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 06:11:12
[cucumber/cucumber-js] Comment on #1691
IMHO this need to be changed as well
"By default, asynchronous hooks and steps timeout after 5000 milliseconds. This can be modified globally with:"
1. now it's 30000 which is hardcoded
2. can be -> has to be
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 07:43:37
[cucumber/cucumber-js] Comment on #1690
<a href="https://github.com/aurelien-reeves">@aurelien-reeves</a> now refactored and got the result I originally wanted.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 07:44:58
[cucumber/cucumber-js] Comment on #1692
Suggested change
?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 07:44:59
[cucumber/cucumber-js] aurelien-reeves commented on davidjgoss's pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 07:46:21
[cucumber/cucumber-js] aurelien-reeves approved davidjgoss's pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 07:48:46
[cucumber/cucumber-js] Comment on #1690
<a href="https://github.com/davidjgoss">@davidjgoss</a> I saw that, nice 👍
Small question: from where that capital `W` come from?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 07:49:57
[cucumber/cucumber-js] Comment on #1692
Thanks!
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 07:50:59
[cucumber/cucumber-js] Issue closed by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 07:51:00
[cucumber/cucumber-js] Pull request merged by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 07:51:32
[cucumber/cucumber-js] aurelien-reeves approved davidjgoss's pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 07:52:53
[cucumber/cucumber-js] Comment on #1690
`<W>` is just something to call the generic type. Actually now you mention it the single-letter convention is a bit arcane, we could be explicit and have it as `<WorldType>`, what do you think?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 07:53:43
[cucumber/cucumber-js] Issue closed by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 07:53:44
[cucumber/cucumber-js] Pull request merged by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 07:55:37
[cucumber/cucumber-js] davidjgoss approved renovate[bot]'s pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 07:56:57
[cucumber/cucumber-js] davidjgoss requested changes on renovate[bot]'s pull request
Multiple `message-streams` versions
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 07:57:04
[cucumber/cucumber-js] Pull request closed by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 07:57:12
[cucumber/cucumber-js] Comment on #1690
> `<W>` is just something to call the generic type. Actually now you mention it the single-letter convention is a bit arcane, we could be explicit and have it as `<WorldType>`, what do you think?
Thank you.
Yes, this is the single-letter name which make me ask. I was not sure.
If single-letter generic names is still usually a thing in TypeScript as we used to have our `templates<T>` in C++, let's go for it.
If not, indeed I think `<WorldType>` may be more appropriate
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 07:59:18
[cucumber/cucumber-js] Comment on #1690
<a href="https://twitter.com/kentcdodds/status/1348016701632221184">https://twitter.com/kentcdodds/status/1348016701632221184</a> :)
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 08:08:53
[cucumber/cucumber-js] davidjgoss approved jshifflet's pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 08:09:49
[cucumber/cucumber-js] aurelien-reeves approved jshifflet's pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 08:35:19
[cucumber/cucumber-js] Comment on #1668
<a href="https://github.com/yopasa94">@yopasa94</a> I've tried adding an e2e test to reproduce this (see <a href="https://github.com/cucumber/cucumber-js/commit/35005591bea61c5cd17fb78c420d89c4bd5d5919">3500559</a>) but haven't been able to see it happen yet.
Could you confirm a few things:
• Version of cucumber you're running
• Any formatters you're using
• Any other CLI arguments
• Does this only happen with `--dry-run`?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 21:04:54
[cucumber/cucumber-js] Comment on #1692
As a note, linking to a branch has the potential of going stale. May be better to update these to a tag
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 21:11:07
[cucumber/cucumber-js] Comment on #1669
Cool. Nice refactor
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 21:11:29
[cucumber/cucumber-js] Comment on #1669
Thanks for doing this <a href="https://github.com/davidjgoss">@davidjgoss</a>!
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 21:14:03
[cucumber/cucumber-js] Comment on #1688
Nice!
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 21:27:38
[cucumber/cucumber-js] Issue closed by charlierudolph
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 21:27:39
[cucumber/cucumber-js] Pull request merged by charlierudolph
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 21:27:39
[cucumber/cucumber-js] Comment on #1568
Hi <a href="https://github.com/jshifflet">@jshifflet</a>,
Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾
In return for this generous offer we hope you will:
• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our <a href="https://cucumber.io/conduct">code of conduct</a> in your interactions with other collaborators and users.
• 💬 Join the <a href="http://cucumber.io/support#slack">community Slack channel</a> to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!
On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 22:03:13
[cucumber/cucumber-js] Comment on #1665
Hi <a href="https://github.com/ggarcia24">@ggarcia24</a>,
I was unable to reproduce and --no-strict was working properly for me in the profile and as a CLI argument. Maybe there was something else leading to the failure.
I'm going to close this for now but feel free to comment if you are still experiencing this and we can reopen
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 22:03:13
[cucumber/cucumber-js] Issue closed by charlierudolph
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 22:24:32
[cucumber/cucumber-js] Comment on #1667
I'm surprised this worked `this` in step definitions was ever auto-typed as World. <a href="https://github.com/davidjgoss">@davidjgoss</a> do you know how this was supported before / what changed that broke it?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 22:25:50
[cucumber/cucumber-js] Comment on #1690
Tests look good. Definitely seems to make some things more verbose but not sure there is a better way
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-03 22:37:10
[cucumber/cucumber-js] Comment on #1667
<a href="https://github.com/charlierudolph">@charlierudolph</a> no I don’t think it ever worked since our refactor to TypeScript. The second screenshot above is from v6 with (presumably) the types from DefinitelyTyped, which did type `this` as `World` - which was just an alias for an object with arbitrary props.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-04 00:36:07
[cucumber/cucumber-js] Comment on #1690
I guess this is for arbitrary properties?
So, no way to avoid the `any` here?
What about deprecating that in a next major release? If users want extra parameters, they would have to implement their own strongly typed custom worlds? Or something else, but with strong types?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-04 00:36:07
[cucumber/cucumber-js] Comment on #1690
Any possibility to avoid the `any` type here?
It is pluralize. Is it an array? Or something else?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-04 00:36:08
[cucumber/cucumber-js] aurelien-reeves commented on davidjgoss's pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-04 00:50:38
[cucumber/cucumber-js] Pull request opened by aurelien-reeves
<p>Refs. <a href="https://github.com/cucumber/cucumber-js/pull/1692#discussion_r645274491">#1692 (comment)</a></p>
<p>Use links to tags instead of links to main branch to avoid the links being dead in a few years.</p>
<p>I am still puzzled about the maintenance of those links. But as it is about the migration from 6 to 7, we can argue that it does not have to be updated for each new version of messages.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-04 00:52:53
[cucumber/cucumber-js] Comment on #1694
<a href="https://coveralls.io/builds/40302689">Coverage Status</a>
Coverage remained the same at 98.516% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/abfff7717d8400167c958adb5552ba887fde973a">abfff77</a> on update-migration-links-to-jsonschemas* into *<a href="https://github.com/cucumber/cucumber-js/commit/ea4d86003a6d309f1d94bd8a42b7795653885ce6">ea4d860</a> on main*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-04 00:57:00
[cucumber/cucumber-js] Comment on #1694
> But as it is about the migration from 6 to 7, we can argue that it does not have to be updated for each new version of messages.
Yeah I think that's fair. I was hesitant to link to a tag for fear of the tag then being outdated, but as you say the migration guide should become defunct anyway.
Side note: it would be cool if we had nice documentation of the message schema on a website somewhere we could link to...
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-04 00:57:13
[cucumber/cucumber-js] davidjgoss approved aurelien-reeves's pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-04 01:00:32
[cucumber/cucumber-js] Comment on #1690
This will be deserialized from <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/cli.md#world-parameters">`---world-parameters`</a> which could be any JSON object. We could try and constrain the type accordingly but...<a href="https://github.com/microsoft/TypeScript/issues/1897">it's a bit of a rabbit hole</a>.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-04 01:01:42
[cucumber/cucumber-js] Comment on #1694
> Side note: it would be cool if we had nice documentation of the message schema on a website somewhere we could link to...
With proto, we generated a messages.md which was nicer to look at than the proto file: <a href="https://github.com/cucumber/common/blob/main/messages/messages.md">https://github.com/cucumber/common/blob/main/messages/messages.md</a>
We have to keep doing that with json schema. For now it is still up-to-date. But it won't be if we do not find a new way to keep it up-to-date with json schemas.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-04 01:02:30
[cucumber/cucumber-js] Comment on #1508
Hi <a href="https://github.com/jbpros">@jbpros</a>,
What you mentioned "remove browser support" means Cucumber used to provide a feature to run a testing on a browser (ex: headless Chrome) and now Cucumber stops supporting?
If the answer is yes, do you have any suggestion to run Cucumber testing on the browser?
In my case, I need Cucumber testing for FE app and it should be running on the browser due to my FE library expect a couple of `window` object methods.
Thanks in advance.
> Should we record the rationale behind the decision to remove browser support somewhere public? I wonder if some people will be surprised or even disappointed and would need an explanation about this change.
>
> In fact, while I agree to drop support for browser runs, I could use a good write up of that decision myself. I still think we're closing a door to a feature without total assurance that it is not used much.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-04 01:05:30
[cucumber/cucumber-js] Comment on #1690
Thanks for the clarification
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-04 01:06:00
[cucumber/cucumber-js] Comment on #1690
Good question!
I think it's reflective of how many people use it in plain JS - setting some properties on `this` without the overhead of writing a custom class (many of our own acceptance tests do this). Once you want to have some methods, logic etc on the world then you'll naturally want to use your own class (for the type completion if nothing else).
We could make it stricter but it'd be a breaking change and would seem to hurt the developer ergonomics a bit IMO.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-04 01:08:37
[cucumber/cucumber-js] Comment on #1690
I understand the need as a JavaScript developer. And I am not sure that would break things for JavaScript.
In the TypeScript world, if we want to enforce use of types, it seems less non-sense.
For TypeScript, maybe there are other, more typed ways to propose such kind of possibility?
And yes, that would be a major breaking change
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-04 01:09:02
[cucumber/cucumber-js] Comment on #1508
<a href="https://github.com/Taewa">@Taewa</a> we removed the ability for cucumber-js itself (the test runner) to run in the browser, but you can absolutely use it to test browser-based software with webdriver, puppeteer, playwright etc as ever.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-04 01:13:13
[cucumber/cucumber-js] davidjgoss approved renovate[bot]'s pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-04 01:13:19
[cucumber/cucumber-js] Pull request merged by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-04 01:51:32
[cucumber/cucumber-js] Comment on #1508
Hi <a href="https://github.com/davidjgoss">@davidjgoss</a> thanks for the quick response.
I am aware of webdriver, puppeteer, playwright and I used to use WDIO.
However, I couldn't find a way to run my test with these tools.
Running e2e test fits well with these e2e tools. Like opening `localhost:8000` and hit the test from beginning to end.
But my purpose is to test each single pages (or controllers) with cucumber.
It's like running test with Karma, Mocha, Chai
```
import { binding, given, then, when } from 'cucumber-tsflow';
import { fixture, html } from '@open-wc/testing';
import '../../src/SimpleGreeting.js';
@binding()
export class SimpleGreetingSteps {
private element;
@given('There is SimpleGreeting component')
public async initComponent() {
this.element = await fixture(
html`
<simple-greeting></simple-greeting>
`,
);
}
@when(/Start rendering/)
public renderComponent() {
this.element.render();
}
@then(/Name is rendered/)
public assertResult() {
// assert with mocha/chai
expect(...)
}
}
```
(I know I am using 3rd party cucumber plugin 'cucumber-tsflow' but this is what I want to run briefly on the browser)
In the above example, `<simple-greeting>` is a web component and I don't think it's possible to run test with e2e tools. I need to launch app first and let e2e tool navigate to the app.
However, I think it might be possible with Karma by running a browser. Just I don't know how to execute `./node_modules/.bin/cucumber-js` inside of Karma.
If you know any other solution or suggestion or please correct me if my knowledge is wrong.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-04 02:08:06
[cucumber/cucumber-js] Pull request merged by aurelien-reeves
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-04 03:37:29
[cucumber/cucumber-js] Comment on #1690
Would you be okay with merging this now and picking the possible breaking change up in another issue?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-04 03:50:47
[cucumber/cucumber-js] Comment on #1508
<a href="https://github.com/davidjgoss">@davidjgoss</a> To add up, using Karma is an optional. My main intention is to use Cucumber (BDD) testing for individual web component.
Since I test web-component, it should be running on a browser.
```
Given "A customer who has an item X" // will be mocked
When "Navigate to item list page" // a web-component
Then "It should display an item X"
```
As you can see there is no "customer login" pre-step.
It's just loading a web component and execute test with some mock data.
It's totally doable with current Karma/Mocha/Chai but Cucumber syntax would be much better to read/understand.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-04 05:13:01
[cucumber/cucumber-js] Comment on #1690
Yes, it's ok
It was more kinda general though
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-04 05:13:24
[cucumber/cucumber-js] aurelien-reeves approved davidjgoss's pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-04 05:37:52
[cucumber/cucumber-js] Issue closed by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-04 05:37:53
[cucumber/cucumber-js] Pull request merged by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-04 16:40:50
[cucumber/cucumber-js] Comment on #1568
<a href="https://github.com/aurelien-reeves">@aurelien-reeves</a> thanks for updating the changelog for me. Sorry about the delay.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-07 00:13:54
[cucumber/cucumber-js] Comment on #1568
> <a href="https://github.com/aurelien-reeves">@aurelien-reeves</a> thanks for updating the changelog for me. Sorry about the delay.
It was not me, but I am sure that you are welcome 🙂
I was about to do it indeed 😅
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-07 05:42:04
[cucumber/cucumber-js] Pull request opened by aslakhellesoy
<p>This prevents the process from calling <code>process.exit</code> when an error occurs during command line parsing.</p>
<p>This is needed to make it easier to control when the process exits from tools that use Cucumber as a library (like <a href="https://github.com/cucumber/cucumber-electron">https://github.com/cucumber/cucumber-electron</a>).</p>
<p>I tried to prevent exit for <code>--help</code> and <code>--version</code>, but this was harder. We parse the command line twice (once to extract the <code>--profile</code>, and once again after reading the profile options), and this caused double rendering when <code>--version</code> was used.</p>
<p>Circumventing this would mean one of the following:</p>
<p>• Don't use commander to extract profiles
• Set a custom <a href="https://github.com/tj/commander.js/#override-exit-and-output-handling">output handler</a></p>
<p>This seemed too cumbersome, so I went with this compromise.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-07 05:44:07
[cucumber/cucumber-js] Comment on #1695
<a href="https://coveralls.io/builds/40360161">Coverage Status</a>
Coverage increased (+0.005%) to 98.521% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/435b0f6c1ed35163d9d5e677381865ca29626af0">435b0f6</a> on do-not-exit* into *<a href="https://github.com/cucumber/cucumber-js/commit/13956f625fc76971d897b224a5f128000919153b">13956f6</a> on main*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-08 00:59:16
[cucumber/cucumber-js] Comment on #1695
Can we avoid adding this `const` by just adding a type qualifier to the catch arg?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-08 00:59:17
[cucumber/cucumber-js] davidjgoss approved aslakhellesoy's pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-08 01:52:43
[cucumber/cucumber-js] Comment on #1489
• Clone: <a href="https://github.com/purpleteam-labs/purpleteam-app-scanner_cucumber-1489-repro">https://github.com/purpleteam-labs/purpleteam-app-scanner_cucumber-1489-repro</a>
• `npm install`
• `npm test`
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-10 04:53:59
[cucumber/cucumber-js] Issue opened by evilC
<p>node 14.16.0<br />
@wdio/cli: 7.3.0<br />
@wdio/cucumber-framework: 7.3.0</p>
<p>With the following code:</p>
<pre><code>Scenario: Foo
Given Foo
Scenario Bar
When Foo
</code></pre>
<pre><code>Given ("Foo", () =&gt; {
someFunc();
});
When ("Foo", () =&gt; {
someFunc();
});
function someFunc(){
}
</code></pre>
<p>When I run my tests with wdio, it fails to hit the first step with no obvious error</p>
<p>In our project, we wish to re-use a step (ie same step can be used as a Given or a When step).<br />
What I currently do is this:</p>
<pre><code>Given, // SonarQube says "Unexpected use of comma operator" for this line
When("Foo", () =&gt; {
// some code here
}); // SonarQube says "Expected an assignment or function call and instead saw an expression" for this line
</code></pre>
<p>However, when SonarQube runs, it flags the lines as mentioned in the comments as code smells, so I was hoping to use the syntax at the start of my post as a work-around. IMHO it really should work - there is no ambiguity there as to which step should be called at which point, and even if it does crash, it should give some kind of meaningful error</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-10 05:01:01
[cucumber/cucumber-js] Comment on #1696
On a technical level you can just do:
```
Given("Foo", () => {
someFunc();
});
```
At runtime cucumber doesn't care which keyword you used to define it, it will work with Given, When, Then, And, But. If you're still seeing issues please post some more detail e.g. an example repo we can look at.
On a philosophical level, it's generally encouraged to remove the ambiguity by having explicit wording for context vs action steps, even if they are mostly doing the same stuff underneath.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-10 05:44:19
[cucumber/cucumber-js] Comment on #1696
Ah, OK, that kind of confirms my suspicions oh how things work internally, but frankly, that's a bit shocking
It could result in all kinds of strangeness going on - especially as if this unintentionally occurred (ie someone wrote a step definition in a completely different file and did not realize that text had been used elsewhere) then the tests would start failing but there would be no obvious errors show to say why
IMHO this should be properly fixed
Also WRT "even if they are mostly doing the same stuff underneath" - surely if they are doing *exactly* the same underneath then there is no ambiguity ?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-10 06:51:36
[cucumber/cucumber-js] Comment on #1696
> (ie someone wrote a step definition in a completely different file and did not realize that text had been used elsewhere)
That will error. You can't define it twice, but you can use it in multiple ways.
There are some long-running discussions around this issue, which is a broader cucumber thing and not specific to JS, so don't really want to get too into it here.
• <a href="https://github.com/cucumber/common/issues/768">cucumber/common#768</a>
• <a href="https://github.com/cucumber/common/issues/1392">cucumber/common#1392</a>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-10 06:51:44
[cucumber/cucumber-js] Issue closed by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-11 08:19:26
[cucumber/cucumber-js] Pull request opened by davidjgoss
<p>Much of the list from <a href="https://github.com/cucumber/cucumber-js/issues/1646#issue-863352190">#1646 (comment)</a>. Most of the rest already available under formatter helpers, probably just need some manual editing in those projects.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-11 08:21:35
[cucumber/cucumber-js] Comment on #1697
<a href="https://coveralls.io/builds/40517194">Coverage Status</a>
Coverage increased (+0.0007%) to 98.516% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/1e7b7c24c4e6dedf263aaa9510ae51cf36b906fc">1e7b7c2</a> on missing-exports* into *<a href="https://github.com/cucumber/cucumber-js/commit/13956f625fc76971d897b224a5f128000919153b">13956f6</a> on main*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-11 08:21:39
[cucumber/cucumber-js] Comment on #1697
This was a mistake from <a href="https://github.com/cucumber/cucumber-js/pull/1690">#1690</a>. The argument isn't optional - we always pass it in - it's just up to the user-authored code whether it does anything with it.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-14 01:28:35
[cucumber/cucumber-js] Comment on #1697
Looks good.
I wonder: is there a way to reproduce through a test the issue reported on <a href="https://github.com/cucumber/cucumber-js/issues/1646">#1646</a>?
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-14 01:37:28
[cucumber/cucumber-js] Comment on #1697
> wonder: is there a way to reproduce through a test the issue reported on <a href="https://github.com/cucumber/cucumber-js/issues/1646">#1646</a>?
Yeah, I added a feature test in <a href="https://github.com/cucumber/cucumber-js/pull/1649">#1649</a> that hits the error when trying to do deep imports after the ESM change. Still working on if/how to handle that.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-14 01:50:45
[cucumber/cucumber-js] Comment on #1697
> > wonder: is there a way to reproduce through a test the issue reported on <a href="https://github.com/cucumber/cucumber-js/issues/1646">#1646</a>?
>
> Yeah, I added a feature test in <a href="https://github.com/cucumber/cucumber-js/pull/1649">#1649</a> that hits the error when trying to do deep imports after the ESM change. Still working on if/how to handle that.
Great!
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-14 01:50:54
[cucumber/cucumber-js] aurelien-reeves approved davidjgoss's pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-14 01:58:25
[cucumber/cucumber-js] Pull request merged by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-16 02:28:38
[cucumber/cucumber-js] Issue opened by aslakhellesoy
<p>When <code>cucumber-js</code>' <code>STDERR</code> or <code>STDOUT</code> is redirected to a file, there are still ANSI escapes in the output.</p>
<p>We should remove ANSI escapes when writing to a non-TTY stream.</p>
<p>One of the reasons we should do this is that the suggestion to redirect <code>STDERR</code> to a file in <a href="https://github.com/cucumber/cucumber-js/issues/1458">#1458</a> makes it difficult to read the contents written to that file:</p>
<pre><code>�[32m�[1m┌──────────────────────────────────────────────────────────────────────────┐�[0m
�[32m�[1m│�[0m View your Cucumber Report at: �[32m�[1m│�[0m
�[32m�[1m│�[0m �[1m�[36m�[4m<https://reports.cucumber.io/reports/59fbb8b0-a625-4f0e-8c5b-284b95387f03�>[0m �[32m�[1m│�[0m
�[32m�[1m│�[0m �[32m�[1m│�[0m
�[32m�[1m│�[0m �[1mThis report will self-destruct in 24h.�[0m �[32m�[1m│�[0m
�[32m�[1m│�[0m Keep reports forever: �[4m�[1m�[36m<https://reports.cucumber.io/profile�>[0m �[32m�[1m│�[0m
�[32m�[1m└──────────────────────────────────────────────────────────────────────────┘�[0m
</code></pre>
<p>Since the ANSI escapes in this case come from the Cucumber Reports server (and not our own code), I suggest we implement this like this:</p>
<pre><code>const stderr = process.stderr.pipe(replaceAnsiStream())
const stdout = process.stderr.pipe(replaceAnsiStream())
</code></pre>
<p>See <a href="https://github.com/chalk/strip-ansi-stream">https://github.com/chalk/strip-ansi-stream</a></p>
<p>Also see <a href="https://github.com/cucumber/cucumber-js/issues/1050">#1050</a> which didn't <em>really</em> solve the problem of stripping ANSI - it just disallows using formatters that output ANSI.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-17 05:58:07
[cucumber/cucumber-js] Comment on #1699
<a href="https://coveralls.io/builds/40668762">Coverage Status</a>
Coverage remained the same at 98.516% when pulling *<a href="https://github.com/cucumber/cucumber-js/commit/44420f3999e05c6a7021a95437538f8794d96418">44420f3</a> on docs-overhaul* into *<a href="https://github.com/cucumber/cucumber-js/commit/df31f71ce3bf0a975d541f0a812fcc7cccda5858">df31f71</a> on main*.
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-17 14:49:39
[cucumber/cucumber-js] New release Release - published by davidjgoss
<p><strong>Added</strong></p>
<p>• Experimental support for <a href="https://github.com/cucumber/common/blob/main/gherkin/MARKDOWN_WITH_GHERKIN.md">Markdown</a><br />
(<a href="https://github.com/cucumber/cucumber-js/pull/1645">#1645</a>)</p>
<p><strong>Changed</strong></p>
<p>• All <code>testCase</code> messages now emitted upfront at the start of the run (relevant for formatter authors) (<a href="https://github.com/cucumber/cucumber-js/issues/1408">#1408</a><br />
<a href="https://github.com/cucumber/cucumber-js/pull/1669">#1669</a>)
• Clarify that the JSON formatter will not be removed any time soon</p>
<p><strong>Fixed</strong></p>
<p>• <code>this</code> now has correct TypeScript type in support code functions (<a href="https://github.com/cucumber/cucumber-js/issues/1667">#1667</a> <a href="https://github.com/cucumber/cucumber-js/pull/1690">#1690</a>)
• Progress bar formatter now reports total step count correctly (<a href="https://github.com/cucumber/cucumber-js/issues/1579">#1579</a><br />
<a href="https://github.com/cucumber/cucumber-js/pull/1669">#1669</a>)
• Rerun functionality will now run nothing if the rerun file is empty from the previous run (<a href="https://github.com/cucumber/cucumber-js/issues/1302">#1302</a> <a href="https://github.com/cucumber/cucumber-js/pull/1568">#1568</a>)
• All messages now emitted with project-relative <code>uri</code>s<br />
(<a href="https://github.com/cucumber/cucumber-js/issues/1534">#1534</a><br />
<a href="https://github.com/cucumber/cucumber-js/pull/1672">#1672</a>)
• Json formatter now works with tagged examples<br />
(<a href="https://github.com/cucumber/cucumber-js/issues/1621">#1621</a><br />
<a href="https://github.com/cucumber/cucumber-js/pull/1651">#1651</a>)</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-17 16:31:03
[cucumber/cucumber-js] Comment on #1699
I think all this is great. I'd merge it and keep going with further PRs. 👍
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-18 00:44:20
[cucumber/cucumber-js] Issue opened by aslakhellesoy
<p>Here is the output from 7.3.0:</p>
<pre><code>Usage: cucumber-js [options] [&lt;GLOB|DIR|FILE[:LINE]&gt;...]
Options:
-v, --version output the version number
-b, --backtrace show full backtrace for errors
-d, --dry-run invoke formatters without executing steps (default: false)
--exit force shutdown of the event loop when the test run has finished: cucumber will call process.exit (default: false)
--fail-fast abort the run on first failure (default: false)
-f, --format &lt;TYPE[:PATH]&gt; specify the output format, optionally supply PATH to redirect formatter output (repeatable) (default: [])
--format-options &lt;JSON&gt; provide options for formatters (repeatable) (default: {})
--i18n-keywords &lt;ISO 639-1&gt; list language keywords (default: "")
--i18n-languages list languages (default: false)
--language &lt;ISO 639-1&gt; provide the default language for feature files (default: "en")
--name &lt;REGEXP&gt; only execute the scenarios with name matching the expression (repeatable) (default: [])
--no-strict succeed even if there are pending steps
--order &lt;TYPE[:SEED]&gt; run scenarios in the specified order. Type should be `defined` or `random` (default: "defined")
-p, --profile &lt;NAME&gt; specify the profile to use (repeatable) (default: [])
--parallel &lt;NUMBER_OF_WORKERS&gt; run in parallel with the given number of workers (default: 0)
--predictable-ids Use predictable ids in messages (option ignored if using parallel) (default: false)
--publish Publish a report to <https://reports.cucumber.io> (default: false)
--publish-quiet Don't print information banner about publishing reports (default: false)
-r, --require &lt;GLOB|DIR|FILE&gt; require files before executing features (repeatable) (default: [])
--require-module &lt;NODE_MODULE&gt; require node modules before requiring files (repeatable) (default: [])
--retry &lt;NUMBER_OF_RETRIES&gt; specify the number of times to retry failing test cases (default: 0) (default: 0)
--retryTagFilter, --retry-tag-filter &lt;EXPRESSION&gt; only retries the features or scenarios with tags matching the expression (repeatable).
This option requires '--retry' to be specified. (default: "")
-t, --tags &lt;EXPRESSION&gt; only execute the features or scenarios with tags matching the expression (repeatable) (default: "")
--world-parameters &lt;JSON&gt; provide parameters that will be passed to the world constructor (repeatable) (default: {})
-h, --help display help for command
For more details please visit <https://github.com/cucumber/cucumber-js/blob/master/docs/cli.md>
</code></pre>
<p>For comparison, cucumber-ruby lists the available formatters:</p>
<p>```
Usage: cucumber [options] [ [FILE|DIR|URL][:LINE[:LINE]**] ]+</p>
<p>Examples:
cucumber examples/i18n/en/features
cucumber @rerun.txt (See --format rerun)
cucumber examples/i18n/it/features/somma.feature:6:98:113
cucumber -s -i <a href="http://rubyurl.com/eeCl">http://rubyurl.com/eeCl</a></p>
<pre><code> --publish Publish a report to <https://reports.cucumber.io>
--publish-quiet Don't print information banner about publishing reports
-r, --require LIBRARY|DIR Require files before executing the features. If this
option is not specified, all **.rb files that are
siblings of or below the features will be loaded auto-
matically. Automatic loading is disabled when this
option is specified; all loading becomes explicit.
Files in directories named "support" are still always
loaded first when their parent directories are
required or if the "support" directories themselves are
explicitly required.
This option can be specified multiple times.
--retry ATTEMPTS Specify the number of times to retry failing tests (default: 0)
--i18n-languages List all available languages
--i18n-keywords LANG List keywords for in a particular language
Run with "--i18n help" to see all languages
--fail-fast Exit immediately following the first failing scenario
-f, --format FORMAT How to format features (Default: pretty). Available formats:
html : Outputs HTML report
json : Prints the feature as JSON.
The JSON format is in maintenance mode.
Please consider using the message formatter
with the standalone json-formatter
(<https://github.com/cucumber/cucumber/tree/master/json-formatter>).
junit : Generates a report similar to Ant+JUnit. Use
junit,fileattribute=true to include a file attribute.
message : Outputs protobuf messages
pretty : Prints the feature as is - in colours.
progress : Prints one character per scenario.
rerun : Prints failing files with line numbers.
stepdefs : Prints All step definitions with their locations. Same as
the usage formatter, except that steps are not printed.
summary : Summary output of feature and scenarios
usage : Prints where step definitions are used.
The slowest step definitions (with duration) are
listed first. If --dry-run is used the duration
is not shown, and step definitions are sorted by
filename instead.
Use --format rerun --out rerun.txt to write out failing
features. You can rerun them with cucumber @rerun.txt.
FORMAT can also be the fully qualified class name of
your own custom formatter. If the class isn't loaded,
Cucumber will attempt to require a file with a relative
file name that is the underscore name of the class name.
Example: --format Foo::BarZap -&gt; Cucumber will look for
foo/bar_zap.rb. You can place the file with this relative
path underneath your features/support directory or anywhere
on Ruby's LOAD_PATH, for example in a Ru…
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-18 00:54:05
[cucumber/cucumber-js] Pull request ready for review by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-18 00:56:29
[cucumber/cucumber-js] Comment on #1700
Agreed. I'm shortly going to merge <a href="https://github.com/cucumber/cucumber-js/pull/1699">#1699</a> and then look at formatters documentation next so I'll do this as part of that.
Here's a PR to remove the reference to protobuf from the ruby one <a href="https://github.com/cucumber/cucumber-ruby/pull/1554">cucumber/cucumber-ruby#1554</a>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-18 04:28:22
[cucumber/cucumber-js] Pull request merged by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-21 02:28:02
[cucumber/cucumber-js] Issue opened by Phonesis
<https://github.com/cucumber/cucumber-js/issues/1701|#1701 Unable to use cucumber pretty formatter >
<p>I get the following error since upgrading to Cucumber 7.3.0 when I try to pass in the following formatter option</p>
<pre><code>-f @cucumber/pretty-formatter
</code></pre>
<p>Error:</p>
<pre><code>TypeError: Cannot read property 'astNodeIds' of undefined
at PrettyFormatter.onTestStepStarte
</code></pre>
<p>Any solutions? I am using latest version of the pretty formatter (1.0.0-alpha.0)</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-21 02:32:29
[cucumber/cucumber-js] Comment on #1701
<p>Hi <a href="https://github.com/Phonesis">@Phonesis</a> - I've raised <a href="https://github.com/jbpros/cucumber-pretty-formatter/pull/5">jbpros/cucumber-pretty-formatter#5</a> to fix the issue there, hopefully that will be released shortly.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-21 02:43:36
[cucumber/cucumber-js] Comment on #1701
<p>That's great thanks <a href="https://github.com/davidjgoss">@davidjgoss</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-21 03:36:21
[cucumber/cucumber-js] Comment on #1701
<p>No problem - going to close this issue since we have the PR.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-21 03:36:21
[cucumber/cucumber-js] Issue closed by davidjgoss
<https://github.com/cucumber/cucumber-js/issues/1701|#1701 Unable to use cucumber pretty formatter >
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-22 02:08:18
[cucumber/cucumber-js] Issue opened by yasserf
<p>Hi! 👋</p>
<p>Firstly, thanks for your work on this project! 🙂</p>
<p>Today I used <a href="https://github.com/ds300/patch-package">patch-package</a> to patch <code>@cucumber/cucumber@7.3.0</code> for the project I'm working on.</p>
<p>The IParameterTypeDefinition in code supported both RegExp and arrays of them.</p>
<p>Here is the diff that solved my problem:</p>
<pre><code>diff --git a/node_modules/@cucumber/cucumber/lib/support_code_library_builder/types.d.ts b/node_modules/@cucumber/cucumber/lib/support_code_library_builder/types.d.ts
index 27e0f51..13b4fbe 100644
--- a/node_modules/@cucumber/cucumber/lib/support_code_library_builder/types.d.ts
+++ b/node_modules/@cucumber/cucumber/lib/support_code_library_builder/types.d.ts
@@ -39,7 +39,7 @@ export interface IDefineTestRunHookOptions {
}
export interface IParameterTypeDefinition&lt;T&gt; {
name: string;
- regexp: RegExp;
+ regexp: RegExp | RegExp[];
transformer: (...match: string[]) =&gt; T;
useForSnippets?: boolean;
preferForRegexpMatch?: boolean;
</code></pre>
<p><em>This issue body was <a href="https://github.com/ds300/patch-package/issues/296">partially generated by patch-package</a>.</em></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-22 03:22:56
[cucumber/cucumber-js] Comment on #1695
<p>Done!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-22 03:33:10
[cucumber/cucumber-js] Pull request opened by aslakhellesoy
<p>Also see <a href="https://github.com/cucumber/docs/pull/636">cucumber/docs#636</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2883895132)
GitHub
2021-06-22 03:35:32
[cucumber/cucumber-js] Comment on #1703
<p><a href="https://coveralls.io/builds/40774800">Coverage Status</a></p>
<p>Coverage remained the same at 98.516% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/102ec8f0e70ddb4c8f06bd9f288a2d6ef9d569c8">102ec8f</a> on environment-variables-link</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/6b09896ccf1dfe58136f247c4fca95f83f4eaaad">6b09896</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-22 04:53:45
[cucumber/cucumber-js] davidjgoss approved aslakhellesoy's pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-22 04:54:07
[cucumber/cucumber-js] Pull request merged by aslakhellesoy
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-23 08:17:01
[cucumber/cucumber-js] Comment on #1695
<p>What does this comment do?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-23 08:32:34
[cucumber/cucumber-js] Pull request opened by charlierudolph
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-23 08:35:47
[cucumber/cucumber-js] Comment on #1704
<p><a href="https://coveralls.io/builds/40819945">Coverage Status</a></p>
<p>Coverage remained the same at 98.516% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/0dcb8b524bfd363b9ad2bd8b3794e10e0094fb85">0dcb8b5</a> on cr-node-versions</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/30ec23a7960be2740f75fe91a6e568b8896da5f8">30ec23a</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-23 08:51:49
[cucumber/cucumber-js] davidjgoss requested changes on charlierudolph's pull request
<p>Fantastic, we can start landing those other breaking changes for 8.0.0 now. It'll also make the ESM thing smaller and easier.</p>
<p>I think we need to update <a href="https://github.com/cucumber/cucumber-js/blob/main/package.json#L168">the <code>package.json</code></a> as well.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-23 11:13:53
[cucumber/cucumber-js] davidjgoss approved charlierudolph's pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-23 11:15:16
[cucumber/cucumber-js] Comment on #1704
<p>Hmm, I don't understand how the 15.x test builds are marked as required (same with audit dependencies)</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-23 14:29:15
[cucumber/cucumber-js] Comment on #1695
<p>This seems to break the fail fast principle. Cucumber should stop when it can't make sense of the input. This prevents unexpected behavior and simplifies debugging.</p>
<p>Rather then using the cli I would expect tools that use cucumber-js in process to use the same underlying api that the cli uses. If that api does not exist, consider making it available.</p>
<p>Alternatively Cucumber JVM has two main methods. A real one and one that returns the exit code but doesn't exit. It's still a bit hacky but does avoid the problems mentioned above.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-23 14:29:16
[cucumber/cucumber-js] mpkorstanje commented on aslakhellesoy's pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-25 00:00:14
[cucumber/cucumber-js] Comment on #1702
<p>Hi :)</p>
<p>Thanks for the report.</p>
<p>Could you please give more details regarding the original issue you were facing?</p>
<p>Did you consider creating a pull request with your changes?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-25 01:48:50
[cucumber/cucumber-js] Comment on #1489
<p>Suggestion: <a href="https://github.com/purpleteam-labs/purpleteam-app-scanner_cucumber-1489-repro/pull/1">purpleteam-labs/purpleteam-app-scanner_cucumber-1489-repro#1</a></p>
<p>All test are passing now</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-25 01:57:27
[cucumber/cucumber-js] Comment on #1702
<p>The <code>IParameterTypeDefinition</code> interface in Cucumber.js is a wrapper around this constructor signature in the cucumber-expressions library:</p>
<p><a href="https://github.com/cucumber/common/blob/5391796cb49ebc93b83325fcce96af2f59e9a201/cucumber-expressions/javascript/src/ParameterType.ts#L44">https://github.com/cucumber/common/blob/5391796cb49ebc93b83325fcce96af2f59e9a201/cucumber-expressions/javascript/src/ParameterType.ts#L44</a></p>
<p>I think an even better fix would be to adopt the same type:</p>
<pre><code>regexp: readonly RegExp[] | readonly string[] | RegExp | string
</code></pre>
<p>Note that the cucumber-expressions library uses the plural <code>regexps</code> while Cucumber.js uses the singular <code>regexp</code>. It's unfortunate that they are different, but for backwards compatibility reasons I think we should keep <code>regexp</code>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-25 03:35:40
[cucumber/cucumber-js] Comment on #1702
<p>The issue i faced was when defining custom parameter types:</p>
<p>For example:</p>
<pre><code>defineParameterType({
regexp: [/object using (.+)$/, /using object (.+)$/],
transformer: function (this: World, not_sure: string, name: string) {
... does something ...
},
useForSnippets: true,
preferForRegexpMatch: true,
name: 'object',
})
</code></pre>
<p><em><strong>note: the above example syntax makes no real sense, it's for a POC which I refactored a few times and so don't actually need both, but the library supports it so the typescript patch stayed</strong></em></p>
<p>I raised the issue because I had a patch via patch-package and it offered to do it via a template, so was pretty quick 🙈</p>
<p>happy to raise a PR in the next few days if noone beats me to it!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-25 03:42:18
[cucumber/cucumber-js] Comment on #1702
<p><a href="https://github.com/yasserf">@yasserf</a> do you mean you wanted to use an array of regexps but it yielded a TypeScript compilation error (even though it would work at runtime)?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-25 04:32:56
[cucumber/cucumber-js] Comment on #1702
<p>Yup, I just patched the type but the functionality itself worked as expected This was a few months ago, so I can’t say for certain it’s still the case</p>
<p><#|…></p>
<p>On Fri, 25 Jun 2021 at 12:42, David Goss <strong><em>*</strong>@<strong></em><em></strong>.<strong></em>*</strong>> wrote: <a href="https://github.com/yasserf">@yasserf</a> <<a href="https://github.com/yasserf">https://github.com/yasserf</a>> do you mean you wanted to use an array of regexps but it yielded a TypeScript compilation error (even though it would work at runtime)? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <<a href="https://github.com/cucumber/cucumber-js/issues/1702#issuecomment-868409069">#1702 (comment)</a>>, or unsubscribe <<a href="https://github.com/notifications/unsubscribe-auth/AAU3WS6RKTTI6S25PHUIGS3TURMRFANCNFSM47DH7IUA">https://github.com/notifications/unsubscribe-auth/AAU3WS6RKTTI6S25PHUIGS3TURMRFANCNFSM47DH7IUA</a>> .</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-25 06:43:49
[cucumber/cucumber-js] Pull request opened by aslakhellesoy
<p><strong>Description</strong></p>
<p>Some users use arrow functions without realising that they cannot access the world from them.</p>
<p><strong>Motivation & context</strong></p>
<p>This is currently described in the FAQ, but people still miss it. I've therefore added more sign-posts from the hook, step definition and parameter type docs.</p>
<p>I also tweaked the FAQ entry a little.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2914592567)
GitHub
2021-06-25 06:46:23
[cucumber/cucumber-js] Comment on #1705
<p><a href="https://coveralls.io/builds/40885284">Coverage Status</a></p>
<p>Coverage remained the same at 98.516% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/7aa4cf1a5751642740a602c9a17adec730e9d970">7aa4cf1</a> on more-arrow-function-warnings</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/30ec23a7960be2740f75fe91a6e568b8896da5f8">30ec23a</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-25 06:49:55
[cucumber/cucumber-js] davidjgoss approved aslakhellesoy's pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-25 07:26:12
[cucumber/cucumber-js] Pull request merged by aslakhellesoy
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-25 07:41:27
[cucumber/cucumber-js] Comment on #1705
<p>I wondered if we could detect this at runtime and emit a warning but seems it's <a href="https://stackoverflow.com/questions/28222228/javascript-es6-test-for-arrow-function-built-in-function-regular-function">not straightforward</a> :(</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-25 09:22:00
[cucumber/cucumber-js] Issue opened by nicojs
<p><strong>Describe the bug</strong></p>
<p>In order to save time, I'm trying to use cucumber-js to target individual features and examples (a lot of them). I'm using these arguments:</p>
<pre><code>$ npx cucumber-js "features/foo.feature:33" "features/foo.feature:34"
</code></pre>
<p>(to target 2 examples)</p>
<p>However, instead of saving time, it just takes more time. It seems that both examples are now executed twice.</p>
<p><strong>To Reproduce</strong></p>
<ol><li>Follow the nodejs example: <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/nodejs_example.md">https://github.com/cucumber/cucumber-js/blob/main/docs/nodejs_example.md</a></li><li>Execute <code>npx cucumber-js features/simple_math.feature:19</code>, see:
<pre><code>...
1 scenario (1 passed)
3 steps (3 passed)
</code></pre></li><li>Same for line 20, <code>npx cucumber-js features/simple_math.feature:20</code>, see:
<pre><code>...
1 scenario (1 passed)
3 steps (3 passed)
</code></pre></li><li>Now, execute <code>npx cucumber-js features/simple_math.feature:19 features/simple_math.feature:20</code>, see:
<pre><code>............
4 scenarios (4 passed)
12 steps (12 passed)
</code></pre></li>
</ol>
<p><strong>Expected behavior</strong></p>
<pre><code>...
2 scenario (2 passed)
6 steps (6 passed)
</code></pre>
<p><strong>Desktop (please complete the following information):</strong></p>
<p>• OS: Windows
• cucumberjs v7.3.0
• npm 6.14.11, node v12.21.0</p>
<p><strong>Smartphone (please complete the following information):</strong></p>
<p>• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-25 09:41:42
[cucumber/cucumber-js] Issue opened by sarahgoldman
<p><strong>Describe the bug</strong></p>
<p>If I tag a scenario with "<a href="https://github.com/reissue">@reissue</a>" or even a tag name containing that word, e.g. "@reissueassignment", the tests fail with error:</p>
<pre><code>[12:25:46] E/launcher - Error: Error: Tag name should have a property "length" that is greater than 0
at Object.ensure (C:\jdev2020\git\via_automated_testing\node_modules\tiny_types\src\ensure.ts:31:15)
at new Tag (C:\jdev2020\git\via_automated_testing\node_modules\@serenity_js\core\src\model\tags\Tag.ts:23:9)
at new IssueTag (C:\jdev2020\git\via_automated_testing\node_modules\@serenity_js\core\src\model\tags\IssueTag.ts:10:9)
at C:\jdev2020\git\via_automated_testing\node_modules\@serenity_js\core\src\model\tags\Tags.ts:17:66
at Array.map (&lt;anonymous&gt;)
at MatchesRegExp.transformation (C:\jdev2020\git\via_automated_testing\node_modules\@serenity_js\core\src\model\tags\Tags.ts:17:53)
at MatchesRegExp.MatcherRule.execute (C:\jdev2020\git\via_automated_testing\node_modules\tiny_types\src\pattern_matching\rules\MatcherRule.ts:13:21)
at StringMatcher.PatternMatcher.else (C:\jdev2020\git\via_automated_testing\node_modules\tiny_types\src\pattern_matching\PatternMatcher.ts:17:71)
at Function.from (C:\jdev2020\git\via_automated_testing\node_modules\@serenity_js\core\src\model\tags\Tags.ts:18:18)
at C:\jdev2020\git\via_automated_testing\node_modules\@serenity_js\cucumber\src\listeners\messages\parser\CucumberMessagesParser.ts:233:80
at Array.map (&lt;anonymous&gt;)
at CucumberMessagesParser.scenarioFrom (C:\jdev2020\git\via_automated_testing\node_modules\@serenity_js\cucumber\src\listeners\messages\parser\CucumberMessagesParser.ts:233:64)
at CucumberMessagesParser.parseTestCaseStarted (C:\jdev2020\git\via_automated_testing\node_modules\@serenity_js\cucumber\src\listeners\messages\parser\CucumberMessagesParser.ts:102:34)
at EventEmitter.&lt;anonymous&gt; (C:\jdev2020\git\via_automated_testing\node_modules\@serenity_js\cucumber\src\listeners\messages\CucumberMessagesListener.ts:49:41)
at EventEmitter.emit (events.js:323:22)
at EventEmitter.emit (domain.js:482:12)
[12:25:46] E/launcher - Process exited with error code 100
</code></pre>
<p><strong>To Reproduce</strong><br />
Steps to reproduce the behavior:<br />
Tag a scenario with "<a href="https://github.com/reissue">@reissue</a>" or "@reissuesomething".</p>
<p><strong>Note</strong>: I am using with protractor-cucumber-framework@~8.0.0</p>
<p>Here is my feature file:</p>
<pre><code>@VIA-150 @establishment @establishmentdetails
Feature: VIA-150 CREATE ASSIGNMENTS
All functionality related to creating an assignments
@reissue
Scenario: 150-16449-AC1-HP2
Given "Coordinator" user is logged in
And the user is viewing an establishment that is marked to be reissued an assignment
When the user creates an assignment for the establishment
Then the system shall display the "Establishment Detail" screen
And the establishment shall not display the Reissue badge
</code></pre>
<p>When I change it to "reissu" without the "e", it works as expected:</p>
<pre><code>@VIA-150 @establishment @establishmentdetails
Feature: VIA-150 CREATE ASSIGNMENTS
All functionality related to creating an assignments
@reissu
Scenario: 150-16449-AC1-HP2
Given "Coordinator" user is logged in
And the user is viewing an establishment that is marked to be reissued an assignment
When the user creates an assignment for the establishment
Then the system shall display the "Establishment Detail" screen
And the establishment shall not display the Reissue badge
</code></pre>
<p><strong>Is <a href="https://github.com/reissue">@reissue</a> a reserved word and is this documented somewhere, or is this a bug?</strong></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-25 09:46:20
[cucumber/cucumber-js] Comment on #1706
<p>Thanks for the report <a href="https://github.com/nicojs">@nicojs</a>.</p>
<p>Just to clarify, it seems like you're running into this when using a Scenario Outline with an Examples table. I assume it doesn't occur with regular Scenarios?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-25 09:59:47
[cucumber/cucumber-js] Comment on #1706
<p>It also occurs with regular scenarios.</p>
<p>I've dug a little deeper and found out the issue:</p>
<p><a href="https://github.com/cucumber/cucumber-js/blob/ea4d86003a6d309f1d94bd8a42b7795653885ce6/src/cli/configuration_builder.ts#L144-L147">cucumber-js/src/cli/configuration_builder.ts</a></p>
<p>Lines 144 to 147 in </cucumber/cucumber-js/commit/ea4d86003a6d309f1d94bd8a42b7795653885ce6|ea4d860></p>
<p>Feature files are expanded <em>but not deduplicated</em>. This fixes it:</p>
<pre><code> async expandFeaturePaths(featurePaths: string[]): Promise&lt;string[]&gt; {
featurePaths = featurePaths.map((p) =&gt; p.replace(/(:\d+)**$/g, '')) // Strip line numbers
+ featurePaths = [...new Set(featurePaths)]; // Deduplicate the feature files
return this.expandPaths(featurePaths, '.feature')
}
</code></pre>
<p>You want me to create a PR? Does this warrant a feature file? Or unit testing?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-25 10:07:54
[cucumber/cucumber-js] Pull request opened by nicojs
<p>Fix the issue where the same scenarios are executed multiple times when the feature file is targeted multiple times.</p>
<p>Example:</p>
<pre><code>$ npx cucumber-js features/simple_math.feature:19 features/simple_math.feature:20
</code></pre>
<p>Will now result in:</p>
<pre><code>...
2 scenario (2 passed)
6 steps (6 passed)
</code></pre>
<p>Fixes <a href="https://github.com/cucumber/cucumber-js/issues/1706">#1706</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-25 10:09:14
[cucumber/cucumber-js] Comment on #1706
<p>The fix seems straight forward enough to not deem itself worthy for a feature file IMHO 🤷♂️ See PR <a href="https://github.com/cucumber/cucumber-js/pull/1708">#1708</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-25 10:10:57
[cucumber/cucumber-js] Comment on #1706
<p>Ah thanks, good find.</p>
<p>FWIW we do have a notation that supports targeting multiple lines in the same file, check out this scenario <a href="https://github.com/cucumber/cucumber-js/blob/main/features/target_specific_scenarios_by_line.feature#L40">https://github.com/cucumber/cucumber-js/blob/main/features/target<em>specific</em>scenarios<em>by</em>line.feature#L40</a>.</p>
<p>If you're willing to do a PR to add the deduplication though that would be great. I think another scenario in the aforementioned file (as I think that's the most likely circumstance to hit this) plus relevant unit testing would be right in terms of coverage.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-25 10:11:03
[cucumber/cucumber-js] Comment on #1708
<p><a href="https://coveralls.io/builds/40892621">Coverage Status</a></p>
<p>Coverage increased (+0.0007%) to 98.517% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/fd33d847fcc971d36d7003bf9feeeead58b33c1b">fd33d84</a> on nicojs:main</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/5b301effa491a7e830b00de2a0108ac01bbc0006">5b301ef</a> on cucumber:main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-25 10:16:39
[cucumber/cucumber-js] Comment on #1706
<p>Ah cool! I was looking for exactly that 😆I will use that then</p>
<p>> If you're willing to do a PR to add the deduplication though that would be great. I think another scenario in the aforementioned file (as I think that's the most likely circumstance to hit this) plus relevant unit testing would be right in terms of coverage.</p>
<p>PR is ready. I will add the scenario too, no problem.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-25 10:22:12
[cucumber/cucumber-js] Comment on #1706
<p>Ok, added it. I've transformed the scenario to a scenario outline with 2 examples. I've also manually "mutation tested" it.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-25 16:34:11
[cucumber/cucumber-js] davidjgoss approved nicojs's pull request
<p>Nice, thanks for doing this <a href="https://github.com/nicojs">@nicojs</a>!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-25 16:58:22
[cucumber/cucumber-js] Comment on #1707
<p>Hi <a href="https://github.com/sarahgoldman">@sarahgoldman</a>, thanks for raising - this was an odd one. I can confirm there are no reserved words for tags in Cucumber itself.</p>
<p>The stack trace you included was helpful though, leading to <a href="https://github.com/serenity-js/serenity-js/blob/master/packages/core/src/model/tags/Tags.ts#L17">this code in serenity-js</a> which is doing special handling for tags that include "issue" or "issues". There's <a href="https://serenity-js.org/handbook/integration/jira-and-other-issue-trackers.html">some documentation here</a> which explains what this is about.</p>
<p>It doesn't seem like there's a way to opt out of this behaviour, but it might be worth raising an issue in that repo?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-25 17:18:25
[cucumber/cucumber-js] Comment on #1702
<p>Thanks for confirming <a href="https://github.com/yasserf">@yasserf</a>.</p>
<p>I've pushed a test for the TypeScript typing <a href="https://github.com/cucumber/cucumber-js/commit/54ef15959448e6bce09b347fb7ecc77ffacd54d8">to this branch</a>, which fails as of now and should pass (along with all existing change) once the change <a href="https://github.com/aslakhellesoy">@aslakhellesoy</a> suggests is made.</p>
<p>If you or anyone interested would like to do a PR for this, that would be great.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-25 20:25:42
[cucumber/cucumber-js] Comment on #1708
<p>duplicate comment, second could be removed</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-25 20:27:40
[cucumber/cucumber-js] Comment on #1708
<p>Looks great! Thanks for the fix</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-25 21:30:17
[cucumber/cucumber-js] Comment on #1489
<p>Thanks for that <a href="https://github.com/aurelien-reeves">@aurelien-reeves</a>.</p>
<p>This appears to asume that the <code>envelopes</code> array will always be in a specific order, that order being:</p>
<ol><li>if there is a <code>gherkinDocument</code> <code>push</code> it. Then <code>push</code> the <code>gherkinDocument</code>s pickles in order from top down</li><li>if there is another <code>gherkinDocument</code> <code>push</code> it. Then <code>push</code> the <code>gherkinDocument</code>s pickles in order from top down</li><li>and so on</li>
</ol>
<p>Is this assumption true?</p>
<p>If so great, it's so simple.</p>
<p>I also didn't know about the <code>pickleFilter.matches</code>, it's basically doing all/most of the work.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-25 21:59:17
[cucumber/cucumber-js] Comment on #1489
<p>Just looked into <code>fromPaths</code> and it appears that it's recursive <code>pipeSequentially</code> does exactly this.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-25 23:27:49
[cucumber/cucumber-js] Comment on #1489
<p>Big thanks <a href="https://github.com/aurelien-reeves">@aurelien-reeves</a> for getting this over the line!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-25 23:27:50
[cucumber/cucumber-js] Issue closed by binarymist
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-26 02:02:59
[cucumber/cucumber-js] Comment on #1708
<p>Oops. 😳</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-26 02:04:05
[cucumber/cucumber-js] Comment on #1708
<p>I see you are using lodash here. Should <code>new Set</code> be changed to <code>_.unique</code>? Both work fine.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-26 02:16:08
[cucumber/cucumber-js] Comment on #1708
<p>Do we still need lodash <a href="https://github.com/charlierudolph">@charlierudolph</a>? Doesn’t the stdlib do everything it does now?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-26 08:30:22
[cucumber/cucumber-js] Comment on #1704
<p>I think we should be okay to merge this even if we want to get our other fixes on the 7.x releases. We should create a 7.x branch and can backport fixes there if need be. Would just want to be sure have the fixes / changelog in the main branch as well.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-26 08:37:10
[cucumber/cucumber-js] Comment on #1708
<p>Set is fine. I'll do an audit of what we use lodash for and see if we can remove it</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-26 08:37:17
[cucumber/cucumber-js] Issue closed by charlierudolph
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-26 08:37:18
[cucumber/cucumber-js] Pull request merged by charlierudolph
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-26 08:37:18
[cucumber/cucumber-js] Comment on #1708
<p>Hi <a href="https://github.com/nicojs">@nicojs</a>,</p>
<p>Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾</p>
<p>In return for this generous offer we hope you will:</p>
<p>• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our <a href="https://cucumber.io/conduct">code of conduct</a> in your interactions with other collaborators and users.
• 💬 Join the <a href="http://cucumber.io/support#slack">community Slack channel</a> to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!</p>
<p>On behalf of the Cucumber core team,<br />
Aslak Hellesøy<br />
Creator of Cucumber</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-26 11:41:17
[cucumber/cucumber-js] Pull request opened by charlierudolph
<p>Seems like we can get by with language features and don't need to make use of lodash anymore</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2922079577)
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2922079558)
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2922079534)
GitHub Actions: test (windows-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2922079527)
GitHub Actions: test (ubuntu-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2922079512)
GitHub Actions: test (ubuntu-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2922079498)
GitHub Actions: test (ubuntu-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2922079476)
GitHub Actions: test (ubuntu-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2922079453)
GitHub Actions: test (windows-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2922077623)
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2922077619)
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2922077611)
GitHub Actions: test (windows-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2922077604)
GitHub Actions: test (ubuntu-latest, 15.x)
(https://github.com/cucumber/cucumber-js/runs/2922077595)
GitHub Actions: test (ubuntu-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2922077584)
GitHub Actions: test (ubuntu-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2922077579)
GitHub Actions: test (ubuntu-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/2922077574)
GitHub
2021-06-26 12:42:07
[cucumber/cucumber-js] Comment on #1709
<p>Switched this to allow use of <code>Array.prototype.flat</code> which appears requires node 12 (<a href="https://node.green/#ES2019-features-Array-prototype--flat--flatMap-">https://node.green/#ES2019-features-Array-prototype--flat--flatMap-</a>)</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-26 13:13:53
[cucumber/cucumber-js] Comment on #1709
<p><a href="https://coveralls.io/builds/40908011">Coverage Status</a></p>
<p>Coverage decreased (-0.05%) to 98.47% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/5d38b2a96fd5bff3e8295c5bb9401e02212c56b8">5d38b2a</a> on cr-lodash</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/17b43911898e50b5077619005223f716c995c877">17b4391</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-26 14:30:10
[cucumber/cucumber-js] Comment on #1453
<p><a href="https://github.com/charlierudolph">@charlierudolph</a> - I'd suggest attaching the original stack trace at the very least. At the moment it's very difficult for custom formatters to understand what error has been thrown based on a formatted stack trace.</p>
<p>I'm guessing the reason behind this design decision is that it's difficult for Cucumber to provide a generic Error serialisation mechanism since you're not in control of things a test might throw, and therefore might not be able to deserialise them afterwards. However, perhaps you could consider making it possible to use a custom error serialiser with Cucumber.js?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-26 16:07:33
[cucumber/cucumber-js] Comment on #1709
<p>Nice one, and as soon as we merge <a href="https://github.com/cucumber/cucumber-js/pull/1704">#1704</a> the build error should go way.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-27 03:08:05
[cucumber/cucumber-js] davidjgoss approved charlierudolph's pull request
<p>> We should create a 7.x branch and can backport fixes there if need be.</p>
<p>Good point, I'll do that.</p>
<p>Not sure what's with the phantom 15.x build showing up, seems to still be doing it even after a merge - hopefully will clear itself when it lands on <code>main</code>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-27 03:14:42
[cucumber/cucumber-js] Pull request merged by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-27 03:29:23
[cucumber/cucumber-js] davidjgoss approved renovate[bot]'s pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-27 03:29:31
[cucumber/cucumber-js] Pull request merged by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-27 04:53:15
[cucumber/cucumber-js] Pull request merged by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-27 05:11:27
[cucumber/cucumber-js] Comment on #1701
<p><code>@cucumber/pretty-formatter</code> version <code>1.0.0-alpha.1</code> is now released with the fix.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-27 23:04:54
[cucumber/cucumber-js] Comment on #1695
<p>The next line gives a compile error. <code>catch (commanderError: CommanderError)</code> is not allowed, you're only allowed to catch <code>any</code> or <code>unknown</code>.</p>
<p>Using <code>@ts-expect-error</code> will ignore the error, like <code>@ts-ignore-error</code>, but is a bit better in that it <em>will give an error when the next line does not give a compile error</em>. For example, if you forget to remove <code>@ts-ignore-error</code> after a refactor.</p>
<p>I'd say: use <code>@ts-expect-error</code> with caution and never use <code>@ts-ignore-error</code>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-27 23:14:00
[cucumber/cucumber-js] Issue opened by nicojs
<p><strong>Is your feature request related to a problem? Please describe.</strong><br />
I'm in the process of adding support for cucumber-js in StrykerJS, the mutation testing framework for JavaScript and friends. See <a href="https://github.com/stryker-mutator/stryker-js/pull/2970">stryker-mutator/stryker-js#2970</a></p>
<p>I would like to use cucumber programmatically. In fact, I'm already doing that in the MR. However, I realize that I'm using an undocumented API, which I don't like doing, since the implementation could break in a patch release version. I strive to use public APIs only.</p>
<p><strong>Describe the solution you'd like</strong></p>
<p>Would you accept a PR that documents the use of the <code>Cli</code> class for public usage?</p>
<pre><code>const { Cli } = require('@cucumber/cucumber')
</code></pre>
<p>I would add it to your <a href="https://github.com/cucumber/cucumber-js/tree/main/docs">docs</a> directory. Either in a new file (<code>programmatic-usage.md</code>) or add it to the <code>cli.md</code> file.</p>
<p><strong><em>*Describe alternatives you've considered</em></strong>*</p>
<p><strong>Additional context</strong><br />
In order to make mutation testing feasible, we need a programmatic API. Simply calling <code>childProcess.exec</code> to execute cucumber-js would work, but is terrible for performance since Stryker will run cucumber-js many times during a mutation testing run.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-28 01:28:15
[cucumber/cucumber-js] Comment on #1710
<p>You are not the only one using the internal APIs for a programmatic usage.</p>
<p>I think it would be a good idea to stabilize such an API and to document it.</p>
<p><a href="https://github.com/orgs/cucumber/teams/cucumber-js">@cucumber/cucumber-js</a> what do you think?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-28 01:30:16
[cucumber/cucumber-js] Comment on #1710
<p>Hey <a href="https://github.com/nicojs">@nicojs</a>, your timing is impeccable! I'm writing a proposal for a new programmatic API this morning that hopefully will be of benefit to you. I'll tag you there as it would be great to get your initial feedback.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-28 02:29:46
[cucumber/cucumber-js] Issue opened by davidjgoss
<p><strong>Problem</strong></p>
<p>Currently we don't have a good way to programmatically run cucumber-js. The need is from two angles:</p>
<p>• Testing - for the CCK and our acceptance tests in the project
• Projects that use cucumber-js as part of a framework (e.g. Serenity, Stryker)</p>
<p><strong>As-is</strong></p>
<p>What tends to happen at the moment is a new instance of <code>Cli</code> is created with <a href="https://github.com/cucumber/cucumber-js/blob/main/compatibility/cck_spec.ts#L41">strung-together argv input</a>. It's obviously very unweildy and also <a href="https://github.com/cucumber/cucumber-js/issues/1710">isn't on the public API</a>.</p>
<p>Sometimes (possibly due to perceived fragility of the above) frameworks will just rely on the cucumber-js CLI but struggle to find ways to integrate and have their own options.</p>
<p>The <a href="https://github.com/cucumber/cucumber-js/blob/main/src/runtime/index.ts#L42"><code>Runtime</code> class</a> is currently part of the public API but it's not useful in these contexts, depending on the pickles and support code to be provided by the caller.</p>
<p><strong>Proposal</strong></p>
<p>Two components in the project:</p>
<p><strong><code>runCucumber</code></strong></p>
<p>New async function that executes a test run in-process. Responsibilities:</p>
<p>• Accept an options object with a nice interface
• Do the "work" of resolving pickles, loading support code, running test cases, orchestrating formatters
• Return a promise that resolves to a result</p>
<p>This would be part of the public API and we'd encourage framework maintainers to use it when "wrapping" cucumber-js. We'd also use it for our own testing.</p>
<p>As much as possible, it would avoid direct interaction with <code>process</code>, instead accepting normalised options and stream interfaces for output, and leaving it to the caller to decide how to exit based on the result or an unhandled error.</p>
<p>Also <code>Runtime</code> should come off the public API as it's really an internal thing.</p>
<p><strong>CLI</strong></p>
<p>Effectively a "client" of <code>runCucumber</code>. Responsibilities:</p>
<p>• Parse input from process arguments (via commander)
• Load profiles (which as it stands are a feature of the CLI) and mix those arguments in as needed
• Call <code>runCucumber</code> with the resolved options
• Exit as appropriate based on the results</p>
<p>This would continue to <em>not</em> be on the public API. Also it would only use functions/interfaces that <em>are</em> on the public API, such that we could easily break it out into its own package at some point, as is a common pattern now with projects like <a href="https://github.com/facebook/jest/tree/master/packages">Jest</a>.</p>
<p>This decoupling also paves the way for some interesting new CLI features without having them bleed into the internals, e.g.:</p>
<p>• <code>--gui</code> for the cucumber-electron stuff
• <code>--interactive</code> for quick targeted reruns when TDD'ing</p>
<p><strong>Timescale</strong></p>
<p>We'd target this at the upcoming 8.0.0 release. I'm ready to gets started on this today.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-28 02:32:39
[cucumber/cucumber-js] Comment on #1711
<p>Paging for initial feedback: <a href="https://github.com/aslakhellesoy">@aslakhellesoy</a> <a href="https://github.com/charlierudolph">@charlierudolph</a> <a href="https://github.com/aurelien-reeves">@aurelien-reeves</a> <a href="https://github.com/mattwynne">@mattwynne</a> <a href="https://github.com/nicojs">@nicojs</a> <a href="https://github.com/jan-molak">@jan-molak</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-28 02:35:02
[cucumber/cucumber-js] Comment on #1711
<p>I love this proposal! We already an API like this in fake-cucumber's <a href="https://github.com/cucumber/common/blob/main/fake-cucumber/javascript/src/runCucumber.ts">runCucumber</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-28 02:35:32
[cucumber/cucumber-js] Comment on #1711
<p><a href="https://github.com/aslakhellesoy">@aslakhellesoy</a> I may have drawn some inspiration from that...</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-28 02:43:12
[cucumber/cucumber-js] Comment on #1711
<p><a href="https://github.com/davidjgoss">@davidjgoss</a> - sounds great!</p>
<p>For your reference, here's how Serenity/JS invokes Cucumber at the moment - <a href="https://github.com/serenity-js/serenity-js/blob/master/packages/cucumber/src/cli/CucumberCLIAdapter.ts"><code>CucumberCLIAdapter</code></a><br />
And here's the logic around converting configuration parameters to argv - <a href="https://github.com/serenity-js/serenity-js/blob/master/packages/cucumber/src/cli/CucumberOptions.ts"><code>CucumberOptions</code></a>.</p>
<p>Being able to provide an options object instead of argv would be much nicer 👍:skin<em>tone</em>2:</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-28 02:43:19
[cucumber/cucumber-js] Comment on #1711
<p>Love it!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-28 02:49:44
[cucumber/cucumber-js] Comment on #1711
<p>While specifying that new public API, we may also consider what recently happened with issue <a href="https://github.com/cucumber/cucumber-js/issues/1489">#1489</a> and think about providing public APIs to have more and better interaction with the filters and the resulting features under test</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-28 03:25:39
[cucumber/cucumber-js] Comment on #1711
<p>And to add to that - let's make something that would make it easier for Cucumber-Electron too:</p>
<p>• <a href="https://github.com/cucumber/cucumber-electron/blob/1c2faaa77065754d1ca17dce27fff1c421d226d0/src/renderer/main.js#L49">https://github.com/cucumber/cucumber-electron/blob/1c2faaa77065754d1ca17dce27fff1c421d226d0/src/renderer/main.js#L49</a>
• <a href="https://github.com/cucumber/cucumber-electron/blob/0617ab15545ac5ceb4587599e589fefd0b670142/src/renderer/index.js#L41-L50">https://github.com/cucumber/cucumber-electron/blob/0617ab15545ac5ceb4587599e589fefd0b670142/src/renderer/index.js#L41-L50</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-28 04:56:10
[cucumber/cucumber-js] Comment on #1711
<p>Having a public API is better than nothing, so go ahead 👍!</p>
<p>Preferably I would also have an API to load profiles using the same rules as <code>cucumber-js</code> does, so I can mimic the exact behavior of a normal cucumber-js call.</p>
<pre><code>loadProfiles(directory = process.cwd()): Record&lt;string, Profile&gt;
</code></pre>
<p>StrykerJS will also rely heavily on the <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/custom_formatters.md">custom_formatters</a> API and the events published by the <code>eventBroadcaster</code>. Could we add those to the public API as well? See: <a href="https://github.com/stryker-mutator/stryker-js/blob/03b1f20ed933d3a50b52022cfe363c606c2b16c5/packages/cucumber-runner/src/stryker-formatter.ts#L45-L69">https://github.com/stryker-mutator/stryker-js/blob/03b1f20ed933d3a50b52022cfe363c606c2b16c5/packages/cucumber-runner/src/stryker-formatter.ts#L45-L69</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-29 13:10:53
[cucumber/cucumber-js] Issue opened by nicojs
<p><strong>Is your feature request related to a problem? Please describe.</strong><br />
Let's say you have this <code>cucumber.js</code> config:</p>
<pre><code>// cucumber.js
module.exports = { default: 'my-features/**.feature' }
</code></pre>
<p>And you now want to focus 1 feature in a feature file:</p>
<pre><code>$ npx cucumber-js my-features/math.feature:7
</code></pre>
<p>In addition to the scenario on line 7 in math.feature, all other feature files will be executed. I've located the code that is responsible here: </p>
<p><a href="https://github.com/cucumber/cucumber-js/blob/4ef971016858bcc3ad5aa3af57439dff5a158277/src/cli/configuration_builder.ts#L125-L141">cucumber-js/src/cli/configuration_builder.ts</a></p>
<p>Lines 125 to 141 in </cucumber/cucumber-js/commit/4ef971016858bcc3ad5aa3af57439dff5a158277|4ef9710></p>
<p><strong>Describe the solution you'd like</strong><br />
I would personally think that <em>command line positional arguments</em> should <strong>not</strong> be merged together with the profile positional arguments, instead it should override them. Note: I do think properties should still be merged, just not positional arguments.</p>
<p><strong>Describe alternatives you've considered</strong><br />
A way to "uninclude" files would be a valid alternative:</p>
<pre><code>$ npx cucumber-js !****/**.feature my-feature/math.feature:7
</code></pre>
<p><strong>Additional context</strong><br />
I've run into this while developing the cucumber plugin for StrykerJS. We want to be able to focus tests, regardless of positional arguments in the profile.</p>
<p>We can also think of another solution when defining the <a href="https://github.com/cucumber/cucumber-js/issues/1711">programmable API</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 00:09:43
[cucumber/cucumber-js] Comment on #1712
<p>That makes sense to me</p>
<p>What do you think <a href="https://github.com/orgs/cucumber/teams/cucumber-js">@cucumber/cucumber-js</a>?</p>
<p>Another possibility could be also to have a <code>--no-profile</code> option to avoid loading any profile, including the default one.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 01:31:21
[cucumber/cucumber-js] Comment on #1712
<p>Thanks <a href="https://github.com/aurelien-reeves">@aurelien-reeves</a> .</p>
<p>A <code>--no-profile</code> would be useful as well for other use cases, but I also want to support profiles. For example:</p>
<pre><code>module.exports = {
default: '--require-module tsnode/register --require my-features/****/**.ts my-features/**.feature'
}
</code></pre>
<p>In this case I still want the options, just not the positional arguments 🤷♂️</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 01:52:29
[cucumber/cucumber-js] Comment on #1712
<p>Thanks for raising <a href="https://github.com/nicojs">@nicojs</a>.</p>
<p>I'd be supportive of changing the logic with the paths so they are considered together and negation is supported. Basically what <a href="https://www.npmjs.com/package/globby">globby</a> does. I don't think this is a breaking change for any use case I can think of, but at any rate we're doing a major release soon. <a href="https://github.com/charlierudolph">@charlierudolph</a> WDYT?</p>
<p>Good point about the API as well, I'll follow up on that issue.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 02:03:29
[cucumber/cucumber-js] Comment on #1711
<p>> Preferably I would also have an API to load profiles using the same rules as cucumber-js does, so I can mimic the exact behavior of a normal cucumber-js call.</p>
<p>This is a good point. Profiles (in their current form at least) are fundamentally coupled to the CLI so it feels right to keep them on that side of the boundary, but we could still expose a function to load them and generate a partial options object.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 02:05:27
[cucumber/cucumber-js] Comment on #1711
<p>> While specifying that new public API, we may also consider what recently happened with issue <a href="https://github.com/cucumber/cucumber-js/issues/1489">#1489</a> and think about providing public APIs to have more and better interaction with the filters and the resulting features under test.</p>
<p>I think we could include an option for providing a custom pickle filter when calling the API (in addition to the names, tags etc that drive the built-in filtering).</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 02:22:49
[cucumber/cucumber-js] Pull request merged by aurelien-reeves
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 03:59:35
[cucumber/cucumber-js] Pull request opened by davidjgoss
<p><strong>Description</strong></p>
<p>Remove the camelCase version of this CLI option as deprecated in 7.0.0 via <a href="https://github.com/cucumber/cucumber-js/pull/1293">#1293</a>.</p>
<p><strong>Type of change</strong></p>
<p>• Breaking change (will cause existing functionality to not<br />
work as expected)</p>
<p><strong>Checklist:</strong></p>
<p>☑︎ My code follows the code style of this project.
☐ My change requires a change to the documentation.
☐ I have updated the documentation accordingly.
☑︎ I have read the <../CONTRIBUTING.md|<strong>CONTRIBUTING</strong>> document.
☐ I have added tests to cover my changes.
☑︎ All new and existing tests passed.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 04:01:43
[cucumber/cucumber-js] Comment on #1713
<p><a href="https://coveralls.io/builds/41001000">Coverage Status</a></p>
<p>Coverage decreased (-0.002%) to 98.515% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/4f8fcd432175e94334be9ef12e6ea6e6161401e4">4f8fcd4</a> on remove-retryTagFilter</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/b8e83b7bfb740e7248f0aabfdc1d55cd161d383b">b8e83b7</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 04:41:26
[cucumber/cucumber-js] Comment on #1711
<p>The current syntax for <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/profiles.md">profiles</a> if very command-line-y.</p>
<p>I would ❤️❤️❤️ to be able to specify profiles in a more generic format such as JSON, JavaScript, YAML or environment variables. In JSON it could look like this:</p>
<p><code>.cucumber.json</code></p>
<pre><code>{
"default": {
"requireModule": ["ts-node/register"],
"require": ["support/****/**./ts"],
"worldParameters": {
"appUrl": "<http://localhost:3000/>",
},
"format": ["progress-bar", "html:./cucumber-report.html"]
},
"ci": {
"requireModule": ["ts-node/register"],
"require": ["support/****/**./ts"],
"worldParameters": {
"appUrl": "<http://localhost:3000/>",
},
"format": ["html:./cucumber-report.html"],
"publish": true
}
}
</code></pre>
<p>Or, using JavaScript</p>
<p><code>.cucumber.js</code></p>
<pre><code>const common = {
"requireModule": ["ts-node/register"],
"require": ["support/****/**./ts"],
"worldParameters": {
"appUrl": "<http://localhost:3000/>",
}
}
module.exports = {
default: {
...common,
"format": ["progress-bar", "html:./cucumber-report.html"]
},
ci: {
...common,
"format": ["html:./cucumber-report.html"],
"publish": true
}
}
</code></pre>
<p>Or even with environment variables (for example loaded with a tool like dotenv):</p>
<p><code>.cucumber.env</code></p>
<pre><code>CUCUMBER_PROFILE_DEFAULT_REQUIREMODULE=ts-node/register
CUCUMBER_PROFILE_DEFAULT_REQUIRE=ts-node/register
CUCUMBER_PROFILE_DEFAULT_WORLDPARAMETERS_APPURL=<http://localhost:3000/>
CUCUMBER_PROFILE_DEFAULT_FORMAT=progress-bar,html:./cucumber-report.html
CUCUMBER_PROFILE_CI_REQUIREMODULE=ts-node/register
CUCUMBER_PROFILE_CI_REQUIRE=ts-node/register
CUCUMBER_PROFILE_CI_WORLDPARAMETERS_APPURL=<http://localhost:3000/>
CUCUMBER_PROFILE_CI_FORMAT=progress-bar,html:./cucumber-report.html
CUCUMBER_PROFILE_CI_PUBLISH=true
</code></pre>
<p>In fact, the <a href="https://github.com/cucumber/common/tree/main/config#readme">config</a> library does exactly this. We never ended up integrating it in Cucumber-JVM because other stuff got in the way, but maybe we could give it a go with a JavaScript implementation?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 04:48:40
[cucumber/cucumber-js] aurelien-reeves approved davidjgoss's pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 04:52:11
[cucumber/cucumber-js] Pull request merged by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 06:10:15
[cucumber/cucumber-js] Comment on #1711
<p><a href="https://github.com/aslakhellesoy">@aslakhellesoy</a> agree that would be awesome! I'll try and get a POC going for this proposal so we have something a bit more concrete to talk around, and would love to make profiles right as part of it (4.5 years and counting on <a href="https://github.com/cucumber/cucumber-js/issues/751">#751</a> 😄)</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 06:13:21
[cucumber/cucumber-js] Comment on #751
<p>Let's pick this up again. See <a href="https://github.com/cucumber/cucumber-js/issues/1711#issuecomment-871329827">#1711 (comment)</a> for some recent details. I'd love to have a JavaScript implementation of <a href="https://github.com/cucumber/common/tree/main/config#readme">config</a> for this! (<code>@cucumber/config</code> lib)</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 06:20:37
[cucumber/cucumber-js] Comment on #1709
<p>Looks good!</p>
<p>Is it ready for review?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 06:30:00
[cucumber/cucumber-js] Comment on #1711
<p>Refs. <a href="https://github.com/cucumber/cucumber-js/issues/1004">#1004</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 07:06:40
[cucumber/cucumber-js] Comment on #1136
<p>I am discovering that issue.</p>
<p>If I understand well, it is requested a new format options to disable step attachments?</p>
<p>Something like that:<br />
<code>--format-options '{"printStepAttachments": true|false}'</code> which would result into, if set to "false", the formatters not printing the attachments?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 09:26:28
[cucumber/cucumber-js] Pull request ready for review by charlierudolph
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 12:15:25
[cucumber/cucumber-js] Comment on #1453
<p>Sorry for the late reply <a href="https://github.com/jan-molak">@jan-molak</a>.</p>
<p>Having the original exception on the param for <code>After</code> and <code>AfterStep</code> makes sense to me.</p>
<p>I think we could do something with messages as well though. From what I've seen, JS assertion libraries are pretty consistent about having <code>actual</code> and <code>expected</code> properties on the error, so we <em>could</em> look for those and add their JSONified value to a message on a best effort basis. I'm not sure how straightforward this would be for other langs but it would enable things like showing a GitHub-style diff in the HTML formatter for an assertion error.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 12:17:59
[cucumber/cucumber-js] davidjgoss approved charlierudolph's pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 13:24:03
[cucumber/cucumber-js] Comment on #1711
<p>> This is a good point. Profiles (in their current form at least) are fundamentally coupled to the CLI so it feels right to keep them on that side of the boundary, but we could still expose a function to load them and generate a partial options object.</p>
<p>Yes, that would be awesome and much appreciated from the point of view of plugin creators.</p>
<p>> I would ❤️❤️❤️ to be able to specify profiles in a more generic format such as JSON, JavaScript, YAML or environment variables. In JSON it could look like this:</p>
<p>That sounds great! And is also exactly the reason I would appreciate an API to load them the same way as cucumberJS does. Loading a single <code>cucumber.js</code> file is trivial. Replicating a configuration file loading algorithm, including precedence, file format, etc AND maintaining it is something else entirely 😅.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 14:38:39
[cucumber/cucumber-js] Comment on #1453
<p>> Having the original exception on the param for After and AfterStep makes sense to me.</p>
<p>Fab, that would be of great help! Should I send you a PR?</p>
<p>> I think we could do something with messages as well though. From what I've seen, JS assertion libraries are pretty consistent about having actual and expected properties on the error, so we could look for those and add their JSONified value to a message on a best effort basis. I'm not sure how straightforward this would be for other langs but it would enable things like showing a GitHub-style diff in the HTML formatter for an assertion error.</p>
<p>Potentially, yeah. Serenity/JS <a href="https://github.com/serenity-js/serenity-js/blob/9763dd720d20278d91e79f332379dc63135eed04/packages/core/src/errors/AssertionError.ts"><code>AssertionError</code></a> also captures the <code>actual</code> and <code>expected</code>. We also capture the <code>cause</code>, and other libraries might have additional custom properties.<br />
Speaking of properties, <code>actual</code> and <code>expected</code> could be instances of objects, so serialisation of those would need to capture their type (i.e. <code>CustomerRecord</code> rather than <code>Object</code>). I think it can all get quite tricky.</p>
<p>🤔 But maybe it's the right thing to do to format the diff on the Cucumber side before creating a message. Maybe the issue is that the representation of the error in the message is trying to be two things at the same time - a stack trace and a diff. Maybe they should be represented in the message separately?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 17:10:29
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 17:10:42
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 17:12:54
[cucumber/cucumber-js] Comment on #1714
<p><a href="https://coveralls.io/builds/41024676">Coverage Status</a></p>
<p>Coverage remained the same at 98.515% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/f29e5078ad9383859a8e1533ef8ca5b403501d52">f29e507</a> on renovate/unit-test-packages</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/2b222f096596d1beea36cba4885bdedd85f745e3">2b222f0</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 17:15:22
[cucumber/cucumber-js] Comment on #1715
<p><a href="https://coveralls.io/builds/41024727">Coverage Status</a></p>
<p>Coverage remained the same at 98.515% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/3db076b5bb5f236b8e63c0037f6fd93c8a6271a5">3db076b</a> on renovate/node-14.x</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/2b222f096596d1beea36cba4885bdedd85f745e3">2b222f0</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 19:04:54
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Release Notes</strong>
Microsoft/TypeScript
<strong><a href="https://togithub.com/Microsoft/TypeScript/releases/v4.3.5"><code>v4.3.5</code></a></strong></p>
<p><a href="https://togithub.com/Microsoft/TypeScript/compare/v4.3.4...v4.3.5">Compare Source</a></p>
<p>This release contains a bug fix for auto-imports on JSX components in the TypeScript language service. <a href="https://togithub.com/microsoft/TypeScript/pull/44724">See the relevant change for more details</a>.</p>
<p><strong><a href="https://togithub.com/Microsoft/TypeScript/releases/v4.3.4"><code>v4.3.4</code></a></strong></p>
<p><a href="https://togithub.com/Microsoft/TypeScript/compare/v4.3.3...v4.3.4">Compare Source</a></p>
<p>This release</p>
<p>• adds an optional <code>getCustomTransformers</code> method to the <code>SolutionBuilderHost**</code> APIs
• uses the transforms given by <code>getCustomTransformers</code> in Builder Program instances when running <code>emit()</code> methods in cases where <code>customTransforms</code> are not given.</p>
<p><a href="https://togithub.com/microsoft/TypeScript/pull/44489">See the change for more details</a></p>
<p><strong><a href="https://togithub.com/Microsoft/TypeScript/releases/v4.3.3"><code>v4.3.3</code></a></strong></p>
<p><a href="https://togithub.com/Microsoft/TypeScript/compare/v4.3.2...v4.3.3">Compare Source</a></p>
<p>For release notes, check out the <a href="https://devblogs.microsoft.com/typescript/announcing-typescript-4-3">release announcement</a>.</p>
<p>For the complete list of fixed issues, check out the</p>
<p>• <https://togithub.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+4.3.0%22+is%3Aclosed+|fixed issues query for TypeScript v4.3.0 (Beta)>.
• <https://togithub.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+4.3.1%22+is%3Aclosed+|fixed issues query for TypeScript v4.3.1 (RC)>.
• <https://togithub.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+4.3.2%22+is%3Aclosed+|fixed issues query for TypeScript v4.3.2>.
• <https://togithub.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+4.3.2%22+is%3Aclosed+|fixed issues query for TypeScript v4.3.3>.</p>
<p>Downloads are available on:</p>
<p>• <a href="https://www.npmjs.com/package/typescript">npm</a>
• <a href="https://marketplace.visualstudio.com/items?itemName=TypeScriptTeam.TypeScript-43">Visual Studio 2017/2019</a> (<a href="https://togithub.com/Microsoft/TypeScript/wiki/Updating-TypeScript-in-Visual-Studio-2017">Select new version in project options</a>)
• <a href="https://www.nuget.org/packages/Microsoft.TypeScript.MSBuild">NuGet package</a></p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2958254205)
GitHub
2021-06-30 19:05:07
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>👻 <strong>Immortal</strong>: This PR will be recreated if closed unmerged. Get <a href="https://togithub.com/renovatebot/renovate/discussions">config help</a> if that's undesired.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 19:09:23
[cucumber/cucumber-js] Comment on #1716
<p><a href="https://coveralls.io/builds/41026833">Coverage Status</a></p>
<p>Coverage remained the same at 98.515% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/cb6e8fa30db1c770c8f79b00eddec6c02a7e900c">cb6e8fa</a> on renovate/typescript-4.x</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/2b222f096596d1beea36cba4885bdedd85f745e3">2b222f0</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 19:11:14
[cucumber/cucumber-js] Comment on #1717
<p><a href="https://coveralls.io/builds/41026871">Coverage Status</a></p>
<p>Coverage remained the same at 98.515% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/4a220539b628fe510dfa34c3a57fcb42dbf2a87d">4a22053</a> on renovate/cucumber-packages</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/2b222f096596d1beea36cba4885bdedd85f745e3">2b222f0</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 20:30:06
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Release Notes</strong>
typescript-eslint/typescript-eslint
<strong><a href="https://togithub.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md#%E2%80%8B4281-httpsgithubcomtypescript-eslinttypescript-eslintcomparev4280v4281-2021-06-28|<code">https://togithub.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md#%E2%80%8B4281-httpsgithubcomtypescript-eslinttypescript-eslintcomparev4280v4281-2021-06-28|<code</a>v4.28.1</code>></strong></p>
<p><a href="https://togithub.com/typescript-eslint/typescript-eslint/compare/v4.28.0...v4.28.1">Compare Source</a></p>
<p><strong>Note:</strong> Version bump only for package <a href="https://togithub.com/typescript-eslint/parser">@typescript-eslint/parser</a></p>
<p><strong><a href="https://togithub.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md#%E2%80%8B4280-httpsgithubcomtypescript-eslinttypescript-eslintcomparev4270v4280-2021-06-21|<code">https://togithub.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md#%E2%80%8B4280-httpsgithubcomtypescript-eslinttypescript-eslintcomparev4270v4280-2021-06-21|<code</a>v4.28.0</code>></strong></p>
<p><a href="https://togithub.com/typescript-eslint/typescript-eslint/compare/v4.27.0...v4.28.0">Compare Source</a></p>
<p><strong>Note:</strong> Version bump only for package <a href="https://togithub.com/typescript-eslint/parser">@typescript-eslint/parser</a></p>
<p><strong><a href="https://togithub.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md#%E2%80%8B4270-httpsgithubcomtypescript-eslinttypescript-eslintcomparev4261v4270-2021-06-14|<code">https://togithub.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md#%E2%80%8B4270-httpsgithubcomtypescript-eslinttypescript-eslintcomparev4261v4270-2021-06-14|<code</a>v4.27.0</code>></strong></p>
<p><a href="https://togithub.com/typescript-eslint/typescript-eslint/compare/v4.26.1...v4.27.0">Compare Source</a></p>
<p><strong>Bug Fixes</strong></p>
<p>• <strong>typescript-estree:</strong> allow providing more one than one existing program in config (<a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/3508">#3508</a>) (<a href="https://togithub.com/typescript-eslint/typescript-eslint/commit/4f1806e548affb7265da360d1fc8d033e25de325">4f1806e</a>)</p>
<p><strong>Features</strong></p>
<p>• allow user to provide TS program instance in parser options (<a href="https://togithub.com/typescript-eslint/typescript-eslint/issues/3484">#3484</a>) (<a href="https://togithub.com/typescript-eslint/typescript-eslint/commit/e855b18b8feee0edb5c617c11006861426a6f530">e855b18</a>)</p>
<p><strong><a href="https://togithub.com/typescript-eslint/typescript-eslint/compare/v4.26.0...v4.26.1">4.26.1</a> (2021-06-07)</strong></p>
<p><strong>Note:</strong> Version bump only for package <a href="https://togithub.com/typescript-eslint/parser">@typescript-eslint/parser</a></p>
<p><strong><a href="https://togithub.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md#%E2%80%8B4261-httpsgithubcomtypescript-eslinttypescript-eslintcomparev4260v4261-2021-06-07|<code">https://togithub.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md#%E2%80%8B4261-httpsgithubcomtypescript-eslinttypescript-eslintcomparev4260v4261-2021-06-07|<code</a>v4.26.1</code>></strong></p>
<p><a href="https://togithub.com/typescript-eslint/typescript-eslint/compare/v4.26.0...v4.26.1">Compare Source</a></p>
<p><strong>Note:</strong> Version bump only for package <a href="https://togithub.com/typescript-eslint/parser">@typescript-eslint/parser</a></p>
<p>eslint/eslint
<strong><a href="https://togithub.com/eslint/eslint/releases/v7.29.0"><code>v7.29.0</code></a></strong></p>
<p><a href="https://togithub.com/eslint/eslint/compare/v7.28.0...v7.29.0">Compare Source</a></p>
<p>• <a href="https://togithub.com/eslint/eslint/commit/bfbfe5c1fd4c39a06d5e159dbe48479ca4305fc0"><code>bfbfe5c</code></a> New: Add only to RuleTester (refs <a href="https://togithub.com/eslint/rfcs/issues/73">eslint/rfcs#73</a>) (<a href="https://togithub.com/eslint/eslint/issues/14677">#14677</a>) (Brandon Mills)
• <a href="https://togithub.com/eslint/eslint/commit/c2cd7b4a18057ca6067bdfc16de771dc5d90c0ea"><code>c2cd7b4</code></a> New: Add ESLint#getRulesMetaForResults() (refs <a href="https://togithub.com/eslint/eslint/issues/13654">#13654</a>) (<a href="https://togithub.com/eslint/eslint/issues/14716">#14716</a>) (Nicholas C. Zakas)
• <a href="https://togithub.com/eslint/eslint/commit/eea7e0d09d6ef43d6663cbe424e7974764a5f7fe"><code>eea7e0d</code></a> Chore: remove duplicate code (<a href="https://togithub.com/eslint/eslint/issues/14719">#14719</a>) (Nitin Kumar)
• <a href="https://togithub.com/eslint/eslint/commit/6a1c7a0dac050ea5876972c50563a7eb867b38d3"><code>6a1c7a0</code></a> Fix: allow fallthrough comment inside block (fixes <a href="https://togithub.com/eslint/eslint/issues/14701">#14701</a>) (<a href="https://togithub.com/eslint/eslint/issues/14702">#14702</a>) (Kevin Gibbons)
• <a href="https://togithub.com/eslint/eslint/commit/a47e5e30b0da364593b6881f6826c595da8696f5"><code>a47e5e3</code></a> Docs: Add Mega-Linter to the list of integrations (<a href="https://togithub.com/eslint/eslint/issues/14707">#14707</a>) (Nicolas Vuillamy)
• <a href="https://togithub.com/eslint/eslint/commit/353ddf965078030794419b089994373e27ffc86e"><code>353ddf9</code></a> Chore: enable reportUnusedDisableDirectives in eslint-config-eslint (<a href="https://togithub.com/eslint/eslint/issues/14699">#14699</a>) (薛定谔的猫)
• <a href="https://togithub.com/eslint/eslint/commit/757c49584a5852c468c1b4a0b74ad3aa39d954e5"><code>757c495</code></a> Chore: add some rules to eslint-config-eslint (<a href="https://togithub.com/eslint/eslint/issues/14692">#14692</a>) (薛定谔的猫)
• <a href="https://togithub.com/eslint/eslint/commit/c93a222563177a9b5bc7a59aa106bc0a6d31e063"><code>c93a222</code></a> Docs: fix a broken link (<a href="https://togithub.com/eslint/eslint/issues/14697">#14697</a>) (Sam Chen)
• <a href="https://togithub.com/eslint/eslint/commit/655c1187fc845bac61ae8d06c556f1a59ee2071b"><code>655c118</code></a> Sponsors: Sync README with website (ESLint Jenkins)
• <a href="https://togithub.com/eslint/eslint/commit/e2bed2ead22b575d55ccaeed94eecd3a979dd871"><code>e2bed2e</code></a> Sponsors: Sync README with website (ESLint Jenkins)
• <a href="https://togithub.com/eslint/eslint/commit/8490fb42e559ef0b3c34ac60be4e05e0d879a9cb"><code>8490fb4</code></a> Sponsors: Sync README with website (ESLint Jenkins)
• <a href="https://togithub.com/eslint/eslint/commit/ddbe877c95224e127215d35562a175c6f2b7ba22"><code>ddbe877</code></a> Sponsors: Sync README with website (ESLint Jenkins)</p>
<p><strong><a href="https://togithub.com/eslint/eslint/releases/v7.28.0"><code>v7.28.0</code></a></strong></p>
<p><a href="https://togithub.com/eslint/eslint/compare/v7.27.0...v7.28.0">Compare Source</a></p>
<p>• <a href="https://togithub.com/eslint/eslint/commit/1237705dd08c209c5e3136045ec51a4ba87a3abe"><code>1237705</code></a> Upgrade: <a href="https://togithub.com/eslint/eslintrc">@eslint/eslintrc</a> to 0.4.2 (<a href="https://togithub.com/eslint/eslint/issues/14672">#14672</a>) (Milos Djermanovic)
• <a href="https://togithub.com/eslint/eslint/commit/123fb8648731c2c23313c544ffa1872d3024fe68"><code>123fb86</code></a> Docs: Add Feedback Needed triage description (<a href="https://togithub.com/eslint/eslint/issues/14670">#14670</a>) (Nicholas C. Zakas)
• <a href="https://togithub.com/eslint/eslint/commit/c5451635b4e89827cfc8d8d77083647c74506e42"><code>c545163</code></a> Update: support multiline /<em>eslint-env</em>/ directives (fixes <a href="https://togithub.com/eslint/eslint/issues/14652">#14652</a>) (<a href="https://togithub.com/eslint/eslint/issues/14660">#14660</a>) (薛定谔的猫)
• <a href="https://togithub.com/eslint/eslint/commit/8d1e75a31b3e3d67130709a219bdd07ce6f3cf74"><code>8d1e75a</code></a> Upgrade: glob-parent version in package.json (<a href="https://togithub.com/eslint/eslint/issues/14658">#14658</a>) (Hamza Najeeb)
• <a href="https://togithub.com/eslint/eslint/commit/1f048cb0eec660d2052f1758f4b2ad7b1cb424e1"><code>1f048cb</code></a> Fix: no-implicit-coercion false positive with <code>String()</code> (fixes <a href="https://togithub.com/eslint/eslint/issues/14623">#14623</a>) (<a href="https://togithub.com/eslint/eslint/issues/14641">#14641</a>) (Milos Djermanovic)
• <a href="https://togithub.com/eslint/eslint/commit/d709abfdde087325d4578b6709dc61040b8ca9d8"><code>d709abf</code></a> Chore: fix comment location in no-unused-vars (<a href="https://togithub.com/eslint/eslint/issues/14648">#14648</a>) (Milos Djermanovic)
• <a href="https://togithub.com/eslint/eslint/commit/e44ce0a8acfaad513c385150c25e76e82a1b8f12"><code>e44ce0a</code></a> Fix: no-duplicate-imports allow unmergeable (fixes <a href="https://togithub.com/eslint/eslint/issues/12758">#12758</a>, fixes <a href="https://togithub.com/eslint/eslint/issues/12760">#12760</a>) (<a href="https://togithub.com/eslint/eslint/issues/14238">#14238</a>) (Soufiane Boutahlil)
• <a href="https://togithub.com/eslint/eslint/commit/bb66a3d91af426dac9a7ffdbe47bdbbc0ffd4dd7"><code>bb66a3d</code></a> New: add <code>getPhysicalFilename()</code> method to rule context (fixes <a href="https://togithub.com/eslint/eslint/issues/11989">#11989</a>) (<a href="https://togithub.com/eslint/eslint/issues/14616">#14616</a>) (Nitin Kumar)
• <a href="https://togithub.com/eslint/eslint/commit/2e43dacd24337a82d4184fac9b44d497675f46ef"><code>2e43dac</code></a> Docs: fix <code>no-sequences</code> example (<a href="https://togithub.com/eslint/eslint/issues/14643">#14643</a>) (Nitin Kumar)
• <a href="https://togithub.com/eslint/eslint/commit/958ff4e8a5102f204f1484d09985e28a79790996"><code>958ff4e</code></a> Docs: add note for arrow functions in no-seq rule (<a href="https://togithub.com/eslint/eslint/issues/14578">#14578</a>) (Nitin Kumar)
• <a href="https://togithub.com/eslint/eslint/commit/e4f111b67d114adbf76a9c9dbb18fa4f49bc91b6"><code>e4f111b</code></a> Fix: arrow-body-style crash with obj…</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 16.x)
(https://github.com/cucumber/cucumber-js/runs/2958786186)
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2958786154)
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2958786128)
GitHub Actions: test (windows-latest, 16.x)
(https://github.com/cucumber/cucumber-js/runs/2958785903)
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2958785871)
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2958785841)
GitHub
2021-06-30 20:30:20
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<https://github.com/cucumber/cucumber-js/pull/1719|#1719 chore(deps): update dependency mocha to v9>
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Release Notes</strong>
mochajs/mocha
<strong><a href="https://togithub.com/mochajs/mocha/blob/master/CHANGELOG.md#%E2%80%8B901--2021-06-18|<code">https://togithub.com/mochajs/mocha/blob/master/CHANGELOG.md#%E2%80%8B901--2021-06-18|<code</a>v9.0.1</code>></strong></p>
<p><a href="https://togithub.com/mochajs/mocha/compare/v9.0.0...v9.0.1">Compare Source</a></p>
<p><strong>🔩 Other</strong></p>
<p>• <a href="https://togithub.com/mochajs/mocha/issues/4657">#4657</a>: Browser: add separate bundle for modern browsers (<a href="https://togithub.com/juergba"><strong>@juergba</strong></a>)</p>
<p>We added a separate browser bundle <code>mocha-es2018.js</code> in javascript ES2018, as we skipped the transpilation down to ES5. This is an <strong>experimental step towards freezing Mocha's support of IE11</strong>.</p>
<p>• <a href="https://togithub.com/mochajs/mocha/issues/4653">#4653</a>: ESM: proper version check in <code>hasStableEsmImplementation</code> (<a href="https://togithub.com/alexander-fenster"><strong>@alexander-fenster</strong></a>)</p>
<p><strong><a href="https://togithub.com/mochajs/mocha/blob/master/CHANGELOG.md#%E2%80%8B900--2021-06-07|<code">https://togithub.com/mochajs/mocha/blob/master/CHANGELOG.md#%E2%80%8B900--2021-06-07|<code</a>v9.0.0</code>></strong></p>
<p><a href="https://togithub.com/mochajs/mocha/compare/v8.4.0...v9.0.0">Compare Source</a></p>
<p><strong>💥 Breaking Changes</strong></p>
<p>• <a href="https://togithub.com/mochajs/mocha/issues/4633">#4633</a>: <strong>Drop Node.js v10.x support</strong> (<a href="https://togithub.com/juergba"><strong>@juergba</strong></a>)
• <a href="https://togithub.com/mochajs/mocha/issues/4635">#4635</a>: <code>import</code>-first loading of test files (<a href="https://togithub.com/giltayar"><strong>@giltayar</strong></a>)</p>
<p><strong>Mocha is going ESM-first!</strong> This means that it will now use ESM <code>import(test_file)</code> to load the test files, instead of the CommonJS <code>require(test_file)</code>. This is not a problem, as <code>import</code> can also load most files that <code>require</code> does. In the rare cases where this fails, it will fallback to <code>require(...)</code>. This ESM-first approach is the next step in Mocha's ESM migration, and allows ESM loaders to load and transform the test file.</p>
<p>• <a href="https://togithub.com/mochajs/mocha/issues/4636">#4636</a>: Remove deprecated <code>utils.lookupFiles()</code> (<a href="https://togithub.com/juergba"><strong>@juergba</strong></a>)
• <a href="https://togithub.com/mochajs/mocha/issues/4638">#4638</a>: Limit the size of <code>actual</code>/<code>expected</code> for <code>diff</code> generation (<a href="https://togithub.com/juergba"><strong>@juergba</strong></a>)
• <a href="https://togithub.com/mochajs/mocha/issues/4389">#4389</a>: Refactoring: Consuming log-symbols alternate to code for win32 in reporters/base (<a href="https://togithub.com/MoonSupport"><strong>@MoonSupport</strong></a>)</p>
<p><strong>🎉 Enhancements</strong></p>
<p>• <a href="https://togithub.com/mochajs/mocha/issues/4640">#4640</a>: Add new option <code>--dry-run</code> (<a href="https://togithub.com/juergba"><strong>@juergba</strong></a>)</p>
<p><strong>🐛 Fixes</strong></p>
<p>• <a href="https://togithub.com/mochajs/mocha/issues/4128">#4128</a>: Fix: control stringification of error message (<a href="https://togithub.com/syeutyu"><strong>@syeutyu</strong></a>)</p>
<p><strong>🔩 Other</strong></p>
<p>• <a href="https://togithub.com/mochajs/mocha/issues/4646">#4646</a>: Deprecate <code>Runner(suite: Suite, delay: boolean)</code> signature (<a href="https://togithub.com/juergba"><strong>@juergba</strong></a>)
• <a href="https://togithub.com/mochajs/mocha/issues/4643">#4643</a>: Update production dependencies (<a href="https://togithub.com/juergba"><strong>@juergba</strong></a>)</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Disabled by config. Please merge this manually once you are satisfied.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 16.x)
(https://github.com/cucumber/cucumber-js/runs/2958786969)
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2958786952)
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2958786933)
GitHub Actions: test (ubuntu-latest, 16.x)
(https://github.com/cucumber/cucumber-js/runs/2958786919)
GitHub Actions: test (ubuntu-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2958786907)
GitHub Actions: test (ubuntu-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2958786889)
GitHub Actions: test (windows-latest, 16.x)
(https://github.com/cucumber/cucumber-js/runs/2958786822)
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2958786811)
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2958786789)
GitHub Actions: test (ubuntu-latest, 16.x)
(https://github.com/cucumber/cucumber-js/runs/2958786784)
GitHub Actions: test (ubuntu-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2958786758)
GitHub
2021-06-30 20:32:37
[cucumber/cucumber-js] Comment on #1718
<p><a href="https://coveralls.io/builds/41028995">Coverage Status</a></p>
<p>Coverage remained the same at 98.468% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/c8d01173bf2d784a1955d145624ef09f9fb93228">c8d0117</a> on renovate/eslint-packages</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/a3aab754155c1c01730338979b586dc644899d23">a3aab75</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 20:34:42
[cucumber/cucumber-js] Comment on #1719
<p><a href="https://coveralls.io/builds/41029036">Coverage Status</a></p>
<p>Coverage remained the same at 98.468% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/7673234800da51012dffa92f31fdd501b54590ea">7673234</a> on renovate/major-unit-test-packages</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/a3aab754155c1c01730338979b586dc644899d23">a3aab75</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 20:46:33
[cucumber/cucumber-js] Pull request merged by charlierudolph
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-06-30 21:20:48
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Release Notes</strong>
tj/commander.js
<strong><a href="https://togithub.com/tj/commander.js/blob/master/CHANGELOG.md#%E2%80%8B800-2021-06-25|<code">https://togithub.com/tj/commander.js/blob/master/CHANGELOG.md#%E2%80%8B800-2021-06-25|<code</a>v8.0.0</code>></strong></p>
<p><a href="https://togithub.com/tj/commander.js/compare/v7.2.0...v8.0.0">Compare Source</a></p>
<p><strong>Added</strong></p>
<p>• <code>.argument(name, description)</code> for adding command-arguments ([<a href="https://togithub.com/tj/commander.js/issues/1490">#1490</a>])
• supports default value for optional command-arguments ([<a href="https://togithub.com/tj/commander.js/issues/1508">#1508</a>])
• supports custom processing function ([<a href="https://togithub.com/tj/commander.js/issues/1508">#1508</a>])
• <code>.createArgument()</code> factory method ([<a href="https://togithub.com/tj/commander.js/issues/1497">#1497</a>])
• <code>.addArgument()</code> ([<a href="https://togithub.com/tj/commander.js/issues/1490">#1490</a>])
• <code>Argument</code> supports <code>.choices()</code> ([<a href="https://togithub.com/tj/commander.js/issues/1525">#1525</a>])
• <code>.showHelpAfterError()</code> to display full help or a custom message after an error ([<a href="https://togithub.com/tj/commander.js/issues/1534">#1534</a>])
• <code>.hook()</code> with support for <code>'preAction'</code> and <code>'postAction'</code> callbacks ([<a href="https://togithub.com/tj/commander.js/issues/1514">#1514</a>])
• client typing of <code>.opts()</code> return type using TypeScript generics ([<a href="https://togithub.com/tj/commander.js/issues/1539">#1539</a>])
• the number of command-arguments is checked for programs without an action handler ([<a href="https://togithub.com/tj/commander.js/issues/1502">#1502</a>])
• <code>.getOptionValue()</code> and <code>.setOptionValue()</code> ([<a href="https://togithub.com/tj/commander.js/issues/1521">#1521</a>])</p>
<p><strong>Changed</strong></p>
<p>• refactor and simplify TypeScript declarations (with no default export) ([<a href="https://togithub.com/tj/commander.js/issues/1520">#1520</a>])
• <code>.parseAsync()</code> is now declared as <code>async</code> ([<a href="https://togithub.com/tj/commander.js/issues/1513">#1513</a>])
• <em>Breaking:</em> <code>Help</code> method <code>.visibleArguments()</code> returns array of <code>Argument</code> ([<a href="https://togithub.com/tj/commander.js/issues/1490">#1490</a>])
• <em>Breaking:</em> Commander 8 requires Node.js 12 or higher ([<a href="https://togithub.com/tj/commander.js/issues/1500">#1500</a>])
• <em>Breaking:</em> <code>CommanderError</code> code <code>commander.invalidOptionArgument</code> renamed <code>commander.invalidArgument</code> ([<a href="https://togithub.com/tj/commander.js/issues/1508">#1508</a>])
• <em>Breaking:</em> TypeScript declaration for <code>.addTextHelp()</code> callback no longer allows result of <code>undefined</code>, now just <code>string</code> ([<a href="https://togithub.com/tj/commander.js/issues/1516">#1516</a>])
• refactor <code>index.tab</code> into a file per class ([<a href="https://togithub.com/tj/commander.js/issues/1522">#1522</a>])
• remove help suggestion from "unknown command" error message (see <code>.showHelpAfteError()</code>) ([<a href="https://togithub.com/tj/commander.js/issues/1534">#1534</a>])
• <code>Command</code> property <code>.arg</code> initialised to empty array (was previously undefined) ([<a href="https://togithub.com/tj/commander.js/issues/1529">#1529</a>])
• update dependencies</p>
<p><strong>Deprecated</strong></p>
<p>• second parameter of <code>cmd.description(desc, argDescriptions)</code> for adding argument descriptions ([<a href="https://togithub.com/tj/commander.js/issues/1490">#1490</a>])
• (use new <code>.argument(name, description)</code> instead)
• <code>InvalidOptionArgumentError</code> (replaced by <code>InvalidArgumentError</code>) ([<a href="https://togithub.com/tj/commander.js/issues/1508">#1508</a>])</p>
<p><strong>Removed</strong></p>
<p>• <em>Breaking:</em> TypeScript declaration for default export of global <code>Command</code> object ([<a href="https://togithub.com/tj/commander.js/issues/1520">#1520</a>])
• (still available as named <code>program</code> export)</p>
<p><strong>Migration Tips</strong></p>
<p>If you have a simple program without an action handler, you will now get an error if<br />
there are missing command-arguments.</p>
<pre><code>program
.option('-d, --debug')
.arguments('&lt;file&gt;');
program.parse();
</code></pre>
<pre><code>$ node trivial.js
error: missing required argument 'file'
</code></pre>
<p>If you want to show the help in this situation, you could check the arguments before parsing:</p>
<pre><code>if (process.argv.length === 2)
<a href="http://program.help">program.help</a>();
program.parse();
</code></pre>
<p>Or, you might choose to show the help after any user error:</p>
<pre><code>program.showHelpAfterError();
</code></pre>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Disabled by config. Please merge this manually once you are satisfied.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 16.x)
(https://github.com/cucumber/cucumber-js/runs/2958949846)
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2958949836)
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2958949816)
GitHub Actions: test (ubuntu-latest, 16.x)
(https://github.com/cucumber/cucumber-js/runs/2958949795)
GitHub Actions: test (ubuntu-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2958949774)
GitHub Actions: test (ubuntu-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2958949740)
GitHub Actions: test (windows-latest, 16.x)
(https://github.com/cucumber/cucumber-js/runs/2958949558)
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2958949532)
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2958949497)
GitHub Actions: test (ubuntu-latest, 16.x)
(https://github.com/cucumber/cucumber-js/runs/2958949476)
GitHub Actions: test (ubuntu-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/2958949447)
GitHub Actions: test (ubuntu-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/2958949407)
GitHub
2021-06-30 21:23:19
[cucumber/cucumber-js] Comment on #1720
<p><a href="https://coveralls.io/builds/41029537">Coverage Status</a></p>
<p>Coverage remained the same at 98.468% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/23d5b88b460394f55c888a0804023de8c0f140e0">23d5b88</a> on renovate/commander-8.x</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/a3aab754155c1c01730338979b586dc644899d23">a3aab75</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-01 00:35:10
[cucumber/cucumber-js] Pull request merged by aurelien-reeves
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-01 00:45:35
[cucumber/cucumber-js] Pull request merged by aurelien-reeves
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-01 01:04:11
[cucumber/cucumber-js] Pull request merged by aurelien-reeves
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-01 01:49:56
[cucumber/cucumber-js] Pull request merged by aurelien-reeves
<https://github.com/cucumber/cucumber-js/pull/1719|#1719 chore(deps): update dependency mocha to v9>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-01 02:00:45
[cucumber/cucumber-js] Pull request merged by aurelien-reeves
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-01 02:21:16
[cucumber/cucumber-js] Pull request merged by aurelien-reeves
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-01 03:09:46
[cucumber/cucumber-js] Pull request opened by aurelien-reeves
<p><strong>Description</strong></p>
<p>Refs. <a href="https://github.com/cucumber/cucumber-js/issues/1136">#1136</a></p>
<p>I've added a scenario to show a new <code>--format-options</code> that would let the possibility to opt-out from the attachments being printed when a scenario is not successful.</p>
<p>That option is named <code>printStepAttachments</code> and is presumably true per default.</p>
<p>If the fix is not too complex, I plan to use this PR as a step-by-step tutorial for new contributors.</p>
<p><strong>Motivation & context</strong></p>
<p>Fixes <a href="https://github.com/cucumber/cucumber-js/issues/1136">#1136</a><br />
May be a good opportunity for a "first new contribution" tutorial</p>
<p><strong>Type of change</strong></p>
<p>• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds new behaviour)</p>
<p><strong>Checklist:</strong></p>
<p>☐ My code follows the code style of this project.
☐ I have updated the documentation accordingly.
☐ I have read the <../CONTRIBUTING.md|<strong>CONTRIBUTING</strong>> document.
☐ I have added tests to cover my changes.
☐ All new and existing tests passed.
☐ CHANGELOG has been updated</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-01 03:18:27
[cucumber/cucumber-js] Pull request merged by aurelien-reeves
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-01 03:47:25
[cucumber/cucumber-js] Comment on #1721
<p>> That option is named <code>printStepAttachments</code> and is presumably true per default.</p>
<p>Given you can attach from hooks and these are also printed:</p>
<p><a href="https://user-images.githubusercontent.com/3192745/124108043-be08e600-da5d-11eb-8cdd-1082d88bfc29.png">image</a></p>
<p>Potentially just <code>printAttachments</code> is a better name?</p>
<p>> If the fix is not too complex, I plan to use this PR as a step-by-step tutorial for new contributors.</p>
<p>That sounds really good!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-01 06:08:38
[cucumber/cucumber-js] Comment on #1649
<p><a href="https://coveralls.io/builds/41043909">Coverage Status</a></p>
<p>Coverage increased (+0.02%) to 98.483% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/16e4f2f1b382c3f4cbae31cff4731bde5f8fdbd7">16e4f2f</a> on esm-take-2</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/d5daabd965915f10e292993cea65d6e6beac07ea">d5daabd</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-01 06:26:34
[cucumber/cucumber-js] Comment on #1649
<p>Thanks for the pointer <a href="https://github.com/TheLudd">@TheLudd</a> - a combination of subpath exports and <a href="https://github.com/nodejs/node/pull/34718">export patterns</a> gets it done:</p>
<pre><code>{
"exports": {
".": {
"import": "./lib/wrapper.mjs",
"require": "./lib/index.js"
},
"./lib/**": {
"require": "./lib/**.js"
}
},
}
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-01 07:54:50
[cucumber/cucumber-js] Comment on #1453
<p>> > Having the original exception on the param for After and AfterStep makes sense to me.
>
> Fab, that would be of great help! Should I send you a PR?</p>
<p>Go ahead!</p>
<p>The potential messages change for more granular info on a failed result is now raised under <a href="https://github.com/cucumber/common/issues/1638">cucumber/common#1638</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-01 09:28:47
[cucumber/cucumber-js] Pull request ready for review by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-01 09:29:42
[cucumber/cucumber-js] Comment on #1649
<p><a href="https://github.com/charlierudolph">@charlierudolph</a> <a href="https://github.com/aurelien-reeves">@aurelien-reeves</a> with the fix for deep imports in commonjs this is good to go now.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-01 11:42:38
[cucumber/cucumber-js] Comment on #1649
<p>We dropped Node 10 support, so, is the following still required?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-01 11:42:39
[cucumber/cucumber-js] aurelien-reeves commented on davidjgoss's pull request
<p>This is really great, well done! 👍</p>
<p>We may have to add an entry in the changelog for bringing back esm support</p>
<p>And, the esm.md is a good idea 👍<br />
Could we add some code examples in it?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-01 11:52:29
[cucumber/cucumber-js] Comment on #1649
<p>Ah good point, I need to update this comment.</p>
<p>We still need to support the commonjs path unfortunately because of transpilers that people use via <code>--require-module</code> - for example with TypeScript, ts-node has <a href="https://github.com/TypeStrong/ts-node/issues/1007">only early experimental support</a> for handling <code>import()</code> (this is why the features in cucumber-js itself didn't work when I tried this).</p>
<p>So I think it's safest to still default to <code>require()</code> for now and have <code>import()</code> be opt-in via the <code>--esm</code> flag.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-01 15:35:38
[cucumber/cucumber-js] Comment on #1707
<p>Ah that makes sense! I have opened an issue on the Serenity/JS repo here: <a href="https://github.com/serenity-js/serenity-js/issues/894">serenity-js/serenity-js#894</a></p>
<p>Thanks for the insight.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-02 00:39:17
[cucumber/cucumber-js] Comment on #1707
<p>No problem!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-02 00:39:17
[cucumber/cucumber-js] Issue closed by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-02 01:46:31
[cucumber/cucumber-js] Comment on #1711
<p>Q: Would I be able to run <code>runCucumber</code> twice in succession <em>without clearing the <a href="https://nodejs.org/api/modules.html#modules_require_cache">require cache</a></em>? This is important for the mutation testing use case.</p>
<p>We want to load the environment and run the tests multiple times in quick succession while changing a global variable in order to switch the active mutant.</p>
<p>Right now, we're <a href="https://github.com/stryker-mutator/stryker-js/pull/2970">using the <code>cli</code> private API</a> and we need to clear the step definition files from the <code>require.cache</code> between each test run. This is not ideal for CommonJS and won't work at all for esm.</p>
<p>Pseudo code of our use case:</p>
<pre><code>const profiles = await loadProfiles();
const options = {
...profiles.default,
formatter: require.resolve('./our-awesomely-crafted-formatter'),
some: 'other options we want to override',
}
const cucumber = new Cucumber(options);
// Allow cucumber to load the step definitions once.
// This is `async`, so support for esm can be added without a breaking change
await cucumber.initialize();
// Initial test run ("dry run"), without mutants active
await cucumber.run();
collectMutantCoveragePerTestFromFormatter();
// Start mutation testing:
global.activeMutant = 1;
await cucumber.run({ features: ['features/a.feature:24']);
collectResultsFromFormatterToDetermineKilledOrSurvivedMutant()
global.activeMutant = 2;
await cucumber.run({ features: ['features/b.feature:24:25:26', 'features/c.feature:12']);
collectResultsFromFormatterToDetermineKilledOrSurvivedMutant()
// etc
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-02 02:03:09
[cucumber/cucumber-js] Comment on #1711
<p><a href="https://github.com/nicojs">@nicojs</a> definitely agree we need this, it's come up a few times before with e.g. people wanting to run cucumber in a lambda, and I'd also like to add an interactive mode which would need it too.</p>
<p>What I had sketched out so far was in more of a functional style but same fundamental concept I think:</p>
<pre><code>const runnerOptions = {
support: {
require: ['features/support/****/**.js']
}
}
// initial run returns support code library
const { support } = await runCucumber(runnerOptions)
// subsequent run reuses support code library
await runCucumber({
...runnerOptions,
support
})
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-02 02:12:54
[cucumber/cucumber-js] Comment on #1710
<p>Going to close this as we're having a good discussion over on <a href="https://github.com/cucumber/cucumber-js/issues/1711">#1711</a> about a new API to solve this need.</p>
<p>I'll just add that the intent is to leave the <code>Cli</code> class working the way it is in 8.0.0, even though it's not on the public API, to give developers time to switch to the new API and iron out any issues there.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-02 02:12:54
[cucumber/cucumber-js] Issue closed by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-02 04:52:35
[cucumber/cucumber-js] Comment on #1649
<p>Alternatively, we could use <code>import()</code> for loading all user code <em>except</em> for requiring support files where <code>--require-module</code> is set (meaning <code>ts-node</code> or <code>babel</code> is in play) and/or the file uses <code>.cjs</code> extension in which case we fall back to <code>require</code>.</p>
<p>I think that's better actually, I'll run it up and see what happens.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-02 04:52:59
[cucumber/cucumber-js] Comment on #1649
<p>> And, the esm.md is a good idea 👍 Could we add some code examples in it</p>
<p>Good point, I've added example code now.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-02 07:36:04
[cucumber/cucumber-js] Comment on #1711
<p>That works for us 👍</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-02 15:03:46
[cucumber/cucumber-js] Comment on #1711
<p>Works for us too 👍:skin<em>tone</em>2:</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-04 01:56:23
[cucumber/cucumber-js] Comment on #751
<p><a href="https://github.com/aslakhellesoy">@aslakhellesoy</a> sounds good, I'll try and do this in conjunction with <a href="https://github.com/cucumber/cucumber-js/issues/1711">#1711</a>.</p>
<p>I think it would make sense to keep this new thing separate from the existing <code>cucumber.js</code> file which would then become deprecated. It'd be good to move away from <code>default</code> as a key on <code>module.exports</code> - it's thrown up some issues when trying to switch to loading with <code>await import()</code> in <a href="https://github.com/cucumber/cucumber-js/pull/1649">#1649</a> (I'm now descoping the config file from that change).</p>
<p>On the naming of the files, what do we think about the unix-esque convention used by mocha, eslint etc:</p>
<pre><code>.cucumberrc.json
.cucumberrc.yml
.cucumberrc.js
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-05 05:44:17
[cucumber/cucumber-js] Comment on #1711
<p>I believe something like this would be very useful as an alternative for the mess we have today with testing tool integrations (Jest, Cypress), for example:</p>
<p>• <code>jest-cucumber</code> is not as convenient as <code>jest-cucumber-fusion</code>
• there's also <code>cucumber-jest</code>...
• <code>jest-cucumber</code> does not support Cucumber JSON reporting (<a href="https://github.com/bencompton/jest-cucumber/issues/27">bencompton/jest-cucumber#27</a>)
• <code>cypress-cucumber-preprocessor</code> generates multiple Cucumber JSON reports with no offical support for aggregation (<a href="https://github.com/TheBrainFamily/cypress-cucumber-preprocessor/issues/423">TheBrainFamily/cypress-cucumber-preprocessor#423</a>)</p>
<p>I would rather see some minimal glue code between Jest/Karma/Cypress/etc. and cucumber-js so I don't have to suffer for all those missing features I need to use.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-05 10:59:10
[cucumber/cucumber-js] Comment on #1711
<p>Great suggestion <a href="https://github.com/davidjgoss">@davidjgoss</a> 👍</p>
<p>This separation of concerns between the command-line user interface and the "business logic" of parsing and executing scenarios as tests reminds me of the <a href="https://alistair.cockburn.us/hexagonal-architecture/">hexagonal architecture</a> pattern.</p>
<p>In cucumber-ruby we actually split the core domain logic (or "inner hexagon") into a separate gem package, as we were rebuilding it from scratch in a "clean room". I realise that's not the context here, but it might be worth drawing some inspiration from, or feeding back innovations from this design into the Ruby API. There's <a href="https://github.com/cucumber/cucumber-ruby-core#example">an example</a> in the cucumber-ruby-core gem's README of how to use that API.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-06 05:04:12
[cucumber/cucumber-js] Comment on commit "chore: remove redundant profile config"
<p><a href="https://github.com/davidjgoss">@davidjgoss</a>, just curious, what makes <code>htmlFormatter</code> redundant? Thanks!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-06 11:33:43
[cucumber/cucumber-js] Comment on commit "chore: remove redundant profile config"
<p><a href="https://github.com/ddsultan">@ddsultan</a> nothing don't worry! This particular config was redundant because it's not been used to test any more. We do include the html formatter in the <code>feature-test</code> run we do as part of the build for this project and it's definitely fully supported.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-07 01:13:12
[cucumber/cucumber-js] Comment on #1136
<p>It could also be an option in the <code>attach</code> function.<br />
At the time, the function can have two arguments:</p>
<pre><code>this.attach('Some info.') // Simple text
this.attach('{"some", "JSON"}}', 'application/json') // Typed data
</code></pre>
<p>Why not using the 2nd argument as a map of options (and keep backward compatibility for string param)</p>
<pre><code>this.attach('{"some", "JSON"}}', {
mime: 'application/json',
print: false, // This would disable logging attachments
})
</code></pre>
<p>That way, we could mix print and hidden attachements on the same run.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-07 01:18:17
[cucumber/cucumber-js] Pull request opened by aurelien-reeves
<p><strong>Description</strong></p>
<p>Addition of a tagged template literal to avoid messing with indentation in test files.</p>
<p>Before:</p>
<pre><code> // Assert
expect(output).to.eql(`\
┌────────────────┬──────────┬───────────────────┐
│ Pattern / Text │ Duration │ Location │
├────────────────┼──────────┼───────────────────┤
│ abc │ UNUSED │ usage_steps.ts:11 │
├────────────────┼──────────┼───────────────────┤
│ /def?/ │ UNUSED │ usage_steps.ts:16 │
├────────────────┼──────────┼───────────────────┤
│ ghi │ UNUSED │ usage_steps.ts:25 │
└────────────────┴──────────┴───────────────────┘
`)
</code></pre>
<p>After:</p>
<pre><code> // Assert
expect(output).to.eql(unindent`
┌────────────────┬──────────┬───────────────────┐
│ Pattern / Text │ Duration │ Location │
├────────────────┼──────────┼───────────────────┤
│ abc │ UNUSED │ usage_steps.ts:11 │
├────────────────┼──────────┼───────────────────┤
│ /def?/ │ UNUSED │ usage_steps.ts:16 │
├────────────────┼──────────┼───────────────────┤
│ ghi │ UNUSED │ usage_steps.ts:25 │
└────────────────┴──────────┴───────────────────┘
`)
</code></pre>
<p><strong>Motivation & context</strong></p>
<p>Indentation is important for readability.<br />
Preserving it in the flow of the source file helps a lot reading and writing those files.</p>
<p>While I try to write kinda tutorial on how to contribute to the code, I was annoyed to explain why some tests had to have some unindented stuff 😅</p>
<p><strong>Type of change</strong></p>
<p>• Refactoring/debt (improvement to code design or tooling without changing behaviour)</p>
<p><strong>Note to other contributors</strong></p>
<p>I have added some JSDoc to provide a sample of usage through VSCode and other IDEs.<br />
We may consider documenting the code for this purpose.<br />
But if other contributors disagree, we can just remove that one and forget about that.</p>
<p><a href="https://user-images.githubusercontent.com/24386780/124724592-69a5b080-df0c-11eb-9f56-a0a4b6841e92.png">image</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-07 01:20:36
[cucumber/cucumber-js] Comment on #1722
<p><a href="https://coveralls.io/builds/41173928">Coverage Status</a></p>
<p>Coverage remained the same at 98.468% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/b5540d164943fbb13184b00b02e65f8e529e7d35">b5540d1</a> on add-helper-to-unindent-templates</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/49c87962431788c2b01ae89734b7e33c881ae97b">49c8796</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-07 01:35:05
[cucumber/cucumber-js] Comment on #1136
<p>> It could also be an option in the <code>attach</code> function.<br />
> At the time, the function can have two arguments:
>
> <code>
&gt; this.attach('Some info.') // Simple text
&gt; this.attach('{"some", "JSON"}}', 'application/json') // Typed data
&gt;</code>
>
> Why not using the 2nd argument as a map of options (and keep backward compatibility for string param)
>
> <code>
&gt; this.attach('{"some", "JSON"}}', {
&gt; mime: 'application/json',
&gt; print: false, // This would disable logging attachments
&gt; })
&gt;</code>
>
> That way, we could mix print and hidden attachements on the same run.</p>
<p>That is interesting</p>
<p>I am more puzzled about it.</p>
<p>Why would we attach some data to not print those ?<br />
If we don't want to print it, may we just avoid attaching it?</p>
<p>That may also lead in big reports embedding a lot of invisible attached data because it would be less easy to notice that some attachments are not printed out.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-07 02:28:15
[cucumber/cucumber-js] Comment on #1136
<p>Yes, the purpose of attachments is to store information during the scenario run for two use cases:</p>
<p>• used by the user to export data
• used temporarily by cucumber to pass information to the formatter</p>
<p>The <code>log</code> function may be a better place to work on. It is based on attachment api, so the <code>print</code> option could be pass internally and avoid ambiguity.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-07 02:47:20
[cucumber/cucumber-js] Comment on #1136
<p>I suggest I continue to work on the first global formatOption as it is a good topic for a tutorial for a future new contributor first contribution.</p>
<p>But your ideas are still interesting and we may continue discuss it, and then open a distinct PR once we have a better idea of what we may do.</p>
<p>What do you think?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-07 03:21:43
[cucumber/cucumber-js] Issue opened by Mkrish123
<https://github.com/cucumber/cucumber-js/issues/1723|#1723 cucumber step definition snippet issue .>
<p>Description:-</p>
<p>On executing feature file step definition snippet is not coming to the console.</p>
<p><strong>To Reproduce</strong><br />
Steps to reproduce the behavior:</p>
<ol><li>select the project and open feature file and run it as cucumber feature.</li>
</ol>
<p>eclipse console output:-</p>
<p>Feature: Login test feature</p>
<p>Scenario: Test Flipkart login page. # C:/Users/HP/eclipse-workspace/CucumberSelenium/src/test/java/Features/login.feature:3</p>
<pre><code>Given: Navigate to the login page.
When: login with valid "username" and "password"
Then: click on login button.
And: Capture the home page.
</code></pre>
<p>0 Scenarios<br />
0 Steps<br />
0m0.000s</p>
<p>In above output step definition snippet suggestion is missing.</p>
<p>+++++++++++++++++++++pom.xml file+++++++++++++++++++++++++++++++</p>
<p>4.0.0</p>
<p>CucumberSelenium<br />
CucumberSelenium<br />
0.0.1-SNAPSHOT</p>
<p>CucumberSelenium</p>
<p><a href="http://www.example.com">http://www.example.com</a></p>
<p>UTF-8 1.7 1.7 junit junit 4.11</p>
<pre><code>&lt;/dependency&gt;
</code></pre>
<p>info.cukes cucumber-java 1.2.5 info.cukes cucumber-junit 1.2.5 test org.seleniumhq.selenium selenium-java 3.141.59</p>
<pre><code> &lt;/dependencies&gt;
</code></pre>
<p>maven-clean-plugin 3.1.0 maven-resources-plugin 3.0.2 maven-compiler-plugin 3.8.0 maven-surefire-plugin 2.22.1 maven-jar-plugin 3.0.2 maven-install-plugin 2.5.2 maven-deploy-plugin 2.8.2 maven-site-plugin 3.7.1 maven-project-info-reports-plugin 3.0.0</p>
<p>please help me to solve the issue...</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-07 04:31:59
[cucumber/cucumber-js] aslakhellesoy approved aurelien-reeves's pull request
<p>LGTM!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-07 05:22:47
[cucumber/cucumber-js] davidjgoss approved aurelien-reeves's pull request
<p>Nice, this would make a good standalone library too.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-07 05:32:25
[cucumber/cucumber-js] Comment on #1722
<p>> Nice, this would make a good standalone library too.</p>
<p>Good idea!<br />
If none exist at the moment (I realize that I may have looked for one before starting to implement it), that could be my very first standalone library of my own :D<br />
And that could also help having proper tests and documentation</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-08 05:16:03
[cucumber/cucumber-js] Comment on #1649
<p><a href="https://github.com/charlierudolph">@charlierudolph</a> <a href="https://github.com/aurelien-reeves">@aurelien-reeves</a></p>
<p>So this is now simplified a bit with Node 10 support having been dropped. <code>await import()</code> is now always available so we can avoid the <code>--esm</code> flag since it works with both ESM and CommonJS code. A couple of exceptions:</p>
<p>• The <code>cucumber-js</code> profiles file remains CommonJS only and loaded via <code>require()</code>. Switching it to use <code>await import()</code> threw up some issues which I think are related to <code>default</code> being one of the profile keys. At any rate this is likely to become a legacy thing via <a href="https://github.com/cucumber/cucumber-js/issues/751">#751</a> / <a href="https://github.com/cucumber/cucumber-js/issues/1711">#1711</a> so I think it's best to just leave it alone at this point.
• You can't <code>await import()</code> things that aren't JavaScript, meaning it would break for folks using TypeScript or Babel. I've used the presence of <code>--require-module</code> as a heuristic for this, so if that option has been used (meaning <code>ts-node</code> or <code>babel</code> etc is in play) then we'll fall back to using <code>require()</code> for loading the support code. Can you see any issues with this?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-08 06:13:32
[cucumber/cucumber-js] Comment on #1711
<p>Okay, here's a first pass at the API signature for the "run" bit. It's heavily based on the <code>IConfiguration</code> object we have internally (so shouldn't cause too much refactoring lower down) but just a little less "flat":</p>
<pre><code>export interface IRunCucumberOptions {
cwd: string
features: {
defaultDialect?: string
paths: string[]
}
filters: {
name?: string[]
tagExpression?: string
}
support:
| {
transpileWith?: string[]
paths: string[]
}
| ISupportCodeLibrary
runtime: {
dryRun?: boolean
failFast?: boolean
filterStacktraces?: boolean
parallel?: {
count: number
}
retry?: {
count: number
tagExpression?: string
}
strict: boolean
worldParameters?: any
}
formats: {
stdout: string
files: Record&lt;string, string&gt;
options: IParsedArgvFormatOptions
}
}
export interface IRunResult {
success: boolean
support: ISupportCodeLibrary
}
export async function runCucumber(
options: IRunCucumberOptions
): Promise&lt;IRunResult&gt; {
// do stuff
}
</code></pre>
<p>And a very contrived example usage:</p>
<pre><code>const result = await runCucumber({
cwd: process.cwd(),
features: {
paths: ['features/****/**.feature'],
},
filters: {
name: ['Acme'],
tagExpression: '@interesting',
},
support: {
transpileWith: ['ts-node'],
paths: ['features/support/****/**.ts'],
},
runtime: {
failFast: true,
retry: {
count: 1,
tagExpression: '@flaky',
},
strict: true,
worldParameters: {
foo: 'bar',
},
},
formats: {
stdout: '@cucumber/pretty-formatter',
files: {
'report.html': 'html',
'TEST-cucumber.xml': 'junit',
},
options: {
printAttachments: false,
},
},
})
</code></pre>
<p>Feedback welcome! Note this doesn't cover the profile/config loading stuff which would be another function.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-08 07:41:37
[cucumber/cucumber-js] Comment on #1711
<p>I think this looks good. Question: How would I configure a custom formatter?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-08 08:16:30
[cucumber/cucumber-js] Comment on #1711
<p><a href="https://github.com/nicojs">@nicojs</a> sorta like on the CLI</p>
<pre><code>formats: {
files: {
'report.html': './my/fancy-reporter.js',
'other-report.html': '@me/reporter-package',
}
},
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-08 09:35:03
[cucumber/cucumber-js] Comment on #1711
<p>Great to see progress on this <a href="https://github.com/davidjgoss">@davidjgoss</a>!</p>
<p>I don't want to slow down the progress on this, but at the same time I want to make sure we adopt a format that can work for other Cucumber implementations too.</p>
<p>Eventually a JSON schema, but while we discuss it I think TypeScript types are easier for us humans to parse.</p>
<p>I suggest we create a new issue about the proposed format in the <code>cucumber/common</code> monorepo and invite the core team to discuss there.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-08 09:54:39
[cucumber/cucumber-js] Comment on #1711
<p><a href="https://github.com/aslakhellesoy">@aslakhellesoy</a> will do.</p>
<p>What would you think about the programmatic API not being tied to the common options structure? Like we'd map from that to the <code>runCucumber</code> options. It adds maybe a little complexity but appeals because of things like having a <code>support</code> block that's either parameters to load, or a previously loaded support code library. Could do similar for features+pickles too. And there are various options we'd support on the CLI (e.g. <code>--exit</code>) that aren't appropriate on the programmatic API.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-08 21:26:23
[cucumber/cucumber-js] Comment on #1722
<p>I've never seem this syntax. Is this a function call? If so, I think i'd prefer we add parens so it is<br />
unindent(<code>...</code>)</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-08 21:27:21
[cucumber/cucumber-js] Comment on #1722
<p>Very cool. Definitely like this.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-08 23:08:00
[cucumber/cucumber-js] Comment on #1722
<p>This is a tagged template, a JavaScript feature that is part of the template literals spec</p>
<p><a href="https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals#tagged_templates">https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template<em>literals#tagged</em>templates</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-08 23:10:08
[cucumber/cucumber-js] Comment on #1722
<p>I am not sure about the name of the function<br />
What about <code>reindent</code> instead of <code>unindent</code>?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-09 00:43:57
[cucumber/cucumber-js] Comment on #1711
<p>> What would you think about the programmatic API not being tied to the common options structure?</p>
<p>I think that's fine, as long as we provide a function that converts from the options file contents to the data structure <code>runCucumber</code> wants.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-09 03:22:25
[cucumber/cucumber-js] Comment on #1711
<p>> Eventually a JSON schema, but while we discuss it I think TypeScript types are easier for us humans to parse.</p>
<p>Why do we need to choose? We're using JSON schema in StrykerJS to generate typescript using <a href="https://www.npmjs.com/package/json-schema-to-typescript">json-schema-to-typescript</a>. We're not committing the TS output files to source control, instead we generate them on the fly using a <code>prebuild</code> step.</p>
<p>JSON schemas are still somewhat readable for humans IMO. We've already had PR's on the Stryker repo and people seem to know what to do 🤷♀️</p>
<p>> sorta like on the CLI
>
> <code>
&gt; formats: {
&gt; files: {
&gt; 'report.html': './my/fancy-reporter.js',
&gt; 'other-report.html': '@me/reporter-package',
&gt; }
&gt; },
&gt;</code></p>
<p>How would this work for a reporter that doesn't need an output file name? Like so:</p>
<pre><code>formats: {
files: {
'': require.resolve('./my-awesome-stryker-formatter')
}
}
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-09 04:17:25
[cucumber/cucumber-js] Comment on #1711
<p>> Why do we need to choose?</p>
<p>I think we should use a JSON Schema as a single source of truth for the structure of the configuration. -And then generate TypeScript/Java/Whatever code from that schema.</p>
<p>But JSON Schema is a bit hard to read for humans, so while we are <em>discussing</em> the schema in a GitHub issue in <code>cucumber/common</code> I was suggesting TypeScript to facilitate the discussion.</p>
<p>See what I mean?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-09 04:18:15
[cucumber/cucumber-js] Comment on #1711
<p>> JSON schemas are still somewhat readable for humans IMO</p>
<p>Not to me :-) Too verbose.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-09 04:18:22
[cucumber/cucumber-js] Comment on #1711
<p>> How would this work for a reporter that doesn't need an output file name?</p>
<pre><code>formats: {
stdout: './my-awesome-stryker-formatter',
files: {
'report.html': './my/fancy-reporter.js',
'other-report.html': '@me/reporter-package',
}
},
</code></pre>
<p>(only one formatter can use the stdout stream)</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-09 04:21:24
[cucumber/cucumber-js] Comment on #1722
<p>> I am not sure about the name of the function<br />
> What about <code>reindent</code> instead of <code>unindent</code>?</p>
<p>Yep, or <code>normaliseIndent</code> maybe</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-09 05:21:59
[cucumber/cucumber-js] Comment on #1722
<p>> > I am not sure about the name of the function<br />
> > What about <code>reindent</code> instead of <code>unindent</code>?
>
> Yep, or <code>normaliseIndent</code> maybe</p>
<p><code>normalizeIndent</code> may let think that the mehod may do more than it does like fixing some indent issues in the process</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-09 05:23:47
[cucumber/cucumber-js] Comment on #1649
<p>I'll take a look next week :)</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-09 09:08:22
[cucumber/cucumber-js] Issue opened by shawnbot
<p><strong>Is your feature request related to a problem? Please describe.</strong><br />
This isn't really a problem, but more of an implementation/API question.</p>
<p>I'm looking into whether it's feasible to build a Cucumber integration with <a href="https://ghostinspector.com/">Ghost Inspector</a> ("GI"), but there's a pretty fundamental difference in the way that the two tools want to run tests: Cucumber wants to execute each step in series and know immediately if one has failed, whereas with GI I was hoping to:</p>
<ol><li>Use step definitions to build the test suite payload</li><li>Send the test suite payload at the end of each scenario</li><li>Set the status of each step once the test results come back</li>
</ol>
<p>I've figured out 1 and 2, but 3 has me stumped. Is this possible, and if so, are there either examples of how to do it that I could look at or some pseudo-code for how to "correctly" modify step results? Thank you! 🙏</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-10 13:57:29
[cucumber/cucumber-js] Comment on #1722
<p>Is there any reason we are using tagged template vs generic function? Seems like it would be more approachable / easier to understand with just a function</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-10 14:00:54
[cucumber/cucumber-js] Pull request merged by charlierudolph
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-10 14:10:23
[cucumber/cucumber-js] Pull request opened by charlierudolph
<p>Don't need generators anymore given async / await has been out for a long time.</p>
<p>Initially held off to allow until we had BeforeStep / AfterStep hooks as the definition function wrapper had been used for things like that</p>
<p>Also removes bluebird (between lodash / bluebird - removing 20% of our bundle: <a href="https://bundlephobia.com/package/@cucumber/cucumber@7.3.0">https://bundlephobia.com/package/@cucumber/cucumber@7.3.0</a>)</p>
<p>closes <a href="https://github.com/cucumber/cucumber-js/issues/1021">#1021</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-10 14:12:25
[cucumber/cucumber-js] Comment on #1725
<p><a href="https://coveralls.io/builds/41269455">Coverage Status</a></p>
<p>Coverage decreased (-0.2%) to 94.909% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/2ae4e8e9a2f98f43642886322216ef675831786d">2ae4e8e</a> on cr-remove-couroutine</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/f879282ce6d3228a7c8a8e6cea7480744f8ccd94">f879282</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-10 14:30:31
[cucumber/cucumber-js] Comment on #1724
<p>Woah, that sounds like a complex integration. Cucumber does not currently expose a method of setting step results and I'm not certain this is something we should support. What's the reasoning behind not wanting to execute each step serially?</p>
<p>Based on our current model of behavior one step has to finish before the next starts and the results are streamed out as events as they happen. Modifying them after fact doesn't sound like a good idea. There are other ways to solve that though such as not streaming step results as they happen and only at the end of the test case</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-10 14:37:31
[cucumber/cucumber-js] Comment on #1588
<p>I agree you have to dive past the pickle level to actually verify it, I'm just suggesting a different interface so that someone looking at the test can understand what is being verified without looking at the code.</p>
<p>I don't think things will get slower as we still go through all envelopes once and the extra assertion time to me would be negligible.</p>
<p>Let me try to implement my thoughts.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-10 19:03:10
[cucumber/cucumber-js] Pull request opened by charlierudolph
<p>I resolved the issue that was incorrectly reporting <code>@tsd/typescript</code> as used</p>
<p>For more context <a href="https://github.com/charlierudolph/dependency-lint/issues/60">charlierudolph/dependency-lint#60</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 16.x)
(https://github.com/cucumber/cucumber-js/runs/3038268543)
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/3038268530)
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/3038268505)
GitHub Actions: test (windows-latest, 16.x)
(https://github.com/cucumber/cucumber-js/runs/3038265873)
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/3038265862)
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/3038265856)
GitHub
2021-07-10 19:05:21
[cucumber/cucumber-js] Comment on #1726
<p><a href="https://coveralls.io/builds/41270390">Coverage Status</a></p>
<p>Coverage remained the same at 95.156% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/7bc9c736877c07a0c8a01944c465fe5bd403301e">7bc9c73</a> on cr-depfix</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/f879282ce6d3228a7c8a8e6cea7480744f8ccd94">f879282</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-11 15:54:07
[cucumber/cucumber-js] Comment on #1726
<p>Seems like we're hitting a Windows issue here?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-11 15:56:17
[cucumber/cucumber-js] Comment on #1725
<p>Are we missing commits that actually remove <code>setDefinitionFunctionWrapper</code> and the related code in <code>UserCodeRunner</code> etc? I think we could also drpo the <code>unwrappedCode</code> field.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-12 00:45:13
[cucumber/cucumber-js] Comment on #1722
<p>For me it feels that this is a perfect use-case for tag templates. There is no hack, nothing has been worked-around for this.</p>
<p>Tagged templates arrived alongside template strings with es6 (es-2015), are perfectly documented and have the same support, and almost any article on the Internet which introduce template literals also introduces tag templates.</p>
<p>I cannot see any reason not to use tag template here actually 😕</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-12 01:11:44
[cucumber/cucumber-js] Comment on #1649
<p>Suggested change</p>
<p>Or something like that?<br />
Seeing two times <code>Syntax =</code> puzzled me actually</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-12 01:11:44
[cucumber/cucumber-js] Comment on #1649
<p>Suggested change</p>
<p>If I understood well, the <code>--esm</code> flag is not required anymore?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-12 01:11:44
[cucumber/cucumber-js] Comment on #1649
<p>Suggested change</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-12 01:11:45
[cucumber/cucumber-js] aurelien-reeves commented on davidjgoss's pull request
<p>Looks good!<br />
I have a few comments, but it looks really good.</p>
<p>I see a lot of new usage of <code>async</code> <code>await</code>. Beside the compatibility with <code>esm</code>, may this impact the code of cucumber users and third-party developers?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-12 02:30:06
[cucumber/cucumber-js] Comment on #1649
<p>That's right, thanks!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-12 02:34:37
[cucumber/cucumber-js] Comment on #1649
<p>> I see a lot of new usage of async await. Beside the compatibility with esm, may this impact the code of cucumber users and third-party developers?</p>
<p>Async/await has been natively supported in Node since v7 so we're all good.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-12 02:38:22
[cucumber/cucumber-js] Comment on #1649
<p>> > I see a lot of new usage of async await. Beside the compatibility with esm, may this impact the code of cucumber users and third-party developers?
>
> Async/await has been natively supported in Node since v7 so we're all good.</p>
<p>Yes, I don't have concerns with using async/await.<br />
I just wanted to make sure there won't be breaking changes for existing code of our users and/or third-party developers.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-12 14:41:18
[cucumber/cucumber-js] Comment on #1724
<p>Thanks for replying. It's not ideal! What would it look like not to stream step results though? Or would that require a change to cucumber-js?</p>
<p>Another path I was looking into was using the test runner internals directly, but I didn't see a very obvious way of piecing them together in the CLI source or by searching. Is this at all feasible?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-12 20:35:14
[cucumber/cucumber-js] Comment on #1722
<p>In my opinion, the fact that you have to reconstruct the interpolated string by adding the expression values and strings is unnecessary complexity being exposed to us. If this was a function that just took in the interpolated string, that logic could be removed. It would be strictly less code.</p>
<p>Tag templates to me are more about controlling the interpolation in some way which is not something we are using here.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-12 20:40:34
[cucumber/cucumber-js] Comment on #1725
<p>Haha focused too much on bluebird there. Thanks <a href="https://github.com/davidjgoss">@davidjgoss</a>. Updated</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-12 20:47:10
[cucumber/cucumber-js] Comment on #1725
<p>Had accidentally added this in a previous PR, added the mocha options forbid-only so unit tests error if this is committed.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-12 20:52:15
[cucumber/cucumber-js] Comment on #1649
<p>Does this have the caveat that you everything must be javascript in order to use ESM? Based on your comment I think so and think that is fine as long as we document it.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-12 20:54:59
[cucumber/cucumber-js] Comment on #1726
<p>Yep, need to investigate that more</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-12 23:55:47
[cucumber/cucumber-js] Comment on #1722
<p>That is a very good point 😅</p>
<p>I change it for a function 👍</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-13 00:47:39
[cucumber/cucumber-js] Comment on #1724
<p>You would like to use your own runner, that's it?<br />
But still use cucumber step definitions and support code in addition of the features? Or you would just need the parsed features?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-13 00:54:28
[cucumber/cucumber-js] Comment on #1725
<p>Shouldn't we deprecate it for at least one entire major version before removing it?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-13 01:01:49
[cucumber/cucumber-js] Comment on #1725
<p>> Shouldn't we deprecate it for at least one entire major version before removing it?</p>
<p>You're right that we haven't done that. Although, it's been kinda pseudo-deprecated since we had async/await natively and then <code>BeforeStep</code> and <code>AfterStep</code> in 7.0.0. I'd be really keen to remove now as it's responsible for a chunk of complexity and there's no case for using it any more (unlike e.g. <code>--no-strict</code> which might be more subjective). We could do a patch release on 7.x.x with an explicit runtime warning?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-13 01:11:30
[cucumber/cucumber-js] Comment on #1725
<p>> It's been kinda pseudo-deprecated since we had async/await natively and then <code>BeforeStep</code> and <code>AfterStep</code> in 7.0.0.</p>
<p>We need to let our users know about that. They may not be aware of that.</p>
<p>> I'd be really keen to remove now as it's responsible for a chunk of complexity and there's no case for using it any more</p>
<p>Yes, of course, I totally agree with that. We have to remove it ASAP if it is useless complex noise in the code base.<br />
But our users have to be informed first to let them some time to update their own code. If we are too quickly into removing it, some users may pin cucumber to v7 for a while, then forget about it, then keep that version for years - worst case scenario 😅</p>
<p>> We could do a patch release on 7.x.x with an explicit warning?</p>
<p>Yes, that would be a good thing 👍</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-13 05:42:29
[cucumber/cucumber-js] Issue opened by karthrav
<p><strong>Describe the bug</strong><br />
Line number 3 i.e. import { version } from '../package.json'; throws a compile error TS2614: Module '"<em>.json"' has no exported member 'version'. Did you mean to use 'import version from "</em>.json"' instead?</p>
<p>This occurs only when you use "tsc --resolveJsonModule false" compile command.<br />
Issue does not occur if you use simply tsc.</p>
<p><strong>To Reproduce</strong><br />
Steps to reproduce the behavior:</p>
<ol><li>Compile your project with tsc --resolveJsonModule false</li><li>See error</li><li>Compile your project with tsc</li><li>No error</li>
</ol>
<p><strong>Expected behavior</strong><br />
No error should occur when compiling with tsc --resolveJsonModule false</p>
<p><strong>Screenshots</strong><br />
<a href="https://user-images.githubusercontent.com/87373079/125452193-4308a756-adc3-4c86-ae94-a98df5af797b.png">image</a><br />
<a href="https://user-images.githubusercontent.com/87373079/125453237-f32a03f3-e39b-43f2-87fd-a5ada792a69a.png">image</a></p>
<p><strong>Desktop:</strong></p>
<p>• OS: Windows</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-13 09:34:08
[cucumber/cucumber-js] Issue opened by fguidobaldi
<p>Is there any way to dynamically generate examples?</p>
<p>I would like to be able to execute the same scenario with different inputs (that share the same expected result) , not just hardcoding these inputs, but generating them programmatically. The current approach it isn't scalable, and it's very expensive to maintain.</p>
<p>I understand that maybe this isn't the typical UC for Cucumber, that's why I'm trying to find out some sort of workaround to this issue. The objective is to reuse when/then steps, without having to write different scenarios, but to execute them the number of times necessary according to the input.</p>
<p>Scenario Outline: User logging<br />
Given there is <user_id> user<br />
When the user tries to login<br />
Then I should receive 200 as status code</p>
<p>• I verify some response value
• I verify another response value</p>
<p>Examples:<br />
| user_id |<br />
| 1 |<br />
| 2 |<br />
| 3 |<br />
| 4 |<br />
| 5 |<br />
| 6 |</p>
<hr />
<p>Scenario: User logging<br />
Given there are 6 users --> THIS STEP GENERATES 6 USER_ID<br />
When the user tries to login<br />
Then I should receive 200 as status code</p>
<p>• I verify some response value
• I verify another response value</p>
<p><strong>WHEN and THEN should be executed 6 times (once for each user_id)</strong></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-13 22:23:29
[cucumber/cucumber-js] charlierudolph approved aurelien-reeves's pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-14 07:54:29
[cucumber/cucumber-js] Comment on #1728
<p>Hi <a href="https://github.com/fguidobaldi">@fguidobaldi</a>, what you're describing there isn't possible with cucumber because scenarios are calculated into test cases upfront and can't be built as you go at runtime.</p>
<p>In your example with 6 users, what behaviour are you trying to describe and test there? Is there something different about each of the users?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-14 08:06:09
[cucumber/cucumber-js] Comment on #1728
<p>Thanks for your answer <a href="https://github.com/davidjgoss">@davidjgoss</a>! In this oversimplified case, the 6 users should be 6 different, random users, but they all should behave the same way when they try to login.</p>
<p>In a real scenario, each scenario I'm trying to run involves different variables (like users, countries, destinations, etc.), but I expect the same output, no matter what the exact combination of these variables is. Since we have millions of users and thousands of possible destinations, I'm trying to generate dynamically these combinations, in order to get a different set of inputs every time I run this test, and not just harcoding the values.</p>
<p>As I said before, I really understand that it's not the typical UC for Cucumber, and if you know of any other tool that may fit this UC, I'll be very grateful. Also, please feel free to close this issue if this is something that's not achievable using Cucumber.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-14 08:47:38
[cucumber/cucumber-js] Comment on #1700
<p>The code for defining and describing the CLI options via the <a href="https://github.com/tj/commander.js/">commander</a> library is here: <a href="https://github.com/cucumber/cucumber-js/blob/main/src/cli/argv_parser.ts">https://github.com/cucumber/cucumber-js/blob/main/src/cli/argv_parser.ts</a></p>
GitHub
2021-07-14 08:53:11
[cucumber/cucumber-js] Comment on #1312
<p>This feature describes and tests the current behaviour around "skipped" <a href="https://github.com/cucumber/cucumber-js/blob/main/features/skipped_steps.feature">https://github.com/cucumber/cucumber-js/blob/main/features/skipped_steps.feature</a> - we'd be adding a couple more scenarios there to cover skipping from steps.</p>
<p>The status is being set on the basis of the "skipped" result from the step code here <a href="https://github.com/cucumber/cucumber-js/blob/main/src/runtime/step_runner.ts#L66">https://github.com/cucumber/cucumber-js/blob/main/src/runtime/step<em>runner.ts#L66</a> - so the orchestration a level up in <a href="https://github.com/cucumber/cucumber-js/blob/main/src/runtime/test_case_runner.ts">https://github.com/cucumber/cucumber-js/blob/main/src/runtime/test</em>case_runner.ts</a> is probably where we need to make changes.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-14 10:24:14
[cucumber/cucumber-js] Comment on #1724
<p>Yeah, I <em>think</em> I'd like to hook into the runner and control the order or execution and/or modify the results then pass them to one of the built-in formatters.</p>
<p>I guess another option might be to use the cucumber CLI w/custom world and step definitions, then in an <code>After()</code> hook set some shared state and write a custom formatter to output the "real" test results? 🤔</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-14 13:40:23
[cucumber/cucumber-js] Issue opened by teststack-git
<p><strong>Is your feature request related to a problem? Please describe.</strong><br />
I am attempting to set up my teams CucumberJS implementation after we identified some short-comings within Jest-Cucumber (notably the lack of Cucumber json reporting). The benefit of using Jest-Cucumber, however is that I can define browsers to use within the config file and the step definition files would know to run tests against those browsers. This also meant that I could achieve parallelization using all tests with all browsers and have it reflected in a report.</p>
<p>I'm having trouble finding a similar solution within CucumberJS as it seems to require a single browser instance at a time. I can use the process.env.BROWSER to sort of dynamically pass in a browser via a nodejs CLI, however that means I would need a separate call for each browser, which then turns into 3 Cucumber reports. I've found the section within the docs that showcase parallel testing, however nothing in regards to browser management. Is this something that is possible with CucumberJS? If so, is there an example that I can look at with that sort of implementation or at the very least the usage of a config.js file that can achieve those goals?</p>
<p><strong>Describe the solution you'd like</strong><br />
A clear and concise description of what you want to happen.</p>
<p><strong>Describe alternatives you've considered</strong><br />
A clear and concise description of any alternative solutions or features you've considered.</p>
<p><strong>Additional context</strong><br />
Add any other context or screenshots about the feature request here.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-14 14:04:54
[cucumber/cucumber-js] Pull request opened by cucumber-ensemble
<p>Co-authored-by: Matt Wynne <a href="mailto:matt@mattwynne.net">matt@mattwynne.net</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-14 14:05:39
[cucumber/cucumber-js] Comment on #1730
<p>This is just a little test of a collaborative mobbing environment I've been setting up.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-14 15:46:08
[cucumber/cucumber-js] Comment on #1730
<p><a href="https://coveralls.io/builds/41379226">Coverage Status</a></p>
<p>Coverage remained the same at 95.156% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/9ae15e1e453a1fe0f241c2d1162f95924b993ea0">9ae15e1</a> on tweak-docs</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/f879282ce6d3228a7c8a8e6cea7480744f8ccd94">f879282</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-15 04:24:55
[cucumber/cucumber-js] Pull request opened by davidjgoss
<p><strong>Description</strong></p>
<p>Emit a warning when you call <code>setDefinitionFunctionWrapper</code>, using same wording as the removal notice in <a href="https://github.com/cucumber/cucumber-js/pull/1725">#1725</a>.</p>
<p><strong>Motivation & context</strong></p>
<p>Give users a bit of warning about the removal in 8.0.0.</p>
<p>Then going to release as 7.3.1 (we had another couple fixes ready anyway on 7.x).</p>
GitHub Actions: test (windows-latest, 10.x)
(https://github.com/cucumber/cucumber-js/runs/3076023688)
GitHub
2021-07-15 04:26:42
[cucumber/cucumber-js] davidjgoss approved charlierudolph's pull request
<p>LGTM</p>
<p>Going to do a 7.3.1 via <a href="https://github.com/cucumber/cucumber-js/pull/1731">#1731</a> to give more explicit deprecation message.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-15 04:27:47
[cucumber/cucumber-js] Comment on #1731
<p><a href="https://coveralls.io/builds/41395662">Coverage Status</a></p>
<p>Coverage increased (+0.0007%) to 98.518% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/7ba4488bbafab1ee01e06ff434546479b586d488">7ba4488</a> on deprecate-generators</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/ee8ab8db3a606f2aa753efedfb3d7b9e58d3a142">ee8ab8d</a> on 7.x</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-15 08:41:12
[cucumber/cucumber-js] charlierudolph approved davidjgoss's pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-15 12:27:31
[cucumber/cucumber-js] Comment on #1722
<p>I've finally published a NPM package: <a href="https://www.npmjs.com/package/reindent-template-literals">https://www.npmjs.com/package/reindent-template-literals</a> 😅</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-15 14:25:03
[cucumber/cucumber-js] Comment on #1278
<p><a href="https://github.com/cucumber/cucumber-js/issues/1711">#1711</a> is related</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-15 16:42:08
[cucumber/cucumber-js] Comment on #1725
<p>Not super related, but if you do a 7.3.1, could you please upgrade as many <code>@cucumber/**</code> dependencies as possible at the same time? There have been a few bug fixes recently since 7.3.0.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-15 16:43:46
[cucumber/cucumber-js] Comment on #1730
<p>I'd prefer if we didn't recommend the use of <code>yarn</code> and use <code>npm</code> instead. Because it's the standard.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-15 16:43:47
[cucumber/cucumber-js] aslakhellesoy requested changes on cucumber-ensemble's pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-16 01:18:35
[cucumber/cucumber-js] Comment on #1725
<p><a href="https://github.com/aslakhellesoy">@aslakhellesoy</a> I'll have a look, although if updates would require the major version change on messages for the relocation of <code>willBeRetried</code> then that will have to wait for 8.0.0.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-16 01:21:11
[cucumber/cucumber-js] Pull request merged by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-16 02:00:51
[cucumber/cucumber-js] Pull request opened by ludeknovy
<p><strong>Description</strong></p>
<p>bringing back v6/5 <code>get_color_fns</code> props</p>
<p><strong>Motivation & context</strong></p>
<p>Fixes <a href="https://github.com/cucumber/cucumber-js/issues/1582">#1582</a></p>
<p><strong>Type of change</strong></p>
<p>• Bug fix (non-breaking change which fixes an issue)</p>
<p><strong>Checklist:</strong></p>
<p>☑︎ My code follows the code style of this project.
☐ My change requires a change to the documentation.
☐ I have updated the documentation accordingly.
☑︎ I have read the <../CONTRIBUTING.md|<strong>CONTRIBUTING</strong>> document.
☐ I have added tests to cover my changes.
☑︎ All new and existing tests passed.</p>
GitHub
2021-07-16 02:16:50
[cucumber/cucumber-js] Pull request opened by ludeknovy
<p><strong>Description</strong></p>
<p>IParameterTypeDefinition interface fix</p>
<p><strong>Motivation & context</strong></p>
<p>_Why is this change required? What problem does it solve?</p>
<p>Fixes <a href="https://github.com/cucumber/cucumber-js/issues/1702">#1702</a></p>
<p><strong>Type of change</strong></p>
<p>• Bug fix (non-breaking change which fixes an issue)</p>
<p><strong>Checklist:</strong></p>
<p>☑︎ My code follows the code style of this project.
☐ My change requires a change to the documentation.
☐ I have updated the documentation accordingly.
☑︎ I have read the <../CONTRIBUTING.md|<strong>CONTRIBUTING</strong>> document.
☐ I have added tests to cover my changes.
☑︎ All new and existing tests passed.</p>
GitHub
2021-07-16 02:32:07
[cucumber/cucumber-js] Comment on #1730
<p>I think the <code>yarn</code> usage is correct currently because the project is developed with yarn (the <code>yarn.lock</code> file, CI builds). That said I would be fine with changing to npm to be more standard.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-16 11:20:53
[cucumber/cucumber-js] Comment on #1734
<p><a href="https://coveralls.io/builds/41438377">Coverage Status</a></p>
<p>Coverage remained the same at 95.156% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/18b3ff3f7836dbb18a53c49a1d360f4e346729e0">18b3ff3</a> on 1648-replace-any</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/a3b71ae3b041c7eaabe932082e4e04809d9b9b00">a3b71ae</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-16 15:49:54
[cucumber/cucumber-js] Comment on #1732
<p>(I think the changelog entry should reflect what we did rather than the framing of the issue.)</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-16 15:49:54
[cucumber/cucumber-js] Comment on #1732
<p>Suggested change</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-16 15:49:55
[cucumber/cucumber-js] davidjgoss requested changes on ludeknovy's pull request
<p>Thanks very much <a href="https://github.com/ludeknovy">@ludeknovy</a> - just suggested a tweak to the changelog entry but other than that I think we're good to go.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-16 15:51:49
[cucumber/cucumber-js] davidjgoss approved ludeknovy's pull request
<p>Thanks for this <a href="https://github.com/ludeknovy">@ludeknovy</a>!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-16 15:52:16
[cucumber/cucumber-js] Comment on #1732
<p><a href="https://coveralls.io/builds/41443632">Coverage Status</a></p>
<p>Coverage decreased (-0.2%) to 94.968% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/79870734cf6b468a21610f9fbffc2955fc03e37c">7987073</a> on ludeknovy:feature/1582-get-colors-fns</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/a3b71ae3b041c7eaabe932082e4e04809d9b9b00">a3b71ae</a> on cucumber:main</strong>.</p>
GitHub
2021-07-16 15:54:13
[cucumber/cucumber-js] Comment on #1733
<p><a href="https://coveralls.io/builds/41443663">Coverage Status</a></p>
<p>Coverage remained the same at 95.156% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/deccfcbe495385b96724fef9ff53c8ab925a087b">deccfcb</a> on ludeknovy:feature/IParameterTypeDefinition-update</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/a3b71ae3b041c7eaabe932082e4e04809d9b9b00">a3b71ae</a> on cucumber:main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-16 15:56:55
[cucumber/cucumber-js] Issue closed by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-16 15:56:56
[cucumber/cucumber-js] Pull request merged by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-16 15:56:56
[cucumber/cucumber-js] Comment on #1733
<p>Hi <a href="https://github.com/ludeknovy">@ludeknovy</a>,</p>
<p>Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾</p>
<p>In return for this generous offer we hope you will:</p>
<p>• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our <a href="https://cucumber.io/conduct">code of conduct</a> in your interactions with other collaborators and users.
• 💬 Join the <a href="http://cucumber.io/support#slack">community Slack channel</a> to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!</p>
<p>On behalf of the Cucumber core team,<br />
Aslak Hellesøy<br />
Creator of Cucumber</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-17 04:38:57
[cucumber/cucumber-js] davidjgoss approved ludeknovy's pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-17 04:39:08
[cucumber/cucumber-js] Issue closed by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-17 04:39:10
[cucumber/cucumber-js] Pull request merged by davidjgoss
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-17 16:37:45
[cucumber/cucumber-js] Comment on #1712
<p>Hmm, I'm uncertain about if profile positional arguments should be added to or overridden by cli positional arguments. Maybe could have a flag <code>--default-features &lt;paths&gt;</code> which is the features used only if no positional arguments are passed. That would support the override case and allow us to keep the same positional arguments we have now.</p>
<p>If we want to support a method of excluding feature, I think that should also be done via a flag as I would want it to apply to all feature paths passed in and that makes more sense to me as a flag than a positional argument</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-17 16:42:29
[cucumber/cucumber-js] Comment on #1729
<p>The parallel feature is currently meant as a means to speed up a single run through (ie each scenario runs once instead of running multiple times with different browsers). Cucumber doesn't have any opinions about browser management and its up to users to determine how they want to handle that.</p>
<p>Based on your use case, I think running cucumber 3 times makes the most sense to me and then you need to write your own process to merge the result files.</p>
GitHub
2021-07-17 16:43:09
[cucumber/cucumber-js] Issue closed by charlierudolph
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-17 16:43:10
[cucumber/cucumber-js] Pull request merged by charlierudolph
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-19 02:17:52
[cucumber/cucumber-js] Comment on #1730
<p><code>yarn</code> is a pretty popular alternative to <code>npm</code>. I would go for documenting usage of both, or none. Eventually only <code>npm</code>. But definitely not <code>yarn</code> only.</p>
<p>Here, listing available scripts with npm is possible with <code>npm run</code> as well as with yarn</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-19 02:21:33
[cucumber/cucumber-js] Comment on #1724
<p>Do you think <a href="https://github.com/cucumber/cucumber-js/issues/1711">#1711</a> would help later? Maybe you could take part to the discussion to expose your own needs and suggestions?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-19 02:25:35
[cucumber/cucumber-js] Comment on #1734
<p>Suggested change</p>
<p>This is not related to the PR, and another PR suggested the same change<br />
<a href="https://github.com/cucumber/cucumber-js/pull/1730">#1730</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-19 02:25:36
[cucumber/cucumber-js] aurelien-reeves requested changes on mattwynne's pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-19 02:36:48
[cucumber/cucumber-js] Comment on #1725
<p>This has been merged, but 7.3.1 with deprecation notice has not been released yet.</p>
<p>Should we undo the merge?</p>
<p><a href="https://github.com/charlierudolph">@charlierudolph</a> <a href="https://github.com/davidjgoss">@davidjgoss</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-19 05:30:16
[cucumber/cucumber-js] Comment on #1725
<p><a href="https://github.com/aurelien-reeves">@aurelien-reeves</a> im doing the release today</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-19 05:34:09
[cucumber/cucumber-js] Comment on #1725
<p>Which one? 7.3.1 without that PR? Or 8.0.0 with it?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-19 07:30:37
[cucumber/cucumber-js] Comment on #1725
<p>Just 7.3.1 with the deprecation notice - there's quite a <a href="https://github.com/cucumber/cucumber-js/milestone/12">bit more to do</a> for 8.0.0 yet</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-19 10:42:28
[cucumber/cucumber-js] Comment on #1711
<p>This sounds great to me. Over in <a href="https://github.com/cucumber/cucumber-js/issues/1724">#1724</a> I was asking if there's a way to modify Cucumber step results so that I can integrate with a test runner that needs the step configuration upfront (which I was hoping to build up from step definitions), runs the whole test suite (scenario) async, then returns results for each step. Typically this would be done in a hook, but none of the Cucumber hooks runs at the right time or gives me (public) access to the step results so that I can update them before they're passed to the formatter.</p>
<p>I could probably do this work in a custom formatter, but that involves (AFAICT) having to share state between the custom world objects (that build up test suites) and the formatter, which feels like a gross hack. Wrapping the test runner programmatically would at least make it easier and a bit more graceful. Without a hooks-like API for <code>runCucumber()</code>, I would expect to be able to do something like this:</p>
<pre><code>import { runCucumber, formatResults } from '@cucumber/cucumber'
import { cucumberDefaults, transformTestResults } from '@sfgov/ghost-cucumber'
const results = await runCucumber({
...cucumberDefaults,
formats: { /** no formatting? **/ }
})
const modifiedResults = await transformTestResults(results)
formatResults(modifiedResults, {
// use the default formatter if none is provided?
file: '/dev/stdout'
})
.then(({ status }) =&gt; process.exit(status)) // does the formatter report status, or...?
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-19 10:48:40
[cucumber/cucumber-js] Comment on #1730
<p>Right now, as David has said, the project uses yarn. If we want to switch to npm that's fine, but let's keep that as a separate issue to improving the current docs.</p>
GitHub
2021-07-19 10:49:12
[cucumber/cucumber-js] Comment on #1734
<p>Yeah, I forgot that I had that other change on the same machine and we branched this PR on top of it.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-19 13:00:33
[cucumber/cucumber-js] Issue opened by eoola
<p><strong>Describe the bug</strong><br />
Whenever the parent directory has parentheses in its name, I noticed the cucumber features tests start to fail. I also noticed that in the tests that are run, the path for the parent directory drops the parentheses from the path name. For the above reason, the path can not be found for a specified directory.</p>
<pre><code>22) Scenario: # features/usage_json_formatter.feature:8
✔ Before # ../../Cucumber x/cucumber-js/src/support_code_library_builder/build_helpers.ts:13
✔ Given a file named "features/a.feature" with: # ../../Cucumber x/cucumber-js/src/support_code_library_builder/build_helpers.ts:13
"""
Feature: a feature
Scenario: a scenario
Given step A
And step A
When step B
Then step C
"""
✔ And a file named "features/step_definitions/steps.js" with: # ../../Cucumber x/cucumber-js/src/support_code_library_builder/build_helpers.ts:13
"""
const {When} = require('@cucumber/cucumber')
When('step A', function() {});
When('step B', function() {});
When('step C', function() {});
When(/step D/, function() {});
"""
✔ When I run cucumber-js with `--format usage-json` # ../../Cucumber x/cucumber-js/src/support_code_library_builder/build_helpers.ts:13
✖ Then it outputs the usage data: # ../../Cucumber x/cucumber-js/src/support_code_library_builder/build_helpers.ts:13
| PATTERN | PATTERN_TYPE | URI | LINE | NUMBER OF MATCHES |
| step A | CucumberExpression | features/step_definitions/steps.js | 3 | 2 |
| step B | CucumberExpression | features/step_definitions/steps.js | 4 | 1 |
| step C | CucumberExpression | features/step_definitions/steps.js | 5 | 1 |
| step D | RegularExpression | features/step_definitions/steps.js | 6 | 0 |
AssertionError
+ expected - actual
-13
+3
at /Users/emmanuelola/Documents/Cucumber (x)/cucumber-js/features/step_definitions/usage_json_steps.ts:15:30
at Array.forEach (&lt;anonymous&gt;)
at World.&lt;anonymous&gt; (/Users/emmanuelola/Documents/Cucumber (x)/cucumber-js/features/step_definitions/usage_json_steps.ts:9:18)
✔ After # ../../Cucumber x/cucumber-js/src/support_code_library_builder/build_helpers.ts:13
</code></pre>
<p><strong>To Reproduce</strong><br />
Steps to reproduce the behavior:</p>
<ol><li>Go to 'the root directory for the project'</li><li>Add a parent directory with a parentheses in its name (include some letters within the parentheses)</li><li>Open the project in your desired IDE</li><li>Run the tests</li><li>See error</li>
</ol>
<p><strong>Expected behavior</strong><br />
Passing tests</p>
<p><strong>Screenshots</strong><br />
<a href="https://user-images.githubusercontent.com/54866720/126218939-c2815926-79e2-4b3e-9af5-0bf987e8598f.png">Untitled</a></p>
<p><strong>Desktop (please complete the following information):</strong></p>
<p>• OS: macOS Big Sur 11.4
• Version: Main Repository Branch</p>
<p><strong>Additional context</strong><br />
Trying to run tests to contribute to cucumber-js with <a href="https://github.com/mattwynne">@mattwynne</a> as part of the Cucumber first timers mob and the folder where I keep my code happens to have parentheses in its name. For more context, this is not the folder shown in the screenshot, that's simply provided for testing purposes.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-19 13:25:02
[cucumber/cucumber-js] Comment on #1735
<p>I added some debugging in <a href="https://github.com/cucumber/cucumber-js/blob/ac124f7b2be5fa54d904c7feac077a2657b19440/src/formatter/helpers/test_case_attempt_formatter.ts#L99"><code>formatTestCaseAttempt</code></a> to try and understand how deep the parameter-stripping is being done.</p>
<p>It looks like the <code>stepDefinition</code> message contains a <code>sourceReference</code> that has the stripped-parentheses path:</p>
<pre><code>$ yarn run feature-test features/usage_json_formatter.feature:8 -f message
...
{"stepDefinition":{"id":"1f352a72-138e-4a0d-9bd0-57266210b312","pattern":{"source":"my env includes {string}","type":"CUCUMBER_EXPRESSION"},"sourceReference":{"uri":"../../Cucumber x/cucumber-js/src/support_code_library_builder/build_helpers.ts","location":{"line":13}}}}
...
</code></pre>
<p>Notice that the parens have been stripped from the path in the <code>sourceReference</code> in this message.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-19 13:34:23
[cucumber/cucumber-js] Comment on #1735
<p>I think I've tracked the problem down to this line:</p>
<p><a href="https://github.com/cucumber/cucumber-js/blob/a3aab754155c1c01730338979b586dc644899d23/src/support_code_library_builder/build_helpers.ts#L13">cucumber-js/src/support<em>code</em>library<em>builder/build</em>helpers.ts</a></p>
<p>Line 13 in </cucumber/cucumber-js/commit/a3aab754155c1c01730338979b586dc644899d23|a3aab75></p>
<p>Where we lean on the <a href="https://github.com/stacktracejs/stacktrace.js"><code>stacktrace-js</code></a> library to parse the filename where the step was defined. When I look at what <code>StackTrace.getSync()</code> is returning, the <code>fileName</code> property already has the parentheses stripped from it.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-19 13:49:53
[cucumber/cucumber-js] Comment on #1735
<p>Maybe the problem is <a href="https://github.com/stacktracejs/error-stack-parser/blob/master/dist/error-stack-parser.js#L47">here</a>?!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-19 14:40:38
[cucumber/cucumber-js] Comment on #1735
<p>I think I've found the root cause.</p>
<p>I think it's in the stacktrace.js library's <a href="https://github.com/stacktracejs/error-stack-parser"><code>error-stack-parser</code></a>.</p>
<p>I cloned that library and wrote a failing test for it that reproduces the problem, in a branch which you can see <a href="https://github.com/stacktracejs/error-stack-parser/compare/master...mattwynne:allow-parens-in-node-filename?expand=1">here</a>.</p>
<p>I've made an issue on their issue tracker, so we can continue the discussion over there if you're interested in helping to fix it <a href="https://github.com/eoola">@eoola</a>? <a href="https://github.com/stacktracejs/error-stack-parser/issues/62">stacktracejs/error-stack-parser#62</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-19 14:57:56
[cucumber/cucumber-js] Comment on #1734
<p>We should merge that change in and rebase this branch. I don't know why, but the build has been stuck on that other branch.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-20 00:06:25
[cucumber/cucumber-js] Comment on #1734
<p>> We should merge that change in and rebase this branch. I don't know why, but the build has been stuck on that other branch.</p>
<p>The build shows the following error:</p>
<pre><code> Error : .github#L1
actions/checkout@v2, actions/setup-node@v2, actions/checkout@v2, actions/setup-node@v2, coverallsapp/github-action@master, actions/checkout@v2, and actions/setup-node@v2 are not allowed to be used in cucumber/cucumber-js. Actions in this workflow must be: within a repository owned by cucumber.
</code></pre>
<p>Someone may have updated the settings of the repo to allow local actions only!?<br />
I suggest to 'allow select actions' including github ones and coveralls</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-20 00:10:04
[cucumber/cucumber-js] Pull request merged by aurelien-reeves
GitHub
2021-07-20 00:27:32
[cucumber/cucumber-js] Pull request opened by aurelien-reeves
<p><strong>Description</strong></p>
<p><code>yarn upgrade</code></p>
<p><strong>Motivation & context</strong></p>
<p>To force upgrade of <code>trim-newlines</code> from 3.0.0 to 3.0.1 to fix a security issue: <a href="https://github.com/advisories/GHSA-7p7h-4mm5-852v">GHSA-7p7h-4mm5-852v</a></p>
<p><strong>Type of change</strong></p>
<p>• Refactoring/debt (improvement to code design or tooling without changing behaviour)</p>
<p><strong>Checklist:</strong></p>
<p>☑︎ My code follows the code style of this project.
☑︎ I have read the <../CONTRIBUTING.md|<strong>CONTRIBUTING</strong>> document.
☑︎ All new and existing tests passed.</p>
GitHub
2021-07-20 00:29:27
[cucumber/cucumber-js] Comment on #1736
<p><a href="https://coveralls.io/builds/41496394">Coverage Status</a></p>
<p>Coverage remained the same at 98.247% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/405663a9c69c5f2ce6642cac4d832f15b5c3e2a0">405663a</a> on upgrade-dependencies</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/75283a8ce979c02864cc64ac274ff6bdb927b92b">75283a8</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-20 01:10:40
[cucumber/cucumber-js] Pull request merged by aurelien-reeves
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-20 01:19:26
[cucumber/cucumber-js] Comment on #1737
<p><a href="https://coveralls.io/builds/41498292">Coverage Status</a></p>
<p>Coverage remained the same at 98.247% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/4afdd858f1aa92f6727d9603b5407494b357deee">4afdd85</a> on fix-workflow-ubuntu-15</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/dd62cbb6a66c89a1bf8dc95ced5742173dee600f">dd62cbb</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-20 01:35:19
[cucumber/cucumber-js] Comment on #1737
<p>From where that <code>Required</code> badge comes from!? 🤔<br />
If we find how to remove it, or move it to another build, that should fix the issue</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-20 01:58:46
[cucumber/cucumber-js] Comment on #1737
<p>Found it!<br />
It is in the repository settings => branches => branch protection rules => [edit] the main branch</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-20 01:58:58
[cucumber/cucumber-js] Pull request closed by aurelien-reeves
GitHub
2021-07-20 03:56:20
[cucumber/cucumber-js] davidjgoss approved aurelien-reeves's pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-20 04:05:29
[cucumber/cucumber-js] Comment on #1737
<p>Nice one <a href="https://github.com/aurelien-reeves">@aurelien-reeves</a>!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-20 05:01:45
[cucumber/cucumber-js] Comment on #1735
<p>I think I’ve found another root cause. We’re depending on a micro ibrary that has low activity and release frequency.</p>
<p>Depending on low-frequency libraries is a liability. We should replace it with our own implementation, possibly a function instead of a lib.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-20 05:45:48
[cucumber/cucumber-js] Pull request merged by aurelien-reeves
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-20 07:13:15
[cucumber/cucumber-js] Issue opened by customcommander
<p><em>I'm sure it must have been suggested before but I cannot find a similar ticket in this repo. Apologies in advance if this discussion has already been settled.</em></p>
<hr />
<p><strong>Is your feature request related to a problem? Please describe.</strong></p>
<p>We have naming convention for tags e.g.</p>
<pre><code>@featureAAA
@featureBBB
@featureCCC
@regressionAAA
@regressionBBB
@regressionCCC
</code></pre>
<p>We apply these tags on scenarios across many files. We can't have all the features scenarios in one directory and all the regressions scenarios in another. We need to be able to mix and match.</p>
<p>With such a setup the only way to run either all features or all regressions scenarios is to apply a general tag <code>@feature</code> and <code>@scenario</code> as well.</p>
<p><strong>Describe the solution you'd like</strong></p>
<p>Would we nice if we could have a tag expression such as <code>@^feature</code> which means "all tags that starts with <code>feature</code>"</p>
<p><strong>Describe alternatives you've considered</strong></p>
<p>The alternative is the apply a global tag as well e.g.</p>
<pre><code>@featureAAA @feature
Scenario: …
Given …
When …
Then …
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-20 08:55:52
[cucumber/cucumber-js] Comment on #1737
<p>Nice! I had messaged support about this as I couldn't find the config and they pointed to the branch protection rules. Sorry hadn't applied that yet.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-20 13:37:57
[cucumber/cucumber-js] Comment on #1735
<p>I thought about this too <a href="https://github.com/aslakhellesoy">@aslakhellesoy</a>. Having looked through the code of that library, there's quite a bit of complexity there to deal with handling call stacks in different browsers. So that's the only trade-off with bringing that functionality in-house - Cucumber-JS might not report filename so reliably if run in a browser.</p>
<p>That seems like an edge-case to me, but that's because I only ever use Cucumber-JS in a node/electron process. I'm not sure how much people are running their tests in browsers.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-20 13:57:39
[cucumber/cucumber-js] Comment on #1735
<p>We don’t need to worry about running in a browser because we <a href="https://github.com/cucumber/cucumber-js/blob/main/CHANGELOG.md#removed-1">removed</a> support for that in 7.0.0.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-20 23:28:12
[cucumber/cucumber-js] Comment on #1735
<p>Good, then I think that settles it, we should rip out stacktrace.js as it's way more than we need.</p>
<p>As you say, we can probably roll our own function using <code>new Error().stack</code>. <a href="https://github.com/eoola">@eoola</a> if I write you some tests, do you want to try and implement it?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-21 00:14:08
[cucumber/cucumber-js] Comment on #1737
<p><a href="https://github.com/charlierudolph">@charlierudolph</a> no worries, that was fun to dig into this :D</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-21 07:39:01
[cucumber/cucumber-js] Comment on #1735
<p>Would love to take that on. Thank you! <a href="https://github.com/mattwynne">@mattwynne</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-22 02:03:04
[cucumber/cucumber-js] Comment on #1153
<p>Hi guys<br />
<a href="https://github.com/charlierudolph">@charlierudolph</a><br />
There is an update about this?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-22 02:23:52
[cucumber/cucumber-js] Comment on #1153
<p>> Hi guys<br />
> <a href="https://github.com/charlierudolph">@charlierudolph</a><br />
> There is an update about this?</p>
<p>As far as I know, no. It seems no PR has been submitted yet :(</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-22 15:02:17
[cucumber/cucumber-js] Comment on #1735
<p>Here are some things we might be able to lean on:</p>
<p><a href="https://www.npmjs.com/package/v8-callsites">https://www.npmjs.com/package/v8-callsites</a><br />
<a href="https://github.com/sindresorhus/callsites">https://github.com/sindresorhus/callsites</a><br />
<a href="https://github.com/tj/callsite">https://github.com/tj/callsite</a></p>
<p>It's currently unclear to me how much of this stuff is now available inside NodeJS itself. I see we're using the <code>CallSite</code> type from <code>NodeJS</code> in our <code>StackTraceFilter</code> already.</p>
<p>My node knowledge isn't deep enough to have a handle on this.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-23 12:05:57
[cucumber/cucumber-js] Comment on #1735
<p>OK <a href="https://github.com/eoola">@eoola</a> this is ready for you.</p>
<p>I've done a bit of "prefactoring" on the current code to make it easier to unit test, and added a unit test for it that helps us to pin-point the problem. The code is in the <a href="https://github.com/cucumber/cucumber-js/tree/fix-1735-parens-in-path"><code>fix-1735-parens-in-path</code></a> of this repo.</p>
<p>I'm sorry I don't have time to leave you guidance about how to check out that branch locally - I need to go out now, but I can update this ticket later on with that info.</p>
<p>Once you've checked out that branch locally, you can run the test like this:</p>
<pre><code>/node_modules/.bin/mocha src/support_code_library_builder/get_definition_line_and_uri_spec.ts
</code></pre>
<p>If you've got your cucumber-js repo in a parent path without parentheses, that unit test should pass fine. If you run it in a path with parentheses however, it should fail like this:</p>
<pre><code>./node_modules/.bin/mocha src/support_code_library_builder/get_definition_line_and_uri_spec.ts
!
0 passing (11ms)
1 failing
1) getDefinitionLineAndUri
correctly gets the filename of the caller:
AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected
+ 'internal/timers.js'
- 'src/support_code_library_builder/get_definition_line_and_uri_spec.ts'
+ expected - actual
-internal/timers.js
+src/support_code_library_builder/get_definition_line_and_uri_spec.ts
at Context.&lt;anonymous&gt; (/Users/matt/git/github.com/cucumber/Cucucmber (JS)
/src/support_code_library_builder/get_definition_line_and_uri_spec.ts:8:12)
at callFn (/Users/matt/git/github.com/cucumber/Cucucmber (JS)
/node_modules/mocha/lib/runnable.js:366:21)
at Test.Runnable.run (/Users/matt/git/github.com/cucumber/Cucucmber (JS)
/node_modules/mocha/lib/runnable.js:354:5)
at Runner.runTest (/Users/matt/git/github.com/cucumber/Cucucmber (JS)
/node_modules/mocha/lib/runner.js:680:10)
at /Users/matt/git/github.com/cucumber/Cucucmber (JS)
/node_modules/mocha/lib/runner.js:803:12
at next (/Users/matt/git/github.com/cucumber/Cucucmber (JS)
/node_modules/mocha/lib/runner.js:595:14)
at /Users/matt/git/github.com/cucumber/Cucucmber (JS)
/node_modules/mocha/lib/runner.js:605:7
at next (/Users/matt/git/github.com/cucumber/Cucucmber (JS)
/node_modules/mocha/lib/runner.js:488:14)
at Immediate._onImmediate (/Users/matt/git/github.com/cucumber/Cucucmber (JS)
/node_modules/mocha/lib/runner.js:573:5)
at processImmediate (internal/timers.js:461:21)
</code></pre>
<p>Now for the fix!</p>
<p>I <em>believe</em> that we can simply replace the call to <code>StackTrace.getSync()</code> on <a href="https://github.com/cucumber/cucumber-js/blob/fix-1735-parens-in-path/src/support_code_library_builder/get_definition_line_and_uri.ts#L14">line 14</a> with a call to <a href="https://www.npmjs.com/package/stack-chain#chaincallsiteoptions"><code>chain.callSite()</code></a> from the <code>stack-chain</code> library which we're already using elsewhere in the <a href="https://github.com/cucumber/cucumber-js/blob/a3aab754155c1c01730338979b586dc644899d23/src/stack_trace_filter.ts#L1"><code>StackTraceFilter</code></a> class. I had a play with it and it doesn't seem to have the same problem with parentheses. There's no need for us to have two dependencies that both do the same job, especially if one of them does it poorly.</p>
<p>Once you've done that, you can remove the dependency on <code>stacktrace-js</code> altogether, with <code>yarn remove stacktrace-js</code> and commit the change to <code>package.json</code> and <code>yarn.lock</code>.</p>
<p>Then we'll be ready for your first PR to cucumber-js! 🎉</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-24 11:08:57
[cucumber/cucumber-js] Pull request merged by charlierudolph
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-26 01:55:11
[cucumber/cucumber-js] Issue opened by tim-yao
<p><strong>Is your feature request related to a problem? Please describe.</strong><br />
Cucumber report(html, json formatter) doesn't include retried details when using <code>--retry</code>.</p>
<p>When we use <code>--retry</code>, report will mark the flaky test pass if there is one retry get pass. That is working as expected. However, if we can also add some details of <code>retry</code> in the report, e.g show the number of failed attempt, that will help us to find potential intermittent bugs, instead of hiding bugs.</p>
<p>The idea is coming from <a href="https://automationpanda.com/2021/06/14/are-automated-test-retries-good-or-bad/">https://automationpanda.com/2021/06/14/are-automated-test-retries-good-or-bad/</a></p>
<p><strong>Describe the solution you'd like</strong><br />
Something on the report to indicate there are retry attempts happened. Like the number of failed attempt. A example:<br />
<a href="https://user-images.githubusercontent.com/31641325/126961755-ac5ac219-2b6f-4d04-adb4-e3cc94d22fc3.png">specflow-report</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-26 02:59:20
[cucumber/cucumber-js] Comment on #1739
<p><a href="https://github.com/SabotageAndi">@SabotageAndi</a> how do you do this in Specflow :D Care to offer a quick win :)</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-26 21:05:53
[cucumber/cucumber-js] Comment on #1739
<p>We're not making any more changes to the JSON formatter, but this could be implemented in <a href="https://github.com/cucumber/common/tree/main/react/javascript#readme">https://github.com/cucumber/common/tree/main/react/javascript#readme</a></p>
<p>Shall we move this issue to <code>cucumber/common</code> and tag it with <code>react</code>?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-28 02:29:34
[cucumber/cucumber-js] Comment on #1649
<p>Good point - I have added a note for this.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-28 02:51:19
[cucumber/cucumber-js] Comment on #1649
<p>Agreed - fixed by inlining the import</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-28 02:56:53
[cucumber/cucumber-js] Comment on #1649
<p><a href="https://github.com/charlierudolph">@charlierudolph</a> <a href="https://github.com/aurelien-reeves">@aurelien-reeves</a> feedback addressed, and now using the file extension as a more deterministic way to know whether to fall back to <code>require</code> - basically if not a JS file, don't try and use native import. Let me know if you think we're good to go.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-28 05:52:21
[cucumber/cucumber-js] Comment on #1649
<p>We've lost the <code>try ... catch</code> around <code>require(codePath)</code> in the process. Is it on purpose?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-28 05:52:22
[cucumber/cucumber-js] aurelien-reeves approved davidjgoss's pull request
<p>There is a lot of changes, and those are not simple one.<br />
As long as the tests are passing, and there is not a big thing that we would certainly have noticed already, I give it a go despite my small question as part of the review</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-28 09:25:49
[cucumber/cucumber-js] Comment on #1649
<p>Why is importer used here always instead of a switch between importer / require? Same for other instances</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-28 09:52:18
[cucumber/cucumber-js] Comment on #1649
<p>For custom snippet syntaxes and formatters, there should be no need to fall back to <code>require</code> - we never supported transpilation for these things, so whether they are ESM or CommonJS modules, the <code>import</code> will just work. Support code is only different because of the transpilation angle (<code>import</code> will currently refuse to load a file that isn't JS just based on the extension).</p>
<p>(An earlier iteration had switching between <code>import</code> and <code>require</code> for all user code based on the now-dropped CLI option, but having removed Node 10 support that's no longer necessary.)</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-28 10:05:25
[cucumber/cucumber-js] Comment on #1649
<p>No - thanks, good catch. Re-added.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-28 10:09:37
[cucumber/cucumber-js] New release Release - v7.3.1 published by davidjgoss
<p><strong>Deprecated</strong></p>
<p>• Deprecate <code>setDefinitionFunctionWrapper</code> and step definition option <code>wrapperOptions</code></p>
<p><strong>Fixed</strong></p>
<p>• Prevent duplicate scenario execution where the same feature is targeted in multiple line expressions (<a href="https://github.com/cucumber/cucumber-js/issues/1706">#1706</a>)
• Fixed reports banner to point to <a href="https://cucumber.io/docs/cucumber/environment-variables/">new docs</a> about environment variables
• Re-add color functions for use with custom formatters <a href="https://github.com/cucumber/cucumber-js/issues/1582">1582</a>
• IParameterTypeDefinition regexp fix <a href="https://github.com/cucumber/cucumber-js/issues/1702">1702</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-28 13:24:14
[cucumber/cucumber-js] Comment on #1508
<p><a href="https://github.com/Taewa">@Taewa</a> i am looking for pretty much the same thing - did you get anywhere?<br />
I am trying to avoid using gherkin directly and then binding to step definitions directly or something like that.</p>
<p>PS: I got here digging through the docs and the issue tracker,<br />
<a href="https://github.com/jbpros">@jbpros</a> the online demo without a note that it is based on an outdated version and ONLY for illustration purposes is definitely irritating. Took me some time to get here..</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-28 13:33:16
[cucumber/cucumber-js] Comment on #1508
<p>Hi <a href="https://github.com/sijakret">@sijakret</a><br />
In the end, I took Cypress + CypressCucumber + Storybook. It work perfectly.</p>
<p>> <a href="https://github.com/Taewa">@Taewa</a> i am looking for pretty much the same thing - did you get anywhere?<br />
> I am trying to avoid using gherkin directly and then binding to step definitions directly or something like that.
>
> PS: I got here digging through the docs and the issue tracker,<br />
> <a href="https://github.com/jbpros">@jbpros</a> the online demo without a note that it is based on an outdated version and ONLY for illustration purposes is definitely irritating. Took me some time to get here..</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-29 07:20:28
[cucumber/cucumber-js] Issue opened by mbrzozowski-merapar
<p><strong>Describe the bug</strong><br />
I am trying to pull current step name out of ITestStepHookParameter in the BeforeStep hook:</p>
<pre><code>BeforeStep(async function(testStep) {
// Should be step name, is scenario name instead
const stepName = testStep.pickle.name;
// stepObj is undefined
const stepObj = testStep.pickle.steps.filter(step =&gt; {
return step.id === testStep.testStepId
});
});
</code></pre>
<p><strong>Cucumber-js version: 7.3.1</strong></p>
<p><strong>Expected behavior</strong><br />
I would expect the <code>testStep.testStepId</code> to be present in the array of steps in the <code>testStep.pickle.steps</code> object. However, that's not the case and the <code>testStepId</code> does not much any of the steps in the array.</p>
<p>Also, the <code>testStep.pickle.name</code> contains the name of the whole scenario, not the concrete step.<br />
As a result, it is not able to pull out the step name inside the BeforeStep hook.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-29 08:02:43
[cucumber/cucumber-js] Issue opened by dambler
<p>After upgrading to 7.3.1, I can see the deprecation notice for the <code>setDefinitionFunctionWrapper</code> method, suggesting to use the new <code>BeforeStep</code> and <code>AfterStep</code> methods instead.</p>
<p>I use <code>setDefinitionFunctionWrapper</code> in a project to control Scenario timeouts and I am at a loss with working out how I can achieve similar behaviour using these new step hooks.</p>
<p>The general gist of the code I am currently using is:</p>
<pre><code>const MAX_DURATION_IN_MS = 90_000;
let timeout: NodeJS.Timeout | undefined;
let maxEndtime = Date.now() + MAX_DURATION_IN_MS;
const clearExecutionTimeout = () =&gt; {
if (!timeout) return;
clearTimeout(timeoutId);
timeout = undefined;
};
setDefinitionFunctionWrapper(
(fn: Function) =&gt;
async function (this: any, ...args: any[]) {
// Only actual test steps should use this timeout value.
const shouldUseTimeOut =
args[0]?.pickle === undefined &amp;&amp;
args[0]?.result === undefined &amp;&amp;
maxEndtime !== undefined;
const promises: Promise&lt;void | string&gt;[] = [fn.apply(this, args)];
if (shouldUseTimeOut) {
promises.push(
new Promise((resolve) =&gt; {
timeout = global.setTimeout(
() =&gt; resolve('skipped'),
Math.max(maxEndtime! - Date.now(), 0),
);
return timeoutId;
}),
);
}
const result = await Promise.race(promises);
clearExecutionTimeout();
return result;
},
);
Before(() =&gt; {
maxEndtime = Date.now() + MAX_DURATION_IN_MS;
});
</code></pre>
<p>I am doing this as I am running these Scenarios inside an AWS lambda and I need to control their execution timeouts to ensure that we get feature JSON output before the handler exits completely.</p>
<p>I have tried setting a timeout in a <code>BeforeStep</code> hook, but retuning 'skipped' there is ignored. I have tried throwing inside a timeout also, but that causes the process to exit non-cleanly (i.e. the json report is not generated).</p>
<p>Any ideas if what I am trying to do is actually possible anymore without <code>setDefinitionFunctionWrapper</code>?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-29 14:02:32
[cucumber/cucumber-js] Pull request opened by aurelien-reeves
<p>I've made an update in the reindent-template-literals package to not process last blank lines, as this is done with first lines.</p>
<p>That has a small impact on the code: where the reindent function is used, we need to add an extra blank lines in the templates when the expected strings ends with a new-line.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-29 14:05:13
[cucumber/cucumber-js] Comment on #1742
<p><a href="https://coveralls.io/builds/41764803">Coverage Status</a></p>
<p>Coverage remained the same at 98.247% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/3da28c780cc4b49db00458102d023a30fa241250">3da28c7</a> on upgrade-reindent-template-literals</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/d4e7a766154fc6f4ba52e6c94fa863c2c54c7202">d4e7a76</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-29 14:13:34
[cucumber/cucumber-js] Pull request merged by aurelien-reeves
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-29 23:20:41
[cucumber/cucumber-js] Comment on #1728
<p><a href="https://github.com/fguidobaldi">@fguidobaldi</a> if you need to programatically run a test with specific user parameters, I'd use something like rspec instead.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-29 23:51:25
[cucumber/cucumber-js] Comment on #1728
<p>Your usecase sounds like you want a pairwise combination of parameters with different value sets (using the pairwise algorithm). If the number of combinations becomes too large, you would use something like property-based testing to select a subset of the combinations that is used in a test run. You basically have basically two possibilities, one that would work right now with cucumber and one if that functionality is provided in a cucumber implementation: <em>* SOLUTION 1: Feature files are text. Therefore, use a template and a template engine to generate the feature file with the examples before the test run. *</em> SOLUTION 2: Use tags to specify a generator mechanism on the Examples table. The tag injects the Example table generator algorithm and executes it before the test run (or similar: reads it from an external source, like Specflow with a CSV file or Excel spreadsheet) Note that this no longer BDD but a mechanism that uses cucumber to achieve the desired goal. SEE ALSO: ** <a href="https://github.com/behave/behave/issues/464">behave/behave#464</a></p>
<p><#|…></p>
<p>On 14. Jul 2021, at 17:06, Fabian Guidobaldi <strong><em>*</strong>@<strong></em><em></strong>.<strong></em>*</strong>> wrote: In a real scenario, each scenario I'm trying to run involves different variables (like users, countries, destinations, etc.), but I expect the same output, no matter what the exact combination of these variables is. That's why I'm trying to generate dynamically these combinations, in order to get a different set of inputs every time I run this test, and not just harcoding the values. You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-30 00:25:59
[cucumber/cucumber-js] Comment on #1740
<p>Indeed the pickle argument given to the callback of the <code>BeforeStep</code> seems to be related to the test case - maybe even the scenario actually - rather than the step.<br />
In our documentation, it is simply explained that we give a pickle, we do not say which one it is 😅</p>
<p>I think we could consider this as a bug. <a href="https://github.com/davidjgoss">@davidjgoss</a> <a href="https://github.com/charlierudolph">@charlierudolph</a> what do you think?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-30 00:31:00
[cucumber/cucumber-js] Comment on #1741
<p>Did you tried the built-in timeout feature of <code>cucumber-js</code>? Do you have issues with it?</p>
<p><a href="https://github.com/cucumber/cucumber-js/blob/main/docs/support_files/timeouts.md">https://github.com/cucumber/cucumber-js/blob/main/docs/support_files/timeouts.md</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-30 04:09:08
[cucumber/cucumber-js] Comment on #1741
<p>From what I understand, built in timeouts cannot be applied to scenarios as a whole. I need an individual scenario not to take over X seconds.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-30 04:36:59
[cucumber/cucumber-js] Comment on #1741
<p>You should give it a try<br />
I am pretty sure you can use it at the scenario level</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-30 04:53:31
[cucumber/cucumber-js] Comment on #1741
<p>Where exactly would you place it to make it affect the entire scenario? Just to clarify, I want the scenario to take no more than, for example 90 seconds, but the steps within the scenario can take as long as they want (within that time frame).</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-30 05:06:46
[cucumber/cucumber-js] Comment on #1741
<p>In the Before hook as explained in the documentation</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-30 05:25:09
[cucumber/cucumber-js] Comment on #1741
<p>As the doc says, we can set that <code>timeout</code> option in a <code>Before</code> hook, or in a step.</p>
<p>The <code>Before</code> hook apply to the whole scenario, not just for a step, so set your timeout in the <code>Before</code> hook, that should fit your needs.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-30 05:49:53
[cucumber/cucumber-js] Comment on #1741
<p>Using the <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/nodejs_example.md">nodejs example</a>, I added a delay method:</p>
<pre><code>const delay = (ms) =&gt; new Promise((res) =&gt; setTimeout(res, ms));
</code></pre>
<p>I set a timeout in a Before hook like so:</p>
<pre><code>Before({ timeout: 100 }, function () {
console.log("Hook");
});
</code></pre>
<p>I alter a step definition like so:</p>
<pre><code>Given("a variable set to {int}", async function (number) {
await delay(5000);
this.setTo(number);
});
</code></pre>
<p>When I execute the test, the test does <em>not</em> timeout after 100ms. It's quite possible I am missing something or doing something incorrectly, but I am just not seeing the behaviour you are saying should work!</p>
<p>I run the test like this <code>yarn cucumber-js .\features\simple_math.feature.feature:6</code> and this is the output I get:</p>
<pre><code>Hook
....
1 scenario (1 passed)
3 steps (3 passed)
0m05.016s (executing steps: 0m05.013s)
Done in 5.45s.
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-30 14:38:38
[cucumber/cucumber-js] Comment on #1741
<p>Could you share the whole code of your test please?</p>
<p>As you can see in the following link, we have a feature test in the code base of cucumber to validate that exact behavior</p>
<p><a href="https://github.com/cucumber/cucumber-js/blob/main/features/hook_timeouts.feature">https://github.com/cucumber/cucumber-js/blob/main/features/hook_timeouts.feature</a></p>
<p>We have to look for what differs between the feature test of cucumber, and your own test</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-31 00:54:58
[cucumber/cucumber-js] Comment on #1741
<p>Sure - here is the code. Its basically just a very minor modification to the NodeJS example in the repo.</p>
<pre><code>#features/support/world.js
const { setWorldConstructor } = require("@cucumber/cucumber");
class CustomWorld {
constructor() {
this.variable = 0;
}
setTo(number) {
this.variable = number;
}
incrementBy(number) {
this.variable += number;
}
}
setWorldConstructor(CustomWorld);
</code></pre>
<pre><code>#features/support/steps.js
const { Given, When, Then } = require("@cucumber/cucumber");
const assert = require("assert").strict;
const delay = (ms) =&gt; new Promise((res) =&gt; setTimeout(res, ms));
Given("a variable set to {int}", async function (number) {
await delay(5000);
this.setTo(number);
});
When("I increment the variable by {int}", function (number) {
this.incrementBy(number);
});
Then("the variable should contain {int}", function (number) {
assert.equal(this.variable, number);
});
</code></pre>
<pre><code>#features/support/hooks.js
const { Before } = require("@cucumber/cucumber");
Before({ timeout: 100 }, function () {
console.log("Hook");
});
</code></pre>
<pre><code>#features/simple_math.feature
Feature: Simple maths
In order to do maths
As a developer
I want to increment variables
Scenario: easy maths
Given a variable set to 1
When I increment the variable by 1
Then the variable should contain 2
Scenario Outline: much more complex stuff
Given a variable set to &lt;var&gt;
When I increment the variable by &lt;increment&gt;
Then the variable should contain &lt;result&gt;
Examples:
| var | increment | result |
| 100 | 5 | 105 |
| 99 | 1234 | 1333 |
| 12 | 5 | 17 |
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-31 17:01:26
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<p>📌 <strong>Important</strong>: Renovate will wait until you have merged this Pin PR before creating any <em>upgrade</em> PRs for the affected packages. Add the preset <code>:preserveSemverRanges</code> to your config if you instead don't wish to pin dependencies.</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-31 17:01:39
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-31 17:03:36
[cucumber/cucumber-js] Comment on #1743
<p><a href="https://coveralls.io/builds/41804761">Coverage Status</a></p>
<p>Coverage remained the same at 98.247% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/b4d4d38866d582f18a66c42d26b652baee2b4a66">b4d4d38</a> on renovate/pin-dependencies</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/79a2f89bdf0d3b58b2c3b22dd41bb049505753bd">79a2f89</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-31 17:05:39
[cucumber/cucumber-js] Comment on #1744
<p><a href="https://coveralls.io/builds/41804650">Coverage Status</a></p>
<p>Coverage remained the same at 98.247% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/185bc5bcbe1f1d4e0b6ce13279ddaccce01a8386">185bc5b</a> on renovate/express-4.x</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/ad4a25b062c2d2922cbbba09712cc026e28fbd5a">ad4a25b</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-31 17:19:37
[cucumber/cucumber-js] Pull request merged by renovate[bot]
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-31 18:24:43
[cucumber/cucumber-js] Pull request merged by renovate[bot]
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-31 18:25:26
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 16.x)
(https://github.com/cucumber/cucumber-js/runs/3211421258)
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/3211421216)
GitHub
2021-07-31 18:25:39
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-31 18:27:37
[cucumber/cucumber-js] Comment on #1745
<p><a href="https://coveralls.io/builds/41805206">Coverage Status</a></p>
<p>Coverage remained the same at 98.247% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/098b98fe405b9d071152b06de4d280356504ba8d">098b98f</a> on renovate/fs-extra-9.x</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/8da91614f465e1663cc604af59fef709761bdf9a">8da9161</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-31 18:30:05
[cucumber/cucumber-js] Comment on #1746
<p><a href="https://coveralls.io/builds/41805222">Coverage Status</a></p>
<p>Coverage remained the same at 98.247% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/985240cfc88221459eef94cfc6c6cb8053043b74">985240c</a> on renovate/glob-7.x</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/8da91614f465e1663cc604af59fef709761bdf9a">8da9161</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-31 20:06:01
[cucumber/cucumber-js] Pull request merged by renovate[bot]
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-31 20:07:05
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-31 20:07:19
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-31 20:11:30
[cucumber/cucumber-js] Comment on #1747
<p><a href="https://coveralls.io/builds/41805981">Coverage Status</a></p>
<p>Coverage remained the same at 98.247% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/01c067c14ac51a20d8e73ef707d1162c665c561e">01c067c</a> on renovate/mustache-4.x</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/2fcb308e88511b1dbe5c2861d562cbb8bfcb778e">2fcb308</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-31 20:11:35
[cucumber/cucumber-js] Comment on #1748
<p><a href="https://coveralls.io/builds/41805983">Coverage Status</a></p>
<p>Coverage remained the same at 98.247% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/f9385c22fdfd823dbcb342098149790b5d01366c">f9385c2</a> on renovate/mz-2.x</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/2fcb308e88511b1dbe5c2861d562cbb8bfcb778e">2fcb308</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-31 20:57:18
[cucumber/cucumber-js] Pull request merged by renovate[bot]
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-31 22:02:55
[cucumber/cucumber-js] Pull request merged by renovate[bot]
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-31 22:03:58
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-31 22:04:11
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 16.x)
(https://github.com/cucumber/cucumber-js/runs/3212124577)
GitHub
2021-07-31 22:08:02
[cucumber/cucumber-js] Comment on #1749
<p><a href="https://coveralls.io/builds/41806594">Coverage Status</a></p>
<p>Coverage remained the same at 98.247% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/a3d58bba9dcb83e7d7cfad08ad30800f7695d523">a3d58bb</a> on renovate/node-14.x</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/b39891507ca00caba84989267160777dd21ae8e9">b398915</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-31 22:10:10
[cucumber/cucumber-js] Comment on #1750
<p><a href="https://coveralls.io/builds/41806601">Coverage Status</a></p>
<p>Coverage remained the same at 98.247% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/0f58a6981e2ed47b09866dc392fdfdafec24febb">0f58a69</a> on renovate/progress-2.x</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/b39891507ca00caba84989267160777dd21ae8e9">b398915</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-31 23:47:29
[cucumber/cucumber-js] Pull request merged by renovate[bot]
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-31 23:48:48
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-31 23:49:02
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-31 23:54:30
[cucumber/cucumber-js] Comment on #1751
<p><a href="https://coveralls.io/builds/41807055">Coverage Status</a></p>
<p>Coverage remained the same at 98.247% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/bcc2e00f80cd94af74a356eaac8b1b582343f66d">bcc2e00</a> on renovate/resolve-1.x</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/c428d24bd2a5f8d2d7274628639cea4c4b615398">c428d24</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-07-31 23:57:00
[cucumber/cucumber-js] Comment on #1752
<p><a href="https://coveralls.io/builds/41807066">Coverage Status</a></p>
<p>Coverage remained the same at 98.247% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/563ff43c69d9cb52caad37ac6d7d170bb87d226a">563ff43</a> on renovate/semver-7.x</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/c428d24bd2a5f8d2d7274628639cea4c4b615398">c428d24</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-01 01:10:04
[cucumber/cucumber-js] Pull request merged by renovate[bot]
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-01 01:11:30
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-01 01:11:43
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/3212764267)
GitHub
2021-08-01 01:19:26
[cucumber/cucumber-js] Comment on #1753
<p><a href="https://coveralls.io/builds/41807490">Coverage Status</a></p>
<p>Coverage remained the same at 98.247% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/e642199c46aeaee98face7120d26396ca16109d7">e642199</a> on renovate/stream-buffers-3.x</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/c5df7809634c492a171753779e557fc78d0d9f9f">c5df780</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-01 01:21:21
[cucumber/cucumber-js] Comment on #1754
<p><a href="https://coveralls.io/builds/41807514">Coverage Status</a></p>
<p>Coverage remained the same at 98.247% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/2dc9759918a893d25ef0dbcdcea75e0e39c35d90">2dc9759</a> on renovate/tmp-0.x</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/c5df7809634c492a171753779e557fc78d0d9f9f">c5df780</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-01 03:21:34
[cucumber/cucumber-js] Pull request merged by renovate[bot]
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-01 03:23:11
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-01 03:23:26
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Release Notes</strong>
typescript-eslint/typescript-eslint
<strong><a href="https://togithub.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md#%E2%80%8B4285-httpsgithubcomtypescript-eslinttypescript-eslintcomparev4284v4285-2021-07-26|<code">https://togithub.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md#%E2%80%8B4285-httpsgithubcomtypescript-eslinttypescript-eslintcomparev4284v4285-2021-07-26|<code</a>v4.28.5</code>></strong></p>
<p><a href="https://togithub.com/typescript-eslint/typescript-eslint/compare/v4.28.4...v4.28.5">Compare Source</a></p>
<p><strong>Note:</strong> Version bump only for package <a href="https://togithub.com/typescript-eslint/parser">@typescript-eslint/parser</a></p>
<p><strong><a href="https://togithub.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md#%E2%80%8B4284-httpsgithubcomtypescript-eslinttypescript-eslintcomparev4283v4284-2021-07-19|<code">https://togithub.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md#%E2%80%8B4284-httpsgithubcomtypescript-eslinttypescript-eslintcomparev4283v4284-2021-07-19|<code</a>v4.28.4</code>></strong></p>
<p><a href="https://togithub.com/typescript-eslint/typescript-eslint/compare/v4.28.3...v4.28.4">Compare Source</a></p>
<p><strong>Note:</strong> Version bump only for package <a href="https://togithub.com/typescript-eslint/parser">@typescript-eslint/parser</a></p>
<p><strong><a href="https://togithub.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md#%E2%80%8B4283-httpsgithubcomtypescript-eslinttypescript-eslintcomparev4282v4283-2021-07-12|<code">https://togithub.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md#%E2%80%8B4283-httpsgithubcomtypescript-eslinttypescript-eslintcomparev4282v4283-2021-07-12|<code</a>v4.28.3</code>></strong></p>
<p><a href="https://togithub.com/typescript-eslint/typescript-eslint/compare/v4.28.2...v4.28.3">Compare Source</a></p>
<p><strong>Note:</strong> Version bump only for package <a href="https://togithub.com/typescript-eslint/parser">@typescript-eslint/parser</a></p>
<p><strong><a href="https://togithub.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md#%E2%80%8B4282-httpsgithubcomtypescript-eslinttypescript-eslintcomparev4281v4282-2021-07-05|<code">https://togithub.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md#%E2%80%8B4282-httpsgithubcomtypescript-eslinttypescript-eslintcomparev4281v4282-2021-07-05|<code</a>v4.28.2</code>></strong></p>
<p><a href="https://togithub.com/typescript-eslint/typescript-eslint/compare/v4.28.1...v4.28.2">Compare Source</a></p>
<p><strong>Note:</strong> Version bump only for package <a href="https://togithub.com/typescript-eslint/parser">@typescript-eslint/parser</a></p>
<p>eslint/eslint
<strong><a href="https://togithub.com/eslint/eslint/releases/v7.32.0"><code>v7.32.0</code></a></strong></p>
<p><a href="https://togithub.com/eslint/eslint/compare/v7.31.0...v7.32.0">Compare Source</a></p>
<p>• <a href="https://togithub.com/eslint/eslint/commit/3c78a7bff6044fd196ae3b737983e6744c6eb7c8"><code>3c78a7b</code></a> Chore: Adopt <code>eslint-plugin/prefer-message-ids</code> rule internally (<a href="https://togithub.com/eslint/eslint/issues/14841">#14841</a>) (Bryan Mishkin)
• <a href="https://togithub.com/eslint/eslint/commit/faecf56cdb4146b28bfa4f1980adb41b4d3614b1"><code>faecf56</code></a> Update: change reporting location for <code>curly</code> rule (refs <a href="https://togithub.com/eslint/eslint/issues/12334">#12334</a>) (<a href="https://togithub.com/eslint/eslint/issues/14766">#14766</a>) (Nitin Kumar)
• <a href="https://togithub.com/eslint/eslint/commit/d7dc07a15e256cee9232183165e2f6102f2c0873"><code>d7dc07a</code></a> Fix: ignore lines with empty elements (fixes <a href="https://togithub.com/eslint/eslint/issues/12756">#12756</a>) (<a href="https://togithub.com/eslint/eslint/issues/14837">#14837</a>) (Soufiane Boutahlil)
• <a href="https://togithub.com/eslint/eslint/commit/1bfbefdaaf19ef32df42b89a3f5d32cff1e5b831"><code>1bfbefd</code></a> New: Exit on fatal error (fixes <a href="https://togithub.com/eslint/eslint/issues/13711">#13711</a>) (<a href="https://togithub.com/eslint/eslint/issues/14730">#14730</a>) (Antonios Katopodis)
• <a href="https://togithub.com/eslint/eslint/commit/ed007c82ee9d2170c87500d98303554b5f90b915"><code>ed007c8</code></a> Chore: Simplify internal <code>no-invalid-meta</code> rule (<a href="https://togithub.com/eslint/eslint/issues/14842">#14842</a>) (Bryan Mishkin)
• <a href="https://togithub.com/eslint/eslint/commit/d53d9064b9dd0dd6a8ea39e07b16310c8364db69"><code>d53d906</code></a> Docs: Prepare data for website to indicate rules with suggestions (<a href="https://togithub.com/eslint/eslint/issues/14830">#14830</a>) (Bryan Mishkin)
• <a href="https://togithub.com/eslint/eslint/commit/d28f2ffb986e49d6da5c1d91215580591f4cfd35"><code>d28f2ff</code></a> Docs: Reference eslint-config-eslint to avoid potential for staleness (<a href="https://togithub.com/eslint/eslint/issues/14805">#14805</a>) (Brett Zamir)
• <a href="https://togithub.com/eslint/eslint/commit/8be8a36010145dfcd31cbdd4f781a91989e3b1bd"><code>8be8a36</code></a> Chore: Adopt <code>eslint-plugin/require-meta-docs-url</code> rule internally (<a href="https://togithub.com/eslint/eslint/issues/14823">#14823</a>) (Bryan Mishkin)
• <a href="https://togithub.com/eslint/eslint/commit/f9c164f7b74ca73384c8c80eed5bdbe359b44f6c"><code>f9c164f</code></a> Docs: New syntax issue template (<a href="https://togithub.com/eslint/eslint/issues/14826">#14826</a>) (Nicholas C. Zakas)
• <a href="https://togithub.com/eslint/eslint/commit/eba0c4595c126a91f700d5f2e8723ec3f820a830"><code>eba0c45</code></a> Chore: assertions on reporting loc in <code>unicode-bom</code> (refs <a href="https://togithub.com/eslint/eslint/issues/12334">#12334</a>) (<a href="https://togithub.com/eslint/eslint/issues/14809">#14809</a>) (Nitin Kumar)
• <a href="https://togithub.com/eslint/eslint/commit/ed945bd662714b1917e9de71d5b322a28be9161b"><code>ed945bd</code></a> Docs: fix multiple broken links (<a href="https://togithub.com/eslint/eslint/issues/14833">#14833</a>) (Sam Chen)
• <a href="https://togithub.com/eslint/eslint/commit/60df44c79b0f74406119c0c040a360ca84e721fc"><code>60df44c</code></a> Chore: use <code>actions/setup-node@v2</code> (<a href="https://togithub.com/eslint/eslint/issues/14816">#14816</a>) (Nitin Kumar)
• <a href="https://togithub.com/eslint/eslint/commit/6641d88e17d952a8e51df5e0d3882a842d4c3f35"><code>6641d88</code></a> Docs: Update README team and sponsors (ESLint Jenkins)</p>
<p><strong><a href="https://togithub.com/eslint/eslint/releases/v7.31.0"><code>v7.31.0</code></a></strong></p>
<p><a href="https://togithub.com/eslint/eslint/compare/v7.30.0...v7.31.0">Compare Source</a></p>
<p>• <a href="https://togithub.com/eslint/eslint/commit/efdbb1227019427ec2d968a8d6e9151dd8a77c35"><code>efdbb12</code></a> Upgrade: <a href="https://togithub.com/eslint/eslintrc">@eslint/eslintrc</a> to v0.4.3 (<a href="https://togithub.com/eslint/eslint/issues/14808">#14808</a>) (Brandon Mills)
• <a href="https://togithub.com/eslint/eslint/commit/a96b05f6c5649cfee112d605c91d95aa191e2f78"><code>a96b05f</code></a> Update: add end location to report in <code>consistent-return</code> (refs <a href="https://togithub.com/eslint/eslint/issues/12334">#12334</a>) (<a href="https://togithub.com/eslint/eslint/issues/14798">#14798</a>) (Nitin Kumar)
• <a href="https://togithub.com/eslint/eslint/commit/e0e8e308929c9c66612505f2da89043f8592eea7"><code>e0e8e30</code></a> Docs: update BUG_REPORT template (<a href="https://togithub.com/eslint/eslint/issues/14787">#14787</a>) (Nitin Kumar)
• <a href="https://togithub.com/eslint/eslint/commit/39115c8b71d2629161359f6456f47fdbd552fddd"><code>39115c8</code></a> Docs: provide more context to no-eq-null (<a href="https://togithub.com/eslint/eslint/issues/14801">#14801</a>) (gfyoung)
• <a href="https://togithub.com/eslint/eslint/commit/9a3c73c130d437a65f4edba0dcb63390e68cac41"><code>9a3c73c</code></a> Docs: fix a broken link (<a href="https://togithub.com/eslint/eslint/issues/14790">#14790</a>) (Sam Chen)
• <a href="https://togithub.com/eslint/eslint/commit/ddffa8ad58b4b124b08061e9045fdb5370cbdbe3"><code>ddffa8a</code></a> Update: Indicating the operator in question (<a href="https://togithub.com/eslint/eslint/issues/14764">#14764</a>) (Paul Smith)
• <a href="https://togithub.com/eslint/eslint/commit/bba714c2ed813821ed288fbc07722cdde6e534fe"><code>bba714c</code></a> Update: Clarifying what changes need to be made in no-mixed-operators (<a href="https://togithub.com/eslint/eslint/issues/14765">#14765</a>) (Paul Smith)
• <a href="https://togithub.com/eslint/eslint/commit/b0d22e3eff18ea7f08189134c07cddceaec69a09"><code>b0d22e3</code></a> Docs: Mention benefit of providing <code>meta.docs.url</code> (<a href="https://togithub.com/eslint/eslint/issues/14774">#14774</a>) (Bryan Mishkin)
• <a href="https://togithub.com/eslint/eslint/commit/000cc796fd487e7b9ba8bcc5857dd691044479cc"><code>000cc79</code></a> Sponsors: Sync README with website (ESLint Jenkins)
• <a href="https://togithub.com/eslint/eslint/commit/a6a7438502abc6a1e29ec35cfbe2058ffc0803b1"><code>a6a7438</code></a> Chore: pin fs-teardown@0.1.1 (<a href="https://togithub.com/eslint/eslint/issues/14771">#14771</a>) (Milos Djermanovic)</p>
<p><strong><a href="https://togithub.com/eslint/eslint/releases/v7.30.0"><code>v7.30.0</code></a></strong></p>
<p><a href="https://togithub.com/eslint/eslint/compare/v7.29.0...v7.30.0">Compare Source</a></p>
<p>• <a href="https://togithub.com/eslint/eslint/commit/5f746420700d457b92dd86659de588d272937b79"><code>5f74642</code></a> Chore: don't check Program.start in SourceCode#getComments (refs <a href="https://togithub.com/eslint/eslint/issues/14744">#14744</a>) (<a href="https://togithub.com/eslint/eslint/issues/14748">#14748</a>) (Milos Djermanovic)
• <a href="https://togithub.com/eslint/eslint/commit/19a871a35ae9997ce352624b1081c96c54b73a9f"><code>19a871a</code></a> Docs: Suggest linting plugins for ESLint plugin developers (<https://togi…</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-01 03:33:03
[cucumber/cucumber-js] Comment on #1755
<p><a href="https://coveralls.io/builds/41808573">Coverage Status</a></p>
<p>Coverage remained the same at 98.247% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/fcbcfff59da865f0a2ae359bbdbcc772e1aac996">fcbcfff</a> on renovate/verror-1.x</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/c6759207672242820a7ac51e2ecb75e62ba24e78">c675920</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-01 03:34:59
[cucumber/cucumber-js] Comment on #1756
<p><a href="https://coveralls.io/builds/41808590">Coverage Status</a></p>
<p>Coverage remained the same at 98.247% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/d66d30c4209e64561774852cc20a28b16cfa8955">d66d30c</a> on renovate/eslint-packages</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/c6759207672242820a7ac51e2ecb75e62ba24e78">c675920</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-01 05:17:47
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-01 05:17:49
[cucumber/cucumber-js] Pull request merged by renovate[bot]
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-01 05:19:44
[cucumber/cucumber-js] Comment on #1757
<p><a href="https://coveralls.io/builds/41809468">Coverage Status</a></p>
<p>Coverage remained the same at 98.247% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/95845514532fafca525dda283be8dc76c021486a">9584551</a> on renovate/node-14.x</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/b54bcd722b4535f4f197d1f0d44d2039de01e579">b54bcd7</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-01 05:20:11
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Release Notes</strong>
mochajs/mocha
<strong><a href="https://togithub.com/mochajs/mocha/blob/master/CHANGELOG.md#%E2%80%8B903--2021-07-25|<code">https://togithub.com/mochajs/mocha/blob/master/CHANGELOG.md#%E2%80%8B903--2021-07-25|<code</a>v9.0.3</code>></strong></p>
<p><a href="https://togithub.com/mochajs/mocha/compare/v9.0.2...v9.0.3">Compare Source</a></p>
<p><strong>🐛 Fixes</strong></p>
<p>• <a href="https://togithub.com/mochajs/mocha/issues/4702">#4702</a>: Error rethrow from cwd-relative path while loading <code>.mocharc.js</code> (<a href="https://togithub.com/kirill-golovan"><strong>@kirill-golovan</strong></a>)
• <a href="https://togithub.com/mochajs/mocha/issues/4688">#4688</a>: Usage of custom interface in parallel mode (<a href="https://togithub.com/juergba"><strong>@juergba</strong></a>)
• <a href="https://togithub.com/mochajs/mocha/issues/4687">#4687</a>: ESM: don't swallow <code>MODULE_NOT_FOUND</code> errors in case of <code>type:module</code> (<a href="https://togithub.com/giltayar"><strong>@giltayar</strong></a>)</p>
<p><strong><a href="https://togithub.com/mochajs/mocha/blob/master/CHANGELOG.md#%E2%80%8B902--2021-07-03|<code">https://togithub.com/mochajs/mocha/blob/master/CHANGELOG.md#%E2%80%8B902--2021-07-03|<code</a>v9.0.2</code>></strong></p>
<p><a href="https://togithub.com/mochajs/mocha/compare/v9.0.1...v9.0.2">Compare Source</a></p>
<p><strong>🐛 Fixes</strong></p>
<p>• <a href="https://togithub.com/mochajs/mocha/issues/4668">#4668</a>: ESM: make <code>--require &lt;dir&gt;</code> work with new <code>import</code>-first loading (<a href="https://togithub.com/giltayar"><strong>@giltayar</strong></a>)</p>
<p><strong>🔩 Other</strong></p>
<p>• <a href="https://togithub.com/mochajs/mocha/issues/4674">#4674</a>: Update production dependencies (<a href="https://togithub.com/juergba"><strong>@juergba</strong></a>)</p>
<p>sinonjs/sinon
<strong><a href="https://togithub.com/sinonjs/sinon/compare/v11.1.1...e97b8427b896337bb4f75fe9b6a858d6eed0297e"><code>v11.1.2</code></a></strong></p>
<p><a href="https://togithub.com/sinonjs/sinon/compare/v11.1.1...e97b8427b896337bb4f75fe9b6a858d6eed0297e">Compare Source</a></p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>👻 <strong>Immortal</strong>: This PR will be recreated if closed unmerged. Get <a href="https://togithub.com/renovatebot/renovate/discussions">config help</a> if that's undesired.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/3213652072)
GitHub
2021-08-01 05:34:56
[cucumber/cucumber-js] Comment on #1758
<p><a href="https://coveralls.io/builds/41809606">Coverage Status</a></p>
<p>Coverage remained the same at 98.247% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/dfb4c813bd39a59e6995ccbee15524ae10fa3b5d">dfb4c81</a> on renovate/unit-test-packages</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/b54bcd722b4535f4f197d1f0d44d2039de01e579">b54bcd7</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-01 07:24:24
[cucumber/cucumber-js] Pull request merged by renovate[bot]
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-01 07:26:42
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 16.x)
(https://github.com/cucumber/cucumber-js/runs/3214129876)
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/3214129861)
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/3214129850)
GitHub Actions: test (ubuntu-latest, 16.x)
(https://github.com/cucumber/cucumber-js/runs/3214129835)
GitHub Actions: test (ubuntu-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/3214129820)
GitHub Actions: test (ubuntu-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/3214129803)
GitHub Actions: test (windows-latest, 16.x)
(https://github.com/cucumber/cucumber-js/runs/3214129642)
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/3214129629)
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/3214129616)
GitHub Actions: test (ubuntu-latest, 16.x)
(https://github.com/cucumber/cucumber-js/runs/3214129602)
GitHub Actions: test (ubuntu-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/3214129590)
GitHub Actions: test (ubuntu-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/3214129569)
GitHub
2021-08-01 07:26:56
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Release Notes</strong>
TypeStrong/ts-node
<strong><a href="https://togithub.com/TypeStrong/ts-node/releases/v10.1.0"><code>v10.1.0</code></a></strong></p>
<p><a href="https://togithub.com/TypeStrong/ts-node/compare/v10.0.0...v10.1.0">Compare Source</a></p>
<p>Questions about this release? Ask in the official discussion thread: <a href="https://togithub.com/TypeStrong/ts-node/issues/1390">#1390</a></p>
<p><strong>Added</strong></p>
<p>• Add <code>"moduleType"</code> option to override module type -- CommonJS or ECMAScript -- on select files. (<a href="https://typestrong.org/ts-node/docs/module-type-overrides">docs</a>) (<a href="https://togithub.com/TypeStrong/ts-node/issues/1342">#1342</a>, <a href="https://togithub.com/TypeStrong/ts-node/issues/1371">#1371</a>, <a href="https://togithub.com/TypeStrong/ts-node/issues/1376">#1376</a>)
• Useful when a configuration file, for example <code>webpack.config.ts</code>, must execute as CommonJS but the rest of the project is ESM
• selectively overrides <code>package.json</code> <code>"type"</code> and <code>tsconfig.json</code> <code>"module"</code>
• akin to <code>.cjs</code> and <code>.mjs</code> extensions, but for <code>.ts</code> and <code>.tsx</code> files
• thanks to <a href="https://togithub.com/jayaddison">@jayaddison</a> for help on test coverage
• Implement <code>"extends"</code> support for <code>"ts-node"</code> options in <code>tsconfig.json</code> (<a href="https://togithub.com/TypeStrong/ts-node/issues/1328">#1328</a>, <a href="https://togithub.com/TypeStrong/ts-node/issues/1356">#1356</a>)
• <code>"ts-node": {}</code> options will be parsed from extended tsconfigs
• allows sharing and deduplicating ts-node configuration
• Un-deprecate <code>scope</code> and <code>scopeDir</code>; add both to CLI and <code>tsconfig.json</code> options; un-deprecate <code>TS_NODE_SCOPE</code> env var; add <code>TS_NODE_SCOPE_DIR</code> env var (<a href="https://typestrong.org/ts-node/docs/options">docs</a>) (<a href="https://togithub.com/TypeStrong/ts-node/issues/1346">#1346</a>, <a href="https://togithub.com/TypeStrong/ts-node/issues/1367">#1367</a>)</p>
<p><strong>Changed</strong></p>
<p>• Improve error messages thrown by native ESM loader hooks (<a href="https://togithub.com/TypeStrong/ts-node/issues/1357">#1357</a>, <a href="https://togithub.com/TypeStrong/ts-node/issues/1373">#1373</a>) <a href="https://togithub.com/tars0x9752">@tars0x9752</a>
• messages more closely match node; are more descriptive
• Emit <code>"ts-node"</code> object at the top of <code>--showConfig</code> output instead of the bottom (<a href="https://togithub.com/TypeStrong/ts-node/issues/1355">#1355</a>)</p>
<p><strong>Fixed</strong></p>
<p>• Fix <a href="https://togithub.com/TypeStrong/ts-node/issues/1282">#1282</a>: Set correct globals in <code>[stdin]</code>, <code>[eval]</code>, and <code>&lt;repl&gt;</code> contexts (<a href="https://togithub.com/TypeStrong/ts-node/issues/1333">#1333</a>)
• More closely align ts-node's behavior with vanilla node
• Affects the interactive REPL, piping to stdin, and <code>ts-node -e</code>
• Matches node's behavior for globals <code>__filename</code>, <code>__dirname</code>, <code>module</code> and sub-fields of <code>module</code>, <code>exports</code>, and builtin module aliases <code>fs</code>, etc
• Fix <a href="https://togithub.com/TypeStrong/ts-node/issues/1343">#1343</a>: Set swc option <code>keepClassNames</code> to <code>true</code> (<a href="https://togithub.com/TypeStrong/ts-node/issues/1344">#1344</a>)
• Fix: <a href="https://togithub.com/TypeStrong/ts-node/issues/1387">#1387</a>: REPL outputs 'use strict' after first empty line of input (<a href="https://togithub.com/TypeStrong/ts-node/issues/1388">#1388</a>) <a href="https://togithub.com/ejose19">@ejose19</a></p>
<p><strong>Docs</strong></p>
<p>• Update ESM docs to say that env vars <em>are</em> supported with <code>node --loader ts-node/esm</code> (<a href="https://togithub.com/TypeStrong/ts-node/issues/1007">docs</a>) (<a href="https://togithub.com/TypeStrong/ts-node/issues/1379">#1379</a>)</p>
<p><a href="https://github.com/TypeStrong/ts-node/milestone/3">https://github.com/TypeStrong/ts-node/milestone/3</a></p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Enabled.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-01 07:41:34
[cucumber/cucumber-js] Comment on #1760
<p><a href="https://coveralls.io/builds/41810728">Coverage Status</a></p>
<p>Coverage remained the same at 98.247% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/c86b76052e7841cfe42e6999b212e11e5321d938">c86b760</a> on renovate/ts-node-10.x</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/2bc7639cc2eb721a39547fc0fcd83ab190c02c9c">2bc7639</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-01 08:33:57
[cucumber/cucumber-js] Pull request merged by renovate[bot]
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-01 08:36:23
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Disabled by config. Please merge this manually once you are satisfied.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-01 08:36:37
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Release Notes</strong>
cucumber/gherkin-javascript
<strong><a href="https://togithub.com/cucumber/gherkin-javascript/compare/v20.0.0...v20.0.1"><code>v20.0.1</code></a></strong></p>
<p><a href="https://togithub.com/cucumber/gherkin-javascript/compare/v20.0.0...v20.0.1">Compare Source</a></p>
<p><strong><a href="https://togithub.com/cucumber/gherkin-javascript/compare/v19.0.3...v20.0.0"><code>v20.0.0</code></a></strong></p>
<p><a href="https://togithub.com/cucumber/gherkin-javascript/compare/v19.0.3...v20.0.0">Compare Source</a></p>
<p>cucumber/messages-javascript
<strong><a href="https://togithub.com/cucumber/messages-javascript/compare/v17.0.0...v17.0.1"><code>v17.0.1</code></a></strong></p>
<p><a href="https://togithub.com/cucumber/messages-javascript/compare/v17.0.0...v17.0.1">Compare Source</a></p>
<p><strong><a href="https://togithub.com/cucumber/messages-javascript/compare/v16.0.1...v17.0.0"><code>v17.0.0</code></a></strong></p>
<p><a href="https://togithub.com/cucumber/messages-javascript/compare/v16.0.1...v17.0.0">Compare Source</a></p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Disabled by config. Please merge this manually once you are satisfied.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>👻 <strong>Immortal</strong>: This PR will be recreated if closed unmerged. Get <a href="https://togithub.com/renovatebot/renovate/discussions">config help</a> if that's undesired.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 16.x)
(https://github.com/cucumber/cucumber-js/runs/3214373956)
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/3214373938)
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/3214373916)
GitHub Actions: test (ubuntu-latest, 16.x)
(https://github.com/cucumber/cucumber-js/runs/3214373882)
GitHub Actions: test (ubuntu-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/3214373856)
GitHub Actions: test (ubuntu-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/3214373834)
GitHub Actions: test (windows-latest, 16.x)
(https://github.com/cucumber/cucumber-js/runs/3214373740)
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/3214373728)
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/3214373714)
GitHub Actions: test (ubuntu-latest, 16.x)
(https://github.com/cucumber/cucumber-js/runs/3214373694)
GitHub Actions: test (ubuntu-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/3214373681)
GitHub Actions: test (ubuntu-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/3214373660)
GitHub
2021-08-01 08:50:25
[cucumber/cucumber-js] Comment on #1761
<p><a href="https://coveralls.io/builds/41811177">Coverage Status</a></p>
<p>Coverage remained the same at 98.247% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/0f2bd63701f0d4ae2659d9a35baf16fb556fb3ab">0f2bd63</a> on renovate/major-unit-test-packages</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/c5e7ad0a96abdfe394e5f3127744441b8f15e527">c5e7ad0</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-01 09:41:46
[cucumber/cucumber-js] Pull request merged by renovate[bot]
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-01 09:44:24
[cucumber/cucumber-js] Pull request opened by renovate[bot]
<https://github.com/cucumber/cucumber-js/pull/1763|#1763 fix(deps): update dependency figures to v4>
<p><a href="https://renovatebot.com">WhiteSource Renovate</a></p>
<p>This PR contains the following updates:</p>
<hr />
<p><strong>Release Notes</strong>
sindresorhus/figures
<strong><a href="https://togithub.com/sindresorhus/figures/releases/v4.0.0"><code>v4.0.0</code></a></strong></p>
<p><a href="https://togithub.com/sindresorhus/figures/compare/v3.2.0...v4.0.0">Compare Source</a></p>
<p><strong>Breaking</strong></p>
<p>• Require Node.js 12 (<a href="https://togithub.com/sindresorhus/figures/issues/79">#79</a>) <a href="https://togithub.com/sindresorhus/figures/commit/5e8705e"><code>5e8705e</code></a>
• This package is now pure ESM. Please <a href="https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c">read this</a>.
• Rename <code>main</code> and <code>windows</code> to <code>mainSymbols</code> and <code>fallbackSymbols</code> (<a href="https://togithub.com/sindresorhus/figures/issues/78">#78</a>) <a href="https://togithub.com/sindresorhus/figures/commit/483ed89"><code>483ed89</code></a>
• Separate <code>replaceSymbols()</code> method (<a href="https://togithub.com/sindresorhus/figures/issues/77">#77</a>) <a href="https://togithub.com/sindresorhus/figures/commit/5aa4c62"><code>5aa4c62</code></a>
• Make <code>square</code> character to fill the whole area (<a href="https://togithub.com/sindresorhus/figures/issues/66">#66</a>) <a href="https://togithub.com/sindresorhus/figures/commit/fafe61a"><code>fafe61a</code></a></p>
<p><strong>New symbols</strong></p>
<p>• Add <code>arrowLeftRight</code> and <code>arrowUpDown</code> symbol (<a href="https://togithub.com/sindresorhus/figures/issues/43">#43</a>) <a href="https://togithub.com/sindresorhus/figures/commit/bac7335"><code>bac7335</code></a>
• Add symbol for box lines (<a href="https://togithub.com/sindresorhus/figures/issues/70">#70</a>) <a href="https://togithub.com/sindresorhus/figures/commit/3a5c569"><code>3a5c569</code></a>
• Add symbol for fill characters (<a href="https://togithub.com/sindresorhus/figures/issues/67">#67</a>) <a href="https://togithub.com/sindresorhus/figures/commit/4d9dfc0"><code>4d9dfc0</code></a>
• Add symbol for some common mathematical symbols (<a href="https://togithub.com/sindresorhus/figures/issues/62">#62</a>) <a href="https://togithub.com/sindresorhus/figures/commit/26343b9"><code>26343b9</code></a>
• Add symbol for musical notes (<a href="https://togithub.com/sindresorhus/figures/issues/61">#61</a>) <a href="https://togithub.com/sindresorhus/figures/commit/9876125"><code>9876125</code></a>
• Add symbol for triangles and lozenges (<a href="https://togithub.com/sindresorhus/figures/issues/64">#64</a>) <a href="https://togithub.com/sindresorhus/figures/commit/b91f16c"><code>b91f16c</code></a>
• Add symbol for subscript numbers (<a href="https://togithub.com/sindresorhus/figures/issues/63">#63</a>) <a href="https://togithub.com/sindresorhus/figures/commit/eb77ed3"><code>eb77ed3</code></a></p>
<p><strong>Improvements</strong></p>
<p>• Add support for Windows terminals with Unicode fonts (<a href="https://togithub.com/sindresorhus/figures/issues/80">#80</a>) <a href="https://togithub.com/sindresorhus/figures/commit/253f966"><code>253f966</code></a>
• Improve percentages symbols (<a href="https://togithub.com/sindresorhus/figures/issues/45">#45</a>) <a href="https://togithub.com/sindresorhus/figures/commit/b0a7ef2"><code>b0a7ef2</code></a>
• Improve <code>bullet</code> symbol (<a href="https://togithub.com/sindresorhus/figures/issues/36">#36</a>) <a href="https://togithub.com/sindresorhus/figures/commit/e4d709a"><code>e4d709a</code></a>
• Improve <code>pointerSmall</code> symbol (<a href="https://togithub.com/sindresorhus/figures/issues/39">#39</a>) <a href="https://togithub.com/sindresorhus/figures/commit/3bf5f0d"><code>3bf5f0d</code></a>
• Improve <code>ellipsis</code> symbol (<a href="https://togithub.com/sindresorhus/figures/issues/38">#38</a>) <a href="https://togithub.com/sindresorhus/figures/commit/4e7f308"><code>4e7f308</code></a>
• Improve <code>dot</code> symbol (<a href="https://togithub.com/sindresorhus/figures/issues/37">#37</a>) <a href="https://togithub.com/sindresorhus/figures/commit/5c09660"><code>5c09660</code></a>
• Improve <code>square</code> and <code>squareFilled</code> symbol (<a href="https://togithub.com/sindresorhus/figures/issues/42">#42</a>) <a href="https://togithub.com/sindresorhus/figures/commit/a06d5b7"><code>a06d5b7</code></a>
• Improve the <code>star</code> symbol (<a href="https://togithub.com/sindresorhus/figures/issues/41">#41</a>) <a href="https://togithub.com/sindresorhus/figures/commit/745987c"><code>745987c</code></a>
• Improve performance of <code>replaceSymbols()</code> (<a href="https://togithub.com/sindresorhus/figures/issues/49">#49</a>) <a href="https://togithub.com/sindresorhus/figures/commit/9c36efc"><code>9c36efc</code></a>
• Improve documentation (<a href="https://togithub.com/sindresorhus/figures/issues/59">#59</a>) <a href="https://togithub.com/sindresorhus/figures/commit/6a43c8a"><code>6a43c8a</code></a>, (<a href="https://togithub.com/sindresorhus/figures/issues/65">#65</a>) <a href="https://togithub.com/sindresorhus/figures/commit/ad85a33"><code>ad85a33</code></a>, (<a href="https://togithub.com/sindresorhus/figures/issues/76">#76</a>) <a href="https://togithub.com/sindresorhus/figures/commit/53c3c6c"><code>53c3c6c</code></a>, (<a href="https://togithub.com/sindresorhus/figures/issues/86">#86</a>) <a href="https://togithub.com/sindresorhus/figures/commit/b314c7b"><code>b314c7b</code></a></p>
<p><strong>Fixes</strong></p>
<p>• Fix <code>circleQuestionMark</code> character does not display properly on Ubuntu (<a href="https://togithub.com/sindresorhus/figures/issues/47">#47</a>) <a href="https://togithub.com/sindresorhus/figures/commit/b86dde4"><code>b86dde4</code></a></p>
<hr />
<p><strong>Configuration</strong></p>
<p>📅 <strong>Schedule</strong>: "on the first day of the month" (UTC).</p>
<p>🚦 <strong>Automerge</strong>: Disabled by config. Please merge this manually once you are satisfied.</p>
<p>♻️ <strong>Rebasing</strong>: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.</p>
<p>🔕 <strong>Ignore</strong>: Close this PR and you won't be reminded about this update again.</p>
<hr />
<p>☐ If you want to rebase/retry this PR, check this box.</p>
<hr />
<p>This PR has been generated by <a href="https://renovate.whitesourcesoftware.com">WhiteSource Renovate</a>. View repository job log <a href="https://app.renovatebot.com/dashboard#github/cucumber/cucumber-js">here</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub Actions: test (windows-latest, 16.x)
(https://github.com/cucumber/cucumber-js/runs/3214592995)
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/3214592985)
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/3214592976)
GitHub Actions: test (ubuntu-latest, 16.x)
(https://github.com/cucumber/cucumber-js/runs/3214592973)
GitHub Actions: test (ubuntu-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/3214592969)
GitHub Actions: test (ubuntu-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/3214592964)
GitHub Actions: test (windows-latest, 16.x)
(https://github.com/cucumber/cucumber-js/runs/3214592905)
GitHub Actions: test (windows-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/3214592895)
GitHub Actions: test (windows-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/3214592881)
GitHub Actions: test (ubuntu-latest, 16.x)
(https://github.com/cucumber/cucumber-js/runs/3214592875)
GitHub Actions: test (ubuntu-latest, 14.x)
(https://github.com/cucumber/cucumber-js/runs/3214592867)
GitHub Actions: test (ubuntu-latest, 12.x)
(https://github.com/cucumber/cucumber-js/runs/3214592855)
GitHub
2021-08-01 10:48:26
[cucumber/cucumber-js] Pull request merged by renovate[bot]
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-01 12:14:20
[cucumber/cucumber-js] Pull request merged by renovate[bot]
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-01 13:29:39
[cucumber/cucumber-js] Pull request merged by renovate[bot]
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-01 15:00:22
[cucumber/cucumber-js] Pull request merged by renovate[bot]
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-01 16:28:45
[cucumber/cucumber-js] Pull request merged by renovate[bot]
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-01 18:33:32
[cucumber/cucumber-js] Comment on #1649
<p>Why the dedicated return statement?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-01 18:36:27
[cucumber/cucumber-js] Comment on #1649
<p>What makes this need to be a require instead of an import?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-01 18:36:56
[cucumber/cucumber-js] Comment on #1649
<p>Looks great! Just a couple comments</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-02 00:42:24
[cucumber/cucumber-js] Comment on #1741
<p>Thanks.</p>
<p>So, indded, I was totally wrong 😰<br />
The timeout is for the hook itself, not for the whole scenario</p>
<p>I continue looking into your issue...</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-02 03:18:10
[cucumber/cucumber-js] Comment on #1741
<p>I've been able to have something that looks a little bit like your original code:</p>
<pre><code>const MAX_DURATION_IN_MS = 500;
let timeout = undefined;
let maxEndtime = Date.now() + MAX_DURATION_IN_MS;
const clearExecutionTimeout = () =&gt; {
if (!timeout) return;
clearTimeout(timeout);
timeout = undefined;
};
Before(function (testStep) {
maxEndtime = Date.now() + MAX_DURATION_IN_MS;
});
BeforeStep(async function (test) {
timeout = global.setTimeout(() =&gt; {
throw 'timedout'
},
Math.max(maxEndtime - Date.now(), 0)
)
return Promise.resolve()
})
AfterStep(function ({result}) {
clearExecutionTimeout()
})
</code></pre>
<p>However I've not been able to set the step has being <code>skipped</code>. I've only succeeded into rejecting the Promise so it result into an error, thus a failed step. I hope that would still help?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-02 03:21:06
[cucumber/cucumber-js] Pull request merged by aurelien-reeves
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-02 03:42:27
[cucumber/cucumber-js] Comment on #1741
<p>Thanks for taking the time to look into this - I tried something similar and the issue with this approach is the exit isn't clean, i.e. my formatters are not run, and I need the JSON output for my reporting stack.</p>
<p>Unfortunately the deprectation of this method (without a viable workaround) may require me to not upgrade to future versions of Cucumber, which sucks!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-02 05:00:43
[cucumber/cucumber-js] Comment on #1741
<p>> Thanks for taking the time to look into this - I tried something similar and the issue with this approach is the exit isn't clean, i.e. my formatters are not run, and I need the JSON output for my reporting stack.</p>
<p>That's an issue on your side. I've just tested with the code I've posted earlier, and the exit is clean and the formatters are properly executed.</p>
<p>Note that the Promises that have triggered a timeout are still executed in the back and may delay the exit of the process.<br />
This is an issue with the code I've submitted, but also with your original code.</p>
<pre><code>$ npm test
&gt; test
&gt; cucumber-js --publish-quiet --format=json
[
{
"description": "",
"elements": [
{
"description": "",
"id": ";sample-test-case",
"keyword": "Scenario Outline",
"line": 4,
"name": "Sample test case",
"steps": [
{
"keyword": "Before",
"hidden": true,
"result": {
"status": "passed",
"duration": 0
}
},
{
"arguments": [],
"keyword": "Given ",
"line": 5,
"name": "this is a test case",
"match": {
"location": "features/step_definitions/steps.js:3"
},
"result": {
"status": "passed",
"duration": 0
}
},
{
"arguments": [
{
"rows": [
{
"cells": [
"Test Child Tag 1"
]
}
]
}
],
"keyword": "When ",
"line": 6,
"name": "I have the following data table",
"match": {
"location": "features/step_definitions/steps-2.js:34"
},
"result": {
"status": "failed",
"duration": 499000000,
"error_message": "timedout"
}
},
{
"arguments": [],
"keyword": "Then ",
"line": 8,
"name": "a JSON report will be generated",
"match": {
"location": "features/step_definitions/steps-2.js:40"
},
"result": {
"status": "skipped",
"duration": 0
}
}
],
"tags": [
{
"name": "@parent_tag",
"line": 3
},
{
"name": "@**test",
"line": 3
},
{
"name": "@child_tag_1",
"line": 10
}
],
"type": "scenario"
}
],
"id": "",
"line": 1,
"keyword": "Feature",
"name": "",
"tags": [],
"uri": "features/test.feature"
}
]%
</code></pre>
<p>Finally, a last question: why do you use timeout per scenario? What are you missing with timeouts per step?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-02 05:38:36
[cucumber/cucumber-js] Comment on #1763
<p>I took a look</p>
<p>The error is</p>
<pre><code>$ mocha 'src/****/**_spec.ts'
TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".ts" for /home/runner/work/cucumber-js/cucumber-js/src/cli/helpers_spec.ts
</code></pre>
<p>It seems to be related to <code>figures</code> now being ESM only.</p>
<p>I have no idea how to fix this. <a href="https://github.com/charlierudolph">@charlierudolph</a> <a href="https://github.com/davidjgoss">@davidjgoss</a> any idea?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-02 23:23:01
[cucumber/cucumber-js] Comment on #1741
<p>Thanks <a href="https://github.com/aurelien-reeves">@aurelien-reeves</a>, I'll try and debug my project a bit to see if I can see why I am not exiting cleanly.</p>
<p>Regarding why I need timeout per scenario - these tests are executed inside an AWS lambda with strict timeouts set. For example, an invocation will timeout after 2 minutes, so I set my Scenario to be maximum 1 minute 30 seconds to ensure that I get all my reporting data.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-03 00:01:37
[cucumber/cucumber-js] Comment on #1741
<p>> Regarding why I need timeout per scenario - these tests are executed inside an AWS lambda with strict timeouts set. For example, an invocation will timeout after 2 minutes, so I set my Scenario to be maximum 1 minute 30 seconds to ensure that I get all my reporting data.</p>
<p>Ok, got it, thanks</p>
<p><a href="https://github.com/davidjgoss">@davidjgoss</a> <a href="https://github.com/charlierudolph">@charlierudolph</a> is there a way to dynamically set the hooks and steps timeouts rather than with a static value in the options?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-03 00:53:58
[cucumber/cucumber-js] Comment on #1740
<p><a href="https://github.com/aurelien-reeves">@aurelien-reeves</a> Is there any workaround to get step name in BeforeStep hook?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-03 01:14:08
[cucumber/cucumber-js] Comment on #1740
<p>I was not able to find a workaround yet for that.<br />
<a href="https://github.com/davidjgoss">@davidjgoss</a> <a href="https://github.com/charlierudolph">@charlierudolph</a> any idea?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-03 01:19:13
[cucumber/cucumber-js] Comment on #1740
<p>> <a href="https://github.com/aurelien-reeves">@aurelien-reeves</a> Is there any workaround to get step name in BeforeStep hook?</p>
<p>May I ask: why do you need the step name in the BeforeStep hook? What are you trying to achieve?</p>
<p>We had the same kind of discussion with <code>cucumber-ruby</code> <a href="https://github.com/cucumber/cucumber-ruby/issues/1432#issuecomment-885147967">recently</a>. It appears that often, what is attempted to be done would be more related to <code>formatters</code>. Did you tried looking at <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/custom_formatters.md">custom formatters</a>?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-03 01:50:35
[cucumber/cucumber-js] Comment on #1740
<p>So I am using custom logger (winston-js) within step definitions to produce JSON-structured logs that also contain metadata. So one of the metadata attached to every log message is scenario name. I wanted to extend it further - attach step name to every log message to give it more context.</p>
<p>So far I was configuring the logger instance in the Before hooks and assign it to the World object to make it accessible from step definitions. I'd also like to keep using my custom logger (winston-js) because it comes with a lot of stuff out of the box.</p>
<p>If there is any other better way to do this please by any mean suggest it - I am more than happy to do better :D</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-03 02:50:22
[cucumber/cucumber-js] Comment on #1740
<p>I would suggest to use a custom formatter for this purpose. It seems totally appropriate for your use-case.<br />
But as I was looking for something relatively easy to give you a basic example, I could not find any 😕</p>
<p>Do you feel comfortable to try writing your own? A good starting point could be to look at <a href="https://github.com/cucumber/cucumber-js/blob/main/src/formatter/progress_formatter.ts">https://github.com/cucumber/cucumber-js/blob/main/src/formatter/progress_formatter.ts</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-05 07:59:40
[cucumber/cucumber-js] Comment on #1136
<p>A step by step tutorial has been added to <a href="https://github.com/cucumber/cucumber-js/pull/1721">#1721</a></p>
<p>You would like to contribute to cucumber, but don't really know where to begin? Take a look on the PR <a href="https://github.com/cucumber/cucumber-js/pull/1721">#1721</a>!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-06 09:48:40
[cucumber/cucumber-js] Pull request opened by 16sheep
<p><strong>Description</strong></p>
<p>See details in commit and commit message.</p>
<p><strong>Motivation & context</strong></p>
<p>Partial fix for <a href="https://github.com/cucumber/cucumber-js/issues/1648">#1648</a></p>
<p><strong>Type of change</strong></p>
<p>• Refactoring/debt (improvement to code design or tooling without</p>
<p><strong>Checklist:</strong></p>
<p>• [ x] My code follows the code style of this project.
☐ My change requires a change to the documentation.
☐ I have updated the documentation accordingly.
• [ x] I have read the <../CONTRIBUTING.md|<strong>CONTRIBUTING</strong>> document.
☐ I have added tests to cover my changes.
• [x ] All new and existing tests passed.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-06 09:52:53
[cucumber/cucumber-js] Comment on #1764
<p><a href="https://coveralls.io/builds/41966490">Coverage Status</a></p>
<p>Coverage remained the same at 98.247% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/847decfac147fb752e26249c9e5876c779bd725e">847decf</a> on 16sheep:value-checker</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/42538f6b1c4f9d7b6d6d02161f52231bd9077aa6">42538f6</a> on cucumber:main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-06 12:22:01
[cucumber/cucumber-js] Comment on #1764
<p>Hi <a href="https://github.com/16sheep">@16sheep</a>,</p>
<p>Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾</p>
<p>In return for this generous offer we hope you will:</p>
<p>• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our <a href="https://cucumber.io/conduct">code of conduct</a> in your interactions with other collaborators and users.
• 💬 Join the <a href="http://cucumber.io/support#slack">community Slack channel</a> to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!</p>
<p>On behalf of the Cucumber core team,<br />
Aslak Hellesøy<br />
Creator of Cucumber</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-06 12:22:02
[cucumber/cucumber-js] Pull request merged by mattwynne
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-09 11:10:17
[cucumber/cucumber-js] Comment on #1734
<p>Superseded by <a href="https://github.com/cucumber/cucumber-js/pull/1764">#1764</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-09 11:10:20
[cucumber/cucumber-js] Pull request closed by mattwynne
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-09 11:18:19
[cucumber/cucumber-js] Pull request opened by mattwynne
<p>Each of the new-contributors ensemble sessions we've run, we've held a 15-minute<br />
retrospective at the end.</p>
<p>I'm not sure where's the best place to put these notes, but I felt like maybe it didn't really do any harm just to put them right here. I'm hopeful we can start to capture more feedback about specific changes we can make to the codebase to make it more welcoming, as time goes on.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-09 11:21:32
[cucumber/cucumber-js] Comment on #1765
<p><a href="https://coveralls.io/builds/42010326">Coverage Status</a></p>
<p>Coverage remained the same at 98.247% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/a569b96abbe9750f4dc910fa198ae5eb1dbef691">a569b96</a> on new-contributors-ensemble-retro-notes</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/04ef57de3cca268d7f258c9629d689a3c473f0f2">04ef57d</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-09 12:32:11
[cucumber/cucumber-js] Comment on #1765
<p>1136 or 1163?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-09 12:32:13
[cucumber/cucumber-js] aslakhellesoy commented on mattwynne's pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-09 12:38:34
[cucumber/cucumber-js] Comment on #1763
<p>Can we also consider removing this dependency? Sounds like feature creep to me.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-09 15:36:28
[cucumber/cucumber-js] davidjgoss commented on mattwynne's pull request
<p>Looks great, thanks for taking the time to write up.</p>
<p>I'd just nitpick on the dir path <code>doc/</code> - we already have <code>docs/</code>, so I'd maybe suggest putting under there, or maybe under a new path like <code>community/</code>?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-09 15:42:19
[cucumber/cucumber-js] Comment on #1740
<p>Agree a formatter is probably the right thing for the general use case.</p>
<p>I do think it makes sense for the before/after step hooks to have the <code>pickleStep</code> available though, given the scenario-level hooks have <code>pickle</code>. I'd probably add it but leave <code>pickle</code> in place to avoid an unnecessary breaking change.</p>
<p>This seems a good first/early issue candidate. Some pointers:</p>
<p>• Where this hook parameter is constructed <a href="https://github.com/cucumber/cucumber-js/blob/main/src/runtime/test_case_runner.ts#L263">https://github.com/cucumber/cucumber-js/blob/main/src/runtime/test<em>case</em>runner.ts#L263</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-09 15:48:32
[cucumber/cucumber-js] Comment on #1741
<p>> is there a way to dynamically set the hooks and steps timeouts rather than with a static value in the options?</p>
<p>I don't think so, because the support code library is finalised before execution.</p>
<p>I'd probably suggest setting a timer on the <code>World</code> (since that is unique per scenario) in the constructor, then checking in on that in a <code>BeforeStep</code> and throwing/skipping if too much time has passed. I guess the original solution using the function wrapper is more precise because it will race the step code and bail as soon as the time limit is reached. Do you have particularly long-running steps <a href="https://github.com/dambler">@dambler</a>?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-10 10:59:36
[cucumber/cucumber-js] Comment on #1765
<p>Thanks!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-10 11:00:29
[cucumber/cucumber-js] Comment on #1765
<p>Thanks <a href="https://github.com/davidjgoss">@davidjgoss</a> I hadn't spotted that. I've moved it into <code>/docs</code></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-10 11:15:39
[cucumber/cucumber-js] Pull request opened by mattwynne
<p><strong>Description</strong></p>
<p>Switch to the <code>--build</code> compilation option when compiling TypeScript.</p>
<p><strong>Motivation & context</strong></p>
<p>This <a href="https://www.typescriptlang.org/docs/handbook/project-references.html">option</a> for the TypeScript compiler speeds up compilation, making it a bit quicker to run the tests.</p>
<p>On my machine, this brings the time to run <code>yarn test</code> down from ~100 seconds to ~70 seconds:</p>
<p>Before:</p>
<pre><code>➜ yarn test
...
✨ Done in 107.57s.
yarn test 102.80s user 11.68s system 106% cpu 1:48.00 total
</code></pre>
<p>After:</p>
<pre><code>➜ yarn test
...
✨ Done in 88.25s.
yarn test 70.84s user 8.79s system 89% cpu 1:28.64 total
</code></pre>
<p><strong>Type of change</strong></p>
<p>• Refactoring/debt (improvement to code design or tooling without changing behaviour)</p>
<p><strong>Checklist:</strong></p>
<p>☑︎ My code follows the code style of this project.
☐ My change requires a change to the documentation.
☐ I have updated the documentation accordingly.
☑︎ I have read the <../CONTRIBUTING.md|<strong>CONTRIBUTING</strong>> document.
☐ I have added tests to cover my changes.
☑︎ All new and existing tests passed.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-10 11:18:24
[cucumber/cucumber-js] Comment on #1766
<p><a href="https://coveralls.io/builds/42040759">Coverage Status</a></p>
<p>Coverage remained the same at 98.247% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/fdd4d9397e7b242a68b2e3962e952179fd658b0e">fdd4d93</a> on use-typescript-incremental-builds</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/04ef57de3cca268d7f258c9629d689a3c473f0f2">04ef57d</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-10 11:19:26
[cucumber/cucumber-js] Pull request merged by mattwynne
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-10 11:33:55
[cucumber/cucumber-js] Pull request opened by mattwynne
<p>As mentioned in the new contributors ensemble <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/retro/2021/07/17.md#what-should-we-decide--change-for-next-time">retro</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-10 11:35:19
[cucumber/cucumber-js] Comment on #1767
<p><a href="https://github.com/artismarti">@artismarti</a> <a href="https://github.com/marjuhirsh">@marjuhirsh</a> <a href="https://github.com/eoola">@eoola</a> what do you think? Is this better? Any suggestions to improve on it?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-10 11:36:10
[cucumber/cucumber-js] Comment on #1767
<p><a href="https://coveralls.io/builds/42041614">Coverage Status</a></p>
<p>Coverage remained the same at 98.247% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/deccc4dc2d1055cda523ee713ef8c9519336e549">deccc4d</a> on make-contributor-guide-more-beginner-friendly</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/d2627712a51bc7298f4f9985b5a6ac25764ee75b">d262771</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-10 14:09:21
[cucumber/cucumber-js] Comment on #1767
<p>I'm gonna merge this as it definitely makes things better, but I'd still welcome comments on how it could be improved further, even after this PR is merged.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-10 14:09:26
[cucumber/cucumber-js] Pull request merged by mattwynne
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-11 00:56:08
[cucumber/cucumber-js] Comment on #1741
<p>I don't especially have long running steps, the problem is the environment that these tests are executed in (AWS lambdas). I'll experiment with using <code>World</code> to see if I can get anything suitable.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-11 01:59:04
[cucumber/cucumber-js] Comment on #1767
<p>Looks good, MAtt. Why not include links to our Twitch sessions & also the videos?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-11 07:43:44
[cucumber/cucumber-js] Issue opened by aslakhellesoy
<p><strong>Describe the bug</strong></p>
<p>Running <code>cucumber-js --dry-run</code> exits with <code>1</code>.</p>
<p><strong>Expected behavior</strong></p>
<p>I expected a <code>0</code> since nothing is run.</p>
<p><strong>Context</strong></p>
<p>I'm building an LSP language server which will spawn cucumber in dry-run mode (to capture step definitions and steps so we can build up an autocomplete index). Because it exits with <code>1</code> I'm unable to tell whether the command failed because of a <em>real</em> error or not.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-11 08:47:09
[cucumber/cucumber-js] charlierudolph approved mattwynne's pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-14 10:13:33
[cucumber/cucumber-js] Comment on #1763
<p>I'd say lets just pin to the old version for now.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-14 10:24:29
[cucumber/cucumber-js] Pull request closed by charlierudolph
<https://github.com/cucumber/cucumber-js/pull/1763|#1763 fix(deps): update dependency figures to v4>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-14 10:25:03
[cucumber/cucumber-js] Comment on #1763
<p><strong>Renovate Ignore Notification</strong></p>
<p>As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for <em>any</em> future 4.x releases. However, if you upgrade to 4.x manually then Renovate will then reenable updates for minor and patch updates automatically.</p>
<p>If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-14 10:33:43
[cucumber/cucumber-js] Comment on #1768
<p><a href="https://github.com/aslakhellesoy">@aslakhellesoy</a> do you have undefined/pending/ambiguous steps when you're seeing this?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-14 12:29:09
[cucumber/cucumber-js] Comment on #1768
<p>I don’t remember TBH - maybe some undefined ones. In any case, I think the exit status should always be 0 regardless of undefined/ambiguous steps.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-15 12:27:05
[cucumber/cucumber-js] Pull request opened by Marketionist
<p><strong>Description</strong></p>
<p>Some minor text styling fixes</p>
<p><strong>Motivation & context</strong></p>
<p>Text styling fixes for the sake of consistency</p>
<p><strong>Type of change</strong></p>
<p>• Refactoring/debt (improvement to code design or tooling without changing behaviour)</p>
<p><strong>Checklist:</strong></p>
<p>☑︎ My code follows the code style of this project.
☑︎ My change requires a change to the documentation.
☑︎ I have updated the documentation accordingly.
☑︎ I have read the <../CONTRIBUTING.md|<strong>CONTRIBUTING</strong>> document.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-15 12:33:00
[cucumber/cucumber-js] Pull request merged by Marketionist
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-17 12:52:11
[cucumber/cucumber-js] Comment on #1393
<p><a href="https://github.com/BlueMona">@BlueMona</a> and I paired on <a href="https://github.com/cucumber/cucumber-js/pull/1770/files">a failing scenario</a> for this today. I suggest we move the discussion over there and help her get the tests into shape and work towards an implementation.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-17 12:57:42
[cucumber/cucumber-js] Comment on #1770
<p>The scenario we have so far doesn't address the issue around immutability. I suggest we add another scenario showing that even if the first scenario mutates the value that was set in the <code>BeforeAll</code> hook, the second scenario gets the original value again. (i.e. we can't use it to leak state between scenarios; each new World instance gets a fresh copy of the <code>testRunContext</code>)</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2021-08-18 07:19:47
[cucumber/cucumber-js] Comment on #1740
<p><a href="https://github.com/aurelien-reeves">@aurelien-reeves</a> <a href="https://github.com/davidjgoss">@davidjgoss</a> so in my case, you'd suggest that I:</p>
<p>• create a custom formatter
• instantiate winston longer inside formatter
• in appropriate event handlers, e.g.<code>TestStepStarted</code> configure the winston logger instance to include additional metadata?</p>
<p>For that to work, I would need to somehow provide the logger instance created inside my Custom Formatter to the step definition code. Is it possible to mutate the World object from inside the formatter? If yes, then how would I do it?</p>
<p>thank you in advance!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-11-05 03:37:37
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2159#issuecomment-1304493292">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>This seems reasonable to me, as long as we're fault-tolerant with it as we could hit e.g. permissions issues from the OS. <a href="https://github.com/charlierudolph">@charlierudolph</a> any thoughts?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-11-05 05:51:01
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2160#issuecomment-1304541022">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Thanks for raising <a href="https://github.com/m-s-c-h">@m-s-c-h</a>. It’s a tricky one in terms of policy as (speaking only for myself) I support the principle but it’s not the way I would choose to communicate.</p>
<p>However we can nearly skirt the issue because I’m planning on refactoring out the durations library anyway. I’ll use this issue as a vehicle for that.</p>
<p>cc <a href="https://github.com/mattwynne">@mattwynne</a> for visibility</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-11-05 11:36:58
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2160#issuecomment-1304608069">Comment</a> on issue by <a href="https://github.com/unional">unional</a>
<p>If you want a remedy to the problem, you can use the <code>overrides</code> mechanism of your package manager of choice.</p>
<p>I have created a video to describe what you need to do: <a href="https://youtu.be/dh9UUqsJLok">https://youtu.be/dh9UUqsJLok</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-11-07 07:27:19
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2160#issuecomment-1305778890">Comment</a> on issue by <a href="https://github.com/m-s-c-h">m-s-c-h</a>
<p>Many thanks <a href="https://github.com/davidjgoss">@davidjgoss</a> and <a href="https://github.com/unional">@unional</a>!!! In the short run, the override mechanism helps us. And the refactoring sounds great for the long run.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-10-27 02:31:28
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2161#issuecomment-1293251050">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Does it work normally without parallel?</p>
<p>Can you post your code for the step that is erroring?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-10-27 21:22:13
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2161#issuecomment-1294434894">Comment</a> on issue by <a href="https://github.com/tkminh">tkminh</a>
<p>Yes, it works normally without parallel.</p>
<p>The code is very simple for step "Give User like to test", just console.log("say test");</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-11-03 06:09:28
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2161#issuecomment-1302089561">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Could you post a minimal reproducible example as a git repo?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-11-03 05:50:45
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2155#issuecomment-1302050535">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>That doesn’t look like cucumber code eg with decorated class methods - are you using a test framework that wraps cucumber?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-11-05 04:53:15
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2173#issuecomment-1304505733">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>When you specify a formatter in the <code>formats</code> property there are two parts split by the <code>:</code> delimiter. The first part is the name or path of the formatter, which you have. The second part is the file path to be output, which is missing in your example and therefore the formatter would output to the terminal. See <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/formatters.md">https://github.com/cucumber/cucumber-js/blob/main/docs/formatters.md</a></p>
<p>Your script for outputting JUnit XML would also need to be adapted to be a formatter i.e. a class that ingests Cucumber's events and writes to a stream. See <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/custom_formatters.md">https://github.com/cucumber/cucumber-js/blob/main/docs/custom_formatters.md</a></p>
<p>Given your logic is derived from the <a href="https://github.com/cucumber/cucumber-js/blob/main/src/formatter/json_formatter.ts">JSON formatter</a> output, you might be able to extend that class to capture its output and do your transformation there.</p>
<p>Finally, it shouldn't be too long until we have a first-party JUnit formatter via <a href="https://github.com/cucumber/cucumber-js/pull/2121">#2121</a>, which I'm going to working on shortly.</p>
<p>Hope this helps.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-11-06 22:45:10
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2173#issuecomment-1305154390">Comment</a> on issue by <a href="https://github.com/testgitdl">testgitdl</a>
<p>Thank you <a href="https://github.com/davidjgoss">@davidjgoss</a> ! I will give it a try. Looking forward to the Junit formatter. In the meantime I also thought about having this in the AfterAll. seems like a simpler solution</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-11-05 03:41:36
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2143#issuecomment-1304493831">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Thanks for raising <a href="https://github.com/Solonotix">@Solonotix</a>! I'd be tempted to just change the definition across the board to <code>Promise&lt;void&gt;</code> even though it's not doing async work in all cases, to simplify things. What do you think?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-11-05 05:43:30
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2156#issuecomment-1304539809">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Sorry for the late reply <a href="https://github.com/jan-molak">@jan-molak</a>! Just wanted to clarify a couple of things:</p>
<p>• Does your After hook need context/state from the specific worker? If yes is that serializable?
• Does your After hook need context/state from the parent process that calls Cucumber? If yes is that serializable?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-11-05 09:40:55
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2156#issuecomment-1304583521">Comment</a> on issue by <a href="https://github.com/jan-molak">jan-molak</a>
<p>Hey <a href="https://github.com/davidjgoss">@davidjgoss</a> - no problem at all, thanks for getting back to me!</p>
<p>The <code>After</code> hook needs a Serenity/JS "scene ID", which is a serialisable value <a href="https://github.com/serenity-js/serenity-js/blob/b7a5d25a4cd37e00204064bb9c263b169be98a78/packages/cucumber/src/listeners/messages/CucumberMessagesListener.ts#L36">initialised by Serenity/JS Cucumber reporter</a> on the <code>serenity</code> instance when the reporter receives a <a href="https://github.com/serenity-js/serenity-js/blob/b7a5d25a4cd37e00204064bb9c263b169be98a78/packages/cucumber/src/listeners/messages/CucumberMessagesListener.ts#L50">Cucumber <code>testCaseStarted</code> message</a>.</p>
<p>So to access this value, the hook could:</p>
<p>• have access to the same <code>serenity</code> instance the reporter uses (which requires them to be in the same process..)
• received the scene ID by <em>some other means</em></p>
<p>Thinking about it, scene ID is a serialisable value that's <a href="https://github.com/serenity-js/serenity-js/blob/b7a5d25a4cd37e00204064bb9c263b169be98a78/packages/cucumber/src/listeners/messages/CucumberMessagesListener.ts#L52">initialised in the process where the reporter is running</a>. This is not ideal, but is currently the only place where I can do it.</p>
<p>What <em>would be ideal</em>, is if plugin developers could have a way to define per-worker <code>Before</code> and <code>After</code> hooks for Cucumber to attach to every worker, and then use the Cucumber message protocol to send custom data from such hooks to reporters.</p>
<p>This way I could:</p>
<p>• attach a per-worker <code>Before</code> hook that initialises a scene ID when the Cucumber scenario starts in the worker
• use Cucumber message protocol to send the scene ID from the <code>Before</code> hook in the worker to the reporter (maybe attach custom data to the <code>testCaseStarted</code> message? is that possible?)
• use the <code>After</code> hook in the reporter to do the clean-up (this is an async process, so the <code>After</code> hook should be able to wait for a promise returned from Serenity/JS cleanup).</p>
<p>Other than the scene ID, the per-worker <code>Before</code> and <code>After</code> hooks won't need any other data from the worker or the parent process. Metadata like the worker process id or some worker identifier could be a nice thing to attach to the report, but they're not necessary.</p>
<p>Of course, such programmatic <code>Before</code> hook would need to be executed before any user-defined <code>Before</code> hooks, and the programmatic <code>After</code> hook would need to be executed after any user-defined <code>After</code> hooks.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-11-06 23:34:22
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2174#issuecomment-1305195760">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>First off thanks for raising <a href="https://github.com/Ugzuzg">@Ugzuzg</a> and explaining your use case, I’m a fan of otel so this is really great to see.</p>
<p>To your question: yes more than happy to take a PR for that refactor you describe.</p>
<p>But also: it would be much better if you didn’t have to reach into internal functions to do the instrumentation. We’ve been working on a plugin system for extending Cucumber and this seems like a good problem to help move that along. I’ll study your otel PR a bit more for specifics but essentially I’m thinking of having granular lifecycle hooks for injecting custom logic before and after invocations of test cases, steps etc.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-11-14 03:16:40
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2176#issuecomment-1313521243">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>This is a compilation error in your code that doesn't relate to any Cucumber types. It's hard to know what it might be without tons of detail about your project, but a couple of things you might look at:</p>
<p>• It looks like you might have both <code>@cucumber/cucumber</code> (current) and <code>cucumber</code> (legacy) npm packages installed?
• <a href="https://www.npmjs.com/package/ts-node#configuration">ts-node</a> will pick up the <code>tsconfig.json</code> from your working dir automatically - could this be different to what you're using in other contexts where there's no error?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-11-17 00:51:19
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2177#issuecomment-1318292492">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Did you follow the sections on the linked documentation around e.g. duplicate dependency and deprecated package?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-11-17 01:00:48
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2177#issuecomment-1318303393">Comment</a> on issue by <a href="https://github.com/sriharircb">sriharircb</a>
<p>i followed <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/installation.md#invalid-installations">https://github.com/cucumber/cucumber-js/blob/main/docs/installation.md#invalid-installations</a> instructions ,</p>
<p>i hit [npm why @cucumber/cucumber] command , where i see only one version were there is no other versions.</p>
<p>mac newsample % npm why @cucumber/cucumber<br />
@cucumber/cucumber@8.8.0 dev<br />
node_modules/@cucumber/cucumber<br />
dev @cucumber/cucumber@"^8.8.0" from the root project</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-11-22 21:49:18
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2177#issuecomment-1324581217">Comment</a> on issue by <a href="https://github.com/sriharircb">sriharircb</a>
<p>issue got fixed , i am running in wrong way.</p>
<p>earlier running : npx nightwatch <strong><em>*</strong></em>*.js file</p>
<p>now i setted up one test under script in package.json. then started running npm run test. it works</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-11-21 23:16:32
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2178#issuecomment-1323215548">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>For an absolute path, it should work correctly if you include the file:// protocol prefix - this is needed for ES module compatibility now.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-11-22 00:02:57
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2178#issuecomment-1323260546">Comment</a> on issue by <a href="https://github.com/yusuke-noda">yusuke-noda</a>
<p>> For an absolute path, it should work correctly if you include the file:// protocol prefix - this is needed for ES module compatibility now.</p>
<p>It is true for TYPE, but not for PATH.<br />
The following error happens when the file:// URL is specified in the PATH.</p>
<pre><code>C:\work\myproject&gt;npx cucumber-js --format json:file://C:\foo\bar.json
Error: ENOENT: no such file or directory, open 'C:\work\myproject\file:\C:\foo\bar.json'
</code></pre>
<p>This is because "file://C:\foo\bar.json" is treated as a relative path.<br />
The following command works fine:</p>
<pre><code>C:\work\myproject&gt;npx cucumber-js --format json:C:\foo\result.json
0 scenarios
0 steps
0m00.000s (executing steps: 0m00.000s)
</code></pre>
<p>And also in fact, the following command works fine without specifying a file:// URL in the TYPE.</p>
<pre><code>C:\work\myproject&gt;npx cucumber-js --format C:\work\myproject\node_modules\@cucumber\cucumber\lib\formatter\json_formatter.js:.\result.json
0 scenarios
0 steps
0m00.000s (executing steps: 0m00.000s)
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-11-22 00:54:16
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2178#issuecomment-1323317671">Comment</a> on issue by <a href="https://github.com/yusuke-noda">yusuke-noda</a>
<p>The thing that bothers me the most is that there is no way to specify a UNC path in PATH.</p>
<p>Also, for the problem that Windows absolute path with "/" as directory separator cannot be specified in PATH, serenity-js specifies Windows absolute path with "/" as directory separator in PATH, so I would like to fix either cucumber-js or serenity-js.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-11-24 09:23:32
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2178#issuecomment-1326708442">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Thanks for the extra detail <a href="https://github.com/yusuke-noda">@yusuke-noda</a> - I'll dig into this and get back to you.</p>
<p>FWIW I think <a href="https://github.com/cucumber/cucumber-js/pull/1847/files">the change that added stripping the quotes</a> has a similar intent re wrapping one side and/or the other with quotes, it's just a slightly heavy-handed implementation, so we could possibly work with that a bit.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-11-23 13:45:13
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2180#issuecomment-1325696545">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>That error is Node.js trying to parse your feature file and failing because it’s expecting JavaScript.</p>
<p>Your feature paths should not go in the “require” array, but in “paths”. Other than that your config looks fine.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-12-01 11:50:42
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2180#issuecomment-1334313029">Comment</a> on issue by <a href="https://github.com/mrsenzy">mrsenzy</a>
<p>Thanks much David. This helps.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-11-23 13:47:30
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2181#issuecomment-1325698468">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>“require” and “requireModule” are not applicable for ESM projects - the former is superseded by “import” and the latter is handled by defining the loader externally as you’ve done.</p>
<p>Drop the “require” and “requireModules” from your config file and you should be set.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-11-23 13:55:08
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2181#issuecomment-1325704388">Comment</a> on issue by <a href="https://github.com/rtomyj">rtomyj</a>
<p>That did it. Thank you!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-11-24 09:13:04
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/1799#issuecomment-1326698484">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p><a href="https://github.com/mattwynne">@mattwynne</a> I think you mentioned there was an initiative around this internally - do you still think it should be a part of Cucumber itself?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-11-24 13:40:50
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/1799#issuecomment-1326851967">Comment</a> on issue by <a href="https://github.com/mattwynne">mattwynne</a>
<p>Yeah, I do. I'm not sure what will happen internally but for me this functionality would be a great addition to cucumber-js, provided we can architect it in a way that doesn't bloat / complicate the codebase.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-11-24 09:14:32
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2118#issuecomment-1326700151">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Closing as this has gone quiet but please re-raise if you have additional details.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-12-02 09:52:53
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2194#issuecomment-1335601261">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Hey <a href="https://github.com/mrsenzy">@mrsenzy</a>, I would recommend using a combination of profiles and world parameters for this. It's <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/profiles.md#using-profiles-for-arguments">discussed a bit in this doc</a> but essentially something like this in your config file:</p>
<pre><code>{
"default": {
// whatever you have already...
},
"chrome-osx {
"worldParameters": {
"browser": "chrome",
"os": "osx",
"os_version": "catalina"
}
},
"edge-windows": {
"worldParameters": {
"browser": "edge",
"os": "Windows",
"os_version": "Win10"
}
}
}
</code></pre>
<p>Then change your <code>runTests</code> function to something like:</p>
<pre><code>export async function runTests(profile) {
const {runConfiguration} = await loadConfiguration({
file: './cucumber.json',
profiles: [profile]
});
</code></pre>
<p>Finally:</p>
<pre><code>['chrome-osx', 'edge-windows'].forEach( async (profile) =&gt; {
runTests(profile).then(() =&gt; {
</code></pre>
<p>Hope this helps.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-12-02 13:03:51
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2194#issuecomment-1335843262">Comment</a> on issue by <a href="https://github.com/mrsenzy">mrsenzy</a>
<p>Thank you very much David. This approach worked for me to run cross browser testing from world parameters and profile. But some how code runs the scenario for one profile only. It doesn't run the second profile. Below is the updated code,</p>
<pre><code>import {loadConfiguration, loadSupport, runCucumber} from "@cucumber/cucumber/api";
var shell = require("shelljs");
export async function runTests(profile) {
const {runConfiguration} = await loadConfiguration({
file: './cucumber.json',
profiles: [profile]
});
const {success} = await runCucumber({...runConfiguration});
return success;
}
const runProfiles = ['chrome_osx', 'edge_windows']
runProfiles.forEach(async (profile) =&gt; {
await runTests(profile)
})
</code></pre>
<p>cucumber.js (I removed cucumber.json because for cucumber.json for each profile I have to copy the default code + world params, cucumber.js was simpler to use)</p>
<pre><code>let common = [
'./tests-examples/features/**.feature',
'--require-module ts-node/register',
'--require ./tests-examples/stepDefinitions/****/**.ts',
'--require ./cucumber.config.ts',
'--format html:./report/cucumberjs-report.html',
'--format progress-bar',
'--format ./node_modules/@cucumber/pretty-formatter',
'--format json:./report/report.json',
'--publish-quiet'
].join(' ');
module.exports = {
default : common + ' ' + `--world-parameters '{"driverName": "Buster"}'`,
tagged : common + ' --tags @data-modeling ',
wParams : common + ' --tags @wParams ' + `--world-parameters '{"driverName": "Buster"}'`,
chrome_osx : common + ' --tags @wParams ' + `--world-parameters '{"driverName": "Buster","browser": "chrome","os": "osx","os_version": "catalina"}'`,
edge_windows : common + ' --tags @wParams ' + `--world-parameters '{"driverName": "Buster","browser": "edge","os": "Windows","os_version": "Win10"}'`,
};
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-12-05 13:12:18
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2194#issuecomment-1338170130">Comment</a> on issue by <a href="https://github.com/mrsenzy">mrsenzy</a>
<p>I am now able to run both scenarios but first run for the scanerio return result as undefined steps and second run for same scenario on other browser runs successfully.</p>
<p>I use below config only - but not aware why first run is unidentified and second run is successful for same scenario. any help on this.</p>
<pre><code>let common = [
'./tests-examples/features/**.feature',
'--require-module ts-node/register',
'--require ./tests-examples/stepDefinitions/****/**.ts',
'--require ./cucumber.config.ts',
//'--format html:./report/cucumberjs-report.html',
'--format progress-bar',
'--format ./node_modules/@cucumber/pretty-formatter',
'--format json:./report/report.json',
'--publish-quiet',
'--parallel 2'
].join(' ');
module.exports = {
default : common + ' ' + `--world-parameters '{"driverName": "Buster"}'`,
tagged : common + ' --tags @data-modeling ',
wParams : common + ' --tags @wParams ' + `--world-parameters '{"driverName": "Buster"}'`,
chrome_osx : common + ' --tags @wParams ' + `--world-parameters '{"driverName": "Buster","browser": "chrome","os": "osx","os_version": "catalina"}'`,
edge_windows : common + ' --tags @wParams ' + `--world-parameters '{"driverName": "Buster","browser": "edge","os": "osx","os_version": "catalina"}'`,
};
</code></pre>
<p><a href="https://user-images.githubusercontent.com/75691269/205743827-03484547-25f9-46bb-b94a-26b0b5988dc0.png">image</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-12-06 11:17:18
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2194#issuecomment-1339855410">Comment</a> on issue by <a href="https://github.com/mrsenzy">mrsenzy</a>
<p>closed as the first solution worked and for the current issue raised a new ticket</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-12-14 11:20:47
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2195#issuecomment-1352030462">Comment</a> on issue by <a href="https://github.com/mrsenzy">mrsenzy</a>
<p>Found approach for it, one of my colleague helped to do it. Below is the approach for it, if it helps. there was a issue while doing parallel execution (support configuration not loaded for parallel run) and workaround for it is added here.</p>
<pre><code>async function runProfileTest(profiles: string[]) {
let success: boolean;
//process.env.BROWSERSTACK = "false";
let { runConfiguration } = await loadConfiguration({ file: "./cucumber.js" });
let support = await loadSupport(runConfiguration);
support.originalCoordinates.requireModules = runConfiguration.support.requireModules;
support.originalCoordinates.requirePaths = runConfiguration.support.requirePaths;
support.originalCoordinates.importPaths = runConfiguration.support.importPaths;
for (const profile of profiles) {
({ runConfiguration } = await loadConfiguration({ file: "cucumber.js", profiles: [profile] }));
const run = await runCucumber({
...runConfiguration,
support
}).then((results) =&gt; {
shell.exec(`node report.js`);
return results;
});
success = run.success &amp;&amp; success;
}
return success;
}
// let profile = process.env.PROFILE
let profile = ["chrome_osx"];
runProfileTest(profile).then(() =&gt; {
process.exit(0);
}).catch((error) =&gt; {
console.error(error);
process.exit(1);
});
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-12-14 11:24:50
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2196#issuecomment-1352034350">Comment</a> on issue by <a href="https://github.com/mrsenzy">mrsenzy</a>
<p>Hi <a href="https://github.com/mcheung-hbo">@mcheung-hbo</a> -</p>
<p>This issue is happening of a issue in cucumber-js itself, the support run configuration for modules, path are not getting loaded during parallel run, hence its crashing. workaround is add below lines after load Support, before calling runcucumber</p>
<pre><code> support.originalCoordinates.requireModules = runConfiguration.support.requireModules;
support.originalCoordinates.requirePaths = runConfiguration.support.requirePaths;
support.originalCoordinates.importPaths = runConfiguration.support.importPaths;
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-12-14 11:34:48
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2196#issuecomment-1352044487">Comment</a> on issue by <a href="https://github.com/mcheung-hbo">mcheung-hbo</a>
<p><a href="https://github.com/mrsenzy">@mrsenzy</a>, thx for commenting, and much appreciated! That's essentially what my workaround does as well to the require file.</p>
<p>Is this issue being tracked somewhere? This workaround just looks hack-y (messing around with cucumber-js internal structures that i guess is subjected to change?) and it will be ideal to address this issue in cucumber-js itself.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-12-14 11:50:19
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2196#issuecomment-1352061377">Comment</a> on issue by <a href="https://github.com/mrsenzy">mrsenzy</a>
<p>yes it must be fixed in cucumber-js itself. I have raised this issue few days back and one of my colleague helped to fix this workaround. will do a PR for this to author (<a href="https://github.com/davidjgoss">@davidjgoss</a> )</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-12-14 15:03:20
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2196#issuecomment-1352335354">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Thanks <a href="https://github.com/mcheung-hbo">@mcheung-hbo</a> and <a href="https://github.com/mrsenzy">@mrsenzy</a> for finding the source of this issue. I've raised a PR which fixes the issue in the right place internally and will get a patch release out soon.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-12-14 15:57:24
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2196#issuecomment-1352375014">Comment</a> on issue by <a href="https://github.com/mcheung-hbo">mcheung-hbo</a>
<p>Awesome! Thanks for the quick turn around fix <a href="https://github.com/davidjgoss">@davidjgoss</a>! much appreciate for the quick support here!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-12-15 15:15:59
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2196#issuecomment-1353835035">Comment</a> on issue by <a href="https://github.com/mcheung-hbo">mcheung-hbo</a>
<p><a href="https://github.com/davidjgoss">@davidjgoss</a> I see that the fix for this issue is merged; i am just curious about the next release of <code>cucmber-js</code> (which ships this fix); what is the typical release cadence for the project? Thank you!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-12-16 02:39:37
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2196#issuecomment-1354535713">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Now released in <a href="https://github.com/cucumber/cucumber-js/releases/tag/v8.9.1">https://github.com/cucumber/cucumber-js/releases/tag/v8.9.1</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-12-14 15:04:47
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2197#issuecomment-1352337365">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/55175614">Coverage Status</a></p>
<p>Coverage remained the same at 98.317% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/9d226a3666b0130046479b9748ecd6aee62c27d3">9d226a3</a> on fix/parallel-loadsupport</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/c2227edfab6016dc6eac265778d13fb1ccd9a2fc">c2227ed</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-12-15 00:56:46
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2198#issuecomment-1352742426">Comment</a> on issue by <a href="https://github.com/anagnxt">anagnxt</a>
<p>I apologize, the problem was using AND instead of OR.</p>
<p>While using</p>
<pre><code>Before({ tags: "@TEST_0 or @TEST_2" }, async () =&gt; {
console.log("Test");
})
</code></pre>
<p>it does work again!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-12-17 08:38:24
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2199#issuecomment-1356328412">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/55252724">Coverage Status</a></p>
<p>Coverage increased (+0.006%) to 98.335% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/111e376ea521fbb77a79a8bae8e15680d0beeb8a">111e376</a> on feat/config-yaml</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/79ba4bd98a2e136e198ce0df5298bb21edf0cd1f">79ba4bd</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-12-18 13:20:25
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2161#issuecomment-1356878354">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>This should be fixed in <a href="https://github.com/cucumber/cucumber-js/releases/tag/v8.9.1">https://github.com/cucumber/cucumber-js/releases/tag/v8.9.1</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-12-19 17:35:38
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2201#issuecomment-1358715621">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/55303994">Coverage Status</a></p>
<p>Coverage decreased (-0.0%) to 98.329% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/2de01ca4cb3b4b333eef47af79c68590fda93953">2de01ca</a> on olivierodo:improve-dx-readme</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/79ba4bd98a2e136e198ce0df5298bb21edf0cd1f">79ba4bd</a> on cucumber:main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-12-20 23:39:48
*Thread Reply:*
Review approved by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/olivierodo">olivierodo's</a> pull request
<p>Thanks!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-12-20 23:40:20
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2201#issuecomment-1360959145">Comment</a> on pull request by <a href="https://github.com/aslakhellesoy">aslakhellesoy</a>
<p>Hi <a href="https://github.com/olivierodo">@olivierodo</a>,</p>
<p>Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾</p>
<p>In return for this generous offer we hope you will:</p>
<p>• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our <a href="https://cucumber.io/conduct">code of conduct</a> in your interactions with other collaborators and users.
• 💬 Join the <a href="http://cucumber.io/support#slack">community Slack channel</a> to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!</p>
<p>On behalf of the Cucumber core team,<br />
Aslak Hellesøy<br />
Creator of Cucumber</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-12-23 20:06:17
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2202#issuecomment-1364455647">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/55440301">Coverage Status</a></p>
<p>Coverage: 98.335%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/117014ef42f955b58e28d34be30b3ede60f89604">117014e</a> on reference-programatically-doc</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/01a929c06f1eb865904d9b37c796e38c28ec73c3">01a929c</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-11 14:18:26
*Thread Reply:*
Reviewed and changes requested by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/olivierodo">olivierodo's</a> pull request
<p>Thanks for doing this. Could we change the link text to "JavaScript API for running programmatically"?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-12 09:09:34
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2202#issuecomment-1380737687">Comment</a> on pull request by <a href="https://github.com/olivierodo">olivierodo</a>
<p>Hello <a href="https://github.com/davidjgoss">@davidjgoss</a>, 👋<br />
thank you for the feedback.</p>
<p>I did the update 🙏</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-12-23 20:25:51
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2203#issuecomment-1364458131">Comment</a> on pull request by <a href="https://github.com/olivierodo">olivierodo</a>
<p>While running it on my fork:<br />
<a href="https://user-images.githubusercontent.com/4768226/209421108-7d49178e-18c3-43a8-b915-d3be58fa2112.png">image</a></p>
<p>Detail : <a href="https://github.com/olivierodo/cucumber-js/actions/runs/3769792862/jobs/6409233445">https://github.com/olivierodo/cucumber-js/actions/runs/3769792862/jobs/6409233445</a></p>
<p>I'll be happy to update the dead link has well 😁</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-12-23 20:25:53
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2203#issuecomment-1364458136">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/55440408">Coverage Status</a></p>
<p>Coverage: 98.335%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/69ce613951faa0dbd71961dd8a054ae9b5e5c6b2">69ce613</a> on ci-addlink-checker</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/01a929c06f1eb865904d9b37c796e38c28ec73c3">01a929c</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-12-27 17:43:14
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2204#issuecomment-1366305984">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<https://github.com/cucumber/cucumber-js/pull/2204|#2204 replace duration with luxon for formatting>
<p><a href="https://coveralls.io/builds/55487225">Coverage Status</a></p>
<p>Coverage: 98.335%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/ec10bc1d6f81ec21b664047972110caaba430fa3">ec10bc1</a> on feat/durations-rework</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/01a929c06f1eb865904d9b37c796e38c28ec73c3">01a929c</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-06 10:49:36
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2205#issuecomment-1374003546">Comment</a> on issue by <a href="https://github.com/mattwynne">mattwynne</a>
<p>Can you say more about why you need this feature in order to be able to integrate with <a href="http://reportportal.io">reportportal.io</a>?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-08 03:32:46
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2205#issuecomment-1374811431">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Added a FAQ for this to explain it a bit:<br />
<a href="https://github.com/cucumber/cucumber-js/blob/main/docs/faq.md#why-arent-there-beforefeature-and-afterfeature-hooks">https://github.com/cucumber/cucumber-js/blob/main/docs/faq.md#why-arent-there-beforefeature-and-afterfeature-hooks</a></p>
<p>But yeah, I'm also interested in what the particular issue is for <a href="http://reportportal.io">reportportal.io</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-12-31 18:18:02
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2206#issuecomment-1368326279">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/55549627">Coverage Status</a></p>
<p>Coverage: 98.335%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/e77ef6dd591e58d7adce6d5f103a2d68230903f5">e77ef6d</a> on renovate/microsoft-api-documenter-7.x</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/43f864916f5d83e538007c13ebdaafe13af18a32">43f8649</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-12-31 18:18:09
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2207#issuecomment-1368326300">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/55549629">Coverage Status</a></p>
<p>Coverage: 98.335%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/340fcd1774d2d614ecfe1f1dfb9449e41f7d301a">340fcd1</a> on renovate/microsoft-api-extractor-7.x</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/43f864916f5d83e538007c13ebdaafe13af18a32">43f8649</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-12-31 21:52:42
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2208#issuecomment-1368359373">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/55550822">Coverage Status</a></p>
<p>Coverage: 98.335%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/057e63a3554c6d5ca98e8318fcc363598b22bc36">057e63a</a> on renovate/express-4.x</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/43f864916f5d83e538007c13ebdaafe13af18a32">43f8649</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2022-12-31 22:07:11
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2209#issuecomment-1368362927">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/55550824">Coverage Status</a></p>
<p>Coverage: 98.335%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/00cec4f229cb6ff85f9033c2cae58c15a71ff776">00cec4f</a> on renovate/node-18.x</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/43f864916f5d83e538007c13ebdaafe13af18a32">43f8649</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-01 00:14:15
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2210#issuecomment-1368383880">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/55551567">Coverage Status</a></p>
<p>Coverage: 98.335%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/aa34e389a1fe6cceac9987d5115095f71790cfd7">aa34e38</a> on renovate/typescript-4.x</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/43f864916f5d83e538007c13ebdaafe13af18a32">43f8649</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-01 00:28:27
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2211#issuecomment-1368385930">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/55551568">Coverage Status</a></p>
<p>Coverage: 98.335%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/4527224508e6e65465b7f9ec337b6503b0b2b4da">4527224</a> on renovate/unit-test-packages</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/43f864916f5d83e538007c13ebdaafe13af18a32">43f8649</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-01 03:46:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2213#issuecomment-1368422804">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/55553523">Coverage Status</a></p>
<p>Coverage: 98.335%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/17c9a49aa386aa0d72ad2623fb76847fd91255e9">17c9a49</a> on renovate/eslint-packages</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/43f864916f5d83e538007c13ebdaafe13af18a32">43f8649</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-04 13:13:16
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2213#issuecomment-1371425461">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Edited/Blocked Notification</strong></p>
<p>Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.<br />
You can manually request rebase by checking the rebase/retry box above.</p>
<p>⚠️ <strong>Warning</strong>: custom changes will be lost.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-01 06:00:48
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2214#issuecomment-1368449322">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/55554968">Coverage Status</a></p>
<p>Coverage: 98.335%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/e7f5c740d0cd51f9225a9d11ae611bdaf5429061">e7f5c74</a> on renovate/major-cucumber-packages</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/43f864916f5d83e538007c13ebdaafe13af18a32">43f8649</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-01 06:03:12
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2215#issuecomment-1368451543">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/55555011">Coverage Status</a></p>
<p>Coverage: 98.335%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/d710b616f3cff73312bbf04386fd5ad37af39542">d710b61</a> on renovate/yaml-2.x</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/43f864916f5d83e538007c13ebdaafe13af18a32">43f8649</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-08 07:47:56
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2215#issuecomment-1374866399">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Needs to drop Node.js 12 support first.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-06 10:15:17
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2216#issuecomment-1373976337">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/55716964">Coverage Status</a></p>
<p>Coverage: 98.563% (+0.2%) from 98.335% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/c42b8304455350b1d5ced124fd64d9568212b97f">c42b830</a> on feat/durations-again</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/eb2a7097d2f373eb67ecd6901a69556dcebfc175">eb2a709</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-10 07:04:42
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2217#issuecomment-1377411607">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>The answer here about why we don't have feature-level hooks has some overlap with what you're asking:<br />
<a href="https://github.com/cucumber/cucumber-js/blob/main/docs/faq.md#why-arent-there-beforefeature-and-afterfeature-hooks">https://github.com/cucumber/cucumber-js/blob/main/docs/faq.md#why-arent-there-beforefeature-and-afterfeature-hooks</a></p>
<p>> Is there any cucumber builtin option for parallel testing to run the scenarios in one feature file in order and then move on to the next feature file?</p>
<p>That reads as just running in serial, but I think what you want is to have all scenarios from a single feature run in sequence and on the same worker? If so you might be able to lean on <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/parallel.md#custom-work-assignment">custom work assignment</a>, at least to keep one scenario at a time running from a given feature (via <code>pickle.uri</code>) - I don't think you could guarantee them being on the same worker though.</p>
<p>> ...but inline command --parallel 3 runs all scenarios in various feature files not in order.</p>
<p>Could you say more about what problem this causes for you? Ideally scenarios should work independently.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-10 08:29:03
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2217#issuecomment-1377529002">Comment</a> on issue by <a href="https://github.com/JinCoreana">JinCoreana</a>
<p>> The answer here about why we don't have feature-level hooks has some overlap with what you're asking: <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/faq.md#why-arent-there-beforefeature-and-afterfeature-hooks">https://github.com/cucumber/cucumber-js/blob/main/docs/faq.md#why-arent-there-beforefeature-and-afterfeature-hooks</a>
>
> > Is there any cucumber builtin option for parallel testing to run the scenarios in one feature file in order and then move on to the next feature file?
>
> That reads as just running in serial, but I think what you want is to have all scenarios from a single feature run in sequence and on the same worker? If so you might be able to lean on <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/parallel.md#custom-work-assignment">custom work assignment</a>, at least to keep one scenario at a time running from a given feature (via <code>pickle.uri</code>) - I don't think you could guarantee them being on the same worker though.
>
> > ...but inline command --parallel 3 runs all scenarios in various feature files not in order.
>
> Could you say more about what problem this causes for you? Ideally scenarios should work independently.</p>
<p>Thank you very much for the reply and links to have a look at, David.<br />
Referring to your description, I guess I was using Cucumber in an unintended way. Because I have several scenarios in one feature connected in sequence. Please see the example.</p>
<p>Let's say we have a <code>feature A - New post</code> with 3no. scenarios and <code>feature B - Custom tap</code> with 2no.scenarios like below.<br />
<strong>scenario A-1</strong> :Create a new post<br />
<strong>scenario A-2</strong>: Edit the content and save changes<br />
<strong>scenario A-3</strong>: Delete the post</p>
<p><strong>scenario B-1</strong>: Save an existing report in custom tap<br />
<strong>scenario B-2</strong>: Delete it from custom tap</p>
<p>Then I run 2 workers expecting one to do <code>feature A</code> and the other one to do <code>feature B</code>. However, the outcome is:<br />
<strong>worker 1</strong>: A-1 ➡️ A-2 ➡️ B-1 fails<br />
<strong>worker 2</strong>: A-3 fails and this worker gets frozen</p>
<p>I will try again after adding some more steps to make each scenario finish and start from the same page. Thank you again for the reply!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-10 10:43:39
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2217#issuecomment-1377695165">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>> I will try again after adding some more steps to make each scenario finish and start from the same page</p>
<p>Yeah I think this is a good approach to run with. Like scenarios A-2 and A-3 could start with something like <code>Given an existing post</code> that goes and creates a post ready to be acted on in the <code>When</code> step(s).</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-11 04:13:03
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2217#issuecomment-1378659215">Comment</a> on issue by <a href="https://github.com/JinCoreana">JinCoreana</a>
<p>This is now working very well!<br />
Although I came across another issue with <code>page.evaluate</code> in BeforeAll hook gets skipped in some of the workers sometimes (50% all work fine - 50% this issue happens I would say). I will prepare an example and post it as a separate issue. Thanks a lot!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-11 04:35:00
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2217#issuecomment-1378684488">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>In case it helps <a href="https://github.com/cucumber/cucumber-js/issues/1153">#1153</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-09 13:47:07
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2218#issuecomment-1376372585">Comment</a> on issue by <a href="https://github.com/michaelm-rsi">michaelm-rsi</a>
<p>I'm still a github noob. Here's the pull request:</p>
<p><a href="https://github.com/cucumber/cucumber-js/compare/main...michaelm-rsi:cucumber_js:issue2218?expand=1">https://github.com/cucumber/cucumber-js/compare/main...michaelm-rsi:cucumber_js:issue2218?expand=1</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-09 13:14:16
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2219#issuecomment-1376325303">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/55779255">Coverage Status</a></p>
<p>Coverage: 98.335%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/8bc0d8b4d60ccda4fa0bfb380862386b53deb09d">8bc0d8b</a> on michaelm-rsi:issue2218</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/e5b57de6d2171f9493a78373c7a7ee53bf2be3c4">e5b57de</a> on cucumber:main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-10 07:53:56
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2159#issuecomment-1377479722">Comment</a> on issue by <a href="https://github.com/michaelm-rsi">michaelm-rsi</a>
<p>Looking into this. Having a little trouble tracking down the feature file for this to insert the scenario associated with this issue.</p>
<p>formatter_paths.feature <- This one? (Looks right)</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-10 08:02:05
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2159#issuecomment-1377491188">Comment</a> on issue by <a href="https://github.com/michaelm-rsi">michaelm-rsi</a>
<p>Also, is it ok to add <a href="https://www.npmjs.com/package/mkdirp">https://www.npmjs.com/package/mkdirp</a> to the dependencies for this?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-10 08:20:14
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2159#issuecomment-1377516971">Comment</a> on issue by <a href="https://github.com/michaelm-rsi">michaelm-rsi</a>
<p>Draft of the scenario -</p>
<pre><code>Scenario: Created relative path
When I run cucumber-js with `-f summary:some/long/path/for/reports/summary.txt`
Then the file "some/long/path/for/reports/summary.txt" has the text:
"""
1 scenario (1 passed)
1 step (1 passed)
&lt;duration-stat&gt;
"""
</code></pre>
<p>That replaces the current invalid path scenario.</p>
<p>Also this to cover reaction to being blocked from creating the directory...</p>
<pre><code> Scenario: No permission to create relative path
Given the OS does not allow cucumber to create directories
When I run cucumber-js with `-f summary:some/long/path/for/reports/summary.txt`
</code></pre>
<p>How should we react to the failure to mkdir? The consistent with previous versions pattern is to allow the error to stop the test, but we could cache it and issue a warning since an inability to write the summary file is a different issue from whether the tests have failed.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-10 10:48:22
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2159#issuecomment-1377700150">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>> we could cache it and issue a warning since an inability to write the summary file is a different issue from whether the tests have failed</p>
<p>Yeah, I think this is the best approach to ensure backwards compatibility.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-16 00:28:19
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2043#issuecomment-1383659957">Comment</a> on issue by <a href="https://github.com/iomedico-beyer">iomedico-beyer</a>
<p>While I still think <code>defineStep</code> should not be removed (see above), I like the idea of these optional two strict validation modes (to fail fast) - even more so since we recently converted all our tests to English. Any idea when this might be implemented?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-17 12:20:54
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2043#issuecomment-1386002110">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p><a href="https://github.com/iomedico-beyer">@iomedico-beyer</a> thanks for highlighting that perspective on the German language.</p>
<p>At this point it looks unlikely we will enforce strict keywords, at least any time soon if ever. So we could keep defineStep and it would just have to throw if called with the strict option on.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-17 12:14:07
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2220#issuecomment-1385994456">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Is that error coming from your code or Cucumber's code? Can you provide a detailed stack? Can you compile your TypeScript code outside of Cucumber e.g. with <code>tsc</code> or <code>ts-node</code>?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-17 12:15:18
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2220#issuecomment-1385995690">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Also if it's an ESM project you might try avoiding <code>require</code> and using Cucumber's ESM support too.<br />
<a href="https://github.com/cucumber/cucumber-js/blob/main/docs/esm.md">https://github.com/cucumber/cucumber-js/blob/main/docs/esm.md</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-11 18:04:18
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2220#issuecomment-1426921546">Comment</a> on issue by <a href="https://github.com/apps/github-actions">github-actions[bot]</a>
<p>This issue is stale because it has been open for 3 weeks with no activity. Remove the stale label or comment or this will be closed in another 5 days.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-17 12:12:16
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2221#issuecomment-1385992520">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>> How can I use playwright reporter in cucumber js</p>
<p>You can't; Playwright Test is a different test runner to Cucumber.</p>
<p>> cucumber.js report does not contain the info for each line of code, but playwright report has</p>
<p>Could you elaborate a little on the functionality you'd like to get from the Cucumber report?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-17 17:38:10
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2221#issuecomment-1386341271">Comment</a> on issue by <a href="https://github.com/bodycombathuang">bodycombathuang</a>
<p>here is the report generated by playwright test runner, it shows whether each expression of code is executed successfully or not (locator.click(internal:role=link[name="Get started"i]), expect.toHaveTitle...)<br />
<url|<br />
playwright<br />
><br />
here is the html report generated by cucumber js test runner, it only contains words from feature file and exceptions in case of error, is it possible cucumber js report can show whether each expression of code is executed successfully or not</p>
<p><a href="https://user-images.githubusercontent.com/20555274/213060730-3b37ea27-2d10-46c6-aff6-d2e02f129400.JPG">cucumberreport</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-19 01:12:18
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2221#issuecomment-1396656287">Comment</a> on issue by <a href="https://github.com/HanLiu1976">HanLiu1976</a>
<p>This is the one I also concern. For how the error indicator detail as playwright by cucumber report. any suggestions?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-19 08:23:13
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2221#issuecomment-1397245028">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Cucumber isn't going to do something that's specific to Playwright itself. But if you can get the information you want out of Playwright there are maybe things you can try:</p>
<p>• <code>this.log</code> from within a step will emit a plain text attachment that shows up in the report. Is there some logging from Playwright you could hook into and send to this?
• <code>setDefinitionFunctionWrapper</code> could be used to wrap the step and do something with the exception before it bubbles up to Cucumber. Maybe there's some detail you can pull out of there and log?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-19 19:09:46
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2221#issuecomment-1397873016">Comment</a> on issue by <a href="https://github.com/bodycombathuang">bodycombathuang</a>
<p><a href="https://github.com/davidjgoss">@davidjgoss</a> thanks for your help. I have more question<br />
which apis/method can return expressions (like page.goto ,expect.toHaveTitle expressions in the above picture), that each test run has called and return whether each expression succeeds or fails</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-20 00:26:18
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2221#issuecomment-1398059312">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>I don't know <a href="https://github.com/bodycombathuang">@bodycombathuang</a>, you'd need to consult <strong>Playwright's docs</strong> for that, it's not in scope of Cucumber's support.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-05 01:55:05
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2221#issuecomment-1417279232">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Going to close this one because the unknowns are about Playwright not Cucumber.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-17 23:08:12
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2222#issuecomment-1386586401">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>There isn’t, reasons are essentially the same as for <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/faq.md#why-arent-there-beforefeature-and-afterfeature-hooks">https://github.com/cucumber/cucumber-js/blob/main/docs/faq.md#why-arent-there-beforefeature-and-afterfeature-hooks</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-19 08:18:50
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2223#issuecomment-1397237708">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Thanks for the detailed report <a href="https://github.com/kbfirebreather">@kbfirebreather</a>! I'll take a proper look at this soon.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-12 08:25:13
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2223#issuecomment-1427072853">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Released in <a href="https://github.com/cucumber/cucumber-js/releases/tag/v8.11.1">https://github.com/cucumber/cucumber-js/releases/tag/v8.11.1</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-21 04:37:26
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2224#issuecomment-1399243714">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/56162687">Coverage Status</a></p>
<p>Coverage: 98.563%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/18a0c978bdc8b9296a3314c39daf55a9cd3b9c95">18a0c97</a> on renovate/commander-10.x</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/0a2d8dcb6afbe1cc50b45091d8294990952932fb">0a2d8dc</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-21 04:45:11
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2224#issuecomment-1399245009">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Should wait for when we drop Node.js 12 support.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-10 09:01:26
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2225#issuecomment-1426089482">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Thanks for raising <a href="https://github.com/triesztui">@triesztui</a>. I can reproduce this too and will dig into it soon.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-10 09:44:39
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2225#issuecomment-1426136965">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Are you using the <code>html</code> formatter <a href="https://github.com/triesztui">@triesztui</a>? Initial investigation suggests it's related.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-12 08:25:09
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2225#issuecomment-1427072832">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Released in <a href="https://github.com/cucumber/cucumber-js/releases/tag/v8.11.1">https://github.com/cucumber/cucumber-js/releases/tag/v8.11.1</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-13 00:23:44
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2225#issuecomment-1427529894">Comment</a> on issue by <a href="https://github.com/triesztui">triesztui</a>
<p>yes I do use the html formatter. Thank you very much for looking into this David.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-13 00:44:19
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2225#issuecomment-1427551692">Comment</a> on issue by <a href="https://github.com/triesztui">triesztui</a>
<p>fix works well, thank you.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-11 00:02:50
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2226#issuecomment-1426654070">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Thanks for the detail <a href="https://github.com/pawelrochala">@pawelrochala</a>. This is a weird one.</p>
<p>I'm not able to reproduce this but I think it's going to be something about one or more of your features. Would you be willing to share the filenames and/or content?</p>
<p>A possible way to narrow it down would be to run one feature at a time and see if any in particular yield the failure.</p>
<p>I'd also note that the command line args you are passing in are duplicating/conflicting what's in your config file.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-20 04:55:32
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2226#issuecomment-1436974124">Comment</a> on issue by <a href="https://github.com/shogowada">shogowada</a>
<p>Moving the feature files to the default location (<code>./features/****</code>) and removing the <code>paths</code> config fixed the issue for me.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-01-25 07:11:04
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2227#issuecomment-1403770179">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/56283405">Coverage Status</a></p>
<p>Coverage: 98.563%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/ad77fde06cdabccb5295cc022eb5df66f53be961">ad77fde</a> on zcmgyu:add-file-junit-formatter</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/0a2d8dcb6afbe1cc50b45091d8294990952932fb">0a2d8dc</a> on cucumber:main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-03 08:27:18
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2227#issuecomment-1416104165">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Thanks for raising this <a href="https://github.com/zcmgyu">@zcmgyu</a>.</p>
<p>I'm in two minds because this seems a useful capability to hook up with in CircleCI, but we don't have the <code>file</code> attr in our <a href="https://github.com/cucumber/cucumber-junit-xml-formatter">canonical JUnit formatter</a> from the JVM implementation, and it's not a standard attr from the (admittedly not particularly well standardised) schema. <a href="https://github.com/mpkorstanje">@mpkorstanje</a> what do you think?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-03 08:51:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2227#issuecomment-1416132672">Comment</a> on pull request by <a href="https://github.com/zcmgyu">zcmgyu</a>
<p><a href="https://github.com/davidjgoss">@davidjgoss</a> Thank you for considering. It would be great if this functionality could support when running Cucumber by feature files on the CircleCI environment. 🔥</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-03 09:54:08
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2227#issuecomment-1416208398">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>Following the principle of robustness whe should be strict in what we emit. So I would recommend against deviations from the schema.</p>
<p>But giving the Circle CI documentation a cursory read I also do think we do not need the changes proposed in this particular PR to support Circle CI test splitting.</p>
<p>The full example provided at the end of the page suggests the following pattern:</p>
<pre><code>circleci tests glob "test/****/**.rb" | circleci tests split &gt; /tmp/tests-to-run
bundle exec rspec $(cat /tmp/tests-to-run)
</code></pre>
<p>Ideally we follow this pattern by allowing Cucumber to list its scenarios and/or features as they appear in the JUnit XML report.</p>
<p>So something like</p>
<pre><code>cucumber-js --list scenarios | circleci tests split --time &gt; /tmp/tests-to-run
cucumber-js $(cat /tmp/tests-to-run)
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-03 10:17:07
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2227#issuecomment-1416233520">Comment</a> on pull request by <a href="https://github.com/zcmgyu">zcmgyu</a>
<p>Hi! <a href="https://github.com/mpkorstanje">@mpkorstanje</a><br />
Thank you for your suggestion.<br />
Do you think about the Scenario Outline with multiple examples? Suppose that I could list up the Scenario Outline name but in the XML output, the test case will be listed with the index. CircleCI could hook up with the first example, but from the second one, I think CircleCI will have no idea what is this scenario.</p>
<p>Below is the output of Scenario Outline <code>my templated scenario</code> executed.</p>
<pre><code>&lt;?xml version="1.0"?&gt;
&lt;testsuite failures="1" skipped="0" name="cucumber-js" time="0.002" tests="2"&gt;
&lt;testcase classname="my feature" name="my templated scenario" time="0.001"&gt;
&lt;system-out&gt;
&lt;![CDATA[Given a passing step......................................................passed]]&gt;
&lt;/system-out&gt;
&lt;/testcase&gt;
&lt;testcase classname="my feature" name="my templated scenario [1]" time="0.001"&gt;
&lt;failure type="FAILED" message="A hook or step failed"&gt;
&lt;![CDATA[error]]&gt;
&lt;/failure&gt;
&lt;system-out&gt;
&lt;![CDATA[Given a failing step......................................................failed]]&gt;
&lt;/system-out&gt;
&lt;/testcase&gt;
&lt;/testsuite&gt;
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-03 12:15:45
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2227#issuecomment-1416356061">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>I do think it is reasonable to expect Cucumber to render the scenario names with sufficient detail in the XML report so that they can be selected for execution again</p>
<p>For example the canonical XML formatter renders the following feature</p>
<pre><code>Feature: Examples Tables
Scenario Outline: Eating cucumbers
Given there are &lt;start&gt; cucumbers
When I eat &lt;eat&gt; cucumbers
Then I should have &lt;left&gt; cucumbers
Examples: These are passing
| start | eat | left |
| 12 | 5 | 7 |
| 20 | 5 | 15 |
Examples: These are failing
| start | eat | left |
| 12 | 20 | 0 |
| 0 | 1 | 0 |
</code></pre>
<p>In the XML as:</p>
<pre><code>&lt;testcase classname="Examples Tables" name="Eating cucumbers - These are passing - Example #1.1" /&gt;
&lt;testcase classname="Examples Tables" name="Eating cucumbers - These are passing - Example #1.2" /&gt;
&lt;testcase classname="Examples Tables" name="Eating cucumbers - These are failing - Example #2.1" /&gt;
&lt;testcase classname="Examples Tables" name="Eating cucumbers - These are failing - Example #2.2" /&gt;
</code></pre>
<p>I don't believe we can currently do this round trip in Cucumber JS, but that would be reasonable to implement in one or more PRs.</p>
<p>I also don't know the exact details of the circle CI <code>circleci tests split --time</code> command, I couldn't find documentation for it either. So some experimentation may be need to see exactly how it processes it's inputs. It may be that the inputs are not processed in a reasonable way.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-03 12:18:13
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2227#issuecomment-1416358681">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>And I do realize that this a bigger ask then the current suggestion, I'm sorry about that. In the long run it causes less grief for us to do things the right way.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-03 22:42:27
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2227#issuecomment-1416679059">Comment</a> on pull request by <a href="https://github.com/zcmgyu">zcmgyu</a>
<p>After a week of researching the CircleCI documentation, this is my awareness of CircleCI split API.</p>
<p>Suppose that I have a list of scenario names in the <code>scenarioList.txt</code> file.</p>
<pre><code>Eating cucumbers
Drink cucumber juice
Cook cucumber
</code></pre>
<p>And run it in 2 parallel executors.</p>
<p><code>cat scenarioList.txt | circleci tests split --split-by=timings</code></p>
<p>Based on the timing data from the JUnit XML report of the previous job run, CircleCI adjusts which test case should be in which executor. As you can see, there is no scenario named <code>Eating cucumbers - These are passing - Example #1.1</code> in <code>scenarioList.txt</code>, then no timing data is found, the tests will then be split alphabetically by test name.</p>
<pre><code>&lt;testcase classname="Examples Tables" name="Eating cucumbers - These are passing - Example #1.1" time="30" /&gt;
&lt;testcase classname="Examples Tables" name="Eating cucumbers - These are passing - Example #1.2" time="60" /&gt;
&lt;testcase classname="Examples Tables" name="Eating cucumbers - These are failing - Example #2.1" time="20" /&gt;
&lt;testcase classname="Examples Tables" name="Eating cucumbers - These are failing - Example #2.2" time="50" /&gt;
...
</code></pre>
<p>How about if we could list the case as a JUnit XML report in the <code>scenarioList.txt</code> file?</p>
<pre><code>Eating cucumbers - These are passing - Example #1.1
Eating cucumbers - These are passing - Example #1.2
...
</code></pre>
<p>Now, CircleCI already knows <code>Eating cucumbers - These are passing - Example #1.1</code> test case took 30 seconds to finish.<br />
I have no idea how to filter which scenario outline's example is run in CucumberJS.<br />
<a href="https://github.com/cucumber/cucumber-js/blob/main/docs/filtering.md">https://github.com/cucumber/cucumber-js/blob/main/docs/filtering.md</a></p>
<p>I did a trick by slicing every example to multiple feature files, then I could filter which example is run by file name. But I missed the file name in the JUnit XML report.</p>
<p>One more odd scenario I'm always wondering about, some examples of the same Scenario Outline could not run in parallel. I could not list it as an execution unit, it got a conflict while running in parallel.</p>
<pre><code>Eating cucumbers - These are passing - Example #1.1
Eating cucumbers - These are passing - Example #1.2
...
</code></pre>
<p>I know it is tough to make sense of all common scenarios. Firstly, I just patch this case in my project.</p>
<p>Let me know if you want some helps.</p>
<p>Thanks again 💯 👍:skin<em>tone</em>2:</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-04 06:26:29
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2227#issuecomment-1416766559">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>> One more odd scenario I'm always wondering about, some examples of the same Scenario Outline could not run in parallel. I could not list it as an execution unit, it got a conflict while running in parallel.</p>
<p>Parallel execution of tests is relatively complex implementation wise. So Cucumber was build with the assumption is that each example and scenario would be independent.</p>
<p>And in the context of Circle CI, we have to flatten Cucumbers hierarchy of scenarios and examples into a <code>classname method-name</code> format for the XML report so it makes sense to hold onto this assumption.</p>
<p>Fundamentally this problem isn't unsolvable, for example in the Java ecosystem with JUnit 5 a generic platform was developed for the discovery, selection and execution of tests. Within this framework tests can indicate which resources they need. A test splitting/distribution tool can use this information to make safe groupings. Though I'm not aware of such a framework in the JavaScript ecosystem. I also think it extremely unlikely we'll be the ones to develop it.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-04 06:58:05
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2227#issuecomment-1416774643">Comment</a> on pull request by <a href="https://github.com/zcmgyu">zcmgyu</a>
<p>> And in the context of Circle CI, we have to flatten Cucumbers hierarchy of scenarios and examples into a classname method-name format for the XML report so it makes sense to hold onto this assumption.</p>
<p>It sounds great.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-02 00:00:26
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2228#issuecomment-1413297521">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/56535901">Coverage Status</a></p>
<p>Coverage: 98.563%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/1a37a62cf687ef50d48f2b88fc3afef5edba3ee8">1a37a62</a> on zcmgyu:replace-invalid-char-in-junit-xml</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/0a2d8dcb6afbe1cc50b45091d8294990952932fb">0a2d8dc</a> on cucumber:main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-03 08:39:53
*Thread Reply:*
Review approved by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/zcmgyu">zcmgyu's</a> pull request
<p>Thanks very much <a href="https://github.com/zcmgyu">@zcmgyu</a>!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-03 08:40:09
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2228#issuecomment-1416119232">Comment</a> on pull request by <a href="https://github.com/aslakhellesoy">aslakhellesoy</a>
<p>Hi <a href="https://github.com/zcmgyu">@zcmgyu</a>,</p>
<p>Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾</p>
<p>In return for this generous offer we hope you will:</p>
<p>• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our <a href="https://cucumber.io/conduct">code of conduct</a> in your interactions with other collaborators and users.
• 💬 Join the <a href="http://cucumber.io/support#slack">community Slack channel</a> to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!</p>
<p>On behalf of the Cucumber core team,<br />
Aslak Hellesøy<br />
Creator of Cucumber</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-12 08:26:05
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2228#issuecomment-1427073069">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Released in <a href="https://github.com/cucumber/cucumber-js/releases/tag/v8.11.0">https://github.com/cucumber/cucumber-js/releases/tag/v8.11.0</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-03 08:56:15
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2214#issuecomment-1416138635">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Edited/Blocked Notification</strong></p>
<p>Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.<br />
You can manually request rebase by checking the rebase/retry box above.</p>
<p>⚠️ <strong>Warning</strong>: custom changes will be lost.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-04 04:27:32
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2212#issuecomment-1416739407">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Edited/Blocked Notification</strong></p>
<p>Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.<br />
You can manually request rebase by checking the rebase/retry box above.</p>
<p>⚠️ <strong>Warning</strong>: custom changes will be lost.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-04 04:50:27
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2212#issuecomment-1416743901">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/56612484">Coverage Status</a></p>
<p>Coverage: 98.563%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/8e71228f65227b1cdedf5218952493dc710062ee">8e71228</a> on renovate/cucumber-packages</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/405984f972a738d306d278d9495b0a00f631fa7c">405984f</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-04 04:44:28
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2088#issuecomment-1416742871">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>I'm a bit uneasy about adding something that's geared specially around a TypeScript concept. I think plain old arrays would be fine though e.g.</p>
<pre><code>defineSimpleParameterTypes({
Fruit: ['Apple', 'Orange', 'Cucumber'],
Vegetables: ['Potato', 'Eggplant']
})
</code></pre>
<p>And with TS it's fairly trivial to define a type from an array so not much extra overhead.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-07 21:57:36
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2088#issuecomment-1422055977">Comment</a> on issue by <a href="https://github.com/mattwynne">mattwynne</a>
<p>I'm confused about why this is useful. Can I see a more realistic example?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-20 07:38:04
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2088#issuecomment-1437210173">Comment</a> on issue by <a href="https://github.com/nextlevelbeard">nextlevelbeard</a>
<p>> I'm a bit uneasy about adding something that's geared specially around a TypeScript concept. I think plain old arrays would be fine though e.g.</p>
<p>This wouldnn't take anything away from existing users, it's just making it simpler working with TS enums.<br />
You can easily add this <code>registerTypes</code> function to any existing setup. But I agree arrays could be a better approach.</p>
<p>The arrays would need to be readonly in order for users to be able to reference the parameter type in the steps.<br />
Would look something like this maybe.</p>
<pre><code>// Proposal, a function that takes an array of strings and defines type parameters
const registerTypes = (types: Record&lt;string, readonly string[]&gt;) =&gt; {
Object.entries(types).forEach(([name, type]) =&gt; defineParameterType({
name: name, // i.e. Fruit
// Enum /w numeric keys are not possible by TypeScript design, we can safely filter keys
regexp: new RegExp(type.filter(k =&gt; !Number(k)).join('|')), // i.e. Apple|Orange|Cucumber,
transformer: (s: string) =&gt; s
}))
}
import { Then, registerTypes } from '@cucumber/cucumber';
const Fruit = ['Apple', 'Orange', 'Cucumber'] as const
const Vegetables = ['Potato', 'Eggplant'] as const
registerTypes({ Fruit, Vegetables })
Then('I should have an? {Fruit} in my basket', stepFn = async function (fruit: typeof Fruit[number]) {
// Type safety, IDE complains about impossible comparisons
if(fruit === "asd"){
}
})
</code></pre>
<p>> I'm confused about why this is useful. Can I see a more realistic example?</p>
<ol><li>Makes working with many multiple choice parameter data simpler by declaring and re-using the options as types</li><li>Simplifies the use of <code>defineParameterType</code> for simple cases</li><li>Makes parameters offer type-safety when doing comparisons in steps.</li>
</ol>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-05 01:22:56
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2229#discussion_r1096650565">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>I can't find the matching expectation for this one.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-05 01:25:23
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2229#discussion_r1096650889">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>This runs against the corresponding CCK feature <a href="https://github.com/cucumber/compatibility-kit/tree/main/devkit/samples/cdata">https://github.com/cucumber/compatibility-kit/tree/main/devkit/samples/cdata</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-05 01:29:47
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2229#discussion_r1096651479">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>But the CCK doesn't contain XML to assert against. I would expect this outcome:</p>
<p><a href="https://github.com/cucumber/cucumber-junit-xml-formatter/blob/main/testdata/cdata.feature.xml">https://github.com/cucumber/cucumber-junit-xml-formatter/blob/main/testdata/cdata.feature.xml</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-05 01:43:52
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2229#discussion_r1096653641">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Ah okay, so that's a test case we can add to the JUnit formatter for now, and then once it moves to the polyglot repo it will have that test anyway.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-05 01:46:37
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2229#discussion_r1096654042">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>👍</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-05 01:51:33
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2229#discussion_r1096654673">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Pushed.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-05 15:01:44
*Thread Reply:*
Review approved by <a href="https://github.com/mpkorstanje">mpkorstanje</a> on <a href="https://github.com/davidjgoss">davidjgoss's</a> pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-05 01:47:15
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2231#issuecomment-1417258323">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/56618819">Coverage Status</a></p>
<p>Coverage: 98.563%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/32fdac14c0659a2fdbb260e1fcff7e7c7236fdca">32fdac1</a> on stale-workflows</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/a8e39b9f4c9bcb126378d0f8e0c173de87ec3631">a8e39b9</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-05 02:10:24
*Thread Reply:*
Review approved by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/olivierodo">olivierodo's</a> pull request
<p>Sorry, I think I worded my request poorly but I've updated now.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-05 02:15:52
*Thread Reply:*
Review comment by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/olivierodo">olivierodo's</a> pull request
<p>Thanks, this looks good. Just to be clear, this is an action that you maintain?</p>
<p>I think all the 404s for the common repo are because those libraries have now been split out into their owns repos under the cucumber org, so they should be fairly simple to resolve - if you have time, great, but don't worry if not.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-27 07:40:51
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2232#issuecomment-1446560673">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/57330829">Coverage Status</a></p>
<p>Coverage: 98.561%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/9212900fc357141097075d86c34772b8d7f4648b">9212900</a> on limaAniceto:ma-parallel-add-worker</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/bf8f6816c1015090a323e38a5052fd6ac6711b51">bf8f681</a> on cucumber:main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-11 00:30:35
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2235#issuecomment-1426661102">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/56843045">Coverage Status</a></p>
<p>Coverage: 98.564%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/76e16aec3390bdb08a1a022c536856ed58fe99f4">76e16ae</a> on fix/flaky-api-tests</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/847f613fd04e134404bc314ee4c2551f1413a711">847f613</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-11 03:13:42
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2236#issuecomment-1426701395">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/56843904">Coverage Status</a></p>
<p>Coverage: 98.563%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/306c8d7e4957c15c6d2d26ce777c079d34209c77">306c8d7</a> on fix/json-formatter-examples-location</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/cd50dc2cdfb3581a5904a3d118aacdf1a38e6969">cd50dc2</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-11 09:48:39
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2237#issuecomment-1426836635">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/56846139">Coverage Status</a></p>
<p>Coverage: 98.563%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/b1e7a94603f7363be2a29bde55e9311a90c4bc98">b1e7a94</a> on cr-remove17</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/cd50dc2cdfb3581a5904a3d118aacdf1a38e6969">cd50dc2</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-12 03:09:46
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2237#issuecomment-1427004149">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>> Will need to a major release for this change. Any other incoming breaking changes planned?</p>
<p>Yep, a few small ones, I've listed them in <a href="https://github.com/cucumber/cucumber-js/milestone/15">https://github.com/cucumber/cucumber-js/milestone/15</a> and will get PRs up for the others shortly.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-16 06:35:09
*Thread Reply:*
Review approved by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/charlierudolph">charlierudolph's</a> pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-12 08:25:18
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2143#issuecomment-1427072869">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Released in <a href="https://github.com/cucumber/cucumber-js/releases/tag/v8.11.1">https://github.com/cucumber/cucumber-js/releases/tag/v8.11.1</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-12 08:08:32
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2240#issuecomment-1427069428">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/56852959">Coverage Status</a></p>
<p>Coverage: 98.563% (+0.0006%) from 98.563% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/d01e286ed09236f45212d6d896d676533a970c75">d01e286</a> on chore/deprecations-housekeeping</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/e07d3ffd178bf18f72387cf4cce09104472ff9f4">e07d3ff</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-12 14:53:57
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2240#issuecomment-1427154426">Comment</a> on pull request by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>From a process point of view I have only one remark:</p>
<p>> except maybe SummaryFormatter which is the one people would reasonably extend when building their own.</p>
<p>If this class is open for extension it should be documented as such. And be tested against the specific use cases it aims to support.</p>
<p>Otherwise it will be hard to evolve the code in the future.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-12 10:27:55
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2241#issuecomment-1427100221">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/56853792">Coverage Status</a></p>
<p>Coverage: 98.561% (-0.002%) from 98.563% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/0b44a0f8eec22a1c2cd9992803309348c1ce075b">0b44a0f</a> on chore/snippets-breaking-changes</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/e07d3ffd178bf18f72387cf4cce09104472ff9f4">e07d3ff</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-13 00:40:55
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2242#issuecomment-1427547958">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Please upgrade to the latest <code>@cucumber/cucumber</code> (8.11.1 at time of writing) and also remove your dependency on <code>@cucumber/html-formatter</code> - you don't need to depend on that yourself because Cucumber brings the correct version in.</p>
<p>In newer versions, you can click on any of the rows in the example table to go through and see attachment/error details for each step.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-15 13:52:50
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2243#issuecomment-1432088288">Comment</a> on issue by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>Pull request issued, but once again I didn't probably link it to the issue - sorry. Will close this and continue discussion there.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-15 12:31:16
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2244#issuecomment-1431990899">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/56979786">Coverage Status</a></p>
<p>Coverage: 98.563%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/d867a7e6331f59e9cdc511428e30acfe28f9db18">d867a7e</a> on michael-lloyd-morris:2243-clarify-transpile.md</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/e07d3ffd178bf18f72387cf4cce09104472ff9f4">e07d3ff</a> on cucumber:main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-16 18:06:48
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2220#issuecomment-1433994911">Comment</a> on issue by <a href="https://github.com/apps/github-actions">github-actions[bot]</a>
<p>This issue was closed because it has been stalled for 5 days with no activity.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-18 11:46:24
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2245#discussion_r1111100225">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<https://github.com/cucumber/cucumber-js/pull/2245|#2245 stop using deprecated api in feature tests>
<p>Should this now say something like "runCucumber threw an error"?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-18 11:46:24
*Thread Reply:*
Review comment by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/charlierudolph">charlierudolph's</a> pull request
<p>Looks good, couple of suggestions.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-18 11:46:24
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2245#discussion_r1111103137">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<https://github.com/cucumber/cucumber-js/pull/2245|#2245 stop using deprecated api in feature tests>
<p>Looking at the 2 failing scenarios, I think this call to <code>parse</code> and the one below to <code>loadConfiguration</code> should also move inside of the try block.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-18 11:48:59
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2245#issuecomment-1435755457">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<https://github.com/cucumber/cucumber-js/pull/2245|#2245 stop using deprecated api in feature tests>
<p>When first implementing <code>runCucumber</code> I looked at this and half-considered just making <code>@spawn</code> the only behaviour i.e. so they all run via the executable in a child process, but that would probably slow it down a lot.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-18 17:02:59
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2245#issuecomment-1435805426">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<https://github.com/cucumber/cucumber-js/pull/2245|#2245 stop using deprecated api in feature tests>
<p><a href="https://coveralls.io/builds/57074208">Coverage Status</a></p>
<p>Coverage: 98.561%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/1e503834c1f7a54fde33dc3d371c81bf5ee543d3">1e50383</a> on cr-stopUsingDeprecated</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/9fbdd82246fdf183efe76545b26bd7cfb9e03639">9fbdd82</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-18 17:07:36
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2245#issuecomment-1435806288">Comment</a> on pull request by <a href="https://github.com/charlierudolph">charlierudolph</a>
<https://github.com/cucumber/cucumber-js/pull/2245|#2245 stop using deprecated api in feature tests>
<p>> When first implementing <code>runCucumber</code> I looked at this and half-considered just making <code>@spawn</code> the only behaviour i.e. so they all run via the executable in a child process, but that would probably slow it down a lot.</p>
<p>On my machine with current:</p>
<pre><code>$ time node bin/cucumber.js 17:00:36
296 scenarios (296 passed)
1520 steps (1520 passed)
1m02.737s (executing steps: 1m02.270s)
________________________________________________________
Executed in 68.98 secs fish external
usr time 55.91 secs 167.00 micros 55.91 secs
sys time 7.16 secs 809.00 micros 7.16 secs
</code></pre>
<p>Switching to spawn only:</p>
<pre><code>$ time node bin/cucumber.js 17:02:28
... &lt;one unexpected test failure&gt;
296 scenarios (1 failed, 295 passed)
1520 steps (1520 passed)
2m59.086s (executing steps: 2m58.641s)
________________________________________________________
Executed in 185.42 secs fish external
usr time 169.14 secs 157.00 micros 169.14 secs
sys time 23.52 secs 916.00 micros 23.52 secs
</code></pre>
<p>So about 3x slower if we switch to spawn only</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-18 17:08:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2245#discussion_r1111132067">Comment</a> on pull request by <a href="https://github.com/charlierudolph">charlierudolph</a>
<https://github.com/cucumber/cucumber-js/pull/2245|#2245 stop using deprecated api in feature tests>
<p>Updated</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-18 17:08:15
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2245#discussion_r1111132088">Comment</a> on pull request by <a href="https://github.com/charlierudolph">charlierudolph</a>
<https://github.com/cucumber/cucumber-js/pull/2245|#2245 stop using deprecated api in feature tests>
<p>Moved inside try block</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-18 23:34:17
*Thread Reply:*
Review approved by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/charlierudolph">charlierudolph's</a> pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-18 17:35:04
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2246#discussion_r1111134146">Comment</a> on pull request by <a href="https://github.com/charlierudolph">charlierudolph</a>
<p>Think we do probably want to extend to running prettier on these md files and most of docs. But thinking can enable that in a follow up</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-18 17:37:09
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2246#issuecomment-1435810446">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/57074428">Coverage Status</a></p>
<p>Coverage: 98.561%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/4b66e00371743da178235c1dd5fcf9feb9ef7e6e">4b66e00</a> on cr-prettier</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/9fbdd82246fdf183efe76545b26bd7cfb9e03639">9fbdd82</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-19 01:30:17
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2246#discussion_r1111200285">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Makes sense. We'd need to watch out for <code>CHANGELOG.md</code> as that gets edited by <a href="https://github.com/cucumber/changelog">a robot</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-19 01:33:18
*Thread Reply:*
Review approved by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/charlierudolph">charlierudolph's</a> pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-21 17:16:27
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2247#issuecomment-1439301795">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<https://github.com/cucumber/cucumber-js/pull/2247|#2247 chore: housekeeping ahead of 9.0.0 release>
<p><a href="https://coveralls.io/builds/57161082">Coverage Status</a></p>
<p>Coverage: 98.561%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/203f3848d93508440d4be2e71068c259d439a7a1">203f384</a> on chore/9-0-0-housekeeping</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/9fbdd82246fdf183efe76545b26bd7cfb9e03639">9fbdd82</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-23 08:08:58
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2248#issuecomment-1442043685">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Do you have a <code>tsconfig.json</code>? If so, what does that look like?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-23 08:21:30
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2248#issuecomment-1442062846">Comment</a> on issue by <a href="https://github.com/NiclasThobaben">NiclasThobaben</a>
<p>Yeah sure! (Totally forgot about that, sorry)<br />
We also tried playing around with the <code>target</code> and <code>module</code> options and followed the instructions in the transpiling documentation.</p>
<pre><code>{
"compilerOptions": {
"target": "es5",
"lib": [
"dom",
"dom.iterable",
"esnext"
],
"allowJs": true,
"skipLibCheck": true,
"esModuleInterop": true,
"allowSyntheticDefaultImports": true,
"strict": true,
"forceConsistentCasingInFileNames": true,
"noFallthroughCasesInSwitch": true,
"module": "esnext",
"moduleResolution": "node",
"resolveJsonModule": true,
"isolatedModules": true,
"noEmit": true,
"jsx": "react-jsx"
},
"include": [
"src"
]
}
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-28 05:56:33
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2248#issuecomment-1448221308">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>As you've found I don't think <code>ts-node</code> will help you here. Babel is what you're using to transpile so we should stick with that.</p>
<p>Calling <code>@babel/register</code> in the way you have from the config file probably makes the most sense. Are you sure it's picking up your babel config file? Also I note <a href="https://babeljs.io/docs/babel-register#ignores-node_modules-by-default">the doc for that package</a> suggests you may need to explicitly configure the <code>ignore</code> there too.</p>
<p>> If this is not something completely obvious, I could create an example repository for this issue.</p>
<p>That would be good if you have time.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-02 08:27:00
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2248#issuecomment-1452157469">Comment</a> on issue by <a href="https://github.com/NiclasThobaben">NiclasThobaben</a>
<p>I created a small example repository <a href="https://github.com/NiclasThobaben/cucumber-esm-issue">here</a>.<br />
It seems like the babel config gets picked up, but also with the explicit <code>ignore</code>, it does not work unfortunately. Only thing I've noticed is, when the <code>ignore</code> is not set, it runs a little bit faster, as if it is correctly trying to transpile the external library.</p>
<p>It seems like the issue now comes from babel. As stated <a href="https://babeljs.io/docs/babel-register/#experimental-babel-8-implementation">here</a>, <code>@babel/register</code> can not transpile ESM on the fly (however, I'm not quite sure if that refers to babel 8 only).</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-07 17:12:50
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2248#issuecomment-1459112907">Comment</a> on issue by <a href="https://github.com/Izhaki">Izhaki</a>
<p>I've been pretty much on the same path as yours, trying everything you've tried, and spent around 10h on this issue.</p>
<p>It would be impossible for me to impart all I've learnt, but this is generally not a cucumber issue. Rather, it is the current friction between CJS and ESM on node (I haven't had a chance to fully investigate it, but my current hypothesis is that the <code>esm</code> node loader can toggle to the <code>cjs</code> loader, but then breaks the other way around).</p>
<p>The good news is that there is a working solution: <a href="https://www.npmjs.com/package/fix-esm">https://www.npmjs.com/package/fix-esm</a>; I've used this:</p>
<pre><code>require("fix-esm").register();
</code></pre>
<p>And for the brave, a hint of the nature of the issue is in that library code:</p>
<pre><code>if (error.code === "ERR_REQUIRE_ESM") {
// NOTE: We completely bypass the default internal loader, as we cannot patch the `type: module` check out of that. Please open a PR if you have a better solution!
let code = fs.readFileSync(filename, "utf8");
let transpiledCode = transpile(code);
mod._compile(transpiledCode.code, filename);
} else {
throw error;
}
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-08 02:32:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2248#issuecomment-1459955146">Comment</a> on issue by <a href="https://github.com/NiclasThobaben">NiclasThobaben</a>
<p>Yeah, exactly my thought. This whole topic of CJS and ESM is somewhat confusing, especially when coming from a different background. It would be great, if library vendors would always still include a CJS build, considering that its actually not that hard to do with rollup etc., but oh well..</p>
<p>I will try the fix-esm package later, seems like it's the best and most "generic" way to go about the issue. Thanks a lot for the hint!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-09 09:06:52
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2248#issuecomment-1462432095">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>I'll close this now as I don't think there's anything for Cucumber to change, it's more a reflection of the weird state of things in Node.js at the moment with regard to module formats and loading.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-09 13:55:52
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2248#issuecomment-1462878469">Comment</a> on issue by <a href="https://github.com/Izhaki">Izhaki</a>
<p><a href="https://github.com/davidjgoss">@davidjgoss</a> I agree that this issue should be closed.</p>
<p>However, I believe <code>cucumber-js</code> is currently only using <code>require</code> internally, which causes all sorts of issues for people who are configuring their repos as esm ones (<code>"type": "module"</code>).</p>
<p>Although many do not support it yet (NextJS for example, as it is using internally bespoke loaders), more and more libraries phase out CJS support, and more and more people migrate to esm repros.</p>
<p>These problems will just generate more and more noise in the future.</p>
<p>I wonder if an <a href="https://github.com/halvardssm/cucumber-js/pull/1/files">initiative such as that</a> by <a href="https://github.com/halvardssm">@halvardssm</a>, where we split the distribution to <code>cucumber-js</code> and <code>cucumber-js-esm</code> are a viable plan forward.</p>
<p>This topic is probably worthy a new issues, maybe an RFC.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-09 14:04:02
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2248#issuecomment-1462887941">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>> currently only using require internally</p>
<p>No, we support ESM as well and will use dynamic import where specified:</p>
<p>• <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/esm.md">https://github.com/cucumber/cucumber-js/blob/main/docs/esm.md</a></p>
<p>> I wonder if an <a href="https://github.com/halvardssm/cucumber-js/pull/1/files">initiative such as that</a> by <a href="https://github.com/halvardssm">@halvardssm</a>, where we split the distribution to cucumber-js and cucumber-js-esm are a viable plan forward.</p>
<p>I don't think that would achieve anything. It was one of the patterns we considered for dual support initially, but it achieves essentially the same result.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-09 14:05:32
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2248#issuecomment-1462889955">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>More background <a href="https://github.com/cucumber/cucumber-js/discussions/2059">https://github.com/cucumber/cucumber-js/discussions/2059</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-09 14:33:25
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2248#issuecomment-1462920073">Comment</a> on issue by <a href="https://github.com/Izhaki">Izhaki</a>
<p>Oooooooooohhhhh.....</p>
<p>It does work! But you have to:</p>
<pre><code>cucumber-js --import 'features/support/****/**.js'
</code></pre>
<p>I have read the ESM guide before, but completely missed this sentence:</p>
<p>> you'll need to use the import configuration option to specify your files.</p>
<p>This is awesome to know!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-09 23:29:51
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2248#issuecomment-1463387598">Comment</a> on issue by <a href="https://github.com/NiclasThobaben">NiclasThobaben</a>
<p><a href="https://github.com/Izhaki">@Izhaki</a> This does not seem to work with Typescript. But using <code>fix-esm</code> with <code>require</code> works, although I need to disable the usage of the local babel config file (not really sure why).</p>
<p>What I don't like about the <code>fix-esm</code> solution, is that the project seems to be hibernating. Open issues and PRs for about a year on a private Gitea server is not really a boost in confidence. So I'm thinking about forking it to Github, so the community can work on it.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-20 15:02:05
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2248#issuecomment-1476993700">Comment</a> on issue by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>I ran into a similar issue to this with NextJS and wrote about my findings here. It might have enough overlap to help:</p>
<p><a href="https://mmorris-sandbox.net/demos/cucumber-next">https://mmorris-sandbox.net/demos/cucumber-next</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-26 18:05:18
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2205#issuecomment-1445563063">Comment</a> on issue by <a href="https://github.com/apps/github-actions">github-actions[bot]</a>
<p>This issue is stale because it has been open for 3 weeks with no activity. Remove the stale label or comment or this will be closed in another 5 days.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-04 18:12:22
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2205#issuecomment-1454961280">Comment</a> on issue by <a href="https://github.com/apps/github-actions">github-actions[bot]</a>
<p>This issue was closed because it has been stalled for 5 days with no activity.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-28 04:52:14
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2249#issuecomment-1448127414">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>It looks like you have some compilation errors in your step definition code. This is on you to fix, but if you post some code there might be something obvious to point out here.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-07 00:35:10
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2249#issuecomment-1457761453">Comment</a> on issue by <a href="https://github.com/abdulkalam1233">abdulkalam1233</a>
<p>When I run the script "node cucumber.runner.js" (js code) works fine. But it is failing with the ts-node</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-07 19:45:43
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2249#issuecomment-1459352844">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>So again you seem to have some type errors. If you try to compile your step definition files with <code>tsc</code> do you get the same result?</p>
<p>Also out of interest, why are you using the API? It seems your usage is quite standard so you could just use the CLI instead of having your own script.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-24 06:27:27
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2249#issuecomment-1482797451">Comment</a> on issue by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>I made a blog entry on my adventures in getting this to work here.</p>
<p><a href="https://mmorris-sandbox.net/demos/cucumber-next">https://mmorris-sandbox.net/demos/cucumber-next</a></p>
<p>Subsequent to that I added some changes to the Cucumber documentation in PR <a href="https://github.com/cucumber/cucumber-js/pull/2244">#2244</a><br />
which has been approved and should be merged soon. Read over the files and if you're still having trouble direct message me on this, I'll be happy to help.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-28 04:49:53
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2250#issuecomment-1448124294">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>That's a feature of the Playwright Test (not just the automation library) which you can't use with Cucumber - they're both test runners, you can't use them both at the same time.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-28 06:11:33
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2250#issuecomment-1448246245">Comment</a> on issue by <a href="https://github.com/arvinder06">arvinder06</a>
<p>> That's a feature of the Playwright Test (not just the automation library) which you can't use with Cucumber - they're both test runners, you can't use them both at the same time.</p>
<p>Thanks for your reply. Is there any other way to achieve this? I want to spread the tests among multiple pods.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-01 04:36:18
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2250#issuecomment-1450079142">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Okay, so I think what Playwright is doing there is sharding based on the worker/total input with a predictable algorithm. We could so something similar in Cucumber but for a first-party feature users would (I think) expect to be able to merge the reporting afterwards.</p>
<p>This is potentially something we could support being done by the community with a plugins mechanism, which we're <a href="https://github.com/cucumber/cucumber-js/discussions/2091">working on at the moment</a>.</p>
<p>In the meantime you could do this crudely yourself by e.g splitting your features into a few directories and using the CLI arguments to limit what's run on each worker.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-02-28 11:40:35
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2224#issuecomment-1448755847">Comment</a> on pull request by <a href="https://github.com/apps/renovate">renovate[bot]</a>
<p><strong>Edited/Blocked Notification</strong></p>
<p>Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.</p>
<p>You can manually request rebase by checking the rebase/retry box above.</p>
<p>⚠️ <strong>Warning</strong>: custom changes will be lost.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-01 03:36:03
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2251#issuecomment-1449962099">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/57415332">Coverage Status</a></p>
<p>Coverage: 98.561%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/e19a347bfeaf61c7c47f76d4283e85ebb36abc3b">e19a347</a> on GeekyDeaks:main</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/f623c7e4cfcd39efde55e4aea755ade3659066bf">f623c7e</a> on cucumber:main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-01 04:26:53
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2251#issuecomment-1450067877">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>No problem <a href="https://github.com/GeekyDeaks">@GeekyDeaks</a>. We can still include you with your GitHub profile URL instead of email address if that would be okay? (I have started doing this for all new contributors, for exactly this kind of reason.)</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-01 04:37:49
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2251#issuecomment-1450081122">Comment</a> on pull request by <a href="https://github.com/GeekyDeaks">GeekyDeaks</a>
<p>Yeah, that works for me. It's just the e-mail address that is the problem. Thanks for being so understanding on this</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-01 06:26:30
*Thread Reply:*
Review approved by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/GeekyDeaks">GeekyDeaks's</a> pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-02 12:37:56
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2252#issuecomment-1452511825">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>What version of Node.js are you using?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-02 12:39:42
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2252#issuecomment-1452513556">Comment</a> on issue by <a href="https://github.com/halvardssm">halvardssm</a>
<p>Node v16.18.1</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-07 16:57:00
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2252#issuecomment-1459100607">Comment</a> on issue by <a href="https://github.com/Izhaki">Izhaki</a>
<p>The stack trace doesn't even hit <code>cucumber</code>: You use <code>ts-node/esm</code> as the node loader, and soon as it gets to <code>yarn</code> it complains.</p>
<p>Your reproduction works if you change the test script to:</p>
<pre><code> "test": "NODE_OPTIONS=\"--loader ts-node/esm\" node_modules/.bin/cucumber-js --config test/cucumber.config.mjs"
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-07 17:26:01
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2252#issuecomment-1459124392">Comment</a> on issue by <a href="https://github.com/Izhaki">Izhaki</a>
<p><a href="https://github.com/halvardssm">@halvardssm</a> <a href="https://github.com/halvardssm/cucumber-js/pull/1/files">your branch</a> could actually be of <em>huge</em> value.</p>
<p>Questions:</p>
<p>• Does my proposed change work (bypassing yarn)?
• Did your branch helped?</p>
<p>Basically, I suspect cucumber toggles back to <code>cjs</code> which then breaks pure <code>esm</code> imports (that's where your branch can help), but your branch and my solution seem to be unrelated.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-07 19:42:14
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2252#issuecomment-1459346737">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Yeah, just removing <code>yarn</code> from that npm script value worked for me, although curiously it worked with that still in too although I could see the extra process being created. I think this may have been more to do with Yarn's interplay with ESM loaders, and some recent changes in Node.js may have fixed it for 16.19+ and 19+.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-08 02:51:56
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2252#issuecomment-1459978571">Comment</a> on issue by <a href="https://github.com/halvardssm">halvardssm</a>
<p><a href="https://github.com/Izhaki">@Izhaki</a> Answers:</p>
<p>> Does my proposed change work (bypassing yarn)?</p>
<p>The proposed change did actually work! Thanks for that! I would also recommend adding this to the docs, but with the node executable to the command:</p>
<pre><code>node --loader ts-node/esm node_modules/.bin/cucumber-js --config test/cucumber.config.mjs
</code></pre>
<p>> Did your branch helped?</p>
<p>I didn't fully finish the branch as all the cjs code would need to be refactored away, but I would suspect this to solve it as I did something similar for an internal package at work. I would try my branch, and expand upon it by making it fully TS (no rouge cjs files to be manually copied), and then compile it to the two formats for publishing (CJS and ESM).</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-09 07:29:59
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2252#issuecomment-1462255077">Comment</a> on issue by <a href="https://github.com/halvardssm">halvardssm</a>
<p><a href="https://github.com/Izhaki">@Izhaki</a> Small update: It does not work once you import anything in the step files (see <a href="https://codesandbox.io/p/github/halvardssm/cucumber-test/main">updated codesandbox</a>)</p>
<pre><code>(node:10466) ExperimentalWarning: Custom ESM Loaders is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Error: Cannot find module '/project/home/halvardssm/workspace/test/veriables' imported from /project/home/halvardssm/workspace/test/steps/hello.ts
at finalizeResolution (/project/home/halvardssm/workspace/node_modules/ts-node/dist-raw/node-internal-modules-esm-resolve.js:366:11)
at moduleResolve (/project/home/halvardssm/workspace/node_modules/ts-node/dist-raw/node-internal-modules-esm-resolve.js:801:10)
at Object.defaultResolve (/project/home/halvardssm/workspace/node_modules/ts-node/dist-raw/node-internal-modules-esm-resolve.js:912:11)
at /project/home/halvardssm/workspace/node_modules/ts-node/src/esm.ts:218:35
at entrypointFallback (/project/home/halvardssm/workspace/node_modules/ts-node/src/esm.ts:168:34)
at /project/home/halvardssm/workspace/node_modules/ts-node/src/esm.ts:217:14
at addShortCircuitFlag (/project/home/halvardssm/workspace/node_modules/ts-node/src/esm.ts:409:21)
at resolve (/project/home/halvardssm/workspace/node_modules/ts-node/src/esm.ts:197:12)
at nextResolve (node:internal/modules/esm/loader:165:28)
at ESMLoader.resolve (node:internal/modules/esm/loader:844:30)
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-09 08:30:24
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2252#issuecomment-1462367403">Comment</a> on issue by <a href="https://github.com/Izhaki">Izhaki</a>
<p><a href="https://github.com/halvardssm">@halvardssm</a> That is because we are in Node esm loading land at that point. So you'll need to add the file extension, but oddly, it should be <code>js</code> and not <code>ts</code>:</p>
<pre><code>import { TEST_VAR } from "../veriables.js";
</code></pre>
<p>The reason it is <code>js</code> and not <code>ts</code> is explained in the <a href="https://www.typescriptlang.org/docs/handbook/esm-node.html">official typescript docs</a>:</p>
<p>> This code works in CommonJS modules, but will fail in ES modules because relative import paths need to use extensions. As a result, it will have to be rewritten to use the extension of the output of foo.ts - so bar.ts will instead have to import from ./foo.js.</p>
<hr />
<p>Mind, if used alongside Vite, NextJS, or Webpack, you may end up with the <a href="https://github.com/vercel/next.js/issues/46806">same issue</a> I did - you can make it work either for tests OR with a bundler, but not both (without effort).</p>
<p>At least locally, I have everything working, but HAD to use <code>fix-esm</code> for esm-only <code>node_modules</code> dependencies. I also use <code>babel</code> rather than <code>ts-node</code> - but as far as my 10 hours went, it doesn't really matter, both behave the same.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-07 19:40:08
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2253#issuecomment-1459342972">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Thanks for raising <a href="https://github.com/aaronpliu">@aaronpliu</a>.</p>
<p>This was discussed a bit in <a href="https://github.com/cucumber/cucumber-js/issues/1712">#1712</a> but fizzled out because the use case was solved another way.</p>
<p>I think there are three ways we could tackle this:</p>
<ol><li>Suport negation in the arguments</li><li>Add another option like <code>--default-paths</code></li><li>Change the behaviour of the feature paths arg so CLI-provided values will override rather than merge</li>
</ol>
<p>The more I think about it, the more I think 3 makes the most sense.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-07 17:32:29
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2254#issuecomment-1459130153">Comment</a> on issue by <a href="https://github.com/Izhaki">Izhaki</a>
<p>Sorry, but it isn't clear what is being proposed here.</p>
<p>Where should <code>gitpod.yml</code> be added? Which tests will be running?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-07 20:03:49
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2254#issuecomment-1459386630">Comment</a> on issue by <a href="https://github.com/Ananya2001-an">Ananya2001-an</a>
<p>It will be added in the root. Something like this:</p>
<pre><code>
tasks:
- init: npm install
command: |
npm run test
</code></pre>
<p>According to contribution guide users have to do both these things before they can start hacking. So it’s better to create this file for gitpod users so that they don’t forget to run the tests and check if everything is working fine.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-09 12:29:07
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2254#issuecomment-1462734743">Comment</a> on issue by <a href="https://github.com/Izhaki">Izhaki</a>
<p>Just let me sure I got this right: The proposal is to add <code>gitpod.yml</code> to this repository, so people who prefer to use GitPod instead of cloning and using their machines have slightly better integration?</p>
<p>A few questions:</p>
<ol><li>How should we deal with the blow-up number of similar platforms (GitHub's Codespaces, Codesandbox, are barely a start)? If we are to add support to each we are going to end up with a lot of 3rd party related files in this repo.</li><li>GitPod does not require <code>gitpod.yml</code> - users can just run the <code>install</code> and <code>test</code> scripts manually. Correct?</li><li>In what way the developer experience be downgraded if we do not add this file? Two more clicks in GitPod?</li>
</ol>
<p>The main concern here is that there is no end for these sort of add-ons and more often than not such files add noise (and could involve maintainability); so it pays to stick to things that are essential or indisputably popular.</p>
<p>I would suggest to close this for now, but if upvoted by, say, more than 50 users we shall add it.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-09 20:36:50
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2254#issuecomment-1463243117">Comment</a> on issue by <a href="https://github.com/Ananya2001-an">Ananya2001-an</a>
<p>I understand. I will close it.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-07 19:43:18
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2255#issuecomment-1459348622">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Could you say a little more about your setup? What's the content of your rerun file look like?</p>
<p>Also, I noticed this is quite an old version of cucumber-js. Could you try again with the latest (9.0.0)?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-29 18:58:31
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2255#issuecomment-1489575528">Comment</a> on issue by <a href="https://github.com/apps/github-actions">github-actions[bot]</a>
<p>This issue is stale because it has been open for 3 weeks with no activity. Remove the stale label or comment or this will be closed in another 5 days.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-04 18:49:12
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2255#issuecomment-1496812174">Comment</a> on issue by <a href="https://github.com/apps/github-actions">github-actions[bot]</a>
<p>This issue was closed because it has been stalled for 5 days with no activity.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-07 16:37:10
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2256#issuecomment-1459085733">Comment</a> on issue by <a href="https://github.com/Izhaki">Izhaki</a>
<p>Cucumber is completely decoupled from any browser driver.</p>
<p>You can set timeouts for each Cucumber step definition, to match the settings in Playwright.</p>
<p>To learn more on how configure Playwright timeouts: <a href="https://stackoverflow.com/a/69105810/1179377">https://stackoverflow.com/a/69105810/1179377</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-07 17:17:02
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2105#issuecomment-1459115960">Comment</a> on issue by <a href="https://github.com/Izhaki">Izhaki</a>
<p>The error message is not a cucumber one. For more details and fix see: <a href="https://github.com/cucumber/cucumber-js/issues/2248#issuecomment-1459112907">#2248 (comment)</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-07 19:47:16
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2105#issuecomment-1459355659">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p><a href="https://github.com/Izhaki">@Izhaki</a> I'm aware of that, but it is triggered by Cucumber trying to load code and will frequently be due to misconfguration, so if we can surface that in a more useful way I think that's worthwhile.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-20 14:57:46
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2105#issuecomment-1476988710">Comment</a> on issue by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>This issue now has a pull request so let's continue discussion in the thread of that PR.</p>
<p><a href="https://github.com/cucumber/cucumber-js/pull/2264">#2264</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-09 10:31:52
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2229#issuecomment-1462571753">Comment</a> on pull request by <a href="https://github.com/Rubea1435">Rubea1435</a>
<p>Can you please explain what's changed in this pull request? I use Cucumber.js since 8.0.0 version and there always have been error messages in step results with error trace.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-09 12:06:17
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2229#issuecomment-1462698964">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p><a href="https://github.com/Rubea1435">@Rubea1435</a> you're right in that the information was there before. It's just now included in a more structured format that makes it more useful to certain reporting tools.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-13 18:53:03
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2226#issuecomment-1467223315">Comment</a> on issue by <a href="https://github.com/apps/github-actions">github-actions[bot]</a>
<p>This issue is stale because it has been open for 3 weeks with no activity. Remove the stale label or comment or this will be closed in another 5 days.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-15 03:11:36
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2226#issuecomment-1469721672">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>I've done a minimal reproducible example here:<br />
<a href="https://github.com/davidjgoss/cucumber-js-repro-2226">https://github.com/davidjgoss/cucumber-js-repro-2226</a></p>
<p>Declaring the paths in both the config file and on the CLI is causing them to be loaded twice, I think. We should be deduplicating the list of feature paths to load from before we pass it to the Gherkin library - this should be a straightforward fix.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-15 14:19:17
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2226#issuecomment-1470860214">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Thanks all for your patience with this one. Fixed in <a href="https://github.com/cucumber/cucumber-js/releases/tag/v9.0.1">https://github.com/cucumber/cucumber-js/releases/tag/v9.0.1</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-15 11:39:23
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2258#issuecomment-1470572984">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/57899243">Coverage Status</a></p>
<p>Coverage: 98.561%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/2622e143739f6d81015fede02cd0d2c517366b53">2622e14</a> on fix/2226</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/3811f811af61d6e7ed29ec2f31b1d2eabefc0a09">3811f81</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-16 05:50:00
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2259#issuecomment-1471897213">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/57928419">Coverage Status</a></p>
<p>Coverage: 98.561%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/07a6b1a4664fff4b5091de784fdaf236d80a1671">07a6b1a</a> on fix/dead-links</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/517338b99041c4633bc5cd98424dad3f71df013a">517338b</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-20 07:12:45
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2260#issuecomment-1476310319">Comment</a> on issue by <a href="https://github.com/badeball">badeball</a>
<p>For reference, <a href="https://github.com/cucumber/json-formatter">cucumber-json-formatter</a> will take attachments with <code>IDENTITY</code> encoding and base64-encode them before outputting a JSON report, thus generating a different one, where both embeddings are identical.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-20 07:15:08
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2260#issuecomment-1476314525">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>> For reference, <a href="https://github.com/cucumber/json-formatter">cucumber-json-formatter</a> will take attachments with IDENTITY encoding and base64-encode them before outputting a JSON report, thus generating a different one, where both embeddings are identical.</p>
<p>Okay, that seems like the canonical behaviour we should follow then.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-20 07:16:34
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2260#issuecomment-1476317019">Comment</a> on issue by <a href="https://github.com/badeball">badeball</a>
<p>Excellent, I'll attempt to create a PR 👍</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-20 07:27:03
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2260#issuecomment-1476334472">Comment</a> on issue by <a href="https://github.com/badeball">badeball</a>
<p>This would however mean that string attachments, as they were attached pre <a href="https://github.com/cucumber/cucumber-js/pull/1552">#1552</a>, would suddenly appear as base64-encoded data in JSON reports. Thus making this seem like a breaking change. Is that relevant in any way?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-20 12:46:42
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2260#issuecomment-1476836810">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Yep, I think it's a breaking change. We have the end of life for Node.js 14 coming up at the end of April so we could do a major release then with both in.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-20 08:43:55
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2261#discussion_r1142329606">Comment</a> on pull request by <a href="https://github.com/badeball">badeball</a>
<p>Is browser compatibility a requirement for this code? (<code>Buffer</code> is node)</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-20 08:44:49
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2261#issuecomment-1476479067">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/58034068">Coverage Status</a></p>
<p>Coverage: 98.561%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/94d5d7c895636491d204ff5cb87d0257ae486cd4">94d5d7c</a> on base64-encode-literals</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/627030d4d657b7efc19b1343d3d77d77c774139e">627030d</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-20 12:47:16
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2261#discussion_r1142606546">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>No, we're Node.js only at the moment so <code>Buffer</code> is fine.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-20 12:38:15
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2262#issuecomment-1476827968">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>There’s an implicit contract around the loading of support files in a predictable order which affects the order of hooks, so this would arguably be a breaking change.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-20 12:45:31
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2262#issuecomment-1476835504">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>(Not saying we shouldn't do it - it just probably needs to be a major release.)</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-20 14:51:34
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2262#issuecomment-1476982852">Comment</a> on issue by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>A cli flag perhaps?</p>
<p>--processESModulesInParallel</p>
<p>Default is false for the current, and the next major will switch it to default to true.</p>
<p>Anyway, there is now a pull request for this here: <a href="https://github.com/cucumber/cucumber-js/pull/2263">#2263</a></p>
<p>Let's continue the conversation there - I'll close this.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-20 12:51:59
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2263#issuecomment-1476842484">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/58045647">Coverage Status</a></p>
<p>Coverage: 98.561% (+0.0006%) from 98.561% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/5a9d473b50ded1fcbdc4c8e019fab7cb2ba7bc2b">5a9d473</a> on michael-lloyd-morris:issue-2262-es-parallel</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/627030d4d657b7efc19b1343d3d77d77c774139e">627030d</a> on cucumber:main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-20 12:55:09
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2263#issuecomment-1476845772">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>There is a behavior change in that the step files resolve simultaneously, but I can't imagine it mattering because Cucumber never gave the end users a way to control the order their step files are resolved in. This might be a concern so I sharded this optimization off to it's own PR for review.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-20 14:55:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2263#issuecomment-1476986087">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p><a href="https://github.com/davidjgoss">@davidjgoss</a> raised the important point that there may be code out there relying on this sequential load behavior. I'm not so sure this is the case, but that is the safest approach to this optimization.</p>
<p>That would mean delaying this to the next major release and/or using a cli or config flag to allow opt in.</p>
<p>I'm inclined to follow David's advice and just defer to the next major, especially since require imports are going to remain sequential as that is the nature of the beast. Also, the optimization isn't worth the headache except perhaps for the very largest of test libraries.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-20 15:08:31
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2263#issuecomment-1477002733">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>To be clear I do think this is the right thing to do. With <code>require</code> being synchronous there was never a way to load in parallel but it's one of the big pluses of ESM so we should lean into it. The potential non-deterministic order of <code>Before</code> etc hooks running could be a surprise to some users so I think we should do it in a major to be cautious. Our advice to users wanting to ensure consistent order of hooks running should be to have them in one file.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-20 16:54:58
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2263#issuecomment-1477099131">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>Agreed, so flag for version 10 and I'll come back to this when work on that major starts to catch up anything that fell behind? How do I do that or do you want to do it?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-20 14:03:26
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2264#issuecomment-1476931048">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/58048102">Coverage Status</a></p>
<p>Coverage: 98.363% (-0.2%) from 98.561% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/90437139c0a87ce502c3ee4f02314c1c45df2426">9043713</a> on michael-lloyd-morris:issue-2105-more-detailed-error</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/627030d4d657b7efc19b1343d3d77d77c774139e">627030d</a> on cucumber:main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-20 15:14:57
*Thread Reply:*
Reviewed and changes requested by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris's</a> pull request
<p>One thing we need to account for here is that, unlike the other way around, it's perfectly valid to <code>import()</code> a CommonJS module.</p>
<p>The example in the feature file yields an error from Node.js because the file is evaluated as an ES module (due to its <code>.mjs</code> suffix) but contains <code>require()</code> calls so is effectively invalid JavaScript from the engine's perspective. If that file was <code>.cjs</code> or even <code>.js</code> (assuming no `type="module" on the package) it would work fine with the import option.</p>
<p>I <em>think</em> the issue can also show up where you use an ESM loader but it outputs code with <code>require()</code> in - again because the file purports to be a module but contains <code>require()</code> calls. This could be easily done if you misconfigure <code>ts-node</code> for example.</p>
<p>It's probably worth catching that error still in the <code>importer</code>, but I think the messaging will need to be more along the lines of "it looks like some of your support code is using require syntax where only imports are expected" and a maybe a link relevant Node.js docs.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-20 15:33:16
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2264#issuecomment-1477031709">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>I did not know that it's valid to import a common JS module. That does explain why the error messages are so different. Of the two native nodejs errors that one is the more easy to understand, so I'll remove the catch on the importer for now to satisfy this requirement along with the scenario testing for that code change. Shall I keep the remaining feature alone in it's own file or move it into the esm.feature file? (on second thought, just going ahead and doing that as it makes the most sense, but I can undo it).</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-20 17:38:24
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2264#issuecomment-1477131645">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>Requested Changes applied.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-23 12:06:02
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2264#issuecomment-1481747408">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>Is there something else I need to do or where the changes I did insufficient?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-23 12:47:21
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2264#discussion_r1146743944">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Can we make the equivalent change for the parallel worker <a href="https://github.com/cucumber/cucumber-js/blob/main/src/runtime/parallel/worker.ts#L77-L78">https://github.com/cucumber/cucumber-js/blob/main/src/runtime/parallel/worker.ts#L77-L78</a> as well?</p>
<p>(At some point it'd be good to extract some code that's common across these two places, but certainly not essential for this PR.)</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-23 12:47:21
*Thread Reply:*
Review comment by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris's</a> pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-23 12:47:21
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2264#discussion_r1146748017">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>It might be worth adding the original error via <code>cause</code> option so the user gets the full stack e.g. <code>new Error('Cucumber...', { cause: error })</code> as in some cases it could be down to a file that is imported from within the file at <code>path</code> rather than that file itself, if that makes sense.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-23 12:49:10
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2264#issuecomment-1481801287">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Just a couple of things to address but this is looking like a good change. Also see a conflict on the changelog file.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-23 16:53:56
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2264#issuecomment-1482060344">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>I'll get to these items in the morning and will try to be done by end of day, though I've got to take a chunk of the day to take my Dad to the hospital.</p>
<p>(Until I have a job, volunteer work here is my job - if only to keep my skills sharp and my sanity intact - so I'm treating it as such).</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-24 06:13:50
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2264#discussion_r1147563705">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>This would be nice, but when I went to do it Typescript balked. I traced down the problem to this:</p>
<p><a href="https://github.com/microsoft/TypeScript/issues/49535">microsoft/TypeScript#49535</a></p>
<p>This feels like a change that should be reserved for a major version change but I'll let you decide. If we add this I'll have to update the tsconfig as outlined in the link above.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-24 06:15:07
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2264#discussion_r1147565250">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>Done. Moved the require logic to its own file in the same directory as the importer and named it try_require. I see an opportunity for further refactoring, but I agree that should probably be another issue ticket.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-24 06:16:38
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2264#issuecomment-1482782160">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>Ok, all requested changes applied, though see the note about Typescript and using the cause option on Error throws.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-26 09:32:18
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2264#discussion_r1148591755">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Oh good spot, hadn't realised that was so new. We'll wait until after dropping Node.js 14 support to use that. I'd still like to include the <code>message</code> from the error that we catch as part of our message though, so they can see that path if it is nested (the stack doesn't matter so much).</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-26 19:45:12
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2264#discussion_r1148732703">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>Ok. Done.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-28 01:27:41
*Thread Reply:*
Review approved by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris's</a> pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-20 16:24:39
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/1393#issuecomment-1477080947">Comment</a> on issue by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>What about allowing BeforeAll to preprocess the world parameters? If it returns an object, that object will be the new world parameters - otherwise the world parameters remain unchanged.</p>
<p>Whatever is decided on, I'm interested in coding it up.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-22 04:16:41
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/1393#issuecomment-1479375989">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>> What about allowing BeforeAll to preprocess the world parameters? If it returns an object, that object will be the new world parameters - otherwise the world parameters remain unchanged.</p>
<p>Interesting idea. It would get away from having to have a new "thing" called test run context if we are just accessing and updating the world parameters. And we did say it has to be serialisable anyway. <a href="https://github.com/BlueMona">@BlueMona</a> and <a href="https://github.com/mattwynne">@mattwynne</a> you've been working on that PR, what do you think on this? Probably something I'm not thinking of.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-21 07:20:01
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2159#issuecomment-1477925514">Comment</a> on issue by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>Bumping this to note I'm working on this today and hope to have it ready by end of week.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-23 13:00:22
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2265#issuecomment-1481815169">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>> Adding options to the json formatter and to the junit in a single formatOptions: {} entry is cumbersome</p>
<p>I tend to agree, and I like your suggestion, though that would potentially end up being a significant change so let's make another issue for that.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-23 13:01:17
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2265#issuecomment-1481816565">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>To enable this with the current options structure we'd do something like:</p>
<pre><code>{
"formatOptions": {
"junit": {
"suiteName": "my test suite"
}
}
}
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-25 02:52:19
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2265#issuecomment-1483781531">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>The line in question is here <a href="https://github.com/cucumber/cucumber-js/blob/main/src/formatter/junit_formatter.ts#L245">https://github.com/cucumber/cucumber-js/blob/main/src/formatter/junit_formatter.ts#L245</a>. The <code>options</code> being passed into the constructor has a <code>parsedArgvOptions</code> prop which should be the format options from the user.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-22 08:02:22
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2266#issuecomment-1479732361">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/58122326">Coverage Status</a></p>
<p>Coverage: 98.565% (+0.004%) from 98.561% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/5af72587c91e1ff21f4bd3d28f7a4c2f58a2d250">5af7258</a> on michael-lloyd-morris:issue2159</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/627030d4d657b7efc19b1343d3d77d77c774139e">627030d</a> on cucumber:main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-22 09:11:46
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2266#discussion_r1145077883">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p><code>fs.exists</code> is deprecated, and <code>mkdirp</code> is going to be <a href="https://github.com/isaacs/node-mkdirp#implementation">doing this check anyway</a>, so I think it would make more sense to just call <code>mkdirp</code> unconditionally.</p>
<p>However I do think we should wrap in a try/catch to be safe, and if something goes wrong do e.g. <code>logger.warn('Failed to ensure directory for formatter target exists')</code> and continue.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-22 09:11:46
*Thread Reply:*
Review comment by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris's</a> pull request
<p>Looks good, couple of requests.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-22 09:11:46
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2266#discussion_r1145071936">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Can we say "formatters" for consistency</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-22 09:56:29
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2266#discussion_r1145143258">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>Requested changes applied.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-22 09:59:12
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2266#discussion_r1145146545">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>I have a spell checker running on VsCode and changed this because I thought I would be editing this file more broadly. This change can be dropped. I don't know if normalised is correct British spelling or not but my checker is on American English so it asked to correct it, and as this is a local var restricted to this function I saw no harm.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-22 10:17:03
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2266#discussion_r1145168371">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>Change applied.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-22 11:35:21
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2266#discussion_r1145254137">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Yeah this is fine to be left in, I probably wrote that being a Brit, but if we standardise on anything it should be US.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-22 14:14:41
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2266#issuecomment-1480270173">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>I'd like to merge this but after reverting <a href="https://github.com/cucumber/cucumber-js/pull/2266/commits/26212c4c57841d65cf5359ce06e6e63538c8cdf7">the last commit</a>. It expands the scope of errors we'll tolerate to things like the formatter class failing to load, or an error in its constructor etc, which isn't really about the target dir/file any more.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-22 14:17:01
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2266#issuecomment-1480272650">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>Well, if I remove the try/catch block then we return to the prior behavior of Cucumber halting with an ENOT error if the file can't be created. Shall I do that?</p>
<p>Logging a warning doesn't really help us. If mkdirp doesn't make the directory the program will crash with ENOT when it tries to open the write stream. We could also catch and throw an error detailing that the file couldn't be created - this will be more in line with existing behavior. I also think it's the safest since running a test without a report detail is as bad as not running it at all, especially if the test takes a long while to run.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-22 14:21:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2266#issuecomment-1480276639">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Not removing the try/catch, but reducing its scope. Reverting <a href="https://github.com/cucumber/cucumber-js/commit/26212c4c57841d65cf5359ce06e6e63538c8cdf7">26212c4</a> would get it back down to just the attempt to ensure the directory i.e. the new behaviour - really as a guard in case that has unexpected effects on an otherwise working setup. That feels like the right step for this PR. I'm not sure if failing to create the stream for a formatter should be downgraded to a warning at this point.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-22 14:22:38
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2266#issuecomment-1480278160">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>I'll change to immediate die so you can see what that looks like. If that isn't good I'll do a full revert back to the point you were comfortable with.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-22 14:40:29
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2266#issuecomment-1480296559">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Thanks, I think going back to <a href="https://github.com/cucumber/cucumber-js/commit/cf5d171757bc05ec0b24360e6f092fa98dd70dfb">cf5d171</a> is the right thing for now</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-22 14:46:41
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2266#issuecomment-1480302290">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>Ok. Done (Well, I used CTRL-Z in Visual Studio code to rewind back to that point instead of git)</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-22 14:56:14
*Thread Reply:*
Review approved by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris's</a> pull request
<p>Thanks for doing this!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-22 15:16:14
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2267#discussion_r1145463486">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>Apparently mz/fs doesn't have the new version of fs.rm in its implementation - that or it's incompatible with the old one the deprecation warns about. In any event, to resolve the deprecation I had to resort to the older Promise.then pattern.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-22 15:17:14
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2267#issuecomment-1480330008">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/58138826">Coverage Status</a></p>
<p>Coverage: 98.561% (+0.0006%) from 98.561% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/3b94338f4e3fb5a22c1867e027204f2a4fea1524">3b94338</a> on michael-lloyd-morris:fixDeprecation</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/627030d4d657b7efc19b1343d3d77d77c774139e">627030d</a> on cucumber:main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-23 05:53:15
*Thread Reply:*
Review approved by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris's</a> pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-23 20:14:59
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2268#issuecomment-1482191992">Comment</a> on issue by <a href="https://github.com/arvinder06">arvinder06</a>
<p>Moreover, when I am using <code>throw new Error("failed");</code> in the core framework, it is throwing the error but not failing the cucumber test case.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-25 03:04:22
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2268#issuecomment-1483784019">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Cucumber will fail the scenario if an error bubbles up from a step, including assertion errors.</p>
<p>It's hard to know what might be going on from what you've described, but you seem to be mixing frameworks (Playwright Test and Cucumber, which are both test runners in their own right) which is usually a recipe for unexpected results.</p>
<p>In particular, it looks like you're using <code>expect</code> from <code>@playwright/test</code>, which from a quick look at their code would expect to be called in the context of a Playwright Test case.</p>
<p>If you can post a <a href="https://stackoverflow.com/help/minimal-reproducible-example">minimum reproducible example</a> here, the community might be able to give some pointers, but I'm pretty sure this isn't going to be a Cucumber issue.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-27 12:10:05
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2268#issuecomment-1485723575">Comment</a> on issue by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>I'm using Playwright with Cucumber here with the Chai assertion library:</p>
<p><a href="https://github.com/michael-lloyd-morris/portfolio">https://github.com/michael-lloyd-morris/portfolio</a></p>
<p>You do not have to use the Playwright test runner to use Playwright as the browser driver - and to be honest I'd advise against trying. As David pointed out Playwright's assertions are customized to it's runner. Using a general purpose assertion library like Chai should help.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-17 18:53:21
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2268#issuecomment-1512323314">Comment</a> on issue by <a href="https://github.com/apps/github-actions">github-actions[bot]</a>
<p>This issue is stale because it has been open for 3 weeks with no activity. Remove the stale label or comment or this will be closed in another 5 days.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-22 19:01:25
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2268#issuecomment-1518918793">Comment</a> on issue by <a href="https://github.com/apps/github-actions">github-actions[bot]</a>
<p>This issue was closed because it has been stalled for 5 days with no activity.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-24 04:11:22
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2244#issuecomment-1482634276">Comment</a> on pull request by <a href="https://github.com/Jeff-Tian">Jeff-Tian</a>
<p>Thanks, <a href="https://github.com/michael-lloyd-morris">@michael-lloyd-morris</a>! Great work, it'll benefit many others unfamiliar with nodejs and esm etc.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-24 04:12:00
*Thread Reply:*
Review approved by <a href="https://github.com/Jeff-Tian">Jeff-Tian</a> on <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris's</a> pull request
<p>Looks good to me! Very helpful messages indeed.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-28 10:59:19
*Thread Reply:*
Review comment by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris's</a> pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-28 10:59:19
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2244#discussion_r1150946792">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>This doesn’t seem right? require-module doesn’t affect import</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-28 10:59:19
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2244#discussion_r1150977992">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>The config file can still be JSON or YAML - I guess we want to say that if JavaScript then it should be the appropriate format.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-28 10:59:20
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2244#discussion_r1150979038">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>I think this can just be removed.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-28 10:59:20
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2244#discussion_r1150979749">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Missing a double quote on the key here</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-28 17:06:00
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2244#discussion_r1151269078">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>Ah. Sorry. Also spotted an uncapitalized T at the start of a sentence so I sent the whole thing through a spell/grammar checker to be sure. Should be good now.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-29 07:11:57
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2244#discussion_r1152009815">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>Lines removed.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-29 07:13:32
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2244#discussion_r1152013697">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>It needs to be reworded heavily and I've done so. If you read that header as applying to all ESM projects others will too. That sub header is level 4 and it was meant to cover "with TS-Node to load ES modules"</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-29 07:16:27
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2244#issuecomment-1488712267">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>These examples are fairly complex and they also raise a lot of Google and Bing search results. Perhaps linking to the relevant cucumber-js-examples would be in order? If so I need to add an example for the somewhat gnarly ts-node with esm modules scenario.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-02 12:18:03
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2244#issuecomment-1493419226">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p><a href="https://github.com/davidjgoss">@davidjgoss</a> Please let me know what else do I need to do for this.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-04 09:34:57
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2244#discussion_r1157503530">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>I don't think this line is an improvement. <code>step-definitions</code> isn't any of our default paths.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-04 09:34:57
*Thread Reply:*
Review comment by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris's</a> pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-04 09:34:58
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2244#discussion_r1157504679">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>We should make clear that both <code>requireModule</code> and <code>require</code> are not suitable for ESM and that the <code>--loader</code> flag and <code>import</code> option are their respective equivalents.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-04 09:43:37
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2244#discussion_r1157513706">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>I don't think we should be prescriptive of using this particular library/approach. By all means mention it as an option but examples should be as vanilla as possible really.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-18 06:12:13
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2244#issuecomment-1513114903">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>Sorry about the lag. Requested updates now pushed.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-18 06:16:30
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2244#discussion_r1170025690">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>Done.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-18 06:16:40
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2244#discussion_r1170025953">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>Done.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-18 06:17:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2244#discussion_r1170026547">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>Reverted. I wasn't aware of that btw - many of the examples follow this pattern.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-21 03:56:28
*Thread Reply:*
Review approved by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris's</a> pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-04 09:37:01
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2269#issuecomment-1496280057">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>I would see this being more of an add-on than a core feature. <a href="https://github.com/mattwynne">@mattwynne</a> was looking at something similar a while ago but with an Electron-based UI rather than an interactive terminal.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-26 00:07:17
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2270#issuecomment-1484014701">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/58235046">Coverage Status</a></p>
<p>Coverage: 98.525%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/4232d14f03f866108d4916aedfea7480c5fe6370">4232d14</a> on Terence625:add-datatable-generic-type</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/f59ea9f239d98d5b9fdc1abb71bb8378767c181c">f59ea9f</a> on cucumber:main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-26 09:36:42
*Thread Reply:*
Review comment by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/Terence625">Terence625's</a> pull request
<p>Thanks for doing this! Would you mind adding an entry to the unreleased section of <code>CHANGELOG.md</code>? Although this is a small change, it will improve types for end users so we should include it.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-26 16:07:24
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2270#issuecomment-1484254164">Comment</a> on pull request by <a href="https://github.com/unional">unional</a>
<p>Should it styled as <code>Array&lt;Record&lt;string, string&gt;&gt;</code> instead of <code>Record&lt;string, string&gt;[]</code>?<br />
For complex type, IMO <code>Array&lt;T&gt;</code> is more readable than <code>T[]</code>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-26 16:14:54
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2270#issuecomment-1484256402">Comment</a> on pull request by <a href="https://github.com/Terence625">Terence625</a>
<p><a href="https://github.com/davidjgoss">@davidjgoss</a> Thanks for reviewing it, I intended to add generic type for hashes() in DataTable like following:</p>
<pre><code>export default class DataTable&lt;T extends Record&lt;string,string&gt; = {}&gt; {
hashes(): T[] {
const copy = this.raw()
const keys = copy[0]
const valuesArray = copy.slice(1)
return valuesArray.map((values) =&gt; {
const rowObject = {} as T
keys.forEach((key, index) =&gt; (rowObject[key as keyof T] = values[index]))
return rowObject
})
}
}
</code></pre>
<p>But it throws typescript error: <code>'string' is assignable to the constraint of type 'T[keyof T]', but 'T[keyof T]' could be instantiated with a different subtype of constraint 'string'.(2322)</code>. It seems to be some tricky typescript issue and seems over-engineered.</p>
<p>I'll just do type assertion in my code which will do the same trick:</p>
<pre><code>//feature file
some step definition
inputValue | inputType
test1 | test2
test3 | test4
//step definition file
Then('some step definition', function(datatable: DataTable) {
const data = datatable.hashes() as {
inputValue: string,
inputType: string
}
)
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-26 16:21:00
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2270#issuecomment-1484264571">Comment</a> on pull request by <a href="https://github.com/Terence625">Terence625</a>
<p><a href="https://github.com/unional">@unional</a> I think they don't have any difference. I just see the original codebase is using [] for array type in other places, I just intended to keep them in the same style.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-28 00:57:40
*Thread Reply:*
Review approved by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/Terence625">Terence625's</a> pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-28 00:58:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2270#issuecomment-1486389439">Comment</a> on pull request by <a href="https://github.com/aslakhellesoy">aslakhellesoy</a>
<p>Hi <a href="https://github.com/Terence625">@Terence625</a>,</p>
<p>Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾</p>
<p>In return for this generous offer we hope you will:</p>
<p>• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our <a href="https://cucumber.io/conduct">code of conduct</a> in your interactions with other collaborators and users.
• 💬 Join the <a href="http://cucumber.io/support#slack">community Slack channel</a> to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!</p>
<p>On behalf of the Cucumber core team,<br />
Aslak Hellesøy<br />
Creator of Cucumber</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-28 00:59:10
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2270#issuecomment-1486390961">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p><a href="https://github.com/unional">@unional</a> I think the <code>array-simple</code> flavour of <a href="https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/array-type.md#array-simple">this ESLint rule</a> strikes a good balance, I'd approve a PR to turn that on.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-03-27 11:34:16
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/1443#issuecomment-1485669644">Comment</a> on issue by <a href="https://github.com/TsayDev">TsayDev</a>
<p>See the example here.<br />
<a href="https://github.com/TsayDev/Advanced-Cucumber">https://github.com/TsayDev/Advanced-Cucumber</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-14 14:14:34
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2273#issuecomment-1509279358">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Unless there's some configuration you haven't shared here, it looks like you don't have anything set up to transpile your TypeScript code to JavaScript that Node.js can interpret.</p>
<p>You probably want to do one of:</p>
<p>• Add <code>--require-module</code> option pointing at something like ts-node or babel, if you have TypeScript configured to emit CommonJS modules
• Switch the <code>--require</code> to <code>--import</code> and declare an ES module loader, if you have TypeScript configured to emit ES modules</p>
<p>There are some docs here offering a bit more detail: <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/transpiling.md">https://github.com/cucumber/cucumber-js/blob/main/docs/transpiling.md</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-17 01:26:12
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2273#issuecomment-1510919019">Comment</a> on issue by <a href="https://github.com/Sam-Levene">Sam-Levene</a>
<p>Thanks David.</p>
<p>Can you please confirm what you mean by "if I have TypeScript configured to emit CommonJS or ES modules".<br />
How do I check which modules my TypeScript is configured to emit? (I am using VS Code)</p>
<p><em>EDIT</em>: I tried to follow your link but it really wasn't very helpful. I tried installing ts-node and got the following error:</p>
<pre><code>TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".ts" for /Users/sam.levene/QA/playwright-automation/features/step_definitions/steps.ts
at new NodeError (internal/errors.js:322:7)
at Loader.defaultGetFormat [as _getFormat] (internal/modules/esm/get_format.js:71:15)
at Loader.getFormat (internal/modules/esm/loader.js:105:42)
at Loader.getModuleJob (internal/modules/esm/loader.js:243:31)
at async Loader.import (internal/modules/esm/loader.js:177:17)
at async importer (/Users/sam.levene/QA/playwright-automation/node_modules/@cucumber/cucumber/lib/importer.js:10:10)
at async getSupportCodeLibrary (/Users/sam.levene/QA/playwright-automation/node_modules/@cucumber/cucumber/src/api/support.ts:33:5)
at async runCucumber (/Users/sam.levene/QA/cbfe-playwright-automation/node_modules/@cucumber/cucumber/src/api/run_cucumber.ts:45:9)
at async Cli.run (/Users/sam.levene/QA/playwright-automation/node_modules/@cucumber/cucumber/src/cli/index.ts:78:25)
at async Object.run [as default] (/Users/sam.levene/QA/playwright-automation/node_modules/@cucumber/cucumber/src/cli/run.ts:38:14)
</code></pre>
<p>and my updated package.json:</p>
<pre><code>{
"name": "playwright-poc",
"version": "0.0.1",
"description": "A Proof of Concept for Playwright",
"scripts": {
"test": "npx cucumber-js --require-module ts-node/register --import features/step_definitions/steps.ts --exit"
},
"type": "module",
"keywords": [],
"author": "Sam Levene",
"license": "ISC",
"devDependencies": {
"@cucumber/cucumber": "^9.0.1",
"@playwright/test": "^1.31.2",
"ts-node": "^10.9.1"
}
}
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-17 06:26:51
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2273#issuecomment-1511348808">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>> How do I check which modules my TypeScript is configured to emit?</p>
<p>Normally you would have a <code>tsconfig.json</code> in the root of your project. In particular under the <code>compilerOptions</code> the combination of <code>target</code> and <code>module</code> would decide what is output. More from the TypeScript docs here <a href="https://www.typescriptlang.org/docs/handbook/2/modules.html">https://www.typescriptlang.org/docs/handbook/2/modules.html</a>. Without a config file, I think it would default to es5 and CommonJS modules, but I'm not sure.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-17 06:30:21
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2273#issuecomment-1511353740">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Consider looking at the example TypeScript project here <a href="https://github.com/cucumber/cucumber-js-examples/tree/main/examples/typescript-node">https://github.com/cucumber/cucumber-js-examples/tree/main/examples/typescript-node</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-17 07:32:42
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2273#issuecomment-1511482741">Comment</a> on issue by <a href="https://github.com/Sam-Levene">Sam-Levene</a>
<p><a href="https://github.com/davidjgoss">@davidjgoss</a> - Hi David - Thanks for that link. I followed your link and added a <code>cucumber.js</code> file with the following:</p>
<pre><code>module.exports = {
default: [
"--require-module ts-node/register",
"--require features/****/**.ts",
"--publish-quiet",
].join(" "),
};
</code></pre>
<p>and I see the following error:</p>
<pre><code>ReferenceError: module is not defined in ES module scope
This file is being treated as an ES module because it has a '.js' file extension and '/Users/sam.levene/QA/playwright-automation/package.json' contains "type": "module". To treat it as a CommonJS script, rename it to use the '.cjs' file extension.
at file:///Users/sam.levene/QA/playwright-automation/cucumber.js:1:1
at ModuleJob.run (internal/modules/esm/module_job.js:183:25)
at async Loader.import (internal/modules/esm/loader.js:178:24)
at async importer (/Users/sam.levene/QA/playwright-automation/node_modules/@cucumber/cucumber/lib/importer.js:10:10)
at async loadFile (/Users/sam.levene/QA/playwright-automation/node_modules/@cucumber/cucumber/lib/configuration/from_file.js:56:35)
at async fromFile (/Users/sam.levene/QA/playwright-automation/node_modules/@cucumber/cucumber/lib/configuration/from_file.js:19:25)
at async loadConfiguration (/Users/sam.levene/QA/playwright-automation/node_modules/@cucumber/cucumber/lib/api/load_configuration.js:29:11)
at async Cli.run (/Users/sam.levene/QA/playwright-automation/node_modules/@cucumber/cucumber/lib/cli/index.js:45:71)
at async Object.run [as default] (/Users/sam.levene/QA/playwright-automation/node_modules/@cucumber/cucumber/lib/cli/run.js:34:18)
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-18 01:09:00
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2273#issuecomment-1512646804">Comment</a> on issue by <a href="https://github.com/Sam-Levene">Sam-Levene</a>
<p><a href="https://github.com/davidjgoss">@davidjgoss</a> - Hi David,</p>
<p>I've had a look and it appears that, because I'm using an ES module, it doesn't like the module.exports config in cucumber.js and expects it to be in an ES module format as such:</p>
<pre><code>export const default = [
"--require-module ts-node/register",
"--require features/****/**.ts",
"--publish-quiet",
].join(" ");
</code></pre>
<p>the only issue is that default is a reserved word in Node.JS and it doesn't let me compile the config. Can I use a different name here and can Cucumber pick up on it if I do?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-18 02:51:00
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2273#issuecomment-1512780763">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>For the default profile you'd just need to do <code>export default</code> followed by the value. Also consider using JSON or YAML.</p>
<p><a href="https://github.com/cucumber/cucumber-js/blob/main/docs/configuration.md#files">https://github.com/cucumber/cucumber-js/blob/main/docs/configuration.md#files</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-18 03:06:31
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2273#issuecomment-1512804274">Comment</a> on issue by <a href="https://github.com/Sam-Levene">Sam-Levene</a>
<p>Hi <a href="https://github.com/davidjgoss">@davidjgoss</a> - when I try that, I get the same error as yesterday with an unknown file extension<code>.ts</code></p>
<pre><code>cucumber.yml
default:
require-module: ts-node/register
import: ["features/****/**.ts"]
</code></pre>
<p>or</p>
<pre><code>cucumber.js
export default [
"--require-module ts-node/register",
"--import features/****/**.ts",
"--publish-quiet",
].join(" ");
</code></pre>
<p>Error when running script:</p>
<pre><code>TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".ts" for /Users/sam.levene/QA/playwright-automation/features/step_definitions/steps.ts
at new NodeError (internal/errors.js:322:7)
at Loader.defaultGetFormat [as _getFormat] (internal/modules/esm/get_format.js:71:15)
at Loader.getFormat (internal/modules/esm/loader.js:105:42)
at Loader.getModuleJob (internal/modules/esm/loader.js:243:31)
at async Loader.import (internal/modules/esm/loader.js:177:17)
at async importer (/Users/sam.levene/QA/playwright-automation/node_modules/@cucumber/cucumber/lib/importer.js:10:10)
at async getSupportCodeLibrary (/Users/sam.levene/QA/playwright-automation/node_modules/@cucumber/cucumber/src/api/support.ts:33:5)
at async runCucumber (/Users/sam.levene/QA/playwright-automation/node_modules/@cucumber/cucumber/src/api/run_cucumber.ts:45:9)
at async Cli.run (/Users/sam.levene/QA/playwright-automation/node_modules/@cucumber/cucumber/src/cli/index.ts:78:25)
at async Object.run [as default] (/Users/sam.levene/QA/playwright-automation/node_modules/@cucumber/cucumber/src/cli/run.ts:38:14)
</code></pre>
<p>EDIT: Forgot to mention here's my tsconfig file:</p>
<pre><code>tsconfig.json
{
"allowSyntheticDefaultImports": true,
"resolveJsonModule": true,
"compilerOptions": {
"module": "ESNext",
"moduleResolution": "node"
}
}
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-18 04:00:05
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2273#issuecomment-1512877070">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>You can't combine <code>--require-module</code> with <code>--import</code>. Since your tsconfig is emitting ESM, you should remove the <code>--require-module</code> and instead use the ESM loader (which you have to set outside of the process e.g. <code>NODE_OPTIONS="--loader ts-node/esm" npx cucumber-js</code>)</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-18 05:44:25
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2273#issuecomment-1513055046">Comment</a> on issue by <a href="https://github.com/Sam-Levene">Sam-Levene</a>
<p>That seems to get me somewhere, now I'm stuck somewhere elsem, to do with esm-resolve and not cuke, so thanks <a href="https://github.com/davidjgoss">@davidjgoss</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-14 18:54:52
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2249#issuecomment-1509459911">Comment</a> on issue by <a href="https://github.com/apps/github-actions">github-actions[bot]</a>
<p>This issue is stale because it has been open for 3 weeks with no activity. Remove the stale label or comment or this will be closed in another 5 days.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-20 18:54:28
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2249#issuecomment-1517146339">Comment</a> on issue by <a href="https://github.com/apps/github-actions">github-actions[bot]</a>
<p>This issue was closed because it has been stalled for 5 days with no activity.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-18 06:25:35
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2274#issuecomment-1513153309">Comment</a> on issue by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>Hmm... I'll look into this.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-18 07:58:19
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2274#issuecomment-1513302794">Comment</a> on issue by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>Ok, I don't fully understand the way we are doing this check, but it looks a bit hackish. I found this library</p>
<p><a href="https://www.npmjs.com/package/resolve-package-path">https://www.npmjs.com/package/resolve-package-path</a></p>
<p>This might resolve both cases correctly, but do we want to add this package to fix this somewhat rare corner case?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-18 08:56:50
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2274#issuecomment-1513416406">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>To be clear this is only a warning, doesn't prevent you running. The detection is from <a href="https://www.npmjs.com/package/is-installed-globally">https://www.npmjs.com/package/is-installed-globally</a> and I don't think it's something we should implement/maintain in Cucumber. Since <a href="https://github.com/cucumber/cucumber-js/pull/2089">#2089</a> the handling for the issue that global (and other invalid) installations cause is much better, so arguably we could make this warning more subtle (one line, softer language) or even just remove it.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-19 02:01:33
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2274#issuecomment-1514381788">Comment</a> on issue by <a href="https://github.com/arbughiu">arbughiu</a>
<p><a href="https://github.com/davidjgoss">@davidjgoss</a> yes I agree its only a warning, and its not affecting behaviour, making this a minor bug. It's more of an annoyance right now, as the QAs running test scripts on Windows in my current company are asking me what they've done wrong to cause that warning message to occur. (the warning does not occur on Mac). Our setup is a bit more complex, but I've simplified it greatly in the example repo I provided.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-19 07:48:08
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2274#issuecomment-1514873814">Comment</a> on issue by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>If we remove it and there is a crash because cucumber was installed as a global, will the error message be clear? Could it be altered to make it clear in such circumstances? If so I would suggest doing that - remove this warning then alter the error message that arises when trying to import or require a step file when cucumber is installed globally.</p>
<p>That said, I have a feeling this might be very difficult to write a test case for.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-19 07:55:52
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2274#issuecomment-1514885892">Comment</a> on issue by <a href="https://github.com/arbughiu">arbughiu</a>
<p>FYI I am not proposing we remove anything (as it would still be useful to be notified of a global installation) but rather fix the original intended behaviour.</p>
<p>In my <a href="https://github.com/arbughiu/cucumber-windows-npm-prefix">sample repo</a> we can see the following:</p>
<p>On Mac:<br />
<code>npm run test</code> - runs fine ✅<br />
<code>npm --prefix . run test</code> - runs fine ✅</p>
<p>On Windows:<br />
<code>npm run test</code> - runs fine ✅<br />
<code>npm --prefix . run test</code> - shows the error message above ❌</p>
<p>But <code>npm --prefix . run test</code> should produce the same result in both Windows and Mac.</p>
<p>The issue appears to be inside the <code>is-installed-globally</code> dependency</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-19 08:55:04
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2274#issuecomment-1514977391">Comment</a> on issue by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>The issue is Windows.</p>
<p>And I'm saying this as a Windows user.</p>
<p>Kidding aside, the most direct fix would need to be in that <code>is-installed-globally</code> package. All we can do at the Cucumber level is find another approach.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-05-07 01:45:05
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2274#issuecomment-1537360559">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Took the middle ground here - the warning remains but the language is softened and it's only shown in debug mode. The issues that stem from using a global install are much less cryptic than they used to be, so I think this is fine now.</p>
<p><a href="https://github.com/cucumber/cucumber-js/pull/2285">#2285</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-05-07 01:46:42
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2274#issuecomment-1537360845">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>(I think it would be worth raising an issue on <code>is-installed-globally</code> all the same though.)</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-05-07 02:46:19
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2274#issuecomment-1537372504">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Released in <a href="https://github.com/cucumber/cucumber-js/releases/tag/v9.1.2">https://github.com/cucumber/cucumber-js/releases/tag/v9.1.2</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-19 06:19:01
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2275#issuecomment-1514722680">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/59082423">Coverage Status</a></p>
<p>Coverage: 98.489%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/0db6410bc97d98f8ec5d1eb033e5130b1087af73">0db6410</a> on michael-lloyd-morris:fixSecurity</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/764b7b6be4ccaa235954acb6424fb9725df6a643">764b7b6</a> on cucumber:main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-19 09:54:27
*Thread Reply:*
Review approved by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris's</a> pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-19 13:33:08
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2275#issuecomment-1515342770">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>chai-xml will be applying this change themselves on next patch version, so shall we wait on that or push this out? Since cucumber is typically a dev-dependency it isn't likely urgent</p>
<p><a href="https://github.com/krampstudio/chai-xml/issues/18">krampstudio/chai-xml#18</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-20 21:47:02
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2275#issuecomment-1517252607">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Looks to have been released now <a href="https://github.com/krampstudio/chai-xml/releases/tag/0.4.1">https://github.com/krampstudio/chai-xml/releases/tag/0.4.1</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-21 06:08:02
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2275#issuecomment-1517812473">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>I have removed the override then uninstalled and reinstalled chai-xml to get npm to recalculate the version number in the package.json file, so this should be good to go provided nothing breaks.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-21 10:23:17
*Thread Reply:*
Review approved by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris's</a> pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-29 06:53:10
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2277#issuecomment-1528793944">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Thanks for raising <a href="https://github.com/maxjoehnk">@maxjoehnk</a>.</p>
<p>Attaching the PDF to the test run will itself work okay:</p>
<pre><code>await this.attach(buffer, 'application/pdf');
</code></pre>
<p>But this won't be rendered usably in our HTML report at the moment as you've hinted at. This is covered in <a href="https://github.com/cucumber/react-components/issues/80">cucumber/react-components#80</a>, so going to close this and continue tracking that issue (which overs all language implementations).</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-21 23:10:51
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/1139#issuecomment-1518527504">Comment</a> on issue by <a href="https://github.com/akwasin">akwasin</a>
<p>Not sure about what the cucumber-runner.js contains but it could be a link to <code>node_modules/@cucumber/cucumber/bin/cucumber.js</code></p>
<p>This is how i solved the issue of using having a project with module: ESNext and needing a separate tsconfig with CommonJS to run cucumber.</p>
<p>(npm run automation)<br />
<code>"automation": "ts-node --project src/tests/tsconfig.commonjs.json ./node_modules/@cucumber/cucumber/bin/cucumber.js src/tests/features/****/**.feature --require-module ts-node/register --require src/tests/test.setup.ts --require src/tests/step-definitions/****/**.spec.ts",</code></p>
<p>We have a react app with standard ./src folder and has a subfolder with features and step-definitions. This subfolder also holds <code>tsconfig.commonjs.jso</code>n that extends base <code>tsconfig.json</code></p>
<pre><code>{
"extends": "../../tsconfig.json",
"compilerOptions": {
"module": "CommonJS"
}
}
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-25 13:30:34
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2279#issuecomment-1522376832">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/59317139">Coverage Status</a></p>
<p>Coverage: 98.489%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/257985778e9073b3ef5f9accb5bb1afcbe676907">2579857</a> on michael-lloyd-morris:needAwait</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/c32b21ea897117177eaf539d4941f4f48618b8f2">c32b21e</a> on cucumber:main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-26 22:11:29
*Thread Reply:*
Review approved by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris's</a> pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-28 09:09:02
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2279#issuecomment-1527783663">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>Am I clear to merge?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-28 09:45:35
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2279#issuecomment-1527821552">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>> Am I clear to merge?</p>
<p>Sure.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-05-01 16:20:58
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2280#issuecomment-1530546659">Comment</a> on issue by <a href="https://github.com/bchew">bchew</a>
<p><a href="https://github.com/davidjgoss">@davidjgoss</a> is there a plan for a release to npm with this fix soon? Thanks</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-05-07 01:09:43
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2280#issuecomment-1537354079">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Released in <a href="https://github.com/cucumber/cucumber-js/releases/tag/v9.1.1">https://github.com/cucumber/cucumber-js/releases/tag/v9.1.1</a> - sorry for the delay.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-26 00:50:23
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2281#issuecomment-1522945670">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/59331872">Coverage Status</a></p>
<p>Coverage: 98.489%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/536b75f2b80d436f7c8caec9d7a533d733aea2f8">536b75f</a> on aukevanleeuwen:fix-2280-cve-on-yaml</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/c32b21ea897117177eaf539d4941f4f48618b8f2">c32b21e</a> on cucumber:main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-26 07:30:27
*Thread Reply:*
Review approved by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a> on <a href="https://github.com/aukevanleeuwen">aukevanleeuwen's</a> pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-26 22:10:32
*Thread Reply:*
Review approved by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/aukevanleeuwen">aukevanleeuwen's</a> pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-26 22:10:49
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2281#issuecomment-1524710891">Comment</a> on pull request by <a href="https://github.com/aslakhellesoy">aslakhellesoy</a>
<p>Hi <a href="https://github.com/aukevanleeuwen">@aukevanleeuwen</a>,</p>
<p>Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾</p>
<p>In return for this generous offer we hope you will:</p>
<p>• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our <a href="https://cucumber.io/conduct">code of conduct</a> in your interactions with other collaborators and users.
• 💬 Join the <a href="http://cucumber.io/support#slack">community Slack channel</a> to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!</p>
<p>On behalf of the Cucumber core team,<br />
Aslak Hellesøy<br />
Creator of Cucumber</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-27 05:21:20
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/1153#issuecomment-1525595332">Comment</a> on issue by <a href="https://github.com/enespekkaya">enespekkaya</a>
<p>Hi <a href="https://github.com/RockMinsk">@RockMinsk</a> and <a href="https://github.com/fescobar">@fescobar</a>,</p>
<p>How have you stopped or paused the other worker process while the first worker is run in BeforeAll hook?</p>
<p>Thank you in advance.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-27 08:09:22
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/1153#issuecomment-1525871006">Comment</a> on issue by <a href="https://github.com/fescobar">fescobar</a>
<p><a href="https://github.com/enespekkaya">@enespekkaya</a> In my case, the first worker process is responsible for creating the file. Meanwhile, other processes check if that file exists, if the file doesn't exist, that process keeps checking until the first worker creates that file. That verification is made every X seconds.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-27 08:34:31
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/1153#issuecomment-1525911986">Comment</a> on issue by <a href="https://github.com/vitalets">vitalets</a>
<p>Maybe take approach used in Playwright - keep <code>beforeAll / afterAll</code> as is but add <a href="https://playwright.dev/docs/test-global-setup-teardown#configure-globalsetup-and-globalteardown">globalSetup</a> config option to execute some file once in main cucumber process.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-28 01:21:03
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/1153#issuecomment-1527175994">Comment</a> on issue by <a href="https://github.com/enespekkaya">enespekkaya</a>
<p>Hi <a href="https://github.com/fescobar">@fescobar</a> ,<br />
I haven't figured out to paused other worker :(. If you share small example of code, I would much more appreciate.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-28 01:33:12
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/1153#issuecomment-1527189362">Comment</a> on issue by <a href="https://github.com/enespekkaya">enespekkaya</a>
<p>Hi <a href="https://github.com/vitalets">@vitalets</a>,<br />
We use cucumber-js with playwright either. We were not able to integrate defineConfig into cucumber-js. Do you have any example of code? Thanks.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-28 03:30:13
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/1153#issuecomment-1527349010">Comment</a> on issue by <a href="https://github.com/vitalets">vitalets</a>
<p>> Hi <a href="https://github.com/vitalets">@vitalets</a>, We use cucumber-js with playwright either. We were not able to integrate defineConfig into cucumber-js. Do you have any example of code? Thanks.</p>
<p>My suggestion is to implement <code>globalSetup</code> option in cucumber config, e.g.:</p>
<pre><code>module.exports = {
default: {
globalSetup: ['features/globalSetup.ts'],
// ...
</code></pre>
<p>PS: for using cucumber-js with playwright you may also have a look on <a href="https://github.com/vitalets/playwright-bdd">playwright-bdd</a>, that supports all playwright config options.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-04-28 16:10:03
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2115#issuecomment-1528182176">Comment</a> on issue by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>I'm going to take a look at this. No promises.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-05-07 01:19:47
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2282#issuecomment-1537355968">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>The error suggests a too-old version of Node.js, maybe 12.x. Can you run in <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/debugging.md">debug mode</a> and post the full output?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-05-28 19:00:21
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2282#issuecomment-1566384182">Comment</a> on issue by <a href="https://github.com/apps/github-actions">github-actions[bot]</a>
<p>This issue is stale because it has been open for 3 weeks with no activity. Remove the stale label or comment or this will be closed in another 5 days.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-05-07 02:46:13
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2283#issuecomment-1537372495">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Released in <a href="https://github.com/cucumber/cucumber-js/releases/tag/v9.1.2">https://github.com/cucumber/cucumber-js/releases/tag/v9.1.2</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-05-07 01:20:47
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2284#issuecomment-1537356128">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/59698050">Coverage Status</a></p>
<p>Coverage: 98.489%. Remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/e2ec16279992df04a29ec040e9d0ae26cecff34d">e2ec162</a> on nicojs:fix/export-support-code-type</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/fea1f4b7ded4973da7cc86e6c8c5eeaf59250a1a">fea1f4b</a> on cucumber:main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-05-07 01:30:23
*Thread Reply:*
Review approved by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/nicojs">nicojs's</a> pull request
<p>Thanks for this <a href="https://github.com/nicojs">@nicojs</a>!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-05-07 01:36:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2284#issuecomment-1537358899">Comment</a> on pull request by <a href="https://github.com/aslakhellesoy">aslakhellesoy</a>
<p>Hi <a href="https://github.com/nicojs">@nicojs</a>,</p>
<p>Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾</p>
<p>In return for this generous offer we hope you will:</p>
<p>• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our <a href="https://cucumber.io/conduct">code of conduct</a> in your interactions with other collaborators and users.
• 💬 Join the <a href="http://cucumber.io/support#slack">community Slack channel</a> to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!</p>
<p>On behalf of the Cucumber core team,<br />
Aslak Hellesøy<br />
Creator of Cucumber</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-05-07 01:46:14
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2285#issuecomment-1537360758">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/59698179">Coverage Status</a></p>
<p>Coverage: 98.49% (+0.001%) from 98.489% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/17bd8193e59cce0e0cb41845817302564de75fff">17bd819</a> on fix/tone-down-global-warning</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/728fe26f9946025946452e73ef615f5488c0e533">728fe26</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-05-12 03:53:16
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2265#issuecomment-1545555371">Comment</a> on issue by <a href="https://github.com/Sam-ScottLogic">Sam-ScottLogic</a>
<p>May I work on this? This is my first time contributing so may have a few questions along the way!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-05-12 03:55:26
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2265#issuecomment-1545557619">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Sure <a href="https://github.com/Sam-ScottLogic">@Sam-ScottLogic</a>, go for it! Feel free to ask questions here, or join <b>#committers-js</b> in the Slack <a href="https://cucumber.io/docs/community/get-in-touch/">https://cucumber.io/docs/community/get-in-touch/</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-05-23 04:04:17
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2265#issuecomment-1559068733">Comment</a> on issue by <a href="https://github.com/astocker-scottlogic">astocker-scottlogic</a>
<p><a href="https://github.com/Sam-ScottLogic">@Sam-ScottLogic</a> Hi am I okay to take a look into this?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-05-23 06:18:41
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2265#issuecomment-1559331070">Comment</a> on issue by <a href="https://github.com/Sam-ScottLogic">Sam-ScottLogic</a>
<p><a href="https://github.com/astocker-scottlogic">@astocker-scottlogic</a> Yes!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-05-23 07:15:13
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2286#issuecomment-1559490675">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/60232351">Coverage Status</a></p>
<p>Coverage: 98.492% (+0.001%) from 98.49% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/8f663e9abab234394fcd1bb248b5148c19b3ec7b">8f663e9</a> on astocker-scottlogic:astocker-2265-custom-formatting-option-junit</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/63f30338e6b8dbe0b03ddd2776079a8ef44d47e2">63f3033</a> on cucumber:main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-05-28 02:02:14
*Thread Reply:*
Review approved by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/astocker-scottlogic">astocker-scottlogic's</a> pull request
<p>Thanks for doing this! I'll merge once it's all green.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-05-28 02:09:20
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2286#issuecomment-1566023508">Comment</a> on pull request by <a href="https://github.com/aslakhellesoy">aslakhellesoy</a>
<p>Hi <a href="https://github.com/astocker-scottlogic">@astocker-scottlogic</a>,</p>
<p>Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾</p>
<p>In return for this generous offer we hope you will:</p>
<p>• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our <a href="https://cucumber.io/conduct">code of conduct</a> in your interactions with other collaborators and users.
• 💬 Join the <a href="http://cucumber.io/support#slack">community Slack channel</a> to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!</p>
<p>On behalf of the Cucumber core team,<br />
Aslak Hellesøy<br />
Creator of Cucumber</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-05-28 01:57:38
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2287#issuecomment-1566018270">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/60366172">Coverage Status</a></p>
<p>Coverage: 98.495% (+0.005%) from 98.49% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/a53b037ff07267017eaf162bee9d1554941dd709">a53b037</a> on feat/parameter-source-reference</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/63f30338e6b8dbe0b03ddd2776079a8ef44d47e2">63f3033</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-02 19:03:58
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2282#issuecomment-1574559678">Comment</a> on issue by <a href="https://github.com/apps/github-actions">github-actions[bot]</a>
<p>This issue was closed because it has been stalled for 5 days with no activity.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-10 04:38:19
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2289#issuecomment-1585629043">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>From the output there it looks like you might have the old “cucumber” module installed, maybe globally?</p>
<p>Can you try removing that?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-19 10:17:50
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2289#issuecomment-1597515305">Comment</a> on issue by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>I've personally never been able to get cucumber-js to invoke that way in Windows PowerShell. When I try I get a different error than OP - specifically the global installed warning even though that is entirely erroneous. Further the script works just fine if invoked through <code>npm test</code></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-09 00:58:47
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2290#issuecomment-1584140897">Comment</a> on issue by <a href="https://github.com/furiel">furiel</a>
<p>I was wondering if you had the opportunity to look into this. Do these sound reasonable?</p>
<p>I tried to join to the slack community, but when I entered my email in the registration <a href="https://cucumberbdd-slack-invite.herokuapp.com/">link</a> I found <a href="https://cucumber.io/tools/cucumber-open/support/">here</a>, I received an error about<br />
<a href="https://user-images.githubusercontent.com/11007226/244630335-02664107-bed2-4dcc-b5c0-5f123d55fcc7.png">image</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-10 04:47:57
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2290#issuecomment-1585631164">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Hey <a href="https://github.com/furiel">@furiel</a>, thanks for the detailed report and sorry for the late reply.</p>
<p>I do think this is a bug - for the purposes of rerun formatter we should only report a scenario as failed if all retries fail.</p>
<p>Since you’ve already pinpointed the source, would you be up for making a PR with the fix?</p>
<p>(I’ve passed in the report re the Slack invite.)</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-14 00:41:48
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2290#issuecomment-1590649600">Comment</a> on issue by <a href="https://github.com/furiel">furiel</a>
<p><a href="https://github.com/davidjgoss">@davidjgoss</a> thanks for the confirmation. I am creating a pull request.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-22 07:43:02
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2290#issuecomment-1602765761">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Fixed by <a href="https://github.com/cucumber/cucumber-js/pull/2292">#2292</a></p>
<p>Released in <a href="https://github.com/cucumber/cucumber-js/releases/tag/v9.2.0">9.2.0 https://github.com/cucumber/cucumber-js/releases/tag/v9.2.0</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-27 23:05:33
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2290#issuecomment-1610802187">Comment</a> on issue by <a href="https://github.com/mattwynne">mattwynne</a>
<p>> slack</p>
<p><a href="https://github.com/furiel">@furiel</a> for Slack, try the registration link here: <a href="https://cucumber.io/community/#slack">https://cucumber.io/community/#slack</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-29 00:45:00
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2290#issuecomment-1612571838">Comment</a> on issue by <a href="https://github.com/furiel">furiel</a>
<p>Thanks for fixing it <a href="https://github.com/mattwynne">@mattwynne</a> . The registration worked now.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-08 07:28:49
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/1871#issuecomment-1582688905">Comment</a> on issue by <a href="https://github.com/pk">pk</a>
<p>Is this issues still valid/pending? I could have a look to get started with the code base.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-10 04:40:07
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/1871#issuecomment-1585629459">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p><a href="https://github.com/pk">@pk</a> absolutely, feel free to raise PRs and let me know if you need any pointers.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-12 00:36:25
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/1871#issuecomment-1586754148">Comment</a> on issue by <a href="https://github.com/pk">pk</a>
<p>Perfect, we are using Cucumber so much that we really would like to contribute. Also our test suites are getting more and more complex and we may need to start to use some features from API, running the Features dynamically so it would be nice to contribute before I start asking too many questions. ;)</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-12 14:08:45
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/1871#issuecomment-1588105924">Comment</a> on issue by <a href="https://github.com/pk">pk</a>
<p>OK, I've looked into this and I think this task is done.</p>
<p>There are steps under <code>compability/****/**.ts</code> and <code>features/step_definitions/**.ts</code> all of which has been converted into the Cucumber Expressions.</p>
<p>I've done search for Given/When/Then with the RegExp patterns and it really yields references to the steps with RegExp only in **.md files.</p>
<p>I may be missing something....</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-14 05:55:48
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/1871#issuecomment-1591152373">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Sorry for the confusion <a href="https://github.com/pk">@pk</a> - updating the examples in the .md docs would be equally valuable though!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-12 04:34:13
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/1393#issuecomment-1587151366">Comment</a> on issue by <a href="https://github.com/pk">pk</a>
<p>+1 for having either World instance or at least the processed <code>parameters</code> available in the <code>BeforeAll</code>. Our use case is that we run test suites in various configurations (locally & CI) and I'd like to:</p>
<ol><li>Log configuration to console<br />
ENV variables gets processed in cucumber.mjs, worldParams are constructed, specific config profile is run, so I can't dump it into console in the cucumber.mjs</li><li>Attach configuration into a report (in the future we will have custom report)</li>
</ol>
<p>I could workaround this by creating a Feature file <code>setup-test-suite.feature</code> (and running it first) where I could implement steps to dump configuration and attach it but... it would be better to have this done in the <code>BeforeAll</code>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-14 02:55:29
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/1153#issuecomment-1590875038">Comment</a> on issue by <a href="https://github.com/luke-hill">luke-hill</a>
<p>Given this has turned into a discussion I'm going to propose we close this as "will not do".</p>
<p>In essence <code>BeforeAll</code>/<code>AfterAll</code> are working as expected. Which is to run the expected code once before everything is done. If you run into issues when running in parallel, you need to explore your test architecture / setup - it's not something cucumber would necessarily fix as it's not broken / a needed feature. For every use case of not needing something more than once, there would be one use case where it would be needed once per thread.</p>
<p>Lots of the proposed workarounds are fine, and just that... "workarounds". In essence if you need something once and once only, you should explore some sort of preliminary step in your CI / other environment. Things like attaching to a specific parallel worker are ok in practice, but we would never evangelise / recommend these as these ID's are often assigned arbitrarily, and as such you might find that the first id numerically may not necessarily be the first one procedurally - YMMV. If you want to go down the route of waiting for that specific action to complete, again that's fine.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-20 00:02:43
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2291#issuecomment-1598223362">Comment</a> on issue by <a href="https://github.com/KrishNair1">KrishNair1</a>
<p><a href="https://github.com/ortoniKC">@ortoniKC</a> one of the options cucumber provides is this: <url|https://github.com/cucumber/cucumber-js/blob/main/docs/formatters.md#colored-output></p>
<p>I used FORCE_COLOR=0 in CLI and worked for me.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-29 22:50:17
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2291#issuecomment-1614161923">Comment</a> on issue by <a href="https://github.com/ortoniKC">ortoniKC</a>
<p><a href="https://github.com/KrishNair1">@KrishNair1</a> Thanks mate, it worked.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-17 05:23:46
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2292#issuecomment-1595730461">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/60798489">Coverage Status</a></p>
<p>coverage: 98.497% (+0.005%) from 98.492% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/2d645c6167f9efc6a9818ef8764c6a7bbadf0f1e">2d645c6</a> on furiel:unstable-tests</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/54ac0473b48fd0c785ec480d09373dce71ccb2af">54ac047</a> on cucumber:main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-17 05:25:33
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2292#discussion_r1233035170">Comment</a> on pull request by <a href="https://github.com/jenisys">jenisys</a>
<p>HINT: It becomes more READABLE if you are using „And …“ (instead of: „Given …“) for the second and following given-steps.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-19 10:08:54
*Thread Reply:*
Review approved by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a> on <a href="https://github.com/furiel">furiel's</a> pull request
<p>Overall looks great. Some minor doc fixing in the changelog, but that could be fixed during merge I think.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-19 10:08:54
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2292#discussion_r1234289176">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>As above, link and destination mismatch.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-19 10:08:54
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2292#discussion_r1234289330">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>As above, link and destination mismatch.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-19 10:08:54
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2292#discussion_r1234288829">Comment</a> on pull request by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>Issue <a href="https://github.com/cucumber/cucumber-js/pull/2285">#2285</a> is listed as the link but Issue <a href="https://github.com/cucumber/cucumber-js/issues/2290">#2290</a> is what is linked. Shouldn't these be the same?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-20 02:52:32
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2292#discussion_r1235026405">Comment</a> on pull request by <a href="https://github.com/furiel">furiel</a>
<p>You are right. Copy paste error from my side.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-20 05:02:13
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2292#discussion_r1235160481">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>The detail in here is a bit too low-level, as this is intended for end users - really just one entry for like "Correctly interpret retried scenarios in rerun formatter" that links to the PR will be fine.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-20 05:02:13
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2292#discussion_r1235158990">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>I'm not sure I see the need for exporting these - they are basic utility functions and not something we should commit to supporting externally.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-20 05:02:13
*Thread Reply:*
Reviewed and changes requested by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/furiel">furiel's</a> pull request
<p>Thanks for doing this, looks good! Just a few things I've noted that would be good to change. Happy to help if you need it.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-20 05:02:13
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2292#discussion_r1235162540">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Could we not achieve the test by using the rerun formatter normally via CLI arguments and asserting on the content of the file that it writes, rather than wrapping it in a custom formatter? I don't doubt that this works, but I wouldn't want a user to take this example and run with it.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-20 11:11:54
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2292#discussion_r1235642103">Comment</a> on pull request by <a href="https://github.com/furiel">furiel</a>
<p>Sure, makes sense. I dropped the patch.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-20 11:13:28
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2292#discussion_r1235643770">Comment</a> on pull request by <a href="https://github.com/furiel">furiel</a>
<p>That's a neat feature. :) I was not aware that I can simply reproduce with <code>--format rerun</code>. The changeset became much simpler.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-22 07:24:05
*Thread Reply:*
Review approved by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/furiel">furiel's</a> pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-22 07:24:16
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2292#issuecomment-1602734811">Comment</a> on pull request by <a href="https://github.com/aslakhellesoy">aslakhellesoy</a>
<p>Hi <a href="https://github.com/furiel">@furiel</a>,</p>
<p>Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾</p>
<p>In return for this generous offer we hope you will:</p>
<p>• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our <a href="https://cucumber.io/conduct">code of conduct</a> in your interactions with other collaborators and users.
• 💬 Join the <a href="http://cucumber.io/support#slack">community Slack channel</a> to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!</p>
<p>On behalf of the Cucumber core team,<br />
Aslak Hellesøy<br />
Creator of Cucumber</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-26 09:24:39
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2293#issuecomment-1607820703">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>When I run <code>npx cucumber-js --help</code> from a new project:</p>
<pre><code>Usage: cucumber-js [options] [&lt;GLOB|DIR|FILE[:LINE]&gt;...]
Options:
-v, --version output the version number
-b, --backtrace show full backtrace for errors
-c, --config &lt;PATH&gt; specify configuration file
-d, --dry-run invoke formatters without executing steps
--exit, --force-exit force shutdown of the event loop when the test run has finished: cucumber will call process.exit
--fail-fast abort the run on first failure
-f, --format &lt;TYPE[:PATH]&gt; specify the output format, optionally supply PATH to redirect formatter output (repeatable). Available formats:
json: Prints the feature as JSON. The JSON format is in maintenance mode. Please consider using the message formatter with the standalone json-formatter (<https://github.com/cucumber/json-formatter>).
message: Outputs protobuf messages
html: Outputs HTML report
progress: Prints one character per scenario.
progress-bar: Similar to the Progress Formatter, but provides a real-time updating progress bar based on the total number of steps to be executed in the test run
rerun: Prints failing files with line numbers.
snippets: The Snippets Formatter doesn't output anything regarding the test run; it just prints snippets to implement any undefined steps
summary: Summary output of feature and scenarios
usage: Prints where step definitions are used. The slowest step definitions (with duration) are listed first. If --dry-run is used the duration is not shown, and step definitions are sorted by filename instead.
usage-json: Does what the Usage Formatter does, but outputs JSON, which can be output to a file and then consumed by other tools.
junit: Outputs JUnit report
--format-options &lt;JSON&gt; provide options for formatters (repeatable)
--i18n-keywords &lt;ISO 639-1&gt; list language keywords
--i18n-languages list languages
-i, --import &lt;GLOB|DIR|FILE&gt; import files before executing features (repeatable)
--language &lt;ISO 639-1&gt; provide the default language for feature files
--name &lt;REGEXP&gt; only execute the scenarios with name matching the expression (repeatable)
--order &lt;TYPE[:SEED]&gt; run scenarios in the specified order. Type should be `defined` or `random`
-p, --profile &lt;NAME&gt; specify the profile to use (repeatable) (default: [])
--parallel &lt;NUMBER_OF_WORKERS&gt; run in parallel with the given number of workers
--publish Publish a report to <https://reports.cucumber.io>
--publish-quiet Don't print information banner about publishing reports
-r, --require &lt;GLOB|DIR|FILE&gt; require files before executing features (repeatable)
--require-module &lt;NODE_MODULE&gt; require node modules before requiring files (repeatable)
--retry &lt;NUMBER_OF_RETRIES&gt; specify the number of times to retry failing test cases (default: 0)
--retry-tag-filter &lt;EXPRESSION&gt; only retries the features or scenarios with tags matching the expression (repeatable).
This option requires '--retry' to be specified.
--strict fail if there are pending steps
--no-strict succeed even if there are pending steps
-t, --tags &lt;EXPRESSION&gt; only execute the features or scenarios with tags matching the expression (repeatable)
--world-parameters &lt;JSON&gt; provide parameters that will be passed to the world constructor (repeatable)
-h, --help display help for command
For more details please visit <https://github.com/cucumber/cucumber-js/blob/main/docs/cli.md>
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-26 09:26:12
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2293#issuecomment-1607822694">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>From certain other keys that are missing e.g. <code>--import</code> and the lack of details around formatters I think that is quite an old version generating that message. Is it possible you have the old <code>cucumber</code> package installed? Or maybe an older version of <code>@cucumber/cucumber</code> coming through another dependency.</p>
<p>It might be worth running:</p>
<pre><code>npm why @cucumber/cucumber
npm why cucumber
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-28 02:57:20
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2293#issuecomment-1611117758">Comment</a> on issue by <a href="https://github.com/kannanmf">kannanmf</a>
<p>I uninstall <code>@cucumber/cucumber</code> and reinstalled the latest version(9.2.0) of <code>@cucumber/cucumber</code> and now --config path is working. Thanks for your time in investigating</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-07-10 06:56:23
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2294#issuecomment-1629020874">Comment</a> on issue by <a href="https://github.com/codetycon">codetycon</a>
<p><a href="https://github.com/davidjgoss">@davidjgoss</a> I checked the CHOR and found that code has been merged but the last release still missing this upgrade. See here:</p>
<p><a href="https://github.com/cucumber/cucumber-js/blob/a03329c8eff6abe06185ab8ff8a619810f44dd96/package.json">https://github.com/cucumber/cucumber-js/blob/a03329c8eff6abe06185ab8ff8a619810f44dd96/package.json</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-07-14 02:23:26
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2294#issuecomment-1635569010">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Released in <a href="https://github.com/cucumber/cucumber-js/releases/tag/v9.3.0">https://github.com/cucumber/cucumber-js/releases/tag/v9.3.0</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-28 00:56:40
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2295#issuecomment-1610944319">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/61008891">Coverage Status</a></p>
<p>coverage: 98.499%. remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/0dc5eded7a583e536eb7985af971dcd92350c1db">0dc5ede</a> on chore/semver-upgrade</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/a03329c8eff6abe06185ab8ff8a619810f44dd96">a03329c</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-07-10 06:56:45
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2295#issuecomment-1629021383">Comment</a> on pull request by <a href="https://github.com/codetycon">codetycon</a>
<p><a href="https://github.com/davidjgoss">@davidjgoss</a> I checked the CHOR and found that code has been merged but the last release still missing this upgrade. See here:</p>
<p><a href="https://github.com/cucumber/cucumber-js/blob/a03329c8eff6abe06185ab8ff8a619810f44dd96/package.json">https://github.com/cucumber/cucumber-js/blob/a03329c8eff6abe06185ab8ff8a619810f44dd96/package.json</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-07-11 07:18:40
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2295#issuecomment-1630920988">Comment</a> on pull request by <a href="https://github.com/A099713">A099713</a>
<p>> <a href="https://github.com/davidjgoss">@davidjgoss</a> I checked the CHOR and found that code has been merged but the last release still missing this upgrade. See here:
>
> <a href="https://github.com/cucumber/cucumber-js/blob/a03329c8eff6abe06185ab8ff8a619810f44dd96/package.json">https://github.com/cucumber/cucumber-js/blob/a03329c8eff6abe06185ab8ff8a619810f44dd96/package.json</a></p>
<p>I noticed that too. Hopefully the semver pkg update will be in the next release. Any ETA on that? Thanks!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-28 22:20:26
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/1770#issuecomment-1612445230">Comment</a> on pull request by <a href="https://github.com/ksathyanm">ksathyanm</a>
<p>Just curious if we have any updates or plan for this PR?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-06-29 01:44:34
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2296#issuecomment-1612645483">Comment</a> on issue by <a href="https://github.com/luke-hill">luke-hill</a>
<p>As mentioned in slack, this is "likely" something that would fit into the "not-cucumber" category.</p>
<p>If this was something you wanted to make as an off-shoot plugin, then go ahead. But I'm not really sure of the need in a ubiquitous spec for cucumber.</p>
<p>If cucumber-js wanted to deviate and maintain this, then that's up to the maintainers here. Primarily <a href="https://github.com/davidjgoss">@davidjgoss</a> - but it's not something that would be welcome across all flavours of cucumber</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-07-11 14:57:23
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2296#issuecomment-1631562935">Comment</a> on issue by <a href="https://github.com/sashokbg">sashokbg</a>
<p>I have just noticed that Jest actually implements this feature:</p>
<p>When having no tests found it fails with error code 1 and optionally can have a flag that disables this.</p>
<p>Actually when we think about it having 0 tests is never OK. If you have no tests implemented just don't put a test framework, other ways it means something went bad and you should fail.</p>
<pre><code>No tests found, exiting with code 1
Run with `--passWithNoTests` to exit with code 0
</code></pre>
<p><a href="https://jestjs.io/docs/cli#--passwithnotests">https://jestjs.io/docs/cli#--passwithnotests</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-07-13 07:45:31
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2296#issuecomment-1634376444">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p>For Cucumber JVM I generally find it prudent to follow the ecosystems conventions. For Java that comes down to treating the set of empty tests as passing by default.</p>
<p><a href="https://github.com/cucumber/cucumber-jvm/issues/2684">cucumber/cucumber-jvm#2684</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-07-19 01:15:15
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2296#issuecomment-1641634701">Comment</a> on issue by <a href="https://github.com/sashokbg">sashokbg</a>
<p>Hello <a href="https://github.com/mpkorstanje">@mpkorstanje</a> I did not understand what you mean to say by "ecosystem conventions" and what Java empty sets has to do with simple validating that a test framework works.</p>
<p>Talk about conventions it seems a lot more logical to have a convention saying that a test's job is to validate that a system is working properly and this covers the use case illustrated in this issue.</p>
<p>PS: Another test framework that I am using has a proper detection of "0 tests found" - ArchUnit:</p>
<p>ArchUnit Log:</p>
<p>java.lang.AssertionError: Rule 'classes that are annotated with <a href="https://github.com/te">@te</a> should have simple name ending with 'Entity'' failed to check any classes. <strong>This means either that no classes have been passed to the rule at all, or that no classes passed to the rule matched the <code>that()</code> clause. To allow rules being evaluated without checking any classes you can either use <code>ArchRule.allowEmptyShould(true)</code></strong> on a single rule or set the configuration property <code>archRule.failOnEmptyShould = false</code> to change the behavior globally.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-07-19 01:18:38
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2296#issuecomment-1641639324">Comment</a> on issue by <a href="https://github.com/luke-hill">luke-hill</a>
<p><a href="https://github.com/sashokbg">@sashokbg</a> The phrase "proper" implies that cucumber reporting 0 tests is incorrect. This isn't the case. Cucumber isn't a testing framework. Furthermore, it is correct to grab 0 tests as we want to cover use cases where for instance tag filtering or folder filtering is working correctly.</p>
<p><strong>Within</strong> a testing framework you could also argue about 0 being correct/incorrect. I have a cucumber framework (Which also uses rspec), and I ran <code>rspec</code> and it correctly returned exit code 0.</p>
<pre><code>[09:16:30] luke@luke-ubuntu:~/Code/folder$ rspec
No examples found.
Finished in 0.00022 seconds (files took 0.032 seconds to load)
0 examples, 0 failures
[09:17:23] luke@luke-ubuntu:~/Code/folder$ echo $?
0
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-07-19 01:36:39
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2296#issuecomment-1641666393">Comment</a> on issue by <a href="https://github.com/mpkorstanje">mpkorstanje</a>
<p><a href="https://github.com/sashokbg">@sashokbg</a> in the Java ecosystem I would consider JUnit 5, Maven and Gradle to be representative. But I don't think we need to have a discussion about Java here. Ideally, since you're advancing this argument for cucumber-js, you could provide examples from the JS ecosystem that treat the set of empty tests as a failure.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-07-19 06:04:49
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2296#issuecomment-1642047370">Comment</a> on issue by <a href="https://github.com/vitalets">vitalets</a>
<p>Maybe just a config setting (like <code>--pass-with-no-tests</code>) and it becomes flexible for everybody</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-07-19 06:41:49
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2296#issuecomment-1642108323">Comment</a> on issue by <a href="https://github.com/luke-hill">luke-hill</a>
<p>If this is a common custom in the majority of JS frameworks <a href="https://github.com/vitalets">@vitalets</a> (such as mocha / chai / jest ....) then I don't see any argument against it.</p>
<p>But I don't have enough knowledge of JS, if it seems as though lots of people are asking for this thing and it aligns nicely then push some work up and have one the JS contributors review it. I think by now we've resolved the "how" it would need to work, given that we've explained by and large cucumber reporting 0 scenarios ran shouldn't be considered (for now), as erroneous.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-07-06 20:17:07
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2253#issuecomment-1624591679">Comment</a> on issue by <a href="https://github.com/pwmcintyre">pwmcintyre</a>
<p>+1 this would be a nice addition</p>
<p>i frequently want to run a single test (eg. while fixing a bug) ... and so i run the following expecting it to run just 1 feature</p>
<pre><code>npm run tests -- test/features/products.feature
</code></pre>
<p>instead it runs the whole lot</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-07-06 23:01:00
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2253#issuecomment-1624791178">Comment</a> on issue by <a href="https://github.com/aleksdobrev">aleksdobrev</a>
<p>For running only one or some tests, I use some of these options:</p>
<p>• <code>npm test --test/features/products.feature:33</code> Where the number is the line at which the test starts.
• <code>npm test -- -f rerun:@filename.ext</code> This will create a file listing all failing scenarios(if there are such) in a syntax like the previous point, which you can use to run only the failing scenarios easily.
• Tags - you can put whatever you like and run <code>npm test -- --tags @tagname</code>.
• Something unique in the name, like an ID number or a text and run <code>npm test -- --name unique_name</code>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-07-10 19:04:37
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2289#issuecomment-1629989876">Comment</a> on issue by <a href="https://github.com/apps/github-actions">github-actions[bot]</a>
<p>This issue is stale because it has been open for 3 weeks with no activity. Remove the stale label or comment or this will be closed in another 5 days.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-07-15 19:16:41
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2289#issuecomment-1636952127">Comment</a> on issue by <a href="https://github.com/apps/github-actions">github-actions[bot]</a>
<p>This issue was closed because it has been stalled for 5 days with no activity.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-07-14 03:03:08
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2298#issuecomment-1635621500">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>The error is because there should be a result for a step and it's not there. We could make the code more defensive but I'd like to understand how this can happen. Are you able to post a minimum reproducible example repo that this happens with? Can you reproduce locally? Can you switch to use the <code>message</code> formatter and post that output somewhere?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-07-18 00:36:38
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2298#issuecomment-1639668735">Comment</a> on issue by <a href="https://github.com/karol719">karol719</a>
<p>There was issue with config we had something like this</p>
<pre><code>module.exports = {
default: {
paths: ['test/e2e/feature/x/****/**.feature'],
require: [
'test/e2e/step-definitions/x/****/**.ts',
'test/e2e/step-definitions/http.step-definition.ts',
],
requireModule: ['ts-node/register'],
publishQuiet: true,
parallel: 1,
},
};
</code></pre>
<p>When parallel is set to 1 then there was an issue, but if I removed parallel everything works fine.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-08-08 19:02:03
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2298#issuecomment-1670546135">Comment</a> on issue by <a href="https://github.com/apps/github-actions">github-actions[bot]</a>
<p>This issue is stale because it has been open for 3 weeks with no activity. Remove the stale label or comment or this will be closed in another 5 days.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-07-12 07:08:55
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2299#issuecomment-1632600257">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>As you're using WebdriverIO and not Cucumber itself, you'll need to raise this over there <a href="https://github.com/webdriverio/webdriverio">https://github.com/webdriverio/webdriverio</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-07-13 13:10:18
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2300#issuecomment-1634839851">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/61335542">Coverage Status</a></p>
<p>coverage: 98.505%. remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/63214437cd5ffb41b3726c4456bbc29716e5e126">6321443</a> on html-formatter-20-4-0</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/aea9e8be42a78e1a32b45ee65f9626329b5edd88">aea9e8b</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-07-14 02:24:11
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2277#issuecomment-1635570078">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Released in <a href="https://github.com/cucumber/cucumber-js/releases/tag/v9.3.0">https://github.com/cucumber/cucumber-js/releases/tag/v9.3.0</a></p>
<p>• You can now download PDF attachments from the HTML report as a file
• You can also optionally specify a filename when you attach</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-07-16 10:39:05
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/1393#issuecomment-1637147379">Comment</a> on issue by <a href="https://github.com/aartajew">aartajew</a>
<p>As a workaround, you can load Cucumber configuration (together with <code>worldParameters</code>) outside of steps using API:</p>
<pre><code>import { loadConfiguration } from '@cucumber/cucumber/api'
import ArgvParser from '@cucumber/cucumber/lib/configuration/argv_parser'
// store original Cucumber argv (needed for parallel runs which spawns child processes with stripped argv)
if (!process.env.CUCUMBER_ARGV) {
process.env.CUCUMBER_ARGV = process.argv.join(' ')
}
export async function loadWorldParams() {
const argv = process.env.CUCUMBER_ARGV!.split(' ')
const { options, configuration } = ArgvParser.parse(argv)
const { useConfiguration } = await loadConfiguration({
file: options.config,
profiles: options.profile,
provided: configuration,
})
return useConfiguration.worldParameters
}
</code></pre>
<p>Works on Cucumber v9.2.0</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-07-16 14:34:35
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/1393#issuecomment-1637195015">Comment</a> on issue by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>Workarounds are great, but even better are improvements to the engine.</p>
<p><a href="https://github.com/mattwynne">@mattwynne</a> and <a href="https://github.com/BlueMona">@BlueMona</a> - Is there anything in your project that conflicts with what I propose?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-07-26 09:35:34
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2301#issuecomment-1652153096">Comment</a> on issue by <a href="https://github.com/hoefken">hoefken</a>
<p>After the deletion of node_modules and some weird caches in my IDE it seems to be working just fine. So I will just close this ticket.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-07-24 23:10:33
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2302#issuecomment-1649180792">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>You can specify any media type for the attach function. Is your issue more about the support in reports?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-07-30 08:41:34
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2302#issuecomment-1657204333">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>It's worth noting that we <a href="https://github.com/cucumber/cucumber-js/releases/tag/v9.3.0">recently</a> released support for downloading attachments from the HTML report - previously anything that wasn't text or an image would be inaccessible.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-08-20 18:47:47
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2302#issuecomment-1685498041">Comment</a> on issue by <a href="https://github.com/apps/github-actions">github-actions[bot]</a>
<p>This issue is stale because it has been open for 3 weeks with no activity. Remove the stale label or comment or this will be closed in another 5 days.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-07-30 08:28:20
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2303#issuecomment-1657201298">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p><a href="https://github.com/MiladSadinam">@MiladSadinam</a> thanks for raising, you'r right that it's currently not supported. <code>parallel</code> just uses multiple worker threads but on the same machine which for reasons you've noted has limitations.</p>
<p>From what you've written, I think the kind of thing you're looking for is more like <a href="https://playwright.dev/docs/test-parallel#shard-tests-between-multiple-machines">Playwright's sharding feature</a>, where an independent run would execute a subset of test cases based on an index and count, e.g.:</p>
<pre><code># machine 1
npx cucumber-js --shard 1/3
# machine 2
npx cucumber-js --shard 2/3
# machine 3
npx cucumber-js --shard 3/3
</code></pre>
<p>I'd definitely be supportive of doing this as a relatively low-effort way to give people another lever for performance.</p>
<hr />
<p>Some thoughts about how this should work (more for internal audience):</p>
<p>• When do we run the logic to get the subset of test cases for this shard? We should be able to do it once we have derived the pickles. Presumably then we wouldn't emit <code>testCase</code> messages for the ones we aren't going to run. I think we probably couldn't avoid emitting the <code>pickle</code> message if we wanted to (without a significant rework), since that is done by Gherkin before any of the Cucumber processing kicks in.
• Once we release this, people are (reasonably) going to want to be able to e.g. concatenate the messages from the multiple sharded runs and produce a single HTML report. I doubt we would support this right away, but we should avoid doing anything that would block it later. We've already taken some small steps towards this with e.g. making <code>testRunStarted</code> messages have a unique id, so it's not totally unrealistic.
• The <code>parallel</code> option should still work in the context of one shard.
• The usual filtering mechanisms (files, lines, tags, names) should all happen as normal <em>before</em> the sharding logic.
• Plugins that e.g. influence the pickle order or do further filtering should also happen before the sharding logic.
• This should be an option on the API, not just the CLI.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-07-31 01:58:36
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2303#issuecomment-1657954784">Comment</a> on issue by <a href="https://github.com/MiladSadinam">MiladSadinam</a>
<p>Thank you for your feedback. Yes, the sharding feature would exactly be what I would like. As feedback from our side, we would not care about merging of the reports.</p>
<p>I was wondering how I could achieve a similar result until you guys hopefully implement this. My idea would be something like:</p>
<pre><code># machine 1
cucumber-js --name "^[a-m].**$"
#machine 2
cucumber-js --name "^[n-z].**$"
</code></pre>
<p>I would need to tweak the limit between the two machines, to get similar execution times, but otherwise it should work.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-07-31 11:36:08
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2303#issuecomment-1658941480">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Yep, that might be worth a try.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-08-01 03:16:11
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2303#issuecomment-1660011034">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Just noting we could also explore doing this as a plugin, with the <a href="https://github.com/cucumber/cucumber-js/discussions/2091">new plugins concept</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-07-31 11:31:01
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2304#issuecomment-1658934185">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>This would be best raised against the <a href="https://github.com/allure-framework/allure-js">https://github.com/allure-framework/allure-js</a> repo, but something I would note from the <a href="https://github.com/allure-framework/allure-js/blob/master/packages/allure-cucumberjs/README.md">readme</a> there:</p>
<p>> If you want to retain default formatter add some dummy file as output:
>
> <code>cucumber-js --format ./path/to/reporter.js:./dummy.txt</code></p>
<p>It looks like the Allure formatter doesn't emit anything to the given stream, so you need to give it a file (the second part after the <code>:</code>) to point at otherwise it overrides the default progress/summary formatter which is why you get no terminal output.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-07-31 12:53:39
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2304#issuecomment-1659041862">Comment</a> on issue by <a href="https://github.com/varshanharshank">varshanharshank</a>
<p><a href="https://github.com/davidjgoss">@davidjgoss</a> Great. Thanks for the quick response. I tried the above step and it is working fine now.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-08-04 07:30:17
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2305#issuecomment-1665708642">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>In terms of providing arbitrary config variables via the CLI, you can do this with <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/support_files/world.md#world-parameters">world parameters</a>.</p>
<p>For your use case with varying the browser here, I'd recommend looking at <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/profiles.md">profiles</a> so you can do something like:</p>
<pre><code>npx cucumber-js --profile firefox --tags '@smoke'
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-08-05 18:29:20
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/1967#issuecomment-1666668419">Comment</a> on issue by <a href="https://github.com/bliu13">bliu13</a>
<p><a href="https://github.com/davidjgoss">@davidjgoss</a>, Anything else you might recommend that is an alternative to Sinon?<br />
<a href="https://stackoverflow.com/questions/50763323/stub-an-export-from-a-native-es-module-without-babel/50763914#50763914">https://stackoverflow.com/questions/50763323/stub-an-export-from-a-native-es-module-without-babel/50763914#50763914</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-08-05 23:24:14
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2306#issuecomment-1666738909">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>And and But are shorthand keywords you a use in your feature file for readability. The step itself should be defined as either Given When or Then.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-08-07 14:36:21
*Thread Reply:*
New comment on issue by <a href="https://github.com/Konubinix">Konubinix</a>
<p><code>This comment was deleted</code></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-08-08 02:36:19
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2307#issuecomment-1669266311">Comment</a> on issue by <a href="https://github.com/Konubinix">Konubinix</a>
<p>I realized something more about this behavior.</p>
<p>All the files loaded after somefile.ts have the issue, but all the files loaded before don't.</p>
<p>To show this, comment the error in <code>somefile.ts</code> and create <code>someotherfile.ts</code> with an error in it.</p>
<p>You should have the following contents.</p>
<p>somefile.ts</p>
<pre><code>import { expect } from "@playwright/test";
let a = expect;
class A {}
// throw new Error();
</code></pre>
<p>someotherfile.ts:</p>
<pre><code>class B {}
throw new Error();
</code></pre>
<p>Now, with this content in cucumber.js</p>
<pre><code>module.exports = {
default: [
"--require ./somefile2.ts",
"--require ./somefile.ts",
"--require-module ts-node/register",
"--require features/****/**.ts",
"--publish-quiet",
].join(" "),
};
</code></pre>
<p><code>npm test</code> gives<br />
<a href="https://user-images.githubusercontent.com/1181438/259055700-af5fbfb6-8d18-4296-a2f8-f505b431080f.png">image</a></p>
<p>Which is the correct line number,</p>
<p>but try reversing the two requires, so that cucumber.js now looks like this</p>
<pre><code>module.exports = {
default: [
"--require ./somefile.ts",
"--require ./somefile2.ts",
"--require-module ts-node/register",
"--require features/****/**.ts",
"--publish-quiet",
].join(" "),
};
</code></pre>
<p>And now, <code>npm test</code> gives<br />
<a href="https://user-images.githubusercontent.com/1181438/259056141-30cb0ea1-7fbf-4135-bf6d-80181bc12de4.png">image</a></p>
<p>It points to the line 4, while I still expect the line 2.</p>
<p>Once again, it is in fact not the value in the transpiled javascript file, as you can see issuing the following command.</p>
<pre><code>$ npm exec tsc somefile2.ts &amp;&amp; cat -n somefile2.js | grep Error
6 throw new Error();
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-08-08 06:47:22
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2307#issuecomment-1669654659">Comment</a> on issue by <a href="https://github.com/Konubinix">Konubinix</a>
<p>After some digging, I realized that I can reproduce the issue with playwright alone, without cucumber. I guess this is not a cucumber issue after all, so I am closing this issue, in favor of <a href="https://github.com/microsoft/playwright/issues/26346">microsoft/playwright#26346</a>.</p>
<p>In any case, if someone can give me a hint about what to look into to fix this issue, I would be very welcome.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-08-08 10:19:19
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2308#issuecomment-1670013244">Comment</a> on issue by <a href="https://github.com/plocket">plocket</a>
<p>Having spent a while digging into our bug, I think it's cropping up because we're messing with internal properties of the scenario object in our <code>After()</code> - changing <code>scenario.result.status</code> to <code>FAILED</code> without adding a <code>scenario.result.message</code>. Not sure why that shows up as an error in the <code>Before()</code>. We shouldn't be messing with internal stuff, so I can understand why there isn't a built in message for this. I'll close this issue. That said, it's very confusing that something in <code>After()</code> is causing an <code>x</code> for <code>Before()</code>.</p>
<p>Again, appreciate all the work you folks are doing.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-08-08 11:21:57
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2308#issuecomment-1670093392">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>From what I can see there, your <code>After</code> hook didn't fail, the error came from the built-in summary formatter trying to summarise the failed scenario afterwards.</p>
<p>In general I would treat anything you're given by Cucumber that you didn't create yourself as immutable. This has actually highlighted that we should really enforce immutability on the parameter passed to these hooks, or at least <code>cloneDeep</code> it each time so mutations are moot. I'd recommend finding another way to influence the status e.g. throw from the <code>After</code> hook.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-08-09 04:38:24
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2308#issuecomment-1671164682">Comment</a> on issue by <a href="https://github.com/plocket">plocket</a>
<p>Thank you for that input. Throwing in <code>After()</code> might work for us.</p>
<p>As far as preventing future similar interference, as a developer I'd prefer inappropriate code manipulation to failed loudly instead of quietly. That is, using only <code>cloneDeep</code> would not tell me, as a developer, why my changes weren't taking effect. My changes would just disappear silently, which I would find confusing. I suppose it could be added to the documentation. Great idea to put explicit bumpers on undesirable behavior, though.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-08-08 06:06:05
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/1649#issuecomment-1669578922">Comment</a> on pull request by <a href="https://github.com/devexpert7">devexpert7</a>
<p>Is this fix available in latest release? Please share working code if available.<br />
I get same error<br />
npx cucumber-js<br />
Error: Cucumber expected a CommonJS module at '/Users/dev/features/support/support.js' but found an ES module.<br />
Either change the file to CommonJS syntax or use the --import directive instead of --require.</p>
<pre><code> Original error message: require() of ES Module /Users/dev/features/support/support.js from /Users/develop/node_modules/@cucumber/cucumber/lib/try_require.js not supported.
</code></pre>
<p>Instead change the require of support.js in /Users/dev/gitlab1/node<em>modules/@cucumber/cucumber/lib/try</em>require.js to a dynamic import() which is available in all CommonJS modules.<br />
at tryRequire (/Users/dev/gitlab1/node<em>modules/@cucumber/cucumber/lib/try</em>require.js:15:19)</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-08-08 21:42:47
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/1649#issuecomment-1670642001">Comment</a> on pull request by <a href="https://github.com/unional">unional</a>
<p>Hi, <a href="https://github.com/devexpert7">@devexpert7</a>,</p>
<p>Probably need more information about your project. Do you have <code>type: module</code> in your package json?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-08-14 15:45:19
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/1649#issuecomment-1678183608">Comment</a> on pull request by <a href="https://github.com/devexpert7">devexpert7</a>
<p>> Hi, <a href="https://github.com/devexpert7">@devexpert7</a>,
>
> Probably need more information about your project. Do you have <code>type: module</code> in your package json?</p>
<p>Yes <a href="https://github.com/unional">@unional</a> , I have <code>type: module</code> in your package json.<br />
I tried to fix this by adding configuration file cucumber.cjs ><br />
const common = {<br />
requireModule: [<br />
...(<br />
<a href="http://process.env.CI">process.env.CI</a> ? [] : ["chromedriver"]<br />
)<br />
],<br />
import: [<br />
"src/steps/**.ts",<br />
"src/steps",<br />
]<br />
}</p>
<p>module.exports = common<br />
....</p>
<p>getting below error now:</p>
<p>> my-dev@1.0.0 test-e2e-scenario<br />
> npm run cucumber -- features --name sayHello</p>
<p>> my-dev@1.0.0 cucumber<br />
> ts-node node-modules/@cucumber/cucumber/bin/cucumber.js -p default features --name sayHello</p>
<p>node:internal/modules/cjs/loader:1080<br />
throw err;<br />
^</p>
<p>Error: Cannot find module './cucumber.js'<br />
Require stack:</p>
<p>• /Users/project1/node-modules/@cucumber/cucumber/bin/imaginaryUncacheableRequireResolveScript<br />
at Module.<em>resolveFilename (node:internal/modules/cjs/loader:1077:15)<br />
at Function.resolve (node:internal/modules/cjs/helpers:127:19)<br />
at requireResolveNonCached (/Users/project1/node</em>modules/ts-node/dist/bin.js:549:16)<br />
at getProjectSearchDir (/Users/project1/node<em>modules/ts-node/dist/bin.js:519:40)<br />
at phase3 (/Users/project1/node</em>modules/ts-node/dist/bin.js:267:27)<br />
at bootstrap (/Users/project1/node<em>modules/ts-node/dist/bin.js:47:30)<br />
at main (/Users/project1/node</em>modules/ts-node/dist/bin.js:33:12)<br />
at Object. (/Users/project1/node<em>modules/ts-node/dist/bin.js:579:5)<br />
at Module.</em>compile (node:internal/modules/cjs/loader:1256:14)<br />
at Module.<em>extensions..js (node:internal/modules/cjs/loader:1310:10) {<br />
code: 'MODULE</em>NOT_FOUND',<br />
requireStack: [<br />
'/Users/project1/node-modules/@cucumber/cucumber/bin/imaginaryUncacheableRequireResolveScript'<br />
]<br />
}</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-09-06 04:26:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2309#issuecomment-1708160302">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>It's been <a href="https://github.com/cucumber/cucumber-ruby/pull/1669#issuecomment-1293742366">mentioned elsewhere</a> in the Cucumber universe that users will always want their own kind of control over retries and thus we should make it a programmatic extension point rather than adding a broad set of first-party options.</p>
<p>Some considerations:</p>
<p>• Existing retry options (on or off, number of retries, tag filter) would need to be respected but perhaps allow overriding in this extension point.
• We may ultimately break those options out to be a separate plugin using this extension point
• The retry concept has made it into the messages protocol <a href="https://github.com/cucumber/messages/blob/main/jsonschema/TestCaseFinished.json#L17-L19">as part of the <code>TestCaseFinished</code> message</a> - we should make sure any custom handling results in the correct value being emitted here</p>
<p>The first phase of the <a href="https://github.com/cucumber/cucumber-js/discussions/2091">plugins system</a> we're starting to work on will focus on coordinator stuff - filtering out scenarios etc. The next thing to look at will be runtime stuff and this may be a good first thing to tackle on that front.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-08-11 00:08:46
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2310#issuecomment-1674299319">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/61926340">Coverage Status</a></p>
<p>coverage: 98.505%. remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/1152b61241f992d081db11b9e7d74cbd31d657f4">1152b61</a> on florianmutter:florianmutter-patch-1</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/fcbeb440ee03203357d5effab48181ffd275bc31">fcbeb44</a> on cucumber:main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-08-11 01:12:15
*Thread Reply:*
Review approved by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/florianmutter">florianmutter's</a> pull request
<p>Thanks <a href="https://github.com/florianmutter">@florianmutter</a>, good catch.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-08-11 01:12:39
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2310#issuecomment-1674365783">Comment</a> on pull request by <a href="https://github.com/aslakhellesoy">aslakhellesoy</a>
<p>Hi <a href="https://github.com/florianmutter">@florianmutter</a>,</p>
<p>Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾</p>
<p>In return for this generous offer we hope you will:</p>
<p>• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our <a href="https://cucumber.io/conduct">code of conduct</a> in your interactions with other collaborators and users.
• 💬 Join the <a href="http://cucumber.io/support#slack">community Slack channel</a> to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!</p>
<p>On behalf of the Cucumber core team,<br />
Aslak Hellesøy<br />
Creator of Cucumber</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-08-12 05:45:50
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2310#issuecomment-1675896740">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Released in <a href="https://github.com/cucumber/cucumber-js/releases/tag/v9.4.0">https://github.com/cucumber/cucumber-js/releases/tag/v9.4.0</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-08-26 08:35:49
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2312#issuecomment-1694387045">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>This isn't something we'll support as an option I'm afraid - <code>pending</code> ties to a specific development workflow, but undefined or ambiguous steps are always considered a failure and that won't change.</p>
<p>You might be able to achieve something close to what you want be doing a separate <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/dry_run.md">dry run</a> for your non-automated feature to generate a JSON output you can work with. Ultimately though Cucumber is for running automated tests - if you want to produce reporting for non-automated feature files, that would be best served by a different tool.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-08-12 05:46:12
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2311#issuecomment-1675896895">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Released in <a href="https://github.com/cucumber/cucumber-js/releases/tag/v9.4.0">https://github.com/cucumber/cucumber-js/releases/tag/v9.4.0</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-08-20 15:28:23
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2313#issuecomment-1685412580">Comment</a> on issue by <a href="https://github.com/devexpert7">devexpert7</a>
<p>This was resolved using typescript/esm loader.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-08-14 18:47:52
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2298#issuecomment-1678313655">Comment</a> on issue by <a href="https://github.com/apps/github-actions">github-actions[bot]</a>
<p>This issue was closed because it has been stalled for 5 days with no activity.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-08-26 05:50:14
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2314#issuecomment-1694334169">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Step bodies can see <code>this.parameters</code>, but yeah <code>BeforeAll</code> is where you have a problem currently. I wouldn't be keen to have profiles (a means of managing configuration) accessible from steps (the execution layer where configuration should long have been resolved).</p>
<p>But <a href="https://github.com/cucumber/cucumber-js/issues/1393">#1393</a> should solve this, because it will make the world parameters available from those global hooks. There was a draft PR there which seems to have stalled; I'd suggest giving it a ping to see if it's abandoned, and if so that can be freely picked up.</p>
<p>In the meantime, I think the best workaround would be avoid the CLI and set some environment variables externally - you can then pick these up in your config file, hooks and steps (including on parallel workers).</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-08-20 17:21:25
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2315#issuecomment-1685440582">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/62099803">Coverage Status</a></p>
<p>coverage: 98.503% (+0.05%) from 98.456% when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/dbe49acf68269c4c2154bd8cd56b15fcba68bfe5">dbe49ac</a> on yusuke-noda:fix-2178-format-option-splitter</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/85b1e5ed13d73d037d39641399f3fdff66faa023">85b1e5e</a> on cucumber:main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-09-06 02:48:04
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2315#issuecomment-1708022985">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Thanks for doing this <a href="https://github.com/yusuke-noda">@yusuke-noda</a>!</p>
<p>Relatedly, I <a href="https://github.com/cucumber/cucumber-js/pull/2318">released a change</a> with 9.5.1 so that in a config file you can provide a two-item array directly instead of a single string to avoid the ambiguity of the splitting. But of course we'll still always need the splitting logic for the CLI.</p>
<p>I'll fully review and merge this shortly. Before releasing I might also add some deprecation warnings, because what I'd like to do long term is enforce quoting either side of the string if it contains colons, so we don't have to do such clever splitting with awareness of all the platform quirks.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-08-25 08:43:45
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2174#issuecomment-1693563236">Comment</a> on issue by <a href="https://github.com/Ugzuzg">Ugzuzg</a>
<p><a href="https://github.com/davidjgoss">@davidjgoss</a>, the instrumentation was released 11 days ago.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-08-26 18:49:13
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2302#issuecomment-1694544593">Comment</a> on issue by <a href="https://github.com/apps/github-actions">github-actions[bot]</a>
<p>This issue was closed because it has been stalled for 5 days with no activity.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-08-31 09:21:47
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2317#issuecomment-1701355469">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Thanks for raising this <a href="https://github.com/laorient">@laorient</a>. You're right that it's a bit confusing as it is. The reason we don't always include <code>default</code> is because that's the default profile and you can have other profiles, and also for config files in ES Module format that use named exports it wouldn't be applicable.</p>
<p>I'll try to come up with a pattern to express it more clearly and roll that out.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-09-01 07:52:36
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/1393#issuecomment-1702881470">Comment</a> on issue by <a href="https://github.com/Antoine-Regembal">Antoine-Regembal</a>
<p>Also interested for this improvement 👍</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-09-01 12:46:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/1393#issuecomment-1703247640">Comment</a> on issue by <a href="https://github.com/michael-lloyd-morris">michael-lloyd-morris</a>
<p>I'm going to begin work on this next week. I presume that this will need to be version 10 because if someone does a return from a BeforeAll (why they should I have no idea) it is bc break. Also, as a precaution I need to make sure BeforeAll hooks resolve sequentially so that all their changes get applied. The order should not be important, but if someone needs the beforeAll hooks to resolve in the same order that would also be a break.</p>
<p>Also, we might wish to consider having a hook that specifically does this behavior and leave BeforeAll alone. In otherwise, a Setup hook. If that's the route chosen I would advise specifying the following:</p>
<ol><li>Only one Setup hook allowed - trying to declare a second one pitches an error</li><li>Setup MUST return worldParameters</li>
</ol>
<p>Either approach is fine by me, but I'd like input as to which approach to take.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-09-01 16:11:38
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/1393#issuecomment-1703452217">Comment</a> on issue by <a href="https://github.com/mattwynne">mattwynne</a>
<p>NB that the PR <a href="https://github.com/cucumber/cucumber-js/pull/1770">#1770</a> is very close to complete, I was supporting <a href="https://github.com/BlueMona">@BlueMona</a> with it but I'm not sure if she has capacity / inclination to finish it, perhaps someone else would like to take that on.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-09-03 00:21:52
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2320#issuecomment-1704034256">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>The way to access things like attachments, especially for a reporting use case, is to <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/custom_formatters.md">write a formatter</a>.</p>
<p>That said, if you really want to get at attachments in an <code>After</code> hook, consider <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/support_files/world.md">implementing a custom world class</a> where you can provide your own <code>attach</code> method that wraps the normal one and adds to an array that you can access from the hook later.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-09-01 16:12:10
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/1770#issuecomment-1703453371">Comment</a> on pull request by <a href="https://github.com/mattwynne">mattwynne</a>
<p><a href="https://github.com/BlueMona">@BlueMona</a> ping me if you want to pair on finishing this off. I'm here to help if you want it.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-09-02 04:17:13
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/1770#issuecomment-1703804698">Comment</a> on pull request by <a href="https://github.com/BlueMona">BlueMona</a>
<p>Let’s do it this week then!</p>
<p><#|…></p>
<p>On Fri, Sep 1, 2023 at 7:12 PM Matt Wynne <strong><em>*</strong>@<strong></em><em></strong>.<strong></em><em></strong>> wrote: <a href="https://github.com/BlueMona">@BlueMona</a> <<a href="https://github.com/BlueMona">https://github.com/BlueMona</a>> ping me if you want to pair on finishing this off. I'm here to help if you want it. — Reply to this email directly, view it on GitHub <<a href="https://github.com/cucumber/cucumber-js/pull/1770#issuecomment-1703453371">#1770 (comment)</a>>, or unsubscribe <<a href="https://github.com/notifications/unsubscribe-auth/AALHLMFA6QMHT7NFI4FZ5RDXYJTVFANCNFSM5CKQKM3Q">https://github.com/notifications/unsubscribe-auth/AALHLMFA6QMHT7NFI4FZ5RDXYJTVFANCNFSM5CKQKM3Q</a>> . You are receiving this because you were mentioned.Message ID: <strong></em><em></strong>@<strong></em><em></strong>.<strong></em>*</strong>></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-09-02 07:18:09
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/1770#issuecomment-1703846277">Comment</a> on pull request by <a href="https://github.com/mattwynne">mattwynne</a>
<p>> Let’s do it this week then!<br />
> <#|…></p>
<p><a href="https://github.com/BlueMona">@BlueMona</a> great!</p>
<p>Can you use <a href="https://calendly.com/mattwynne">https://calendly.com/mattwynne</a> to book a slot?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-09-03 00:28:34
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2321#issuecomment-1704035539">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Thanks <a href="https://github.com/tamil777selvan">@tamil777selvan</a>, good catch. I can see the issue and will do something for this now.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-09-03 11:10:11
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2321#issuecomment-1704366341">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Released in <a href="https://github.com/cucumber/cucumber-js/releases/tag/v9.5.0">https://github.com/cucumber/cucumber-js/releases/tag/v9.5.0</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-09-06 02:54:22
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2323#issuecomment-1708032230">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Noting that the Nightwatch issue was <a href="https://github.com/nightwatchjs/nightwatch/issues/3861#issuecomment-1695197874">closed with a fix suggestion</a>, so also closing this issue.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-09-06 02:57:51
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2253#issuecomment-1708037257">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>A quick update on this: I think the best approach will be to announce our intention to make this change (see <a href="https://github.com/cucumber/cucumber-js/issues/3">#3</a> from my <a href="https://github.com/cucumber/cucumber-js/issues/2253#issuecomment-1459342972">earlier comment</a>) by emitting a deprecation warning if you provide path(s) on the CLI that are merged into config. We can see if there is any pushback from the community with genuine use cases for having it merge instead of overwrite.</p>
<p>(Also thanks <a href="https://github.com/aleksdobrev">@aleksdobrev</a>, some smart workarounds there.)</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-09-08 06:46:03
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2326#issuecomment-1711701382">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Hey <a href="https://github.com/tamil777selvan">@tamil777selvan</a>. There is a change in the works to improve the parsing here.</p>
<p>But also, you should be able to wrap the value in an array and Cucumber will not attempt to split it. So like:</p>
<pre><code>format: [ [ 'file:///c:/reporter.js' ] ]
</code></pre>
<p>(It also supports a second item in the array to denote the target file, but from what I know of your use case that's not needed.)</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-09-10 09:03:05
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2326#issuecomment-1712850418">Comment</a> on issue by <a href="https://github.com/tamil777selvan">tamil777selvan</a>
<p>Thank you, <a href="https://github.com/davidjgoss">@davidjgoss</a>. The solution provided above solved the issue. I will close this now.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-09-28 02:51:04
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2327#issuecomment-1738834181">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Hey <a href="https://github.com/tamil777selvan">@tamil777selvan</a>, sorry for the late reply.</p>
<p>The support code loading for parallel is...a bit weird. We load it on the coordinator (from where we emit the <a href="https://github.com/cucumber/messages/blob/main/jsonschema/StepDefinition.json">messages</a> about it) and then again on each worker (where the tests are actually going to be run). There's then a kind of sync process so they share the same ids in all places.</p>
<p>So if you jump in via the builder and add a hook on the coordinator only, there'll be a mismatch and thing will break in the way that you've seen.</p>
<p>I'm sure we can figure out a solution though. One of the things I've been looking at under the umbrella of <a href="https://github.com/cucumber/cucumber-js/discussions/2091">Plugins</a> is an extension point to prepend/append steps and hooks separate to the normal support code loading cycle. Also though, there might be other ways you can inject the behaviour you want besides a hook.</p>
<p>Can you say a bit more about the use case that's driving this?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-09-29 20:14:00
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2327#issuecomment-1741643190">Comment</a> on issue by <a href="https://github.com/tamil777selvan">tamil777selvan</a>
<p>Hi <a href="https://github.com/davidjgoss">@davidjgoss</a>,</p>
<p>This scenario is particularly relevant when integrating <a href="https://github.com/webdriverio/webdriverio/issues/11101">WebdriverIO with Cucumber's parallel</a> execution mechanism. When parallel execution is enabled, the WebdriverIO hooks invoked are not processed within the parallel coordinator, resulting in the observed issue.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-16 13:29:07
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2327#issuecomment-1765222460">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>> the WebdriverIO hooks invoked</p>
<p>Could you say a bit more about what these hooks do? i.e. is it user-authored code, or more like wdio plumbing? If you were to put them in a file and add it to the <code>require</code> option, would that break in some way?</p>
<p>(I suspect there is some overlap with <a href="https://github.com/cucumber/cucumber-js/issues/2156">#2156</a> here.)</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-19 00:37:16
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2327#issuecomment-1770236192">Comment</a> on issue by <a href="https://github.com/tamil777selvan">tamil777selvan</a>
<p><a href="https://github.com/davidjgoss">@davidjgoss</a>, these codes are provided by users and are integrated into Cucumber hooks through the support code library within the <code>wdio-cucumber-framework</code>. Even if we attempt to isolate this hook in a separate file and import it, it may not function as expected. The reason for this is that WebDriverIO hooks have their own names, and these names are internally mapped to corresponding Cucumber hooks.</p>
<p>For example, the <code>beforeScenario</code> WebDriverIO hook aligns with the <code>before</code> Cucumber hook.</p>
<p>This seems quite similar to the previous issue, as both cases involve the need to load custom hooks for parallel execution.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-09-23 02:17:57
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2328#issuecomment-1732263284">Comment</a> on issue by <a href="https://github.com/badeball">badeball</a>
<p><a href="https://github.com/badeball/cypress-cucumber-preprocessor/issues/1100#issuecomment-1732050611">badeball/cypress-cucumber-preprocessor#1100 (comment)</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-09-24 10:37:27
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2328#issuecomment-1732627314">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>As <a href="https://github.com/badeball">@badeball</a> hinted in the other issue, the cucumber-js option is <code>--publish</code>, and positional arguments refer to features.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-08 00:09:45
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2332#issuecomment-1751944014">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Closing as you got the right pointers on the Slack thread <a href="https://cucumberbdd.slack.com/archives/C60TKS3SL/p1696091351991659">https://cucumberbdd.slack.com/archives/C60TKS3SL/p1696091351991659</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-03 10:42:08
*Thread Reply:*
Review approved by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/yusuke-noda">yusuke-noda's</a> pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-04 01:32:01
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2315#issuecomment-1746393128">Comment</a> on pull request by <a href="https://github.com/aslakhellesoy">aslakhellesoy</a>
<p>Hi <a href="https://github.com/yusuke-noda">@yusuke-noda</a>,</p>
<p>Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾</p>
<p>In return for this generous offer we hope you will:</p>
<p>• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our <a href="https://cucumber.io/conduct">code of conduct</a> in your interactions with other collaborators and users.
• 💬 Join the <a href="http://cucumber.io/support#slack">community Slack channel</a> to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!</p>
<p>On behalf of the Cucumber core team,<br />
Aslak Hellesøy<br />
Creator of Cucumber</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-07 01:41:59
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2315#issuecomment-1751653100">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Released in <a href="https://github.com/cucumber/cucumber-js/releases/tag/v9.6.0">https://github.com/cucumber/cucumber-js/releases/tag/v9.6.0</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-07 09:19:54
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2040#issuecomment-1751749508">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>I took a quick run at this today and found it difficult given how spread out our code and types for user code is, with <code>SupportCodeLibraryBuilder</code> etc. It might be one to return to once we've had a chance to simplify that area a bit.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-07 10:06:54
*Thread Reply:*
Review approved by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/badeball">badeball's</a> pull request
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-09 08:11:24
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2260#issuecomment-1753196027">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Released in <a href="https://github.com/cucumber/cucumber-js/releases/tag/v10.0.0">https://github.com/cucumber/cucumber-js/releases/tag/v10.0.0</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-07 10:15:25
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2263#issuecomment-1751774028">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Noting that this would, as it stands, break the parallel runtime because that depends on support code being registered in a consistent order across coordinator and workers. We'll need to try and find another way around that in order to go ahead with this change.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-10 10:13:07
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2338#issuecomment-1755896663">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Can you show what's in the <code>package.json</code> under <code>/Users/../node_modules/@privateModule</code> - that will be what's used to determine whether the file is in a module context or not. If it doesn't have <code>"type": "module"</code> then Node.js would not expect to encounter <code>import</code> statements so that error would be expected.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-10 10:39:55
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2338#issuecomment-1755931895">Comment</a> on issue by <a href="https://github.com/zoiman">zoiman</a>
<p>> Can you show what's in the <code>package.json</code> under <code>/Users/../node_modules/@privateModule</code> - that will be what's used to determine whether the file is in a module context or not. If it doesn't have <code>"type": "module"</code> then Node.js would not expect to encounter <code>import</code> statements so that error would be expected.</p>
<p>I updated the question.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-19 10:15:12
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2338#issuecomment-1771403901">Comment</a> on issue by <a href="https://github.com/pk">pk</a>
<p>I may be wrong here but:</p>
<p>I'm not familiar with Babel, however is the root package.json also having <code>type</code> set to module? If so then the ESM environment would be expected and therefore the:<br />
<code>'--require src/step-definitions/****/**.ts', // Load step definitions</code></p>
<p>Should be changed to <code>--import</code>. I've been fighting with the ESM/CommonJS interoperability for some time and resorted to use ESM in all the test suites.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-23 00:52:19
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2338#issuecomment-1774619309">Comment</a> on issue by <a href="https://github.com/zoiman">zoiman</a>
<p>no in the root <code>package.json</code> there is not <code>type</code> defined</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-23 02:50:50
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2338#issuecomment-1774825063">Comment</a> on issue by <a href="https://github.com/pk">pk</a>
<p>Would that not mean, in that case that it defaults to CommonJS modules. Therefore the root package will require loading the support code with <code>require</code> while child packages will be ESM, needing <code>import</code>....</p>
<p>I had (maybe not the same issue) with our E2E where Angular dropped CommonJS support. As Angular was dependency requiring the ESM I had to make our E2E test suite also ESM in order to make everything work reasonably smoothly.</p>
<p>I may be wrong, of course.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-23 03:55:20
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2338#issuecomment-1774936995">Comment</a> on issue by <a href="https://github.com/zoiman">zoiman</a>
<p>so you mean I should use <code>--import</code> in my <code>cucumber.js</code> ?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-24 13:45:35
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2338#issuecomment-1778009793">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Based on the config you have provided, your TypeScript code will be compiled down to CommonJS, meaning although you write <code>import {foo} from './foo.js'</code> this will compile down to <code>const {foo} = require('./foo.js')</code> (you should be able to validate by doing <code>tsc</code> and viewing the compiled JS). This is probably okay until you try to bring in something that is a native ES module, like perhaps one of your private libraries. You can't <code>require</code> an ES module because <code>require</code> is sync and modules are async, so that will fail. It's surprising to see it manifest as a syntax error like that though, so it does seem like something else is going on there.</p>
<p>The thing I'd recommend you try is to change your tsconfig to emit ES modules (see docs for <code>compilerOptions.module</code>) and then use Cucumber's <code>--import</code> option along with ts-node's ESM loader (via <code>NODE_OPTIONS</code>, see <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/esm.md#transpiling">this doc</a>) instead of <code>--require</code> and <code>--require-module</code> respectively.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-25 00:40:10
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2338#issuecomment-1778691412">Comment</a> on issue by <a href="https://github.com/zoiman">zoiman</a>
<p>thank you for your help, just a quick follow up question:<br />
those modules where I want to import stuff either its from a component or from a private module all have this tsconfig:<br />
<a href="https://www.npmjs.com/package/@tsconfig/node18">https://www.npmjs.com/package/@tsconfig/node18</a></p>
<p>So actually <em>everything</em> is commonjs or am I wrong?</p>
<p>and by changeing my tsconfig you mean <em>all</em> tsconfigs of all modules or just the one where my cucumber tests are running?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-25 05:36:03
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2338#issuecomment-1779178933">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>AFAIK <code>esModuleInterop</code> is meant to deal with inconsistencies around default imports rather than the module format.</p>
<p>It would be good to add a <a href="https://stackoverflow.com/help/minimal-reproducible-example">minimal reproducible example</a> to work against here.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-25 07:35:47
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2338#issuecomment-1779424598">Comment</a> on issue by <a href="https://github.com/zoiman">zoiman</a>
<p>I have no clue how to make a minimal reproducible example since this happens only when I import from a private module.</p>
<p>But I found out when I import a const <code>MYCONST</code> from <code>@mycompany/constants/myconst</code> then I will get the above error from the first <code>import</code> of <code>myconst.js</code> which is <code>import {fu} from</code> ../bar/fu`</p>
<p>but when I then try to import <code>fu</code> directly in my steps I get this error:</p>
<pre><code>Error: Cucumber expected a CommonJS module at '/Users/.../servicetest/src/step-definitions/mysteps.steps.ts' but found an ES module.
Either change the file to CommonJS syntax or use the --import directive instead of --require.
</code></pre>
<p>so maybe switching my test component to ESmodule might do the trick?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-26 02:52:35
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2338#issuecomment-1780787434">Comment</a> on issue by <a href="https://github.com/zoiman">zoiman</a>
<p>I now managed to switch to ES modules but I am facing the same issue. However I now have a clearer picture what is causing the issue.</p>
<p>There are two private npm packages where <code>packageA</code> has <code>type:commonjs</code> in the <code>package.json</code> and <code>packageB</code> which is imported in <code>packageA</code> has <code>type:module</code> in the <code>package.json</code></p>
<pre><code>@mycompany/packageA/schema. // commonjs
@mycompany/packageB/valueObjects. // module
</code></pre>
<p>so when I import something from packageA in my step like this:</p>
<pre><code>import pkg from `@mycompany/packageA/schema/someSchema/index.js`
const {MYSCHEMA} = pkg
const foo = MYSCHEMA
</code></pre>
<p>I get the following error:</p>
<pre><code>import { SOMEVALUEOBJECT } from '@mycomany/packageB/value-objects';
^^^^^^
SyntaxError: Cannot use import statement outside a module
</code></pre>
<p>this is how my <code>tsconfig.json</code> now looks like:</p>
<pre><code>{
"extends": "../../tsconfig.json",
"compilerOptions": {
"allowImportingTsExtensions": true,
"module": "es2022",
"target": "es2021",
"moduleResolution": "node",
"esModuleInterop": true,
"forceConsistentCasingInFileNames": true,
"allowSyntheticDefaultImports": true,
"resolveJsonModule": true,
"experimentalDecorators": true,
"emitDecoratorMetadata": true,
"sourceMap": true,
"baseUrl": ".",
},
}
</code></pre>
<p>and this is how I start my test:<br />
<code>"test:e2e": "NODE_OPTIONS=\"--loader ts-node/esm\" cucumber-js -p default",</code></p>
<p>I am sorry for this mess, but I have no idea how to fix this.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-27 01:10:16
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2338#issuecomment-1782486827">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>I think I can now say with confidence this isn't a Cucumber issue, and your setup for your main project seems good to me.</p>
<p>Your issue seems to be in package A, where Node.js is throwing the error because it encounters an <code>import</code> statement in what it expects to be CommonJS code. I'd suggest you need to either change the <code>type</code> to <code>module</code> in your <code>package.json</code> there, or change the code to be CommonJS format to match what the package declares.</p>
<p>It might save you some time to isolate this from Cucumber - perhaps add a file <code>test.mjs</code> to your main package that just imports package A, and run with <code>node ./test.mjs</code>.</p>
<p>I'm going to close this now as it's not an issue with Cucumber, but feel free to take this into a thread <a href="https://communityinviter.com/apps/cucumberbdd/docs-page">on Slack</a>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-11 01:29:45
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2339#issuecomment-1757119991">Comment</a> on issue by <a href="https://github.com/jfstephe">jfstephe</a>
<p>Also, FYI this was on node 18.14.2</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-11 03:16:09
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2339#issuecomment-1757332554">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>This is not something we'll have documentation for in cucumber-js - event just the React ecosystem has virtually infinite different combinations of structure and dependencies, all of which is a moving target, even before we get to any other ecosystems.</p>
<p>Happy to look at adding a basic example to <a href="https://github.com/cucumber/cucumber-js-examples">https://github.com/cucumber/cucumber-js-examples</a> though.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-11 16:18:05
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2339#issuecomment-1758676646">Comment</a> on issue by <a href="https://github.com/jfstephe">jfstephe</a>
<p>Sure. I get where you are coming from. I think it's probably a simpler set of combinations though. (happy to be wrong)</p>
<p>For example cucumber can be used client or server side. Assuming the project under development is either commonjs or esm, it could have commonjs and/or esm dependencies.</p>
<p>I just don't think (and I'd be very happy to be wrong here) that babel and ts-node for example can work in all those scenarios.</p>
<p>Having some guidance to say, in the scenario of client side Esm project using both commonjs and esm dependencies, to say use TSX and here's a config we know works would be super useful.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-11 16:22:56
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2339#issuecomment-1758682463">Comment</a> on issue by <a href="https://github.com/jfstephe">jfstephe</a>
<p>The cucumber typescript example you linked to is a perfect example of something that works some of the time, but not all of the time for different dependencies. Finding that out leaves you a bit blind sided, and then you have to embark on a nightmare of, in our case, about 10 days dev time to sort out. We came close to giving up on cucumber as a result.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-15 08:34:08
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/718#issuecomment-1763425778">Comment</a> on issue by <a href="https://github.com/grf1986">grf1986</a>
<p>Hi all i am having the same issue i did all there has been done here my setup:<br />
project: setup playwright with typescript and cucumber in VScode<br />
issue: i can navigate to stepdefinitions from feature file but when running test with npx cucumber-js src\tests\features<br />
i get:</p>
<p><code>1 scenario (1 undefined) 4 steps (4 undefined) 0m00.000s</code></p>
<p>running test without cucumber work fine</p>
<p>.vscode/settings.json:</p>
<p><code>{ "cucumberautocomplete.steps": [ "****/**.steps.ts", ], "cucumberautocomplete.syncfeatures": "****/.**feature .ts", "cucumberautocomplete.strictGherkinCompletion": true, "cucumberautocomplete.strictGherkinValidation": true, "cucumberautocomplete.smartSnippets": true, "cucumberautocomplete.stepsInvariants": true, "cucumberautocomplete.customParameters": [ { "parameter": "{ab}", "value": "(a|b)" }, ], "cucumberautocomplete.pages": { "users": "features/**.ts", "pathes": "features/**.ts", "main": "features/**.ts", }, "cucumberautocomplete.skipDocStringsFormat": true, "cucumberautocomplete.formatConfOverride": { "And": 3, "But": "relative", }, "cucumberautocomplete.onTypeFormat": true, "editor.quickSuggestions": { "comments": false, "strings": true, "other": true }, "cucumberautocomplete.gherkinDefinitionPart": "(Given|When|Then)\\(", "cucumberautocomplete.stepRegExSymbol": "'" }</code></p>
<p>feature file:</p>
<p>`Feature:Check user is on the right page</p>
<p>as a user<br />
I want to log in to the AppFactoryApp application<br />
and navigate to the aanvragen app<br />
so i can check if i am on the right page</p>
<p>Scenario:Check if user is on the right page<br />
Given Go to AppFactoryApp app page<br />
When Login to AppFactoryApp test env<br />
When Click on aanvragen app<br />
Then Check that user is on the right page<br />
`</p>
<p>glue code aka steps.definations:</p>
<p>`import { Given, When, Then } from "@cucumber/cucumber";<br />
import { test } from "../pageObjects";<br />
import { expect } from "@playwright/test";<br />
import { GoToApp } from "../helpers/goToApp";<br />
import { baseURL } from "../generic/utils/environment.properties";</p>
<p>const gotoApp = new GoToApp();</p>
<p>test.describe.parallel('Navigate to aanvragen app from Appfactory', async () => {<br />
test('check if user is on the right page', async ({ AppFactory, page, context }) => {</p>
<pre><code> Given('Go to AppFactoryApp app page', async () =&gt; {
await gotoApp.AppFactoryAppsUrl(page);
});
When('Login to AppFactoryApp test env', async () =&gt; {
await AppFactory.loginPage.LoginToAppFactory('rgga', 'rggdrg!');
});
When('Click on aanvragen app', async () =&gt; {
await AppFactory.selectAppPage.ClickOnAanvragenApp();
});
Then('Check that user is on the right page', async () =&gt; {
const pages = context.pages();
if (pages.length &gt;= 2) {
const aanvragenapp = pages[1];
expect(aanvragenapp.url()).toContain(baseURL.AanvragenApp);
}
});
})
</code></pre>
<p>});</p>
<p>Package.json:<br />
<code>{ "name": "playwright", "version": "1.0.0", "description": "", "main": "index.js", "scripts": { "test": "cucumber-js test" }, "keywords": [], "author": "XXXXXX", "license": "ISC", "devDependencies": { "@cucumber/cucumber": "^10.0.0", "@cucumber/messages": "^22.0.0", "@playwright/test": "^1.39.0", "@types/jquery": "^3.5.22", "@types/node": "^20.8.0", "cucumber": "^1.3.3", "playwright-cucumber": "^1.0.15", "ts-node": "^10.9.1", "typescript": "^5.2.2", "winston": "^3.8.2" }, "dependencies": { "playwright": "^1.39.0" } }</code></p>
<p>i am using VSCode plugins see screenshots:<br />
<a href="https://user-images.githubusercontent.com/10376868/275335673-0852fd9c-9921-4df5-8458-965a6332e063.png">VS code plugins</a></p>
<p>project structure:</p>
<p><a href="https://user-images.githubusercontent.com/10376868/275335835-2ad7ba65-62e8-46cf-95c4-4da51c335b8a.png">project structure</a></p>
<p>please help me i have stayed 48 hours on this issue :(</p>
<p>`</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-16 13:39:48
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2340#issuecomment-1765236163">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Thanks for all the detail <a href="https://github.com/grf1986">@grf1986</a></p>
<p>The problem you have here is that both Cucumber and <code>@playwright/test</code> are test runners, and you can only really use one test runner at a time. In your step definitions file, the only top-level calls are to <code>test</code> that is imported from your other file. It's not clear what that function does, but I suspect it doesn't just run whatever function you passed in, meaning the step definitions won't be registered with Cucumber. Conversely, if you run <code>@playwright/test</code>, perhaps your calls to <code>test</code> cause a test suite/case to run, but since Cucumber is not actually running at that point, the calls to <code>Given</code> etc won't do anything.</p>
<p>I would suggest you want to use Cucumber as your test runner but still use Playwright as your browser automation tool - this is fine. Try to remove the <code>test</code> wrappers and just have your calls to <code>Given</code> etc at the root of your step definitions file. If you then run Cucumber it should at least match and run the steps. Be careful using <code>expect</code> from Playwright, as I think it is a kind of soft assertion and doesn't throw directly (which Cucumber would need in order to recognise a failure).</p>
<p>> i can navigate to stepdefinitions from feature file but when running test</p>
<p>In case you're wondering why this works, the various editor plugins tend not to hook into Cucumber directly but use a fairly loose algorithm of looking for calls to functions called <code>Given</code> etc, so they show up even when mixing frameworks etc.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-17 02:22:10
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2340#issuecomment-1766019176">Comment</a> on issue by <a href="https://github.com/grf1986">grf1986</a>
<p>can you please give me a example i am new to this</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-17 02:45:02
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2340#issuecomment-1766058400">Comment</a> on issue by <a href="https://github.com/grf1986">grf1986</a>
<p>i did the following:</p>
<p>`import { Given, When, Then } from "@cucumber/cucumber";<br />
import { test } from "../pageObjects";<br />
import { expect } from "@playwright/test";<br />
import { GoToApp } from "../helpers/goToApp";<br />
import { baseURL } from "../generic/utils/environment.properties";</p>
<p>import { TestCase } from "@cucumber/messages";</p>
<p>Given('Navigate to aanvragen app from Appfactory', async function () {<br />
Given('Check if user is on the right page', async function ({ AppFactory, page, context }) {<br />
const gotoApp = new GoToApp(page);</p>
<pre><code> Given('Go to AppFactoryApp app page', async function () {
await gotoApp.AppFactoryAppsUrl(page);
});
When('Login to AppFactoryApp test env', async () =&gt; {
await AppFactory.loginPage.LoginToAppFactory('XXXXX', 'XXXXX');
});
When('Click on aanvragen app', async () =&gt; {
await AppFactory.selectAppPage.ClickOnAanvragenApp();
});
Then('Check that user is on the right page', async () =&gt; {
const pages = context.pages();
if (pages.length &gt;= 2) {
const aanvragenapp = pages[1];
expect(aanvragenapp.url()).toContain(baseURL.AanvragenApp);
}
});
})
</code></pre>
<p>});`</p>
<p>Is this what you mean?</p>
<p>output:</p>
<p>`Warnings:</p>
<ol><li><p>Scenario: Check if user is on the right page # src\tests\features\login.feature:8<br />
? Given Navigate to aanvragen app from Appfactory<br />
Undefined. Implement with the following snippet:</p>
<pre><code> Given('Navigate to aanvragen app from Appfactory', function () {
// Write code here that turns the phrase above into concrete actions
return 'pending';
});
</code></pre>
<p>? Given Check if user is on the right page<br />
Undefined. Implement with the following snippet:</p>
<pre><code> Given('Check if user is on the right page', function () {
// Write code here that turns the phrase above into concrete actions
return 'pending';
});
</code></pre>
<p>? Given Go to AppFactoryApp app page<br />
Undefined. Implement with the following snippet:</p>
<pre><code> Given('Go to AppFactoryApp app page', function () {
// Write code here that turns the phrase above into concrete actions
return 'pending';
});
</code></pre>
<p>? When Login to AppFactoryApp test env<br />
Undefined. Implement with the following snippet:</p>
<pre><code> When('Login to AppFactoryApp test env', function () {
// Write code here that turns the phrase above into concrete actions
return 'pending';
});
</code></pre>
<p>? When Click on aanvragen app<br />
Undefined. Implement with the following snippet:</p>
<pre><code> When('Click on aanvragen app', function () {
// Write code here that turns the phrase above into concrete actions
return 'pending';
});
</code></pre>
<p>? Then Check that user is on the right page<br />
Undefined. Implement with the following snippet:</p>
<pre><code> Then('Check that user is on the right page', function () {
// Write code here that turns the phrase above into concrete actions
return 'pending';
});
</code></pre></li>
</ol>
<p>1 scenario (1 undefined)<br />
6 steps (6 undefined)<br />
0m00.000s`</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-19 09:34:51
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2340#issuecomment-1771344645">Comment</a> on issue by <a href="https://github.com/pk">pk</a>
<p>That means that Cucumber does not see your step definitions. Most likely you need amend configuration of the Cucumber and tell it where to look for the <code>support</code> code and your steps.</p>
<p>You have Feature files and Step definition files. Cucumber needs to know locations of both and you do that using configuration file.</p>
<p>All is well documented here:<br />
<a href="https://github.com/cucumber/cucumber-js/blob/main/docs/configuration.md">https://github.com/cucumber/cucumber-js/blob/main/docs/configuration.md</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-19 09:56:50
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2340#issuecomment-1771378389">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>You can also try enabling debug mode so you get some feedback about your config and what it finds (or doesn't find) <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/debugging.md">https://github.com/cucumber/cucumber-js/blob/main/docs/debugging.md</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-11-10 23:28:54
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2340#issuecomment-1806730937">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Closing as not an issue with Cucumber.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-16 13:51:51
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2341#issuecomment-1765255528">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Thanks for the high-quality MRE repo <a href="https://github.com/artinalbert">@artinalbert</a>, much appreciated!</p>
<p>The problem with running Cucumber several times in the same Node.js process is that after the first time all the step/support code files are loaded, they are cached by the module loader, so if they are requested a second time (by the next run) there'll be no error but the code is not executed again and so the steps are not registered.</p>
<p>To deal with this we have a function called <code>loadSupport</code> where you load the support code once upfront and can then reuse it on multiple calls to <code>runCucumber</code> in the same process.</p>
<p>I raised a PR against your repo which now passes <a href="https://github.com/artinalbert/cucumber-in-loop-minimum-viable-example/pull/1">artinalbert/cucumber-in-loop-minimum-viable-example#1</a> - hope it makes sense, let me know if you have any questions.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-17 09:50:50
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2341#issuecomment-1766805613">Comment</a> on issue by <a href="https://github.com/artinalbert">artinalbert</a>
<p>Thank you for the quick response and the PR that made it clear!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-17 07:11:12
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2342#issuecomment-1766503048">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>The pretty formatter doesn't yet support outputting the hook names - I'll transfer this issue there.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-19 10:21:01
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2343#issuecomment-1771411889">Comment</a> on issue by <a href="https://github.com/pk">pk</a>
<p>I've been going through the open issues and I'm not sure if this one is relevant or not to my use case: <a href="https://github.com/cucumber/cucumber-js/issues/2253">#2253</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-19 10:29:17
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2343#issuecomment-1771423022">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Thanks for raising <a href="https://github.com/pk">@pk</a>. I think this has come from the upgrade to the latest <code>glob</code> which we did before the 10.0.0 release and included some changes to ordering which we had to adapt. I'll take a look and see what we can do to fix.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-19 10:46:38
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2343#issuecomment-1771447418">Comment</a> on issue by <a href="https://github.com/pk">pk</a>
<p><a href="https://github.com/davidjgoss">@davidjgoss</a> I had to revert to @cucumber/cucumber@9.6.0 to have the (my) expected behaviour. Which I think is the latest 9x release, right?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-20 12:28:34
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2343#issuecomment-1773288786">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p><a href="https://github.com/pk">@pk</a> that's right yes.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-20 23:07:38
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2343#issuecomment-1773687614">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Released in <a href="https://github.com/cucumber/cucumber-js/releases/tag/v10.0.1">https://github.com/cucumber/cucumber-js/releases/tag/v10.0.1</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-23 01:52:15
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2343#issuecomment-1774721747">Comment</a> on issue by <a href="https://github.com/pk">pk</a>
<p>Hi <a href="https://github.com/davidjgoss">@davidjgoss</a> , thank you for the quick fix and release.<br />
We confirm the fix works, at least for our scenario.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-20 01:07:26
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2344#issuecomment-1772274892">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/63427281">Coverage Status</a></p>
<p>coverage: 97.834%. remained the same when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/3622327e183a754010a49a74bdceb6263bdc99e8">3622327</a> on dependabot/npm<em>and</em>yarn/babel/traverse-7.23.2</strong> into <strong><a href="https://github.com/cucumber/cucumber-js/commit/842099b87b6d689c2a45f13c820fd382108346a8">842099b</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-24 13:22:16
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2346#issuecomment-1777977563">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<https://github.com/cucumber/cucumber-js/issues/2346|#2346 Support for Node.js Built-in `.env` File>
<p>Thanks for raising <a href="https://github.com/x80486">@x80486</a>, I hadn't heard about the built-in <code>.env</code> support yet (<a href="https://nodejs.org/en/blog/release/v20.6.0#built-in-env-file-support">https://nodejs.org/en/blog/release/v20.6.0#built-in-env-file-support</a> for reference).</p>
<p>However, to have an <code>envFile</code> or similar configuration key in Cucumber , we'd be <em>replicating</em> this functionality rather than leaning into what Node.js now provides. As I understand it, you could do this today without any changes:</p>
<pre><code>NODE_OPTIONS="--env-file=.env" npx cucumber-js
</code></pre>
<p>(I think this could be unergonomic in practise for users, because Cucumber only allows its own configuration to be set in files or the CLI. If we were to add support for configuration via environment variables, you could control everything - Cucumber stuff and non-Cucumber stuff - via a <code>.env</code> file. I've raised <a href="https://github.com/cucumber/cucumber-js/issues/2347">#2347</a> accordingly.)</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-24 17:15:46
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2346#issuecomment-1778264929">Comment</a> on issue by <a href="https://github.com/x80486">x80486</a>
<https://github.com/cucumber/cucumber-js/issues/2346|#2346 Support for Node.js Built-in `.env` File>
<p>I agree with the perspective that we should aim to reuse existing tools and mechanisms when possible to keep things simple and avoid redundancy. The primary goal should be to enhance Cucumber's compatibility with Node.js without adding unnecessary complexity.</p>
<p>Additional dependencies is also a valid concern. For instance, if users had to rely on external dependencies or complex configurations to use <code>.env</code> files, it could create friction and increase the learning curve for new users. What I specifically refer is to the usage of <code>NODE_OPTIONS="--env-file=.env" npx cucumber-js</code>. Granted this could be used, but usually we <em>encode</em> actions within <code>npm</code> scripts, and to be able to use environment variables, <code>cross-env</code> (or any other similar) should be used. Moreover, I guess <code>NODE_OPTIONS</code> is one of those variables you can even define inside <code>.env</code> files now — pretty tricky, at least for me because I don't fully understand all the moving parts 😬</p>
<p>Another suggestion that comes to my minf is to have a CLI configuration setting: <code>--use-env-file</code> — or similar. It would give users the flexibility to activate or deactivate the feature as needed, without introducing unnecessary complexity into the project's core configuration. Problem is that I'm not entirely sure how Cucumber can build a pass-through to activate a Node's feature, and the order in the lifecycle of the applcation.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-24 23:26:14
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2347#issuecomment-1778594253">Comment</a> on issue by <a href="https://github.com/vitalets">vitalets</a>
<p>Do we really need this third source of truth?<br />
Currently if I want some parameter to be configured via env var, I can explicitly define that:</p>
<pre><code>export default {
retryTagFilter: process.env.MY_VARIABLE_FOR_TAG_FILTER
}
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-25 05:33:31
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2347#issuecomment-1779174861">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>> Do we really need this third source of truth?</p>
<p>Need? No. But I think it's worthwhile (if not exactly urgent).</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-10-24 13:31:42
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2327#issuecomment-1777990362">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Thanks for the detail!</p>
<p>For this to work we have to find a way to have these user-authored hooks register on both the coordinator (parent) process and the worker processes.</p>
<p>I assume we don't have this problem for steps because users are calling the Cucumber <code>Given</code>, <code>When</code>, <code>Then</code> functions directly and we're loading that code via the <code>require</code> and/or <code>import</code> options? Would this be an option for the hooks too (e.g. use <code>Before</code>, <code>BeforeAll</code>, <code>BeforeStep</code> etc) or do the hooks get some special wdio-specific context/args passed to them?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-11-01 07:40:12
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2273#issuecomment-1789076904">Comment</a> on issue by <a href="https://github.com/apazureck">apazureck</a>
<p>Hi,</p>
<p>I had the same problem. The suggested answers did not work for me. I am also using a shared package.json with my angular project. Finally I found a fix, which works for me and wanted to share it:</p>
<ol><li>Add a tsconfig file to your test folder with the following content:</li>
</ol>
<pre><code>{
"compilerOptions": {
"module": "NodeNext",
"target": "ES2022",
"allowSyntheticDefaultImports": true,
"resolveJsonModule": true,
"moduleResolution": "NodeNext"
}
}
</code></pre>
<ol start="2"><li>Go to the folder with this tsconfig.json</li><li>Start cucumber-js using the <code>--resolve-module</code> flag set to <code>ts-node/register</code> or put it in your cucumber config file.</li>
</ol>
<p>This will pick up the tsconfig from the current working directory.</p>
<p>If you have, like me, a project where the modules are resolved from the workspace root, you can set the baseurl in the tsconfi accordingly. So if your cucumber tsconfig is in <code>&lt;root&gt;/e2etest</code> folder for example, just set your baseurl to <code>"../"</code>. My IDE (VSCode) autocompletes the imports using the baseurl in my "main" tsconfig.json.</p>
<p>So I hope this helps somebody.</p>
<p>My current versions are:</p>
<pre><code>node: v20.5.0
npm: 9.8.0
"@cucumber/cucumber": "^10.0.1",
"ts-node": "^10.9.1",
"typescript": "~5.1.3",
</code></pre>
<p>Here is my current cucumber config (as yaml)</p>
<pre><code>default:
features:
- "features/****/**.feature"
requireModule:
- "ts-node/register"
require:
- "steps/****/**.ts"
- "setup/****/**.ts"
format:
- progress-bar
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-11-09 12:50:02
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2348#issuecomment-1804665880">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>To recap a bit here from a discussion on Slack:</p>
<p>• Exposing formatter implementation details is not desirable for a few reasons
• cucumber-js can split out the stack trace from the message (it does this already)
• If we add a separate <code>stackTrace</code> field to the message schema, we could change the junit formatter to match the desired behaviour described above</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-11-09 04:09:07
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2350#issuecomment-1803712269">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>From the 10.0.0 <a href="https://github.com/cucumber/cucumber-js/blob/main/UPGRADING.md#attachments-in-json-formatter">release notes</a>:</p>
<p>> Previously, string attachments were included as plain text in the JSON formatter output, where other attachments were Base64 encoded. This meant for consumers, it was ambiguous whether any attachment was Base64 encoded or not. Now, all attachments are Base64 encoded regardless of how they were initially attached.</p>
<p>(<a href="https://github.com/cucumber/cucumber-js/pull/2261">#2261</a>)</p>
<p>The code that produces your HTML report from the JSON output will need to Base64 decode the attachment body.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-11-10 13:12:56
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2351#issuecomment-1806441349">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/63894524">Coverage Status</a></p>
<p>coverage: 98.355% (+0.5%) from 97.833%<br />
when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/43c83bbdb6a7102e63be8d7a84b2744b0c187432">43c83bb</a> on chore/cck-updates-nov23</strong><br />
into <strong><a href="https://github.com/cucumber/cucumber-js/commit/6eede88fe6e6aed83a1ac581740d179e09643e3b">6eede88</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-11-19 01:26:30
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/1139#issuecomment-1817798874">Comment</a> on issue by <a href="https://github.com/delairec">delairec</a>
<p>I had some problems while configuring cucumber to run with typescript and using dedicated tsconfig file, so I want to add some information here :</p>
<ol><li>it is possible to use a simple command in package.json, like <code>cucumber-js features/****/**.feature</code></li><li>in cucumber-js the (minimal) configuration is :</li>
</ol>
<pre><code>// cucumber.js
let common = [
'--require cucumber.setup.js', // Load setup file
'--require features/****/**.step.ts', // Load step definitions
].join(' ');
module.exports = {
default: common
};
</code></pre>
<ol start="4"><li>then you are able to pass a tsconfig via cucumber.setup.js, like this example :</li>
</ol>
<pre><code>// cucumber.setup.js
const tsconfig = {
compilerOptions: {
'module': 'commonjs',
}
};
require('ts-node').register(tsconfig);
</code></pre>
<p>Note : in my case, the error was coming from the line <code>'--require-module ts-node/register'</code> in cucumber.js. If you use the setup file to require ts-node, do not forget to remove the require-module from cucumber.js file or your code will be transpiled twice. The first transpilation will be on typescript code, the second on js result from first transpilation, so it will cause many weird errors.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-11-20 19:01:27
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/1139#issuecomment-1820137700">Comment</a> on issue by <a href="https://github.com/mattwynne">mattwynne</a>
<p>Thanks for sharing <a href="https://github.com/delairec">@delairec</a> - feel free to send a PR updating the existing example or adding a new one: <a href="https://github.com/cucumber/cucumber-js-examples/tree/main/examples/typescript-node">https://github.com/cucumber/cucumber-js-examples/tree/main/examples/typescript-node</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-11-26 06:18:03
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2339#issuecomment-1826796705">Comment</a> on issue by <a href="https://github.com/pixelass">pixelass</a>
<p>We just removed cucumber from one of our projects because of this bottomless pit of issues.<br />
We're still using it in our boilerplate but one specific problem with next.js and Satori requires <code>import.meta.url</code> in an edge function and every option in the documentation or issues failed at some point.</p>
<p>I might have done something wrong (which isn't surprising considering the vague docs on how to get ESM with typescript support).<br />
Since everything works except for cucumber, I dare say: "something is fishy here".</p>
<p>This example does not help at all since it doesn't even have a tsconfig 🤷: <a href="https://github.com/cucumber/cucumber-js-examples/tree/main/examples/typescript-node">https://github.com/cucumber/cucumber-js-examples/tree/main/examples/typescript-node</a></p>
<p>> I ❤️ cucumber and use it a lot, just in this one case I had to ditch all behavior tests because they became a show-stopper.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-11-27 06:46:04
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2347#issuecomment-1827975811">Comment</a> on issue by <a href="https://github.com/Ben-EJ">Ben-EJ</a>
<p>Mind if I give this a go? : )</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-12 12:10:41
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2347#issuecomment-1852731595">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p><a href="https://github.com/Ben-EJ">@Ben-EJ</a> definitely, feel free to give this a go!</p>
<p>I've just updated the description to clarify a 1) the prefix should be <code>CUCUMBER_OPTION_</code> to avoid collisions with env vars that we <em>set</em> from Cucumber and 2) the CLI is still top in order of priority.</p>
<p>To give you an idea of where to look, <a href="https://github.com/cucumber/cucumber-js/blob/main/src/api/load_configuration.ts#L40-L44">https://github.com/cucumber/cucumber-js/blob/main/src/api/load_configuration.ts#L40-L44</a> is where the configurations from different places (currently defaults, config file and CLI) are merged together, so capturing from the environment should probably happen around here.</p>
<p>Feel free to drop into <b>#committers-js</b> on <a href="https://cucumber.io/docs/community/get-in-touch/#slack">the Slack</a> or raise a draft PR if you want some early feedback/guidance!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-11-28 20:26:39
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2009#issuecomment-1831196850">Comment</a> on issue by <a href="https://github.com/xenbartolokath">xenbartolokath</a>
<p>Hello! Any updates on this?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-11-29 09:20:48
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2009#issuecomment-1832375963">Comment</a> on issue by <a href="https://github.com/notaphplover">notaphplover</a>
<p>Hi <a href="https://github.com/xenbartolokath">@xenbartolokath</a> , none so far, if you are interested in this feature I would suggest you to thumbs up the issue 😃</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-12 12:51:59
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2009#issuecomment-1852793512">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Thanks for showing your interest folks. The core team will get to this but I can't promise when.</p>
<p>Meanwhile, if anyone is up for contributing a PR, we'd more than welcome that, and the relevant code is here <a href="https://github.com/cucumber/cucumber-js/blob/main/src/configuration/from_file.ts">https://github.com/cucumber/cucumber-js/blob/main/src/configuration/from_file.ts</a>. I think we have a consensus around a default export of an async function that resolves to the profiles.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-06 23:06:14
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2354#issuecomment-1844787684">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Before hooks always run once per scenario regardless of serial/parallel. Do you mean BeforeAll?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-06 23:12:24
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2354#issuecomment-1844793467">Comment</a> on issue by <a href="https://github.com/jkalandarov">jkalandarov</a>
<p>I have 5 scenarios with <a href="https://github.com/purchasing">@purchasing</a> tag. In this case, how many times does the following hook run?</p>
<pre><code>Before({ tag: '@purchasing' }, async function() {
await purchaseCampaign();
});
</code></pre>
<p>It's running (purchasing a campaign) 5 times in my case.<br />
I need an implementation to run it once no matter what mode is set in config.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-06 23:29:55
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2354#issuecomment-1844811668">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p><code>Before</code> hooks run once per scenario, regardless of serial or parallel. They're designed that way, it's not something we're ever going to change.</p>
<p><code>BeforeAll</code> hooks run once per test run or, for parallel, once per worker. There are workarounds described in <a href="https://github.com/cucumber/cucumber-js/issues/1153#issuecomment-1590875038">#1153 (comment)</a> where you could conditionally run something on just the first worker.</p>
<p>For your case though I would recommend you make your <code>purchaseCampaign()</code> idempotent so it only does the expensive work once regardless of how many times called.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-12 11:58:32
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2355#issuecomment-1852714984">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>You can set timeouts globally or for individual hooks and steps per <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/support_files/timeouts.md">https://github.com/cucumber/cucumber-js/blob/main/docs/support_files/timeouts.md</a>.</p>
<p>This will apply to your whole hook or step. Cucumber has no awareness of what you're doing inside of those steps e.g. calls to Playwright Test or similar - any timeouts for those specifically would need to be dealt with as part of those libraries.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-12 13:10:40
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2356#issuecomment-1852816799">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Could you elaborate by providing your step definition code and configuration?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-12 13:17:59
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2356#issuecomment-1852825515">Comment</a> on issue by <a href="https://github.com/mrsenzy">mrsenzy</a>
<p>Step definition:</p>
<pre><code>Given("my color is {string}", async function(this: CustomWorld, color: string) {
console.log("Given Color: ", this.parameters.color)
this.parameters.color = color;
console.log("Given Color after assigning: ", this.parameters.color)
})
Then("my color should not be red", async function(this: CustomWorld) {
console.log("Then Color: ", this.parameters.color)
let favColor = this.parameters.color
if(favColor!="blue"){
logger.error("Assertion failed: ",favColor=="blue")
console.trace('trace')
}
expect(favColor).toStrictEqual("blue")
})
</code></pre>
<pre><code>let common = [
'./e2e/features/****/**.feature',
'--require-module ts-node/register',
'--require ./e2e/stepDefinitions/****/**.ts',
'--require ./cucumber.config.ts',
'--format json:./report/report.json',
'--format html:./report/cucumberjs-report.html',
'--format progress-bar',
'--format @cucumber/pretty-formatter',
'--format rerun:@failedScenarios.txt',
].join(' ');
</code></pre>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-12 13:25:51
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2356#issuecomment-1852834672">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Thanks <a href="https://github.com/mrsenzy">@mrsenzy</a>. So, yeah, currently the world parameters are mutable from user code.</p>
<p>The normal pattern is to use world parameters as a source of arbitrary configuration, and set state on the world itself e.g. <code>this.color = 'red'</code> - however it's important to have guard rails. I think we should address this by:</p>
<p>• Marking the world parameters as (recursively) read-only in our type definitions
• Each time we create a new world for executing a scenario, give it a clone of the original (this should cause no issues, the world parameters must be JSON-serialisable anyway) - so even if a user mutates <code>this.parameters</code>, those changes are gone once the scenario finishes</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-12 13:27:55
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2356#issuecomment-1852837620">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Somewhat related to <a href="https://github.com/cucumber/cucumber-js/issues/2308">#2308</a>, in that probably <em>most</em> things we pass to user code should be immutable (practically if not physically).</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-21 09:41:25
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2356#issuecomment-1866699789">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Released in <a href="https://github.com/cucumber/cucumber-js/releases/tag/v10.1.0">https://github.com/cucumber/cucumber-js/releases/tag/v10.1.0</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-12 13:02:48
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2346#issuecomment-1852806955">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<https://github.com/cucumber/cucumber-js/issues/2346|#2346 Support for Node.js Built-in `.env` File>
<p>> Problem is that I'm not entirely sure how Cucumber can build a pass-through to activate a Node's feature, and the order in the lifecycle of the application.</p>
<p>Yep exactly. I think we'll wait a bit and see where Node.js goes with the dotenv file support. It may be that, much like module loaders, future releases make it less friction-y to use and add the ability to activate it in-process, at which point it might start to make sense for Cucumber to lean into it.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-14 06:34:08
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2358#issuecomment-1855962427">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Most JavaScript assertion libraries don't have a soft assert concept. But you could implement something in Cucumber, where you:</p>
<p>• Catch the assertion error
• Add an item to a list on your <code>World</code> e.g. something like <code>this.assertionErrors.push(error)</code>
• In an <code>After</code> hook, check your <code>World</code> for any assertion errors, and if there are > 0 then throw from there to fail the scenario</p>
<p>Relevant docs:</p>
<p>• <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/support_files/world.md">https://github.com/cucumber/cucumber-js/blob/main/docs/support<em>files/world.md</a>
• <a href="https://github.com/cucumber/cucumber-js/blob/main/docs/support_files/hooks.md">https://github.com/cucumber/cucumber-js/blob/main/docs/support</em>files/hooks.md</a></p>
<p>Happy to discuss more in <b>#help-cucumber-js</b> in <a href="https://cucumber.io/docs/community/get-in-touch/">the Slack</a>, but going to close the issue as there's nothing for us to change here.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-14 06:57:54
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2358#issuecomment-1856004432">Comment</a> on issue by <a href="https://github.com/user753">user753</a>
<p>Thanks.</p>
<p>> Most JavaScript assertion libraries don't have a soft assert concept. But you could implement something in Cucumber, where you:</p>
<p>Would it be possible to add soft to StepOptions?</p>
<pre><code>export interface IDefineStepOptions {
timeout?: number;
soft?: boolean
wrapperOptions?: any;
}
Then({soft: true}, ...)
</code></pre>
<p>> In an After hook, check your World for any assertion errors, and if there are > 0 then throw from there to fail the scenario</p>
<p>Yes, I do something like that, but I would like to show this step as failed in report. Is it possible?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-14 07:03:26
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2358#issuecomment-1856014677">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>This is not currently possible, no. Assertions are not in scope of what Cucumber does as purely a runner.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-14 22:23:39
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2358#issuecomment-1857344291">Comment</a> on issue by <a href="https://github.com/user753">user753</a>
<p>> Assertions are not in scope of what Cucumber does as purely a runner.</p>
<p>But it's not about making assertions, it's about running the test. I want to continue running the scenario even if some steps fail. There is already a similar feature for when there is no implementation for a step. Instead of stopping after the first missing step, it continues running to collect all missing steps. My case is exactly the same, but the problem isn't a missing step implementation, it's something else.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-21 04:54:14
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2359#issuecomment-1866196796">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Thanks for raising <a href="https://github.com/timvahlbrock">@timvahlbrock</a>.</p>
<p>I've got a PR up to remove <code>verror</code> since we can now use platform-native stuff to achieve the same thing. This would make it tolerant of errors that aren't <code>Error</code> instances, so should solve that problem for you.</p>
<p>For the point about loaders, I've raised <a href="https://github.com/cucumber/cucumber-js/issues/2364">#2364</a>. Both <code>--loader</code> and <code>register()</code> are still experimental, we may let this shake out a bit before committing to putting something in our own API, just to manage expectations.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-21 09:41:33
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2359#issuecomment-1866699923">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Released in <a href="https://github.com/cucumber/cucumber-js/releases/tag/v10.1.0">https://github.com/cucumber/cucumber-js/releases/tag/v10.1.0</a></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-20 08:29:24
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/1770#issuecomment-1864781807">Comment</a> on pull request by <a href="https://github.com/LANDG-MartinP">LANDG-MartinP</a>
<p>any news on this PR?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-21 02:15:09
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/1770#issuecomment-1865996039">Comment</a> on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Just noting here the idea raised on the issue of, rather than adding a new <code>testRunContext</code> concept, just passing in the world parameters and allowing a <code>BeforeAll</code> to return a fresh world parameters if it wants to. So like:</p>
<pre><code>BeforeAll(async function() {
this.token = await authenticate(this.parameters.url, this.parameters.clientId, this.parameters.clientSecret)
return {
...this.parameters,
token
}
})
</code></pre>
<p>I think this would solve all the use cases nicely and this PR could be adapted to it without much work - <a href="https://github.com/BlueMona">@BlueMona</a> <a href="https://github.com/mattwynne">@mattwynne</a> I'm happy to pick this up if you're time-constrained, since I'm working in this area already.</p>
<p>Also somewhat related is <a href="https://github.com/cucumber/cucumber-js/issues/2356">#2356</a> which I'm looking at today.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-21 05:04:06
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/1770#issuecomment-1866209070">Comment</a> on pull request by <a href="https://github.com/BlueMona">BlueMona</a>
<p>David, Yes, please do.</p>
<p><#|…></p>
<p>On Thu, Dec 21, 2023 at 5:15 AM David Goss <strong><em>*</strong>@<strong></em><em></strong>.<strong></em><em></strong>> wrote: Just noting here the idea raised on the issue of, rather than adding a new testRunContext concept, just passing in the world parameters and allowing a BeforeAll to return a fresh world parameters if it wants to. So like: BeforeAll(async function() { this.token = await authenticate(this.parameters.url, this.parameters.clientId, this.parameters.clientSecret) return { ...this.parameters, token } }) I think this would solve all the use cases nicely and this PR could be adapted to it without much work - <a href="https://github.com/BlueMona">@BlueMona</a> <<a href="https://github.com/BlueMona">https://github.com/BlueMona</a>> <a href="https://github.com/mattwynne">@mattwynne</a> <<a href="https://github.com/mattwynne">https://github.com/mattwynne</a>> I'm happy to pick this up if you're time-constrained, since I'm working in this area already. Also somewhat related is <a href="https://github.com/cucumber/cucumber-js/issues/2356">#2356</a> <<a href="https://github.com/cucumber/cucumber-js/issues/2356">#2356</a>> which I'm looking at today. — Reply to this email directly, view it on GitHub <<a href="https://github.com/cucumber/cucumber-js/pull/1770#issuecomment-1865996039">#1770 (comment)</a>>, or unsubscribe <<a href="https://github.com/notifications/unsubscribe-auth/AALHLMDE5Y34FGZHXLOQ6PTYKQD3NAVCNFSM5CKQKM32U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBWGU4TSNRQGM4Q">https://github.com/notifications/unsubscribe-auth/AALHLMDE5Y34FGZHXLOQ6PTYKQD3NAVCNFSM5CKQKM32U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBWGU4TSNRQGM4Q</a>> . You are receiving this because you were mentioned.Message ID: <strong></em><em></strong>@<strong></em><em></strong>.<strong></em>*</strong>></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-21 08:17:37
*Thread Reply:*
Review approved by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/BlueMona">BlueMona's</a> pull request
<p>After some conflict untangling, this fitted together nicely with some other recent changes.</p>
<p>Many thanks <a href="https://github.com/BlueMona">@BlueMona</a> for doing most of this!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-21 08:25:00
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/1770#issuecomment-1866601609">Comment</a> on pull request by <a href="https://github.com/aslakhellesoy">aslakhellesoy</a>
<p>Hi <a href="https://github.com/BlueMona">@BlueMona</a>,</p>
<p>Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾</p>
<p>In return for this generous offer we hope you will:</p>
<p>• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our <a href="https://cucumber.io/conduct">code of conduct</a> in your interactions with other collaborators and users.
• 💬 Join the <a href="http://cucumber.io/support#slack">community Slack channel</a> to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!</p>
<p>On behalf of the Cucumber core team,<br />
Aslak Hellesøy<br />
Creator of Cucumber</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-21 14:41:25
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/1770#issuecomment-1867018636">Comment</a> on pull request by <a href="https://github.com/iamkenos">iamkenos</a>
<p>This one's a great holiday gift. Thanks team 🖤. Happy holidays!</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-21 21:49:07
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/1770#issuecomment-1867270108">Comment</a> on pull request by <a href="https://github.com/mattwynne">mattwynne</a>
<p>🎉 nice one <a href="https://github.com/BlueMona">@BlueMona</a>! (and <a href="https://github.com/davidjgoss">@davidjgoss</a> 😄 )</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-21 03:27:10
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2362#issuecomment-1866090350">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/64706972">Coverage Status</a></p>
<p>coverage: 98.383%. remained the same<br />
when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/e0936026a65734547ca72bd844880814f4011e1e">e093602</a> on fix/world-parameters-immutable</strong><br />
into <strong><a href="https://github.com/cucumber/cucumber-js/commit/052ac1abf33824b954f2524d610e370e81a02db1">052ac1a</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-21 09:40:54
*Thread Reply:*
New comment on pull request by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p><code>This comment was deleted</code></p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-21 04:46:47
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2363#issuecomment-1866187350">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/64708299">Coverage Status</a></p>
<p>coverage: 98.381% (-0.002%) from 98.383%<br />
when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/d8edc8f0c02980f769ae5a74ac2a1431203915d3">d8edc8f</a> on fix/remove-verror</strong><br />
into <strong><a href="https://github.com/cucumber/cucumber-js/commit/052ac1abf33824b954f2524d610e370e81a02db1">052ac1a</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-21 09:42:19
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/1393#issuecomment-1866700718">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Released in <a href="https://github.com/cucumber/cucumber-js/releases/tag/v10.1.0">https://github.com/cucumber/cucumber-js/releases/tag/v10.1.0</a></p>
<p>See the documentation linked from the changelog entry for usage.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-21 09:27:01
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2366#issuecomment-1866682824">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/64714494">Coverage Status</a></p>
<p>coverage: 98.381%. remained the same<br />
when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/926a004164add26a52d7068b16c1878d931ae010">926a004</a> on chore/cucumber-dependencies</strong><br />
into <strong><a href="https://github.com/cucumber/cucumber-js/commit/521e28e3cf3d2063cd1165ec6f75f915c0e5ca0f">521e28e</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-21 09:46:48
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/1851#issuecomment-1866705199">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>Noting some overlap with <a href="https://github.com/cucumber/react-components/issues/336">cucumber/react-components#336</a>, where we also want a coherent way to express a test case for the purposes of the HTML formatter components.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2023-12-28 05:31:08
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2368#issuecomment-1871181637">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>It looks like you’re using cucumber-jvm - transferring the issue accordingly.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2024-01-10 23:58:42
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2369#issuecomment-1886563161">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p>This is expected behaviour - you can specify either a glob, or a full path with a line number.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2024-01-15 01:07:01
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2372#issuecomment-1891629385">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/65069248">Coverage Status</a></p>
<p>coverage: 98.379%. remained the same<br />
when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/5bd3c702f2134632082e577de7661c271521de25">5bd3c70</a> on renfeng:patch-1</strong><br />
into <strong><a href="https://github.com/cucumber/cucumber-js/commit/53ccc44cb7f60d0f7de2893662f83eac7b60307c">53ccc44</a> on cucumber:main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2024-01-15 05:56:24
*Thread Reply:*
Review approved by <a href="https://github.com/davidjgoss">davidjgoss</a> on <a href="https://github.com/renfeng">renfeng's</a> pull request
<p>Thanks for this <a href="https://github.com/renfeng">@renfeng</a> - I've updated a few other docs to match too.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2024-01-15 05:56:36
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2372#issuecomment-1892224123">Comment</a> on pull request by <a href="https://github.com/aslakhellesoy">aslakhellesoy</a>
<p>Hi <a href="https://github.com/renfeng">@renfeng</a>,</p>
<p>Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾</p>
<p>In return for this generous offer we hope you will:</p>
<p>• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our <a href="https://cucumber.io/conduct">code of conduct</a> in your interactions with other collaborators and users.
• 💬 Join the <a href="http://cucumber.io/support#slack">community Slack channel</a> to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!</p>
<p>On behalf of the Cucumber core team,<br />
Aslak Hellesøy<br />
Creator of Cucumber</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2024-01-15 06:05:30
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2348#issuecomment-1892238648">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<p><a href="https://github.com/kevinlacotaco">@kevinlacotaco</a> could you show an example of an XSD-compliant JUnit output with a stack trace in a property element?</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2024-01-16 02:27:01
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/pull/2374#issuecomment-1893462772">Comment</a> on pull request by <a href="https://github.com/coveralls">coveralls</a>
<p><a href="https://coveralls.io/builds/65092269">Coverage Status</a></p>
<p>coverage: 98.385% (+0.002%) from 98.383%<br />
when pulling <strong><a href="https://github.com/cucumber/cucumber-js/commit/139113612398b099862e1081b9c167359d0ba0bd">1391136</a> on feat/argv-accept-array</strong><br />
into <strong><a href="https://github.com/cucumber/cucumber-js/commit/23e015599406b01030a935fd3689f9f5dd06e666">23e0155</a> on main</strong>.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2024-01-18 01:14:03
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2375#issuecomment-1898082382">Comment</a> on issue by <a href="https://github.com/k02pradeep">k02pradeep</a>
<p><a href="https://github.com/cucumber/react-components/issues/342">Issue</a> in react component</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2024-01-18 01:17:22
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2375#issuecomment-1898088146">Comment</a> on issue by <a href="https://github.com/k02pradeep">k02pradeep</a>
<p>As an alternative solution, adding mediaType text/html should be supported so that custom html content can be attached</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
GitHub
2024-01-31 11:23:55
*Thread Reply:*
<a href="https://github.com/cucumber/cucumber-js/issues/2377#issuecomment-1919779893">Comment</a> on issue by <a href="https://github.com/davidjgoss">davidjgoss</a>
<https://github.com/cucumber/cucumber-js/issues/2377|#2377 Adding timestamps to html or json report>
<p>Thanks for raising <a href="https://github.com/jonathan-boudreau-work">@jonathan-boudreau-work</a>. You mentioned both JSON and HTML so I'll address them separately:</p>
<h3> JSON</h3>
<p>The JSON formatter has durations for steps, but not timestamps. This format is in maintenance mode now and won't have any new functionality added. You can however use the <code>message</code> formatter which emits Cucumber Messages - these include <code>testStepStarted</code> events which have a timestamp.</p>
<p><strong>HTML</strong></p>
<p>What you're saying here chimes a lot with <a href="https://github.com/cucumber/html-formatter/issues/283">cucumber/html-formatter#283</a>, where we want to change the design direction of the formatter to include more useful information for debugging, and this would definitely include timings.</p>
<a href="https://github.com/cucumber/cucumber-js">cucumber/cucumber-js</a>
